Ronnie Sahlberg [Sun, 4 Oct 2009 05:57:57 +0000 (16:57 +1100)]
add trailer alignment to structures
ronnie sahlberg [Tue, 6 Oct 2009 06:49:59 +0000 (17:49 +1100)]
PIDL fix for using external types with wireshark backend
List,
Please review this patch to pidl.
Basically, we need to process the wireshark conformance file BEFORE
we process the idl file since this file may define external types
and set the alignment for them (using the TYPE directive).
Otherwise pidl will default all external types to use 4byte alignment
which breaks (much more often) on NDR64
regards
ronnie sahlberg
From
8f86903fc353d0906bd82e72ce19c5af09beb001 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Mon, 5 Oct 2009 15:22:43 +1100
Subject: [PATCH] In the PIDL wireshark backend, we define external types in the conformance
file using the TYPE directive.
If we declare external types here, we must parse this file before we process
the IDL file, or else these external types will all default to 4byte padding
(pidl assumes all unknown types are 4byte aligned).
Make sure we read the conformance file and create these new types before
we parse the idl file.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Andrew Tridgell [Tue, 6 Oct 2009 08:05:15 +0000 (19:05 +1100)]
s4-provision: match win2003 functional level
We are now defaulting to win2003 functional level, and see to report
the right revisions of our db and schema
Andrew Tridgell [Tue, 6 Oct 2009 07:59:47 +0000 (18:59 +1100)]
s4-drs: added some debug lines to DsAddEntry()
Andrew Tridgell [Tue, 6 Oct 2009 07:59:30 +0000 (18:59 +1100)]
s4-drs: take advantage of system session auth in dsbind
Now that the bind opens samdb with the right credentials, we no longer
need the re-open in updaterefs and getncchanges
Andrew Tridgell [Tue, 6 Oct 2009 07:58:41 +0000 (18:58 +1100)]
s4-drs: fixed error message for drs_security_level_check
Andrew Tridgell [Tue, 6 Oct 2009 07:58:13 +0000 (18:58 +1100)]
s4-drs: open samdb with system credentials when authorised
When a DC connects to DRS, open the samdb with system session
credentials, so that we don't have to re-open it each time on other
calls.
Andrew Tridgell [Tue, 6 Oct 2009 07:57:06 +0000 (18:57 +1100)]
s4-ldb: fixed error on single value error
When you try to add a 2nd value to a single valued attribute you get
LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS. w2k8-r2 join to s4 relies on this
error, doing a replace after it sees the error
Andrew Tridgell [Tue, 6 Oct 2009 07:55:14 +0000 (18:55 +1100)]
s4-repl: added RELAX control and fix transactions
Added the RELAX control to dsdb_origin_objects_commit(), as it needs
to modify system objects. This patch also fixes the use of ldb
transactions in that function, and fixes a memory leak.
Andrew Bartlett [Mon, 5 Oct 2009 23:59:36 +0000 (10:59 +1100)]
s4:drs-development Scripts to assist testing of DRS replication with AD
These scripts, originally by tridge, allow developers to easily
reproduce the same domain join senerio time after time.
They need documentation, and the template named.conf and zone files
for hosting an AD domain are not provided. However, I hope to have
the provision script provide these shortly.
They assume a local 'bind' set up to read PREFIX/private/named.conf
(as per the provision instructions).
Ensure you edit the 'vars' file to match your local setup.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Oct 2009 02:01:33 +0000 (12:01 +1000)]
s4:param Remove duplicate argument to python provision
Andrew Bartlett [Fri, 2 Oct 2009 02:01:00 +0000 (12:01 +1000)]
s4:provision Remove unused parameters from provision scripts
Andrew Tridgell [Mon, 5 Oct 2009 22:18:53 +0000 (09:18 +1100)]
s4-seftest: skip hold.oplock for SMB2 as well
This test is not designed to be run automatically. It deliberately
blocks forever.
Volker Lendecke [Mon, 5 Oct 2009 20:14:06 +0000 (22:14 +0200)]
Revert "s3: Attempt to fix machine password change"
This reverts commit
20a8ea91e10af167067cc794a251265aaf489e75.
Ooops, this should not have been committed.
Volker Lendecke [Mon, 5 Oct 2009 20:09:01 +0000 (22:09 +0200)]
s3:winbind: Slightly simplify the logic of nss_init(), make it static
Volker Lendecke [Mon, 5 Oct 2009 20:00:16 +0000 (22:00 +0200)]
s3:winbind: Fix typos
Volker Lendecke [Sun, 4 Oct 2009 13:47:33 +0000 (15:47 +0200)]
s3: Attempt to fix machine password change
Jeremy Allison [Mon, 5 Oct 2009 17:27:48 +0000 (10:27 -0700)]
Fix bug 6776 - Running overlapping Byte Lock test will core dump Samba daemon.
Re-write core of POSIX locking logic.
Jeremy.
Günther Deschner [Mon, 5 Oct 2009 13:10:35 +0000 (15:10 +0200)]
libndr: add int3264 ndr prototype.
Guenther
Günther Deschner [Mon, 5 Oct 2009 11:01:53 +0000 (13:01 +0200)]
s3-net: print error when "net rpc changetrustpw" has failed.
Guenther
Volker Lendecke [Sun, 4 Oct 2009 13:19:19 +0000 (15:19 +0200)]
s3: Remove a scary error message -- talloc_move can not fail :-)
Signed-off-by: Günther Deschner <gd@samba.org>
Volker Lendecke [Sun, 4 Oct 2009 13:13:44 +0000 (15:13 +0200)]
s3: Fix nonempty blank lines
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 1 Oct 2009 23:25:13 +0000 (01:25 +0200)]
lib/tdr: get rid of build warning when using TDR_ALLOC macro.
Guenther
Günther Deschner [Thu, 1 Oct 2009 11:42:29 +0000 (13:42 +0200)]
s3: remove unused PRS_POINTER_CAST macro.
Guenther
Günther Deschner [Thu, 1 Oct 2009 10:52:46 +0000 (12:52 +0200)]
s3: remove unused SYSTEMTIME struct.
Guenther
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 10:01:15 +0000 (12:01 +0200)]
s3/s4 common: fix up header file
Björn Jacke [Sat, 3 Oct 2009 23:40:34 +0000 (01:40 +0200)]
s3:Makefile: another attempt to fix the wbclient dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 23:33:12 +0000 (01:33 +0200)]
s3:Makefile: another attempt to fix the netapi dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 23:30:43 +0000 (01:30 +0200)]
s3:Makefile: another attempt to fix the tdb dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 23:20:38 +0000 (01:20 +0200)]
s3:Makefile: another attempt to fix the talloc dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 21:04:12 +0000 (23:04 +0200)]
Revert "s3:Makefile: fix talloc dependencies with static build (2nd try)"
This reverts commit
b60d87c20712bd3d83166bd13fe1d2bab0315609.
Björn Jacke [Sat, 3 Oct 2009 21:00:37 +0000 (23:00 +0200)]
Revert "s3:Makefile: fix libtdb dependencies with static build"
This reverts commit
da15726630b0f796aef52a20d96898e269058456.
Björn Jacke [Sat, 3 Oct 2009 20:53:52 +0000 (22:53 +0200)]
Revert "s3:Makefile: fix libwbclient dependencies with static build"
This reverts commit
d7795f2afa3779399fe9e7b4f050d19a412f8bcd.
Björn Jacke [Sat, 3 Oct 2009 20:53:15 +0000 (22:53 +0200)]
Revert "s3:Makefile: fix libnetapi dependencies with static build"
This reverts commit
110897a057af01f3c01a1783e06080b54631ba2d.
Volker Lendecke [Sat, 3 Oct 2009 15:10:53 +0000 (17:10 +0200)]
s3:winbind: use wb_fill_pwent in wb_getpwsid
Volker Lendecke [Sat, 3 Oct 2009 15:11:43 +0000 (17:11 +0200)]
s3:winbind: No point in using strequal to detect a 0-length string
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 14:50:34 +0000 (16:50 +0200)]
s4:ldap.py - commented out the UTF8 tests (and fixed some deletion DNs)
Volker Lendecke [Sat, 3 Oct 2009 14:43:01 +0000 (16:43 +0200)]
s3:winbind: use talloc_tos() instead of NULL in fillup_pw_field
Volker Lendecke [Sat, 3 Oct 2009 14:36:11 +0000 (16:36 +0200)]
s3:winbind: Fix a debug message
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:37:25 +0000 (15:37 +0200)]
s4:ldb_tdb - fix memory leaks
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:36:44 +0000 (15:36 +0200)]
heimdal kerberos - fix memory leak (free the plugin list always - not only in error cases)
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:08:19 +0000 (15:08 +0200)]
s4:objectclass - Free unused memory from responses
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:08:00 +0000 (15:08 +0200)]
s4:schema_inferiors - Fix wrong check
Volker Lendecke [Sat, 3 Oct 2009 12:21:13 +0000 (14:21 +0200)]
s3: Make default_[static|shared]_modules a bit more readable
Matthias Dieter Wallnöfer [Thu, 1 Oct 2009 09:37:01 +0000 (11:37 +0200)]
s4:ldb.h - add constant for LDAP EXOP password change
Also enhance some other comments.
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 09:43:17 +0000 (11:43 +0200)]
heimdal - fix various warnings
- Shadowed variables
- "const" related warnings
- Parameter names which shadow function declarations
- Non-void functions which have no return value
(patch also ported upstream)
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 09:37:30 +0000 (11:37 +0200)]
s4:ldap.py - add tests for valid parent and RDN
Andrew Bartlett [Thu, 24 Sep 2009 22:14:49 +0000 (15:14 -0700)]
s4:dsdb Use possibleInferiors to restrict creation of child objects
This also uses systemPossibleInferiors when the 'relax' control is
specified, which is done by the provision.
Andrew Bartlett
Andrew Bartlett [Thu, 24 Sep 2009 22:12:49 +0000 (15:12 -0700)]
s4:dsdb add systemPossibleInferiors to schema code
This allows us to figure out what the system can add, which will not
be in possibleInferiors due to the systemOnly flag.
Andrew Bartlett
Andrew Bartlett [Thu, 24 Sep 2009 04:16:42 +0000 (21:16 -0700)]
s4:dsdb Add objectClass and RDN constraints to objectClass module
These additional constraints are applied, found by the Microsoft testsuite.
- When the parent is not present, we now return 'NO_SUCH_OBJECT'.
- Restrict the choice of RDN to the correct one per the schema
- Honour the allowedChildClasses attribute from the parent's objectClass.
Andrew Bartlett
Andrew Tridgell [Sat, 3 Oct 2009 09:02:27 +0000 (19:02 +1000)]
ndr: rebuild lsa IDL after recent change
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 08:57:14 +0000 (10:57 +0200)]
s4:ldap.py - add a test for the "systemOnly" classes
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 08:52:53 +0000 (10:52 +0200)]
s4:dsdb Don't allow creation of systemOnly objectclasses
(except as part of the provision, which specifies the 'relax' control)
Andrew Bartlett
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 08:36:41 +0000 (10:36 +0200)]
s4:rdn_name - fix up the rename operation
A function call was wrong ("ldb_request" rathen than "ldb_next_request").
Andrew Tridgell [Sat, 3 Oct 2009 08:13:50 +0000 (18:13 +1000)]
idl: some lsa vars are uint3264
Andrew Tridgell [Sat, 3 Oct 2009 08:13:25 +0000 (18:13 +1000)]
pidl: added int3264 as a base type
This is the type used for a variable that is 32 bits for NDR32 and 64
bits for NDR64
Björn Jacke [Fri, 2 Oct 2009 22:19:30 +0000 (00:19 +0200)]
s3:Makefile: minor clean up
Björn Jacke [Fri, 2 Oct 2009 22:15:19 +0000 (00:15 +0200)]
s3:Makefile: fix libnetapi dependencies with static build
analogical to previous libtalloc fix
Björn Jacke [Fri, 2 Oct 2009 21:08:11 +0000 (23:08 +0200)]
s3:Makefile: eventlogadm dependency cleanup
no need to link against popt lib
Björn Jacke [Fri, 2 Oct 2009 21:05:27 +0000 (23:05 +0200)]
s3:Makefile: fix libwbclient dependencies with static build
analogical to previous libtalloc fix
Björn Jacke [Fri, 2 Oct 2009 21:01:18 +0000 (23:01 +0200)]
s3:Makefile: fix libtdb dependencies with static build
analogical to previous libtalloc fix
Björn Jacke [Fri, 2 Oct 2009 20:43:14 +0000 (22:43 +0200)]
s3:Makefile: fix talloc dependencies with static build (2nd try)
When configure options --with-libtalloc=no --enable-shared-libs=no are used,
LIBTALLOC_TARGET stays empty. Actually LIBTALLOC_TARGET which is only used for
Makefile dependencies is obsolete as LIBTALLOC contains exactly the targets
that we depend on, libtalloc finally is the target to depend on.
Björn Jacke [Fri, 2 Oct 2009 20:00:50 +0000 (22:00 +0200)]
Revert "s3:Makefile: fix talloc dependencies with static build"
This reverts commit
2af2334522bc3d2c44bdcf7c9f1e80d2bcbf2024.
a more correct way to fix the libtalloc dependencies follows
Björn Jacke [Fri, 2 Oct 2009 00:18:50 +0000 (02:18 +0200)]
s3:Makefile: libsmbsharemode dependency cleanup
no need to link against ldap and krb5 libs
Björn Jacke [Fri, 2 Oct 2009 00:28:56 +0000 (02:28 +0200)]
s3:Makefile: net utility dependency cleanup
no need to link against iniparser lib
Björn Jacke [Fri, 2 Oct 2009 17:53:53 +0000 (19:53 +0200)]
s3:configure: use --aѕ-needed linker option when supported
Based on a patch from Andreas Schneider but modified that --aѕ-needed is also
used when own libs are not build shared (--enable-shared). Also change order of
options so that user supplied LDFLAGS are put *after* the automatic --aѕ-needed
flag. This way it's pollible to force not use as-needed by setting LDFLAGS
environment variable to "-Wl,--no-as-needed".
Björn Jacke [Fri, 2 Oct 2009 15:55:50 +0000 (17:55 +0200)]
s3:doc: add some detail about lanman auth parameter
add interesting detail: lm passwords will be removed from databaѕe with
lanman auth = no
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 22:06:41 +0000 (00:06 +0200)]
Revert "s4:LDB/LDAP - Re-allow renames"
This reverts commit
767fce6fccf484b547219abd5e6abc941eacaf92.
Simo pointed out that the patch generates race conditions. We need to solve this
using a new control.
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 21:26:35 +0000 (23:26 +0200)]
s4:repl_meta_data - various
- Add more "talloc_free"s and right error values where needed
- Add a pre-lookup for entries before searching for metadata attribute
(also suggested by TODO list)
- Now the most part of "ldap.py" works again
Jeremy Allison [Fri, 2 Oct 2009 20:45:38 +0000 (13:45 -0700)]
Remove lots of duplicate code and move it into one
function vfs_stat_fsp(). Stops code looking at fsp->posix_open
except for exceptional circumstances.
Jeremy.
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 19:26:35 +0000 (21:26 +0200)]
s4:ldap.py - add a very special rename test (with invalid - empty RDN)
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 19:26:12 +0000 (21:26 +0200)]
s4:ldb_ildap - Don't segfault on a empty RDN
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 19:23:23 +0000 (21:23 +0200)]
s4:LDB/LDAP - Re-allow renames
The main problem is that the "rdn_name" module launches on a rename request also
a modification one with the "special attributes" which can't be changed directly.
An introduced flag helps to bypass the restriction.
Jeremy Allison [Fri, 2 Oct 2009 18:07:17 +0000 (11:07 -0700)]
Missed one VFS_STAT -> VFS_LSTAT
Jeremy.
Jeremy Allison [Fri, 2 Oct 2009 18:05:03 +0000 (11:05 -0700)]
Fix more use of VFS_STAT when posix pathnames selected.
Jeremy.
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 16:31:38 +0000 (18:31 +0200)]
s4:ldap.py - major enhancements
- Clean up and reorder it a bit
- Test which adds invalid attributes
- Test which makes sure that the 'distinguishedName' attribute cannot be modified
- Test which makes sure that we cannot change the RDN/'name' attribute through a modify request
Andrew Bartlett [Thu, 24 Sep 2009 04:12:00 +0000 (21:12 -0700)]
s4:ldb Don't allow RDN to be modified with an LDB modify message
Found by the Microsoft testsuite at the AD interop event.
Andrew Bartlett
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 17:09:13 +0000 (19:09 +0200)]
s4:rdn_name module - a normal error message should be enough for this failure
I don't think that we really want to have this error printed out on the server
console (stdout) since this hasn't serious results as DB or data corruption
and similar.
Andrew Bartlett [Fri, 25 Sep 2009 00:20:55 +0000 (17:20 -0700)]
s4:ldb Don't allow modifcation of distinguishedName
Andrew Bartlett [Fri, 25 Sep 2009 23:40:30 +0000 (16:40 -0700)]
s4:dsdb Return correct error on invalid attribute
This error per the Microsoft testsuite
Andrew Bartlett [Thu, 24 Sep 2009 04:13:22 +0000 (21:13 -0700)]
s4:dsdb Pass down the exact error code on failure in repl_meta_data
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 16:03:31 +0000 (18:03 +0200)]
s4:samdb_set_password - Return the maximum password age when requested (not the minimum one)
Matthias Dieter Wallnöfer [Wed, 23 Sep 2009 17:23:17 +0000 (19:23 +0200)]
s4:samdb_set_password - cosmetic fixes
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 09:49:50 +0000 (11:49 +0200)]
s4: fix various warnings (not "const" related ones)
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 09:49:50 +0000 (11:49 +0200)]
s4/srvsvc: deactivate a "ntvfs_connect" with a wrong parameter
In the srvsvc code for s4 (NTVFS module) there exists a call to "ntvfs_connect"
which is performed with a totally wrong argument. Since I'm not able to fix
this, I commented it out and added a "FIXME" comment.
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 13:21:17 +0000 (15:21 +0200)]
s4:provision_users.ldif - Put potential primary groups in front of the file
(So they can be always found by the SAMLDB module)
Andrew Tridgell [Fri, 2 Oct 2009 12:40:50 +0000 (22:40 +1000)]
Revert "s4:ldb-samba Use temp talloc contexts and talloc_steal avoid leaks."
This reverts commit
38f87f40bfd7892043d49009067ae28431279580.
Andrew Tridgell [Fri, 2 Oct 2009 12:40:31 +0000 (22:40 +1000)]
Revert "s4:ldb Fix ldb_list_find() folowing the change from char * to TDB_DATA"
This reverts commit
f0c2c9854c7659221fe9480110a7d9b2b48afbf9.
Andrew Tridgell [Fri, 2 Oct 2009 12:40:02 +0000 (22:40 +1000)]
Revert "s4:ldb always talloc_free() the ldb_ldif_write context, even on success"
This reverts commit
a610843e9f21ee77fd29356313d2ef05fe25a1ed.
Andrew Tridgell [Fri, 2 Oct 2009 12:39:44 +0000 (22:39 +1000)]
Revert "s4:ldb Remove LTDB_PACKING_FORMAT_NODN"
This reverts commit
bcbf0ae1e707c2355824800dc213d364070f070a.
Andrew Tridgell [Fri, 2 Oct 2009 12:39:19 +0000 (22:39 +1000)]
Revert "s4-ldb: merged with master"
This reverts commit
14c9070322d089dd96b389e8087c4f4bf1a6c7cc.
Andrew Tridgell [Fri, 2 Oct 2009 12:39:10 +0000 (22:39 +1000)]
Revert "s4-ldb: overallocate idxptr to reduce memory fragmentation"
This reverts commit
e7846f69cacdd0551fcd777a71bf833a2fc9ca2b.
Andrew Tridgell [Fri, 2 Oct 2009 12:38:58 +0000 (22:38 +1000)]
Revert "s4-ldb: fixed a memory leak"
This reverts commit
c7358d989034c9d936c04f2a7e4f89db252b798e.
Andrew Tridgell [Fri, 2 Oct 2009 12:17:42 +0000 (22:17 +1000)]
s4-winbind: support the s3 response flags on krb5 auth too
This fixes the samba4.blackbox.wbinfo test, which was failing on a
wbinfo -K command
Andrew Tridgell [Fri, 2 Oct 2009 11:31:05 +0000 (21:31 +1000)]
s4-winbind: support the Samba3 TXT form of the info3 for wbinfo -a
This sends the info3 as hand marshalled data
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 10:23:25 +0000 (12:23 +0200)]
s4:ldb.h - cosmetic - add whitespace
Matthias Dieter Wallnöfer [Fri, 2 Oct 2009 10:18:03 +0000 (12:18 +0200)]
s4:provision - Cosmetic - right indentations
Andrew Bartlett [Sat, 26 Sep 2009 00:37:21 +0000 (17:37 -0700)]
s4:dsdb Fix crash from LDAP login of DOM\\
The issue here is that when we resolve DOM\\ into an NT4 name, we
would not initilise the nt4_account output.
Andrew Bartlett
Andrew Bartlett [Thu, 24 Sep 2009 22:06:11 +0000 (15:06 -0700)]
s4:dsdb rework instanceType module - put instanceType in provision
The instanceType needs to be specified in future because that's how
the partitions are actually created.
Andrew Bartlett [Fri, 25 Sep 2009 15:34:33 +0000 (08:34 -0700)]
s4:dsdb Don't allow creating of new objects with an isDefunct schema class