Michael Adam [Mon, 23 Sep 2013 06:58:56 +0000 (08:58 +0200)]
build: list sources of binary profiles directly in def, remov vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:58:00 +0000 (08:58 +0200)]
build: list source of subsys PROFILE directly in definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:57:08 +0000 (08:57 +0200)]
build: list source of subsys GROUPDB direclty in def
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:54:58 +0000 (08:54 +0200)]
build: list sources of lib pdb directly in def, removing vars=locals()
Also, remove a comment
"#FIXME: lib/winbind_util.c probably is not part of PASSDB_SRC"
while moving he list:
lib/winbind_util.c is in fact a winbind wrapper for passdb.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:47:20 +0000 (08:47 +0200)]
build: list sources of subsys LOCKING directly in def, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:45:21 +0000 (08:45 +0200)]
build: list source of subsys RPC_CLIENT_SCHANNEL direclty in def, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:44:17 +0000 (08:44 +0200)]
build: list source of subsys LIBEVENTLOG directly in definition, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:43:28 +0000 (08:43 +0200)]
build: list sources of SERVICES directly in def, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:41:53 +0000 (08:41 +0200)]
build: list sources of REG_API_REGF directly in def, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:40:46 +0000 (08:40 +0200)]
build: list sources of subsys REG_FULL directly in def, remov vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:38:45 +0000 (08:38 +0200)]
build: list sources of subsys REG_SMBCONF directly in def, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:38:04 +0000 (08:38 +0200)]
build: list sources of lib smbregistry directly in def, remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:33:08 +0000 (08:33 +0200)]
build: list sources of lib msrpc3 directly in def, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:32:01 +0000 (08:32 +0200)]
build: list sources of library libsmb directly in def, also removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:30:14 +0000 (08:30 +0200)]
build: list sources of subsys TLDAP directly in definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:28:14 +0000 (08:28 +0200)]
build: list sources of subsys LIBNTLMSSP in definition, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:24:04 +0000 (08:24 +0200)]
build: list sources of subsys LIBNMB directly in def, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:05:50 +0000 (08:05 +0200)]
build: list sources of lib secrets3 directly in def, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:03:56 +0000 (08:03 +0200)]
build: list source of subsys LIBADS_PRINTER directly in def, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:02:52 +0000 (08:02 +0200)]
build: list sources of subsystem LIBADS_SERVER directly in def, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:01:39 +0000 (08:01 +0200)]
build: list sources of library ads directly in sources, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 06:00:16 +0000 (08:00 +0200)]
build: list sources of library gpo directly in definition, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:58:32 +0000 (07:58 +0200)]
build: list source of subsystem KRBCLIENT directly in defintion, removing vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:57:22 +0000 (07:57 +0200)]
build: list source of subsystem param directly in definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:55:52 +0000 (07:55 +0200)]
build: list source of subsystem PARAM_UTIL directly in definition and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:54:19 +0000 (07:54 +0200)]
build: list source of library popt_samba3 directly in definition and rm vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:51:12 +0000 (07:51 +0200)]
build: list sources of subsystem samba3util directly in definition and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:49:33 +0000 (07:49 +0200)]
build: split REG_PARSE_PRS as subsystem and list sources of REGFIO directly.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:44:58 +0000 (07:44 +0200)]
build: list sources of libcli_netlogon3 library directly in the definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:43:49 +0000 (07:43 +0200)]
build: list sources of subsystem LIBCLI_SAMR directly in the definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:43:06 +0000 (07:43 +0200)]
build: list sources of library libcli_lsa3 directly in the definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:42:14 +0000 (07:42 +0200)]
build: list sources of cli_spoolss directly in the definition.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:40:42 +0000 (07:40 +0200)]
build: list source of subsystem PASSCHANGE directly in definition and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:39:57 +0000 (07:39 +0200)]
build: list source of subsystem SERVER_MUTEX directly in its definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:38:45 +0000 (07:38 +0200)]
build: list source of subsystem AVAHI directly in its definition.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:37:45 +0000 (07:37 +0200)]
build: list LIB_SRC files directly in samba3core.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 05:34:48 +0000 (07:34 +0200)]
build: define a subsystem TDB_LIB from TDB_LIB_SRC and depend on in sin samba3core
This also allows us to remove vars=locals() from samba3core.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:55:56 +0000 (02:55 +0200)]
build: list winbindd sources in definition and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:50:19 +0000 (02:50 +0200)]
build: make TDB_VALIDATE its own subsystem and have winbindd depend on it
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:38:15 +0000 (02:38 +0200)]
build: LIBAFS depends on LIBAFS_SETTOKEN
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:18:11 +0000 (02:18 +0200)]
build: list sources directly in def of LIBAFS_SETTOKEN subsystem and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:16:47 +0000 (02:16 +0200)]
build: list sources directly in the definition of LIBAFS subsystem and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:15:16 +0000 (02:15 +0200)]
build: list sources directly in definition of SAMBA_VERSION, and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:14:15 +0000 (02:14 +0200)]
build: list sources directly in smbldap library and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:08:49 +0000 (02:08 +0200)]
build: list sources of nmbd directly in the definition and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 23 Sep 2013 00:00:56 +0000 (02:00 +0200)]
build: list sources of smbclient directly in the definition
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Sun, 22 Sep 2013 23:58:47 +0000 (01:58 +0200)]
build: list sources directly in the netapi library and remove vars=locals()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Sun, 22 Sep 2013 23:55:09 +0000 (01:55 +0200)]
build: fix spacing in definition of "idmap_ldap" module
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Thu, 9 May 2013 03:16:55 +0000 (15:16 +1200)]
python-samba-tool fsmo: Do not give an error on a successful role transfer
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9461
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Sep 23 12:00:24 CEST 2013 on sn-devel-104
Michael Adam [Sun, 22 Sep 2013 19:11:40 +0000 (21:11 +0200)]
build: fix spacing in the definition of the "idmap_autorid" target
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Sep 23 10:11:51 CEST 2013 on sn-devel-104
Michael Adam [Sun, 22 Sep 2013 21:21:01 +0000 (23:21 +0200)]
build: remove vars=locals() from the nss_info library: there is no need for this
Might have been a copy'n'paste.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Sun, 22 Sep 2013 21:20:12 +0000 (23:20 +0200)]
build: remove vars=locals() from the IDMAP_HASH subsystem: there is no need for this
Might have been a copy'n'paste.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Sun, 22 Sep 2013 21:03:10 +0000 (23:03 +0200)]
build: clean the idmap sybsystems/modules definitions
Directly list the sources in the definitions of subsystems/modules/libraries
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Sun, 22 Sep 2013 20:51:48 +0000 (22:51 +0200)]
build: remove vars=locals() from the IDMAP_AD subsystem: there is no need for this
Might have been a copy'n'paste.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Sun, 22 Sep 2013 20:49:22 +0000 (22:49 +0200)]
build: reorganize idmap_rw and idmap_tdb int subsystems with proper dependencies
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Sun, 22 Sep 2013 05:06:54 +0000 (22:06 -0700)]
selftst: add tests based on 4.1.0rc3 to check for zero invocationID in replPropertyMetaData
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Sep 23 01:29:10 CEST 2013 on sn-devel-104
Andrew Bartlett [Sun, 22 Sep 2013 05:52:01 +0000 (22:52 -0700)]
selftest: Add release-4-1-0rc3 saved provision
This version has the regression where we would, on join, write an
all-zero invocationID in the replPropertyMetaData attribute, on
Deleted Objects in particular.
To demonstrate this regression, this is based on the promoted_dc
environment from make test, with the domain altered to match the
pattern used in these trees.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sun, 22 Sep 2013 06:36:46 +0000 (23:36 -0700)]
selftest: Only run referenceprovision and ldapcmp for the 4.0.0 test
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sun, 22 Sep 2013 01:52:21 +0000 (18:52 -0700)]
selftest: Add script to assist in writing out a tree undump.sh can restore
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sun, 22 Sep 2013 01:03:43 +0000 (18:03 -0700)]
dbcheck: Look for and fix the all-zero invocationID in replPropertyMetaData
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sat, 21 Sep 2013 21:33:21 +0000 (14:33 -0700)]
dsdb: Refuse to replicate an all-zero invocationID GUID in replPropertyMetaData
This matches Windows 2008R2.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sat, 21 Sep 2013 21:32:27 +0000 (14:32 -0700)]
smb.conf: Fill out the ntvfs handler smb.conf page from source4/NEWS
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sat, 21 Sep 2013 21:31:31 +0000 (14:31 -0700)]
Remove NEWS file containing confusing information
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sat, 21 Sep 2013 21:10:02 +0000 (14:10 -0700)]
Remove confusing TODO file
This makes no sense in the merged tree, and only confuses users.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Sat, 21 Sep 2013 20:55:00 +0000 (13:55 -0700)]
dsdb: Use WERR_DS_ATT_NOT_DEF_IN_SCHEMA for failed schema lookups
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Matthieu Patou [Sat, 7 Sep 2013 06:23:07 +0000 (23:23 -0700)]
Backport
0e97908 from WAF repository: symlink fix for OpenBSD
Author: Thomas Nagy <tnagy1024@gmail.com>
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sat Sep 21 11:14:30 CEST 2013 on sn-devel-104
Michael Adam [Sat, 21 Sep 2013 00:51:34 +0000 (02:51 +0200)]
s4:torture: remove and useless variable and assignment in smb2.session.reauth5
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Sep 21 08:00:02 CEST 2013 on sn-devel-104
Michael Adam [Fri, 20 Sep 2013 23:49:08 +0000 (01:49 +0200)]
auth: fix space/tab mixup in cli_credentials_get_password()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Daniel Liberman [Thu, 19 Sep 2013 23:28:33 +0000 (20:28 -0300)]
Fix bug 10162 - POSIX ACL mapping failing when setting DENY ACE's from Windows.
Fix for ACL problem - not accepting DENY. Code was checking for pointer and not for content.
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat Sep 21 05:24:07 CEST 2013 on sn-devel-104
Günther Deschner [Wed, 7 Aug 2013 15:43:08 +0000 (17:43 +0200)]
s3-rpc: remove unused source3/librpc/rpc/rpc_common.c
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Sep 20 14:57:06 CEST 2013 on sn-devel-104
Günther Deschner [Wed, 18 Sep 2013 08:59:14 +0000 (10:59 +0200)]
s3-rpc: use dcerpc_default_transport_endpoint function.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 8 Aug 2013 15:33:29 +0000 (17:33 +0200)]
librpc: add dcerpc_default_transport_endpoint() function.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 08:58:16 +0000 (10:58 +0200)]
s3-rpc: use ndr_interface_name() instead of get_pipe_name_from_syntax() in DEBUG.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 8 Aug 2013 15:40:22 +0000 (17:40 +0200)]
s3-rpc: use table->name directly in DEBUG contexts.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 8 Aug 2013 15:34:56 +0000 (17:34 +0200)]
librpc/ndr: make sure ndr_table_list() always calls ndr_init_table() first.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Mon, 12 Aug 2013 15:22:15 +0000 (17:22 +0200)]
librpc/ndr: call ndr_table_list() from all ndr_X functions.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Matthieu Patou [Thu, 19 Sep 2013 18:18:32 +0000 (11:18 -0700)]
libcli: continue to read from the socket even if the size is 0
This is an issue found by Codenomicon, with a malicious packet with 0
bytes UDP payload we will continiously be looping trying to react from
the socket event and continiously do nothing as we will bail out
thinking that we had a memory allocation error.
Original fix comes from Volker Lendecke <vl@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Sep 20 04:46:47 CEST 2013 on sn-devel-104
Andrew Bartlett [Wed, 18 Sep 2013 21:29:26 +0000 (14:29 -0700)]
lib/messaging: Check the server_id type correctly
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Sep 19 23:19:16 CEST 2013 on sn-devel-104
Andrew Bartlett [Tue, 17 Sep 2013 22:31:04 +0000 (15:31 -0700)]
dsdb-repl_meta_data: Make handling of Deleted Objects DN clearer in delete
This code no longer needs to handle not renaming Deleted Objects
during a re-delete, because it is no longer called in that case.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 17 Sep 2013 22:28:32 +0000 (15:28 -0700)]
dsdb-repl_meta_data: Do not re-delete the Deleted Objects DN during replication
We need to ensure we do not re-delete the Deleted Objects DN during replication.
It itself not entirely a deleted object, but has isDeleted set.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 17 Sep 2013 22:20:48 +0000 (15:20 -0700)]
dsdb: Refuse to return an all-zero invocationID
This could cause an all-zero GUID to be entered into the
replPropertyMetaData, which will then fail to be replicated to other
DCs.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Tue, 17 Sep 2013 22:31:51 +0000 (15:31 -0700)]
dsdb-repl_meta_data: Check for a NULL invocationID and do not proceed
This can happen if we do not find the invocationID, with later patches.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Wed, 18 Sep 2013 21:27:26 +0000 (14:27 -0700)]
python/drs: Ensure to pass in the local invocationID during the domain join
This ensures (and asserts) that we never write an all-zero GUID as an invocationID
to the database in replPropertyMetaData.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 19 Sep 2013 09:05:21 +0000 (11:05 +0200)]
s3-rpc_srv: remove unused schannel calls from srv_pipe.c
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu Sep 19 12:59:04 CEST 2013 on sn-devel-104
Günther Deschner [Thu, 19 Sep 2013 09:04:19 +0000 (11:04 +0200)]
s3-rpc_cli: remove unused schannel calls from cli_pipe.c
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 19 Sep 2013 09:03:31 +0000 (11:03 +0200)]
s3-rpc_cli: remove unused schannel calls from dcerpc_helpers.c
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 16:36:19 +0000 (18:36 +0200)]
s3-rpc: use gensec for schannel footer processing.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 16:34:58 +0000 (18:34 +0200)]
s3-rpc_srv: use gensec for schannel bind.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 16:33:14 +0000 (18:33 +0200)]
s3-rpc_cli: use gensec for schannel bind.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 16:23:40 +0000 (18:23 +0200)]
s3-auth: register schannel gensec module in auth_generic_prepare() as well.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 15:44:10 +0000 (17:44 +0200)]
s3-rpc_cli: allow to pass down a netlogon CredentialState struct to gensec.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 15:27:28 +0000 (17:27 +0200)]
s3-auth: also load schannel module from auth_generic_client_prepare().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 15:25:55 +0000 (17:25 +0200)]
gensec: check for NULL gensec_security in gensec_security_by_auth_type().
We have equivalent checks in other gensec_security_by_X calls already.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 15:24:49 +0000 (17:24 +0200)]
gensec: remove duplicate gensec_security_by_authtype() call.
We should use the equivalent gensec_security_by_auth_type() call which is
exposed in the public header.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Wed, 18 Sep 2013 15:24:10 +0000 (17:24 +0200)]
gensec: move schannel module to toplevel.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Howard Chu [Wed, 18 Sep 2013 05:14:20 +0000 (22:14 -0700)]
Fix SEGV from improperly formed SUBSTRING/PRESENCE filter
Signed-off-by: Howard Chu <hyc@symas.com>
Reviewed-by: Simo Sorce <idra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Sep 19 01:42:43 CEST 2013 on sn-devel-104
Howard Chu [Tue, 17 Sep 2013 22:38:42 +0000 (15:38 -0700)]
OpenLDAP provisioning tweaks
Remove BerkeleyDB-specific setup.
Streamline cn=samba partition initialization - allow any backend type for it.
Use back-mdb instead of back-ldif for cn=samba partition
Signed-off-by: Howard Chu <hyc@symas.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
Autobuild-User(master): Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date(master): Wed Sep 18 21:39:51 CEST 2013 on sn-devel-104
Howard Chu [Tue, 17 Sep 2013 21:04:06 +0000 (14:04 -0700)]
Use SASL/EXTERNAL over ldapi://
The provision script will map the uid of the user running the
script to the samba-admin LDAP DN.
Signed-off-by: Howard Chu <hyc@symas.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
Howard Chu [Tue, 17 Sep 2013 20:09:50 +0000 (13:09 -0700)]
Add SASL/EXTERNAL gensec module
Signed-off-by: Howard Chu <hyc@symas.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
Howard Chu [Tue, 17 Sep 2013 20:09:07 +0000 (13:09 -0700)]
Prepare for SASL/EXTERNAL support
Signed-off-by: Howard Chu <hyc@symas.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Nadezhda Ivanova <nivanova@symas.com>
git.samba.org / nivanova / samba-autobuild / .git / log