"Response flags" in GIOP Request is misinterpreted

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26177 f5534014-38df-0310-8fa8-9805f1628bb7

diff --git a/epan/dissectors/packet-giop.c b/epan/dissectors/packet-giop.c
index 551d8e93793e3e04f2c239ce2bcf99edd559556e..8b95fb5ae637e4dae892b04f5d5068d16a814e61 100644 (file)
--- a/epan/dissectors/packet-giop.c
+++ b/epan/dissectors/packet-giop.c
@@ -471,7 +471,7 @@ static const value_string giop_endianess_vals[] = {
   { 0x1, "Little Endian" },
   { 0, NULL}
 };
-
+/*
 static const value_string sync_scope[] = {
        { 0x0, "SYNC_NONE" },
        { 0x1, "SYNC_WITH_TRANSPORT"},
@@ -479,6 +479,16 @@ static const value_string sync_scope[] = {
        { 0x3, "SYNC_WITH_TARGET"},
        { 0, NULL}
 };
+Bug fix:
+https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800
+http://ethereal.netmirror.org/lists/ethereal-users/200303/msg00135.html
+*/
+static const value_string response_flags_vals[] = {
+    { 0x0, "SyncScope NONE or WITH_TRANSPORT" },
+    { 0x1, "SyncScope WITH_SERVER"},
+    { 0x3, "SyncScope WITH_TARGET"},
+    { 0, NULL}
+};
 
 /* Profile ID's */
 
@@ -3519,7 +3529,7 @@ dissect_giop_request_1_2 (tvbuff_t * tvb, packet_info * pinfo,
     {
       proto_tree_add_text (request_tree, tvb, offset-1, 1,
                           "Response flags: %s (%u)",
-                               val_to_str(response_flags, sync_scope, "(0x%x)"),
+                               val_to_str(response_flags, response_flags_vals, "(0x%x)"),
                                response_flags);
     }