From Mike Morrin: Fix for "The previous patch had an error and was returning too many bits." https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6878 From me: Correct the indentation to match the rest of the file. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41230 f5534014-38df-0310-8fa8-9805f1628bb7
Fix several messages of type: epan/tvbuff.c: In function ‘tvb_get_bits16’: epan/tvbuff.c:1736:82: error: unused parameter ‘encoding’ [-Werror=unused-parameter] Compilation still fails with: epan/tvbuff.c: In function ‘_tvb_get_bits64’: epan/tvbuff.c:1829:19: error: ‘value’ may be used uninitialized in this function [-Werror=uninitialized git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41227 f5534014-38df-0310-8fa8-9805f1628bb7
OK, to heck with it - link reassemble_test with libwireshark. Trying to selectively pick up particular object files is just too much of a mess. Alas, this requires that we add some additional symbols to the list exported by libwireshark; the DCE RPC ones shouldn't be global, but reassemble_test uses them, so.... Get rid of stubs in reassemble_test.c - they just stub out routines from libwireshark, but that's not necessary any more. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41223 f5534014-38df-0310-8fa8-9805f1628bb7
From Mijo Safradin: Add ECP VDP TLV dissector. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6849 Fixed encoding arguments, removed unused variables checkapi errors etc. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41221 f5534014-38df-0310-8fa8-9805f1628bb7
reassemble_test now requires mark_frame_as_depended_upon(), so it requires packet.c. (If it requires any more, we should just make it link with libwireshark in its entirety.) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41219 f5534014-38df-0310-8fa8-9805f1628bb7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3315 - make Save-As/Displayed/All-Packets save not only the displayed packets but also any other packets needed (e.g., for reassembly) to fully dissect the displayed packets. This works only for the "All packets" case; choosing only the Selected packet, the Marked packets, or a range of packets would require actually storing which packets depend on which (too much memory) or going through the packet list many times (too slow). Also, this behavior is always the case: you can't save the displayed packets without their dependencies (I don't see why this would be desirable). So far this is done for SCTP and things using the reassembly routines (TCP has been tested). The Win32 dialog was modified but hasn't been tested yet. One confusing aspect of the UI is that the Displayed count in the Save-As dialog does not match the number of displayed packets. (I tried renaming the button "Displayed + Dependencies" but it looked too big.) The tooltip tries to explain this and the fact that this works only in the All-Packets case; suggestions for improvement are welcome. Implementation details: Dissectors (or the reassembly code) can list frames which were needed to build the current frame's tree. If the current frame passes the display filter then each listed frame is marked as "depended upon" (this takes up the last free frame_data flag). When performing a Save-As/Displayed/All-Packets then choose packets which passed the dfilter _or_ are depended upon. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41216 f5534014-38df-0310-8fa8-9805f1628bb7