Andrew Bartlett [Fri, 13 May 2011 08:26:20 +0000 (10:26 +0200)]
lib/util/charset Move built-in charset modules to the top level
This removes the 'charset' subsystem and allows these modules to be
used across the whole of Samba.
Andrew Bartlett
Andrew Bartlett [Tue, 10 May 2011 20:11:55 +0000 (22:11 +0200)]
s3-netapi Initialise global variables in libnetapi
It is important to initalise the global variables when loading this
configuration for the potentially first time.
Andrew Bartlett
Andrew Bartlett [Tue, 10 May 2011 20:08:36 +0000 (22:08 +0200)]
s3-libnetapi Don't create a talloc_stackframe() in a global variable
This also ensures that libnetapi_free() invalidates the global
stat_ctx variable, and changes the API so that the behaviour of the
error string routines is to consistently return a allocated string.
Pair-Programmed-With: Günther Deschner <gd@samba.org>
Andrew Bartlett
Andrew Bartlett [Mon, 9 May 2011 15:43:45 +0000 (17:43 +0200)]
lib/util/ Fix crash bug caused by gfree_debug()
The issue is that we should reset the debug_num_classes to 0 when we
un-initialise the debug system.
Andrew Bartlett
Günther Deschner [Fri, 13 May 2011 13:03:59 +0000 (15:03 +0200)]
s3-net: fix potential crash bug in display_print_driver3().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 18:49:06 CEST 2011 on sn-devel-104
Michael Adam [Fri, 6 May 2011 15:10:13 +0000 (17:10 +0200)]
s3:build: install libtdb with full version number instead of only SO version
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri May 13 17:45:01 CEST 2011 on sn-devel-104
Michael Adam [Fri, 6 May 2011 15:10:13 +0000 (17:10 +0200)]
s3:build: install libtalloc with full version number instead of only SO version
Michael Adam [Fri, 6 May 2011 15:00:32 +0000 (17:00 +0200)]
s3:build: build libtalloc.so.$VERSION with full version number instead only SO version
Michael Adam [Fri, 6 May 2011 15:00:32 +0000 (17:00 +0200)]
s3:build: build libtdb.so.$VERSION with full version number instead only SO version
Michael Adam [Fri, 6 May 2011 14:43:31 +0000 (16:43 +0200)]
s3:build: link libtdb as shared lib if using shared libs at all
Michael Adam [Fri, 6 May 2011 14:42:53 +0000 (16:42 +0200)]
s3:build: determine full version of libtdb for the samba build
Michael Adam [Fri, 6 May 2011 14:42:07 +0000 (16:42 +0200)]
s3:build: link libtalloc as shared lib if using shared libs at all
Michael Adam [Fri, 6 May 2011 14:40:59 +0000 (16:40 +0200)]
s3:build: determine full version of libtalloc for the samba build
Michael Adam [Fri, 6 May 2011 14:39:03 +0000 (16:39 +0200)]
s3:build: fix typo in definition of --enable-external-libtdb
Michael Adam [Fri, 6 May 2011 14:38:38 +0000 (16:38 +0200)]
s3:build: reformat AC_ARG_ENABLE(external_libtalloc...)
Michael Adam [Fri, 6 May 2011 10:57:03 +0000 (12:57 +0200)]
s3:build: print the full version number in the showlibs targets
Michael Adam [Fri, 6 May 2011 14:37:58 +0000 (16:37 +0200)]
s3:build: add LIBWBCLIENT_FULLVER for consistency with SMB_LIBRARY()
Michael Adam [Fri, 6 May 2011 10:44:04 +0000 (12:44 +0200)]
s3:build: add an optional full version argument to the SMB_LIBRARY() macro.
Michael Adam [Fri, 6 May 2011 16:35:06 +0000 (18:35 +0200)]
s3:configure: add --enable-smbtorture4 switch
Simo Sorce [Wed, 11 May 2011 20:38:46 +0000 (16:38 -0400)]
rpc_server: Always use rpc_pipe_open_interface()
This way we can configure which rpc service we actually want to connect to.
By default it uses an "embedded" interface and calls rpc_pipe_open_internal()
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 14:40:26 CEST 2011 on sn-devel-104
Kamen Mazdrashki [Thu, 12 May 2011 16:43:54 +0000 (19:43 +0300)]
s4/test/getnc_exop: Tune the the test to work against windows
It turns out that sometimes, w2k8-r2 returns objects
even when FSMO extended request has failed.
Also verify that target DC returns source_dsa_guid and
source_dsa_invocation_id correctly
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Fri May 13 02:26:04 CEST 2011 on sn-devel-104
Günther Deschner [Thu, 12 May 2011 22:19:13 +0000 (00:19 +0200)]
s3-libnetjoin: fix uninitialized variable.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 01:22:18 CEST 2011 on sn-devel-104
Günther Deschner [Thu, 12 May 2011 22:15:41 +0000 (00:15 +0200)]
s3-libnetapi/libnetjoin: fix uninitialized variables after the libsmbconf changes.
Guenther
Günther Deschner [Thu, 12 May 2011 22:09:48 +0000 (00:09 +0200)]
libcli/auth/krb5_wrap: correctly use discard_const().
Jeremy, please check.
Guenther
Günther Deschner [Thu, 12 May 2011 15:03:20 +0000 (17:03 +0200)]
s3-lib/smbconf: fix uninitialized error code in smbconf_reg_init().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 18:09:16 CEST 2011 on sn-devel-104
Günther Deschner [Thu, 12 May 2011 12:33:15 +0000 (14:33 +0200)]
s3-waf: stop building smbtortre4.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 15:35:02 CEST 2011 on sn-devel-104
Michael Adam [Wed, 11 May 2011 09:57:10 +0000 (11:57 +0200)]
libcli/auth/smbencrypt: in E_deshash, use talloc_stackframe instead of "#if _SAMBA_BUILD_ == 3" and talloc_tos()
talloc_stackframe() is used in other shared components already,
and if the stack is a talloc_pool, then in most cases, it should
also not be more expensive than directly using talloc_tos().
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 12 12:52:02 CEST 2011 on sn-devel-104
Michael Adam [Wed, 11 May 2011 14:19:41 +0000 (16:19 +0200)]
s3:registry: add a warning debug message when the sorted subkeys is created from key_exists()
Michael Adam [Wed, 11 May 2011 13:58:48 +0000 (15:58 +0200)]
s3:registry: recreate the sorted subkeys cache when storing keys
This is to avoid turning the next read operation into a write op.
Michael Adam [Wed, 11 May 2011 13:27:01 +0000 (15:27 +0200)]
s3:registry: add create_sorted_subkeys() to delete and recreate the sorted subkeys key
This is to be used from other places than the key_exists() code path.
Michael Adam [Wed, 11 May 2011 12:53:48 +0000 (14:53 +0200)]
s3:registry: turn create_sorted_subkeys_internal to NTSTATUS return type
(from bool)
Michael Adam [Wed, 11 May 2011 12:49:10 +0000 (14:49 +0200)]
s3:registry: rename create_sorted_subkeys() to create_sorted_subkeys_internal()
Michael Adam [Wed, 11 May 2011 12:17:21 +0000 (14:17 +0200)]
s3:registry: fix a typo in a debug message
Volker Lendecke [Fri, 6 May 2011 09:26:56 +0000 (11:26 +0200)]
s3: Slightly simplify smbd_smb2_request_next_vector
Metze, Jeremy, please check!
Kamen Mazdrashki [Wed, 11 May 2011 18:05:42 +0000 (21:05 +0300)]
s4/drepl_fsmo: Add an CR so that message is visible in the logs
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed May 11 21:03:59 CEST 2011 on sn-devel-104
Kamen Mazdrashki [Wed, 11 May 2011 18:04:54 +0000 (21:04 +0300)]
s4/getnc_exop: Initial implementation of a testsuite for GetNCChanges extended opeartion handling
Kamen Mazdrashki [Wed, 11 May 2011 18:09:34 +0000 (21:09 +0300)]
s4/getncchanges: Pre-mark extended requests as success in case a sub-function "forget" to do this
Kamen Mazdrashki [Wed, 11 May 2011 17:49:42 +0000 (20:49 +0300)]
s4/getncchanges: Implement placeholder for handling ex-op collection of objects
Right now it is solely based on function that handles objects
in normal DsGetNCChanges calls.
Kamen Mazdrashki [Wed, 11 May 2011 17:48:53 +0000 (20:48 +0300)]
s4/getncchanges: Move the code that collects objects into separate function
Kamen Mazdrashki [Mon, 9 May 2011 17:11:22 +0000 (20:11 +0300)]
s4/getncchanges: Don't mask Extended operation result - callers need it
Kamen Mazdrashki [Mon, 9 May 2011 17:09:49 +0000 (20:09 +0300)]
s4/getncchanges: Fail extended request rather than failing whole request
in case that destination_dsa_guid is not valid
Günther Deschner [Wed, 11 May 2011 08:30:42 +0000 (10:30 +0200)]
s3-printing: make cups_pull_comment_location() work again.
we deal with lp_cups_server in cups_connect() already, inside the URI all our
other cups functions we use ipp://localhost, do the same here.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 11 11:36:07 CEST 2011 on sn-devel-104
Michael Adam [Tue, 10 May 2011 20:02:49 +0000 (22:02 +0200)]
s3:librpc: remove unneded gssapi includes from source3/librpc/crypto/gse.c
These come in via the smb_krb5.h include (and lib/replace/system/kerberos.h)
in the end.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue May 10 23:12:31 CEST 2011 on sn-devel-104
Michael Adam [Tue, 10 May 2011 19:59:38 +0000 (21:59 +0200)]
libcli/auth: fix "no talloc stackframe around" message from the samba4.blackbox.kinit test
create_kerberos_key_from_string_direct() used talloc_tos() directly.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Tue, 10 May 2011 18:54:06 +0000 (20:54 +0200)]
lib/replace: fix an #if HAVE_GSSAPI_GSSAPI_EXT_H to be an #ifdef
Andreas Schneider [Thu, 14 Apr 2011 09:59:57 +0000 (11:59 +0200)]
libsmbconf: Define a doxygen group for libsmbconf.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:54:11 +0000 (11:54 +0200)]
libsmbconf: Document smbconf_transaction_cancel().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:53:25 +0000 (11:53 +0200)]
libsmbconf: Document smbconf_transaction_commit().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:52:30 +0000 (11:52 +0200)]
libsmbconf: Document smbconf_transaction_start().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:50:05 +0000 (11:50 +0200)]
libsmbconf: Document smbconf_delete_global_includes().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:49:24 +0000 (11:49 +0200)]
libsmbconf: Document smbconf_delete_includes().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:48:15 +0000 (11:48 +0200)]
libsmbconf: Document smbconf_set_global_includes().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:47:41 +0000 (11:47 +0200)]
libsmbconf: Document smbconf_set_includes().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:45:14 +0000 (11:45 +0200)]
libsmbconf: Document smbconf_get_global_includes().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:44:22 +0000 (11:44 +0200)]
libsmbconf: Document smbconf_get_includes().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:38:31 +0000 (11:38 +0200)]
libsmbconf: Document smbconf_delete_global_parameter().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:37:59 +0000 (11:37 +0200)]
libsmbconf: Document smbconf_delete_parameter().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:36:36 +0000 (11:36 +0200)]
libsmbconf: Document smbconf_get_global_parameter().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:35:11 +0000 (11:35 +0200)]
libsmbconf: Document smbconf_get_parameter().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:32:06 +0000 (11:32 +0200)]
libsmbconf: Document smbconf_set_global_parameter().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:31:17 +0000 (11:31 +0200)]
libsmbconf: Document smbconf_set_parameter().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:28:00 +0000 (11:28 +0200)]
libsmbconf: Document smbconf_delete_share().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:27:03 +0000 (11:27 +0200)]
libsmbconf: Document smbconf_get_share().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:25:07 +0000 (11:25 +0200)]
libsmbconf: Document smbconf_create_share().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:23:56 +0000 (11:23 +0200)]
libsmbconf: Document smbconf_share_exists().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:22:25 +0000 (11:22 +0200)]
libsmbconf: Document smbconf_get_share_names().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:19:36 +0000 (11:19 +0200)]
libsmbconf: Document smbconf_get_config().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:13:49 +0000 (11:13 +0200)]
libsmbconf: Document smbconf_drop().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:12:27 +0000 (11:12 +0200)]
libsmbconf: Document smbconf_changed().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:05:09 +0000 (11:05 +0200)]
libsmbconf: Document smbconf_shutdown().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:04:15 +0000 (11:04 +0200)]
libsmbconf: Document smbconf_is_writeable().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 14 Apr 2011 09:02:49 +0000 (11:02 +0200)]
libsmbconf: Document smbconf_backend_requires_messaging().
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Tue, 12 Apr 2011 09:02:07 +0000 (11:02 +0200)]
s3-waf: Create a public libsmconf.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Tue, 12 Apr 2011 08:59:20 +0000 (10:59 +0200)]
s3-waf: Create a registry private library.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 15:43:10 +0000 (17:43 +0200)]
libsmbconf: Convert smbconf_get_config() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 15:24:13 +0000 (17:24 +0200)]
libsmbconf: Convert smbconf_transaction_*() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 14:01:22 +0000 (16:01 +0200)]
libsmbconf: Convert smbconf_delete_includes() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 13:14:52 +0000 (15:14 +0200)]
libsmbconf: Convert smbconf_set_includes() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 12:52:52 +0000 (14:52 +0200)]
libsmbconf: Convert smbconf_get_includes() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 12:20:32 +0000 (14:20 +0200)]
libsmbconf: Convert smbconf_delete_parameter() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 11:50:53 +0000 (13:50 +0200)]
libsmbconf: Convert smbconf_get_parameter() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 11:23:26 +0000 (13:23 +0200)]
libsmbconf: Convert smbconf_set_parameter() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Mon, 11 Apr 2011 09:39:03 +0000 (11:39 +0200)]
libsmbconf: Convert smbconf_delete_share() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Fri, 8 Apr 2011 15:20:35 +0000 (17:20 +0200)]
libsmbconf: Convert smbconf_get_share() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Fri, 8 Apr 2011 13:48:01 +0000 (15:48 +0200)]
libsmbconf: Convert smbconf_create_share() to smbErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Fri, 8 Apr 2011 12:19:15 +0000 (14:19 +0200)]
libsmbconf: Convert smbconf_get_share_names() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Fri, 8 Apr 2011 08:40:02 +0000 (10:40 +0200)]
libsmbconf: Convert smbconf_drop() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Fri, 8 Apr 2011 08:28:17 +0000 (10:28 +0200)]
libsmbconf: Convert smbconf_open() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 7 Apr 2011 15:19:03 +0000 (17:19 +0200)]
libsmbconf: Convert smbconf_init() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 7 Apr 2011 13:27:52 +0000 (15:27 +0200)]
libsmbconf: Added a sbcErrorString() function.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Thu, 7 Apr 2011 13:27:26 +0000 (15:27 +0200)]
libsmbconf: Introduce a sbcErrType.
Signed-off-by: Michael Adam <obnox@samba.org>
Jelmer Vernooij [Mon, 9 May 2011 07:13:15 +0000 (09:13 +0200)]
Fix alpha version - we're now working on alpha16.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue May 10 18:36:08 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 10 May 2011 13:49:05 +0000 (15:49 +0200)]
s3-printing: Fix double free of cups request.
We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):
"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."
Revert "Fix a memory leak in cups_pull_comment_location"
This reverts commit
fee2664dad37536b05ce8bdae3e74d45b257f632.
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 10 May 2011 13:48:25 +0000 (15:48 +0200)]
s3-printing: very obvious fix for cups_pull_comment_location().
This has been in there since 2008...
Guenther
Andrew Tridgell [Tue, 10 May 2011 12:55:45 +0000 (14:55 +0200)]
s3-events: tevent_internal.h is not a public header
We need to use the "foo.h" form instead of the <foo.h> form for
headers that are not installed publicly. Otherwise when an external
version of tevent is used we won't find the header and the build will
fail.
Note that this creates a structure dependency between the
tevent structures in the external library and the headers in our
source tree. That is not ideal, but is currently OK as the waf build
will only use the external library if it is at least the same version
as the internal tree, which means it will actually be the same
version, as we release the external version from our tree.
We should come up with a better solution, but for now this allows
openchange to build again.
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue May 10 16:06:40 CEST 2011 on sn-devel-104
Volker Lendecke [Tue, 10 May 2011 09:05:47 +0000 (11:05 +0200)]
s3: Use tevent_req_ntstatus properly in a few places
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 10 13:11:10 CEST 2011 on sn-devel-104
Volker Lendecke [Tue, 10 May 2011 09:05:47 +0000 (11:05 +0200)]
s3: Use tevent_req_ntstatus properly in a few places
Rusty Russell [Tue, 10 May 2011 08:03:11 +0000 (17:33 +0930)]
async_smb.c: convert cli->timeout properly
I have a test failure on my 32-bit Ubuntu system, in that
samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than
waiting 5 seconds for the child).
Debugging revealed this code: timeout is in ms and is set to > 1000 in
various places. The code dates from 2002, and other perturbations didn't
reveal why it breaks now, but fix it anyway.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104
Rusty Russell [Tue, 10 May 2011 02:16:53 +0000 (11:46 +0930)]
tdb_wrap.h: not a public header.
It is a private library, and OpenChange has their own which they use, so
it's not for them either.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue May 10 05:21:19 CEST 2011 on sn-devel-104
Rusty Russell [Tue, 19 Apr 2011 02:36:05 +0000 (12:06 +0930)]
gencache: don't use CLEAR_IF_FIRST as fallback.
CLEAR_IF_FIRST only works if *all* openers use that flag.
So just truncate the file: it's racy, but that's what we're doing anyway.
We'd really need a TDB_OPENCHECK_OR_CLEAR flag to do this properly (or in
TDB2, a open hook at the right point).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>