-After applying this patch and running configure, you MUST run this
-command before "make":
+To use this patch, run these commands for a successful build:
- make proto
+ patch -p1 <patches/atimes.diff
+ ./prepare-source
+ ./configure (optional if already run)
+ make
---- orig/batch.c 2005-02-16 17:08:13
-+++ batch.c 2004-07-03 20:15:41
-@@ -205,6 +205,8 @@ void show_flist(int index, struct file_s
- rprintf(FINFO, "flist->flags=%#x\n", fptr[i]->flags);
- rprintf(FINFO, "flist->modtime=%#lx\n",
- (long unsigned) fptr[i]->modtime);
-+ rprintf(FINFO, "flist->atime=%#lx\n",
-+ (long unsigned) fptr[i]->atime);
- rprintf(FINFO, "flist->length=%.0f\n",
- (double) fptr[i]->length);
- rprintf(FINFO, "flist->mode=%#o\n", (int) fptr[i]->mode);
---- orig/flist.c 2005-02-20 00:16:35
-+++ flist.c 2005-02-07 21:06:04
-@@ -54,6 +54,7 @@ extern int relative_paths;
+--- old/flist.c
++++ new/flist.c
+@@ -46,6 +46,7 @@ extern int preserve_devices;
+ extern int preserve_specials;
+ extern int preserve_uid;
+ extern int preserve_gid;
++extern int preserve_atimes;
+ extern int relative_paths;
extern int implied_dirs;
- extern int copy_links;
- extern int copy_unsafe_links;
-+extern int copy_atimes;
- extern int protocol_version;
- extern int sanitize_paths;
- extern int deletion_count;
-@@ -143,16 +144,18 @@ static void list_file_entry(struct file_
+ extern int flist_extra_cnt;
+@@ -134,6 +135,7 @@ void show_flist_stats(void)
+ static void list_file_entry(struct file_struct *f)
+ {
+ char permbuf[PERMSTRING_SIZE];
++ time_t atime = preserve_atimes ? F_ATIME(f) : 0;
+ double len;
+
+ if (!F_IS_ACTIVE(f)) {
+@@ -146,14 +148,16 @@ static void list_file_entry(struct file_
#ifdef SUPPORT_LINKS
if (preserve_links && S_ISLNK(f->mode)) {
- rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
+ rprintf(FINFO, "%s %11.0f %s %s %s -> %s\n",
- perms,
- (double)f->length, timestring(f->modtime),
-+ timestring(f->atime),
- safe_fname(f_name(f)), safe_fname(f->u.link));
+ permbuf, len, timestring(f->modtime),
++ preserve_atimes ? timestring(atime) : "",
+ f_name(f, NULL), F_SYMLINK(f));
} else
#endif
{
- rprintf(FINFO, "%s %11.0f %s %s\n",
+ rprintf(FINFO, "%s %11.0f %s %s %s\n",
- perms,
- (double)f->length, timestring(f->modtime),
-+ timestring(f->atime),
- safe_fname(f_name(f)));
+ permbuf, len, timestring(f->modtime),
++ preserve_atimes ? timestring(atime) : "",
+ f_name(f, NULL));
}
}
-@@ -316,6 +319,7 @@ void send_file_entry(struct file_struct
+@@ -311,6 +315,7 @@ static void send_file_entry(struct file_
{
unsigned short flags;
static time_t modtime;
static mode_t mode;
static int64 dev;
static dev_t rdev;
-@@ -331,7 +335,7 @@ void send_file_entry(struct file_struct
+@@ -326,7 +331,7 @@ static void send_file_entry(struct file_
if (!file) {
write_byte(f, 0);
- modtime = 0, mode = 0;
+ modtime = 0, atime = 0, mode = 0;
- dev = 0, rdev = makedev(0, 0);
+ dev = 0, rdev = MAKEDEV(0, 0);
rdev_major = 0;
uid = 0, gid = 0;
-@@ -380,6 +384,12 @@ void send_file_entry(struct file_struct
+@@ -376,6 +381,13 @@ static void send_file_entry(struct file_
flags |= XMIT_SAME_TIME;
else
modtime = file->modtime;
-+ if (copy_atimes && !S_ISDIR(mode)) {
-+ if (file->atime == atime)
++ if (preserve_atimes && !S_ISDIR(mode)) {
++ time_t file_atime = F_ATIME(file);
++ if (file_atime == atime)
+ flags |= XMIT_SAME_ATIME;
+ else
-+ atime = file->atime;
++ atime = file_atime;
+ }
#ifdef SUPPORT_HARD_LINKS
- if (file->link_u.idev) {
-@@ -435,6 +445,8 @@ void send_file_entry(struct file_struct
+ if (tmp_idev.dev != 0) {
+@@ -428,6 +440,8 @@ static void send_file_entry(struct file_
write_int(f, modtime);
if (!(flags & XMIT_SAME_MODE))
write_int(f, to_wire_mode(mode));
-+ if (copy_atimes && !S_ISDIR(mode) && !(flags & XMIT_SAME_ATIME))
++ if (preserve_atimes && !S_ISDIR(mode) && !(flags & XMIT_SAME_ATIME))
+ write_int(f, atime);
if (preserve_uid && !(flags & XMIT_SAME_UID)) {
if (!numeric_ids)
add_uid(uid);
-@@ -508,6 +520,7 @@ static struct file_struct *receive_file_
- unsigned short flags, int f)
+@@ -494,7 +508,7 @@ static void send_file_entry(struct file_
+ static struct file_struct *recv_file_entry(struct file_list *flist,
+ unsigned short flags, int f)
{
- static time_t modtime;
-+ static time_t atime;
+- static time_t modtime;
++ static time_t modtime, atime;
static mode_t mode;
static int64 dev;
static dev_t rdev;
-@@ -526,7 +539,7 @@ static struct file_struct *receive_file_
+@@ -514,7 +528,7 @@ static struct file_struct *recv_file_ent
struct file_struct *file;
if (!flist) {
- modtime = 0, mode = 0;
+ modtime = 0, atime = 0, mode = 0;
- dev = 0, rdev = makedev(0, 0);
+ dev = 0, rdev = MAKEDEV(0, 0);
rdev_major = 0;
uid = 0, gid = 0;
-@@ -582,6 +595,8 @@ static struct file_struct *receive_file_
+@@ -570,6 +584,8 @@ static struct file_struct *recv_file_ent
modtime = (time_t)read_int(f);
if (!(flags & XMIT_SAME_MODE))
mode = from_wire_mode(read_int(f));
-+ if (copy_atimes && !S_ISDIR(mode) && !(flags & XMIT_SAME_ATIME))
++ if (preserve_atimes && !S_ISDIR(mode) && !(flags & XMIT_SAME_ATIME))
+ atime = (time_t)read_int(f);
- if (preserve_uid && !(flags & XMIT_SAME_UID))
- uid = (uid_t)read_int(f);
-@@ -632,6 +647,7 @@ static struct file_struct *receive_file_
-
- file->flags = 0;
- file->modtime = modtime;
-+ file->atime = atime;
- file->length = file_length;
- file->mode = mode;
- file->uid = uid;
-@@ -881,6 +897,7 @@ skip_filters:
-
- file->flags = flags;
- file->modtime = st.st_mtime;
-+ file->atime = st.st_atime;
- file->length = st.st_size;
- file->mode = st.st_mode;
- file->uid = st.st_uid;
---- orig/generator.c 2005-02-20 22:13:19
-+++ generator.c 2004-11-03 23:02:12
-@@ -150,7 +150,7 @@ static int unchanged_file(char *fn, stru
- if (ignore_times)
- return 0;
-
-- return cmp_modtime(st->st_mtime, file->modtime) == 0;
-+ return cmp_time(st->st_mtime, file->modtime) == 0;
- }
-
-
-@@ -725,7 +725,7 @@ static void recv_generator(char *fname,
- }
-
- if (update_only && fnamecmp_type == FNAMECMP_FNAME
-- && cmp_modtime(st.st_mtime, file->modtime) > 0) {
-+ && cmp_time(st.st_mtime, file->modtime) > 0) {
- if (verbose > 1)
- rprintf(FINFO, "%s is newer\n", safe_fname(fname));
- return;
---- orig/options.c 2005-02-21 07:28:59
-+++ options.c 2005-01-24 01:51:48
-@@ -50,6 +50,7 @@ int preserve_uid = 0;
+ if (chmod_modes && !S_ISLNK(mode))
+ mode = tweak_mode(mode, chmod_modes);
+@@ -654,6 +670,8 @@ static struct file_struct *recv_file_ent
+ F_UID(file) = uid;
+ if (preserve_gid)
+ F_GID(file) = gid;
++ if (preserve_atimes)
++ F_ATIME(file) = atime;
+
+ if (dirname_len) {
+ file->dirname = lastdir = bp;
+@@ -930,6 +948,8 @@ struct file_struct *make_file(const char
+ F_UID(file) = st.st_uid;
+ if (preserve_gid)
+ F_GID(file) = st.st_gid;
++ if (preserve_atimes)
++ F_ATIME(file) = st.st_atime;
+
+ if (dirname_len) {
+ file->dirname = lastdir = bp;
+--- old/generator.c
++++ new/generator.c
+@@ -43,6 +43,7 @@ extern int preserve_perms;
+ extern int preserve_uid;
+ extern int preserve_gid;
+ extern int preserve_times;
++extern int preserve_atimes;
+ extern int omit_dir_times;
+ extern int delete_mode;
+ extern int delete_before;
+@@ -475,6 +476,9 @@ void itemize(struct file_struct *file, i
+ && (!(iflags & ITEM_XNAME_FOLLOWS) || *xname))
+ || (keep_time && cmp_time(file->modtime, st->st_mtime) != 0))
+ iflags |= ITEM_REPORT_TIME;
++ if (preserve_atimes && !S_ISDIR(file->mode) && !S_ISLNK(file->mode)
++ && cmp_time(F_ATIME(file), st->st_atime) != 0)
++ iflags |= ITEM_REPORT_ATIME;
+ if ((file->mode & CHMOD_BITS) != (st->st_mode & CHMOD_BITS))
+ iflags |= ITEM_REPORT_PERMS;
+ if (preserve_uid && am_root && F_UID(file) != st->st_uid)
+@@ -785,6 +789,8 @@ static int try_dests_reg(struct file_str
+ if (hard_link_one(file, ndx, fname, 0, stp,
+ cmpbuf, 1, i, code) < 0)
+ goto try_a_copy;
++ if (preserve_atimes)
++ set_file_attrs(fname, file, stp, 0);
+ if (preserve_hard_links && F_IS_HLINKED(file))
+ hard_link_cluster(file, ndx, itemizing, code, j);
+ } else
+--- old/log.c
++++ new/log.c
+@@ -37,6 +37,7 @@ extern int msg_fd_out;
+ extern int allow_8bit_chars;
+ extern int protocol_version;
+ extern int preserve_times;
++extern int preserve_atimes;
+ extern int preserve_uid;
+ extern int preserve_gid;
+ extern int stdout_format_has_i;
+@@ -625,7 +626,8 @@ static void log_formatted(enum logcode c
+ c[5] = !(iflags & ITEM_REPORT_PERMS) ? '.' : 'p';
+ c[6] = !(iflags & ITEM_REPORT_OWNER) ? '.' : 'o';
+ c[7] = !(iflags & ITEM_REPORT_GROUP) ? '.' : 'g';
+- c[8] = '.';
++ c[8] = !(iflags & ITEM_REPORT_ATIME) ? '.'
++ : S_ISLNK(file->mode) ? 'U' : 'u';
+ c[9] = '\0';
+
+ if (iflags & (ITEM_IS_NEW|ITEM_MISSING_DATA)) {
+--- old/options.c
++++ new/options.c
+@@ -55,6 +55,7 @@ int preserve_uid = 0;
int preserve_gid = 0;
int preserve_times = 0;
int omit_dir_times = 0;
-+int copy_atimes = 0;
++int preserve_atimes = 0;
int update_only = 0;
int cvs_exclude = 0;
int dry_run = 0;
-@@ -284,6 +285,7 @@ void usage(enum logcode F)
- rprintf(F," -g, --group preserve group\n");
- rprintf(F," -D, --devices preserve devices (root only)\n");
- rprintf(F," -t, --times preserve times\n");
-+ rprintf(F," -A, --copy-atimes copy access times\n");
- rprintf(F," -O, --omit-dir-times omit directories when preserving times\n");
+@@ -307,8 +308,9 @@ void usage(enum logcode F)
+ rprintf(F," --devices preserve device files (super-user only)\n");
+ rprintf(F," --specials preserve special files\n");
+ rprintf(F," -D same as --devices --specials\n");
+- rprintf(F," -t, --times preserve times\n");
+- rprintf(F," -O, --omit-dir-times omit directories when preserving times\n");
++ rprintf(F," -t, --times preserve modify times\n");
++ rprintf(F," -O, --omit-dir-times omit directories when preserving modify times\n");
++ rprintf(F," -U, --atimes preserve access (use) times\n");
+ rprintf(F," --super receiver attempts super-user activities\n");
rprintf(F," -S, --sparse handle sparse files efficiently\n");
rprintf(F," -n, --dry-run show what would have been transferred\n");
-@@ -408,6 +410,7 @@ static struct poptOption long_options[]
- {"devices", 'D', POPT_ARG_NONE, &preserve_devices, 0, 0, 0 },
- {"times", 't', POPT_ARG_NONE, &preserve_times, 0, 0, 0 },
- {"omit-dir-times", 'O', POPT_ARG_NONE, &omit_dir_times, 0, 0, 0 },
-+ {"copy-atimes", 'A', POPT_ARG_NONE, ©_atimes, 0, 0, 0 },
- {"checksum", 'c', POPT_ARG_NONE, &always_checksum, 0, 0, 0 },
- {"verbose", 'v', POPT_ARG_NONE, 0, 'v', 0, 0 },
- {"quiet", 'q', POPT_ARG_NONE, 0, 'q', 0, 0 },
-@@ -1272,6 +1275,8 @@ void server_options(char **args,int *arg
+@@ -425,6 +427,9 @@ static struct poptOption long_options[]
+ {"times", 't', POPT_ARG_VAL, &preserve_times, 1, 0, 0 },
+ {"no-times", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
+ {"no-t", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
++ {"atimes", 'U', POPT_ARG_VAL, &preserve_atimes, 1, 0, 0 },
++ {"no-atimes", 0, POPT_ARG_VAL, &preserve_atimes, 0, 0, 0 },
++ {"no-U", 0, POPT_ARG_VAL, &preserve_atimes, 0, 0, 0 },
+ {"omit-dir-times", 'O', POPT_ARG_VAL, &omit_dir_times, 2, 0, 0 },
+ {"modify-window", 0, POPT_ARG_INT, &modify_window, OPT_MODIFY_WINDOW, 0, 0 },
+ {"super", 0, POPT_ARG_VAL, &am_root, 2, 0, 0 },
+@@ -1223,6 +1228,8 @@ int parse_arguments(int *argc, const cha
+ preserve_uid = ++flist_extra_cnt;
+ if (preserve_gid)
+ preserve_gid = ++flist_extra_cnt;
++ if (preserve_atimes)
++ preserve_atimes = ++flist_extra_cnt;
+
+ *argv = poptGetArgs(pc);
+ *argc = count_args(*argv);
+@@ -1542,6 +1549,8 @@ void server_options(char **args,int *arg
argstr[x++] = 'D';
if (preserve_times)
argstr[x++] = 't';
-+ if (copy_atimes)
-+ argstr[x++] = 'A';
- if (omit_dir_times && am_sender)
- argstr[x++] = 'O';
++ if (preserve_atimes)
++ argstr[x++] = 'U';
if (preserve_perms)
---- orig/rsync.c 2005-02-20 00:02:23
-+++ rsync.c 2005-01-24 01:59:12
-@@ -27,6 +27,7 @@ extern int dry_run;
- extern int daemon_log_format_has_i;
+ argstr[x++] = 'p';
+ else if (preserve_executability && am_sender)
+--- old/rsync.c
++++ new/rsync.c
+@@ -34,6 +34,7 @@ extern int verbose;
+ extern int dry_run;
+ extern int preserve_perms;
+ extern int preserve_executability;
++extern int preserve_atimes;
extern int preserve_times;
extern int omit_dir_times;
-+extern int copy_atimes;
extern int am_root;
- extern int am_server;
- extern int am_sender;
-@@ -173,6 +174,7 @@ int set_perms(char *fname,struct file_st
+@@ -182,6 +183,7 @@ int set_file_attrs(char *fname, struct f
int updated = 0;
STRUCT_STAT st2;
int change_uid, change_gid;
+ time_t atime, mtime;
+ mode_t new_mode = file->mode;
if (!st) {
- if (dry_run)
-@@ -185,18 +187,28 @@ int set_perms(char *fname,struct file_st
- st = &st2;
+@@ -201,18 +203,36 @@ int set_file_attrs(char *fname, struct f
+ }
}
-+ if (!copy_atimes || S_ISLNK(st->st_mode) || S_ISDIR(st->st_mode))
-+ flags |= PERMS_SKIP_ATIME;
- if (!preserve_times || S_ISLNK(st->st_mode)
- || (S_ISDIR(st->st_mode)
- && (omit_dir_times || (make_backups && !backup_dir))))
- flags |= PERMS_SKIP_MTIME;
-+ if (!(flags & PERMS_SKIP_ATIME)
-+ && cmp_time(st->st_atime, file->atime) != 0) {
-+ atime = file->atime;
-+ updated = 1;
-+ } else
-+ atime = st->st_atime;
- if (!(flags & PERMS_SKIP_MTIME)
-- && cmp_modtime(st->st_mtime, file->modtime) != 0) {
-- if (set_modtime(fname,file->modtime) != 0) {
-- rsyserr(FERROR, errno, "failed to set times on %s",
-- full_fname(fname));
-- return 0;
-- }
-+ && cmp_time(st->st_mtime, file->modtime) != 0) {
++ /* This code must be the first update in the function due to
++ * how it uses the "updated" variable. */
+ if (!preserve_times || (S_ISDIR(st->st_mode) && omit_dir_times))
+ flags |= ATTRS_SKIP_MTIME;
++ if (!preserve_atimes || S_ISDIR(st->st_mode))
++ flags |= ATTRS_SKIP_ATIME;
+ if (!(flags & ATTRS_SKIP_MTIME)
+ && cmp_time(st->st_mtime, file->modtime) != 0) {
+- int ret = set_modtime(fname, file->modtime, st->st_mode);
+ mtime = file->modtime;
- updated = 1;
++ updated = 1;
+ } else
+ mtime = st->st_mtime;
-+ if (updated && set_times(fname, mtime, atime) != 0) {
-+ rsyserr(FERROR, errno, "failed to set times on %s",
-+ full_fname(fname));
-+ return 0;
++ if (!(flags & ATTRS_SKIP_ATIME)) {
++ time_t file_atime = F_ATIME(file);
++ if (cmp_time(st->st_atime, file_atime) != 0) {
++ atime = file_atime;
++ updated = 1;
++ } else
++ atime = st->st_atime;
++ } else
++ atime = st->st_atime;
++ if (updated) {
++ int ret = set_times(fname, mtime, atime, st->st_mode);
+ if (ret < 0) {
+ rsyserr(FERROR, errno, "failed to set times on %s",
+ full_fname(fname));
+ return 0;
+ }
+- if (ret == 0) /* ret == 1 if symlink could not be set */
+- updated = 1;
++ if (ret > 0) /* ret == 1 if symlink could not be set */
++ updated = 0;
}
- change_uid = am_root && preserve_uid && st->st_uid != file->uid;
---- orig/rsync.h 2005-02-20 00:02:23
-+++ rsync.h 2004-07-03 20:15:41
+ change_uid = am_root && preserve_uid && st->st_uid != F_UID(file);
+--- old/rsync.h
++++ new/rsync.h
@@ -54,6 +54,7 @@
#define XMIT_HAS_IDEV_DATA (1<<9)
#define XMIT_SAME_DEV (1<<10)
/* These flags are used in the live flist data. */
-@@ -116,6 +117,7 @@
+@@ -121,6 +122,7 @@
- #define PERMS_REPORT (1<<0)
- #define PERMS_SKIP_MTIME (1<<1)
-+#define PERMS_SKIP_ATIME (1<<2)
+ #define ATTRS_REPORT (1<<0)
+ #define ATTRS_SKIP_MTIME (1<<1)
++#define ATTRS_SKIP_ATIME (1<<2)
#define FULL_FLUSH 1
#define NORMAL_FLUSH 0
-@@ -498,6 +500,7 @@ struct file_struct {
- struct hlink *links;
- } link_u;
- time_t modtime;
-+ time_t atime;
- uid_t uid;
- gid_t gid;
- mode_t mode;
---- orig/rsync.yo 2005-02-20 01:12:43
-+++ rsync.yo 2005-01-24 01:57:18
-@@ -322,6 +322,7 @@ to the detailed description below for a
- -D, --devices preserve devices (root only)
- -t, --times preserve times
- -O, --omit-dir-times omit directories when preserving times
-+ -A, --copy-atimes copy access times
+@@ -511,6 +513,7 @@ struct file_struct {
+ union flist_extras {
+ uid_t uid; /* The user ID number */
+ uid_t gid; /* The group ID number or GID_NONE */
++ time_t utime; /* A unix-time value */
+ struct idev *idev; /* The hard-link info during matching */
+ struct hlist *hlist; /* The hard-link info after matching */
+ uint32 unum; /* An unsigned number */
+@@ -551,6 +554,7 @@ extern int preserve_gid;
+ /* When the associated option is on, all entries will have these present: */
+ #define F_UID(f) REQ_EXTRA(f, preserve_uid)->uid
+ #define F_GID(f) REQ_EXTRA(f, preserve_gid)->gid
++#define F_ATIME(f) REQ_EXTRA(f, preserve_atimes)->utime
+
+ /* These are per-entry optional and mutally exclusive: */
+ #define F_IDEV(f) OPT_EXTRA(f, LEN64_BUMP(f))->idev
+--- old/rsync.yo
++++ new/rsync.yo
+@@ -328,8 +328,9 @@ to the detailed description below for a
+ --devices preserve device files (super-user only)
+ --specials preserve special files
+ -D same as --devices --specials
+- -t, --times preserve times
+- -O, --omit-dir-times omit directories when preserving times
++ -t, --times preserve modify times
++ -O, --omit-dir-times omit directories when preserving mod-times
++ -U, --atimes preserve access (use) times
+ --super receiver attempts super-user activities
-S, --sparse handle sparse files efficiently
-n, --dry-run show what would have been transferred
- -W, --whole-file copy files whole (without rsync algorithm)
-@@ -654,6 +655,11 @@ dit(bf(-O, --omit-dir-times)) This tells
- it is preserving modification times (see bf(--times)). If NFS is sharing
+@@ -870,6 +871,12 @@ it is preserving modification times (see
the directories on the receiving side, it is a good idea to use bf(-O).
+ This option is inferred if you use bf(--backup) without bf(--backup-dir).
-+dit(bf(-A, --copy-atimes)) This tells rsync to transfer access times
-+along with the files and update them on the remote system. Note that
-+reading the source file may update the atime and hence repeated rsync
-+copies with --copy-atimes may copy files unnecessarily.
++dit(bf(-U, --atimes)) This tells rsync to set the access (use) times of the
++destination files to the same value as the source files. Note that the
++reading of the source file may update the atime of the source files, so
++repeated rsync runs with --atimes may be needed if you want to force the
++access-time values to be 100% identical on the two systems.
+
- dit(bf(-n, --dry-run)) This tells rsync to not do any file transfers,
- instead it will just report the actions it would have taken.
-
---- orig/testsuite/copy-atimes.test 2004-06-30 00:06:23
-+++ testsuite/copy-atimes.test 2004-06-30 00:06:23
+ dit(bf(--super)) This tells the receiving side to attempt super-user
+ activities even if the receiving rsync wasn't run by the super-user. These
+ activities include: preserving users via the bf(--owner) option, preserving
+@@ -1403,7 +1410,7 @@ with older versions of rsync, but that a
+ verbose messages).
+
+ The "%i" escape has a cryptic output that is 9 letters long. The general
+-format is like the string bf(YXcstpogz), where bf(Y) is replaced by the
++format is like the string bf(YXcstpogu), where bf(Y) is replaced by the
+ type of update being done, bf(X) is replaced by the file-type, and the
+ other letters represent attributes that may be output if they are being
+ modified.
+@@ -1443,7 +1450,7 @@ quote(itemization(
+ by the file transfer.
+ it() A bf(t) means the modification time is different and is being updated
+ to the sender's value (requires bf(--times)). An alternate value of bf(T)
+- means that the time will be set to the transfer time, which happens
++ means that the modify time will be set to the transfer time, which happens
+ anytime a symlink is transferred, or when a file or device is transferred
+ without bf(--times).
+ it() A bf(p) means the permissions are different and are being updated to
+@@ -1452,7 +1459,10 @@ quote(itemization(
+ sender's value (requires bf(--owner) and super-user privileges).
+ it() A bf(g) means the group is different and is being updated to the
+ sender's value (requires bf(--group) and the authority to set the group).
+- it() The bf(z) slot is reserved for future use.
++ it() A bf(u) means the access (use) time is different and is being updated to
++ the sender's value (requires bf(--atimes)). An alternate value of bf(U)
++ means that the access time will be set to the transfer time, which happens
++ when a symlink or directory is updated.
+ ))
+
+ One other output is possible: when deleting files, the "%i" will output
+--- old/sender.c
++++ new/sender.c
+@@ -41,6 +41,7 @@ extern int do_progress;
+ extern int inplace;
+ extern int batch_fd;
+ extern int write_batch;
++extern unsigned int file_struct_len;
+ extern struct stats stats;
+ extern struct file_list *the_file_list;
+ extern char *stdout_format;
+--- old/testsuite/atimes.test
++++ new/testsuite/atimes.test
@@ -0,0 +1,19 @@
+#! /bin/sh
+
+
+TLS_ARGS=--atime
+
-+checkit "$RSYNC -rtAgvvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
++checkit "$RSYNC -rtUgvvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
+
+# The script would have aborted on error, so getting here means we've won.
+exit 0
---- orig/testsuite/rsync.fns 2005-02-21 07:29:00
-+++ testsuite/rsync.fns 2005-02-21 07:30:11
-@@ -50,7 +50,7 @@ printmsg() {
-
+--- old/testsuite/rsync.fns
++++ new/testsuite/rsync.fns
+@@ -66,7 +66,7 @@ printmsg() {
+ }
rsync_ls_lR() {
- find "$@" -print | sort | sed 's/ /\\ /g' | xargs "$TOOLDIR/tls"
+ find "$@" -print | sort | sed 's/ /\\ /g' | xargs "$TOOLDIR/tls" $TLS_ARGS
}
- rsync_getgroups() {
-@@ -158,6 +158,8 @@ checkit() {
+ check_perms() {
+@@ -184,6 +184,10 @@ checkit() {
# We can just write everything to stdout/stderr, because the
# wrapper hides it unless there is a problem.
-+ ( cd "$2" && rsync_ls_lR . ) > "$tmpdir/ls-from"
++ if test x$TLS_ARGS = x--atime; then
++ ( cd "$2" && rsync_ls_lR . ) > "$tmpdir/ls-from"
++ fi
+
echo "Running: \"$1\""
eval "$1"
status=$?
-@@ -168,7 +170,6 @@ checkit() {
+@@ -191,10 +195,13 @@ checkit() {
+ failed="YES";
+ fi
+
++ if test x$TLS_ARGS != x--atime; then
++ ( cd "$2" && rsync_ls_lR . ) > "$tmpdir/ls-from"
++ fi
++
echo "-------------"
echo "check how the directory listings compare with diff:"
echo ""
( cd "$3" && rsync_ls_lR . ) > "$tmpdir/ls-to"
diff $diffopt "$tmpdir/ls-from" "$tmpdir/ls-to" || failed=YES
---- orig/tls.c 2005-01-19 20:11:10
-+++ tls.c 2004-07-03 20:15:41
-@@ -39,6 +39,7 @@
-
+--- old/tls.c
++++ new/tls.c
+@@ -34,6 +34,7 @@
+ * change. */
#include "rsync.h"
+#include "popt.h"
#define PROGRAM "tls"
-@@ -48,6 +49,7 @@ int read_only = 1;
+@@ -43,6 +44,8 @@ int read_only = 1;
int list_only = 0;
int preserve_perms = 0;
+static int display_atime = 0;
-
++
static void failed(char const *what, char const *where)
{
-@@ -56,14 +58,29 @@ static void failed(char const *what, cha
+ fprintf(stderr, PROGRAM ": %s %s: %s\n",
+@@ -50,12 +53,29 @@ static void failed(char const *what, cha
exit(1);
}
-+static void storetime(char *dest, time_t t)
++static void storetime(char *dest, time_t t, size_t destsize)
+{
+ if (t) {
+ struct tm *mt = gmtime(&t);
-
-+ sprintf(dest, "%04d-%02d-%02d %02d:%02d:%02d ",
-+ mt->tm_year + 1900,
-+ mt->tm_mon + 1,
-+ mt->tm_mday,
-+ mt->tm_hour,
-+ mt->tm_min,
-+ mt->tm_sec);
-+ } else {
-+ strcpy(dest, " ");
-+ }
-+}
-
++
++ snprintf(dest, destsize,
++ "%04d-%02d-%02d %02d:%02d:%02d ",
++ (int)mt->tm_year + 1900,
++ (int)mt->tm_mon + 1,
++ (int)mt->tm_mday,
++ (int)mt->tm_hour,
++ (int)mt->tm_min,
++ (int)mt->tm_sec);
++ } else
++ strlcpy(dest, " ", destsize);
++}
++
static void list_file(const char *fname)
{
STRUCT_STAT buf;
char linkbuf[4096];
if (do_lstat(fname, &buf) < 0)
-@@ -96,19 +113,8 @@ static void list_file(const char *fname)
+@@ -88,19 +108,8 @@ static void list_file(const char *fname)
permstring(permbuf, buf.st_mode);
- if (buf.st_mtime) {
- mt = gmtime(&buf.st_mtime);
-
-- sprintf(datebuf, "%04d-%02d-%02d %02d:%02d:%02d",
-- mt->tm_year + 1900,
-- mt->tm_mon + 1,
-- mt->tm_mday,
-- mt->tm_hour,
-- mt->tm_min,
-- mt->tm_sec);
-- } else {
-- strcpy(datebuf, " ");
-- }
-+ storetime(mtimebuf, buf.st_mtime);
-+ storetime(atimebuf, buf.st_atime);
+- snprintf(datebuf, sizeof datebuf,
+- "%04d-%02d-%02d %02d:%02d:%02d",
+- (int)mt->tm_year + 1900,
+- (int)mt->tm_mon + 1,
+- (int)mt->tm_mday,
+- (int)mt->tm_hour,
+- (int)mt->tm_min,
+- (int)mt->tm_sec);
+- } else
+- strlcpy(datebuf, " ", sizeof datebuf);
++ storetime(mtimebuf, buf.st_mtime, sizeof mtimebuf);
++ storetime(atimebuf, buf.st_atime, sizeof atimebuf);
/* TODO: Perhaps escape special characters in fname? */
-@@ -119,24 +125,55 @@ static void list_file(const char *fname)
+@@ -111,23 +120,55 @@ static void list_file(const char *fname)
(long)minor(buf.st_rdev));
} else /* NB: use double for size since it might not fit in a long. */
printf("%12.0f", (double)buf.st_size);
+ printf(" %6ld.%-6ld %6ld %s%s%s%s\n",
(long)buf.st_uid, (long)buf.st_gid, (long)buf.st_nlink,
- datebuf, fname, linkbuf);
-+ mtimebuf, display_atime ? atimebuf : "",
++ mtimebuf, display_atime && !S_ISDIR(buf.st_mode) ? atimebuf : "",
+ fname, linkbuf);
- }
-
++}
++
+static struct poptOption long_options[] = {
+ /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
+ {"atime", 'u', POPT_ARG_NONE, &display_atime, 0, 0, 0},
+ fprintf(stderr, "usage: " PROGRAM " [--atime | -u] DIR ...\n"
+ "Trivial file listing program for portably checking rsync\n");
+ exit(ret);
-+}
+ }
int
main(int argc, char *argv[])
- fprintf(stderr, "usage: " PROGRAM " DIR ...\n"
- "Trivial file listing program for portably checking rsync\n");
- return 1;
+- }
+ poptContext pc;
+ const char **extra_args;
+ int opt;
-+
+
+- for (argv++; *argv; argv++) {
+- list_file(*argv);
+ pc = poptGetContext(PROGRAM, argc, (const char **)argv,
+ long_options, 0);
+ while ((opt = poptGetNextOpt(pc)) != -1) {
+ }
}
-- for (argv++; *argv; argv++) {
-- list_file(*argv);
-- }
+ extra_args = poptGetArgs(pc);
+ if (*extra_args == NULL)
+ tls_usage(1);
+ for (; *extra_args; extra_args++)
+ list_file(*extra_args);
+ poptFreeContext(pc);
-
++
return 0;
}
---- orig/util.c 2005-02-20 19:17:49
-+++ util.c 2005-02-07 21:09:12
-@@ -128,12 +128,17 @@ void overflow(char *str)
-
-
+--- old/util.c
++++ new/util.c
+@@ -121,7 +121,7 @@ NORETURN void overflow_exit(const char *
+ exit_cleanup(RERR_MALLOC);
+ }
--int set_modtime(char *fname, time_t modtime)
-+int set_times(char *fname, time_t modtime, time_t atime)
+-int set_modtime(const char *fname, time_t modtime, mode_t mode)
++int set_times(const char *fname, time_t modtime, time_t atime, mode_t mode)
{
+ #if !defined HAVE_LUTIMES || !defined HAVE_UTIMES
+ if (S_ISLNK(mode))
+@@ -129,9 +129,13 @@ int set_modtime(const char *fname, time_
+ #endif
+
if (verbose > 2) {
- rprintf(FINFO, "set modtime of %s to (%ld) %s",
+ char mtimebuf[200];
+ strlcpy(mtimebuf, timestring(modtime), sizeof mtimebuf);
+ rprintf(FINFO,
+ "set modtime, atime of %s to (%ld) %s, (%ld) %s\n",
- safe_fname(fname), (long)modtime,
+ fname, (long)modtime,
- asctime(localtime(&modtime)));
-+ mtimebuf,
-+ (long)atime, timestring(atime));
++ mtimebuf, (long)atime, timestring(atime));
}
if (dry_run)
-@@ -142,17 +147,17 @@ int set_modtime(char *fname, time_t modt
+@@ -140,7 +144,7 @@ int set_modtime(const char *fname, time_
{
- #ifdef HAVE_UTIMBUF
+ #ifdef HAVE_UTIMES
+ struct timeval t[2];
+- t[0].tv_sec = time(NULL);
++ t[0].tv_sec = atime;
+ t[0].tv_usec = 0;
+ t[1].tv_sec = modtime;
+ t[1].tv_usec = 0;
+@@ -153,12 +157,12 @@ int set_modtime(const char *fname, time_
+ return utimes(fname, t);
+ #elif defined HAVE_UTIMBUF
struct utimbuf tbuf;
- tbuf.actime = time(NULL);
+ tbuf.actime = atime;
t[1] = modtime;
return utime(fname,t);
#else
- struct timeval t[2];
-- t[0].tv_sec = time(NULL);
-+ t[0].tv_sec = atime;
- t[0].tv_usec = 0;
- t[1].tv_sec = modtime;
- t[1].tv_usec = 0;
-@@ -1149,8 +1154,8 @@ int msleep(int t)
-
-
- /**
-- * Determine if two file modification times are equivalent (either
-- * exact or in the modification timestamp window established by
-+ * Determine if two file times are equivalent (either
-+ * exact or in the timestamp window established by
- * --modify-window).
- *
- * @retval 0 if the times should be treated as the same
-@@ -1159,7 +1164,7 @@ int msleep(int t)
- *
- * @retval -1 if the 2nd is later
- **/
--int cmp_modtime(time_t file1, time_t file2)
-+int cmp_time(time_t file1, time_t file2)
- {
- if (file2 > file1) {
- if (file2 - file1 <= modify_window)
git.samba.org / rsync-patches.git / blobdiff