Expand some comments.
authorguy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>
Thu, 17 Jun 2010 21:41:03 +0000 (21:41 +0000)
committerguy <guy@f5534014-38df-0310-8fa8-9805f1628bb7>
Thu, 17 Jun 2010 21:41:03 +0000 (21:41 +0000)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33248 f5534014-38df-0310-8fa8-9805f1628bb7

epan/dissectors/packet-smb.c

index 4fba707bb8f084022d7d2844b2e2b7105b353a10..44275f1498dfdc6dff7354d8a6caa50cffca2215 100644 (file)
@@ -6482,6 +6482,9 @@ dissect_read_andx_response(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        offset += 2;
 
        /*
+        * XXX - the SNIA SMB spec says this is a USHORT, not a
+        * ULONG.
+        *
         * XXX - we should really only do this in case we have seen
         * LARGE FILE being negotiated.  Unfortunately, we might not
         * have seen the negotiation phase in the capture....
@@ -6641,7 +6644,11 @@ dissect_write_andx_request(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
        proto_tree_add_item(tree, hf_smb_remaining, tvb, offset, 2, TRUE);
        offset += 2;
 
-       /* XXX we should really only do this in case we have seen LARGE FILE being negotiated */
+       /*
+        * XXX - we should really only do this in case we have seen
+        * LARGE FILE being negotiated.  Unfortunately, we might not
+        * have seen the negotiation phase in the capture....
+        */
        /* data length high */
        datalen_high = tvb_get_letohs(tvb, offset);
        proto_tree_add_uint(tree, hf_smb_data_len_high, tvb, offset, 2, datalen_high);