obnox/wireshark/wip.git
14 years agoAdded Håkon Nessjøen.
stig [Tue, 22 Jun 2010 15:14:42 +0000 (15:14 +0000)]
Added Håkon Nessjøen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33290 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Håkon Nessjøen via bug 4899:
stig [Tue, 22 Jun 2010 15:12:20 +0000 (15:12 +0000)]
From Håkon Nessjøen via bug 4899:
Dissector for Mikrotik RouterOS protocol for telneting without using IP
addresses.

From me:
Code cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33289 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck for custom column before using custom_field.
stig [Tue, 22 Jun 2010 13:40:28 +0000 (13:40 +0000)]
Check for custom column before using custom_field.
Store hidden columns correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33288 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf the trailer is less than 4 bytes it's not a Gigamon hdr.
etxrab [Tue, 22 Jun 2010 13:29:33 +0000 (13:29 +0000)]
If the trailer is less than 4 bytes it's not a Gigamon hdr.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33287 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate to reflect changes in defines: REP_* > ENC_*
stig [Tue, 22 Jun 2010 11:54:45 +0000 (11:54 +0000)]
Update to reflect changes in defines: REP_* > ENC_*

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33286 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlways make new columns visible.
stig [Tue, 22 Jun 2010 11:09:07 +0000 (11:09 +0000)]
Always make new columns visible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33285 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInclude some column details in the "Displayed Columns" list.
stig [Tue, 22 Jun 2010 08:56:05 +0000 (08:56 +0000)]
Include some column details in the "Displayed Columns" list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33284 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHighlight correct number of bytes when highlighted hex dump ends at the end
stig [Tue, 22 Jun 2010 08:49:12 +0000 (08:49 +0000)]
Highlight correct number of bytes when highlighted hex dump ends at the end
of the first block.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33283 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4852:
jake [Tue, 22 Jun 2010 07:52:06 +0000 (07:52 +0000)]
Fix for bug 4852:
Don't short circuit dissection if tree==NULL when column values are to be set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33282 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded the displayed columns menu in the heading popup.
stig [Mon, 21 Jun 2010 20:33:39 +0000 (20:33 +0000)]
Added the displayed columns menu in the heading popup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33281 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd an if-test to fix a fuzz-test crash;
wmeier [Mon, 21 Jun 2010 14:24:34 +0000 (14:24 +0000)]
Add an if-test to fix a fuzz-test crash;
See Bug #4897: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4897

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33280 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename "Visible" to "Displayed" for hide columns functions.
stig [Mon, 21 Jun 2010 13:57:03 +0000 (13:57 +0000)]
Rename "Visible" to "Displayed" for hide columns functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33279 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoved leading empty line.
stig [Mon, 21 Jun 2010 11:30:27 +0000 (11:30 +0000)]
Removed leading empty line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33278 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCorrected printed name for id-permissiveAttributes.
stig [Mon, 21 Jun 2010 11:29:54 +0000 (11:29 +0000)]
Corrected printed name for id-permissiveAttributes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33277 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCorrected copyright header.
stig [Mon, 21 Jun 2010 11:28:52 +0000 (11:28 +0000)]
Corrected copyright header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33276 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded volatile to 'offset' (needed by my version of gcc).
martinm [Mon, 21 Jun 2010 09:41:57 +0000 (09:41 +0000)]
Added volatile to 'offset' (needed by my version of gcc).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33275 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe length of the dot11CurrentChannelNumber parameter is 1 octet.
etxrab [Mon, 21 Jun 2010 03:01:41 +0000 (03:01 +0000)]
The length of the dot11CurrentChannelNumber parameter is 1 octet.
Fixes bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4894

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33274 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoProperly terminate gmhdr_ftype_timestamp[].
guy [Sun, 20 Jun 2010 22:36:32 +0000 (22:36 +0000)]
Properly terminate gmhdr_ftype_timestamp[].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33273 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMark pinfo as unused.
guy [Sun, 20 Jun 2010 21:43:52 +0000 (21:43 +0000)]
Mark pinfo as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33272 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore rework of the code:
wmeier [Sun, 20 Jun 2010 21:18:48 +0000 (21:18 +0000)]
More rework of the code:
 - Refactor to use a separate function for common code;
 - Prefs callback not required;
 - Use val_to_str(...);
 - Fix issues relating to incorrect bytes highlighted in the hex view;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33271 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4888:
jake [Sun, 20 Jun 2010 18:24:25 +0000 (18:24 +0000)]
Fix for bug 4888:
Restore setting DSCP column value, when relevant.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33270 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4888:
jake [Sun, 20 Jun 2010 18:23:35 +0000 (18:23 +0000)]
Fix for bug 4888:
Convert DSCP column to the proper custom column filter code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33269 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd get_column_visible & set_column_visible
wmeier [Sun, 20 Jun 2010 16:57:50 +0000 (16:57 +0000)]
Add get_column_visible & set_column_visible

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33268 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 4875:
jake [Sun, 20 Jun 2010 16:27:03 +0000 (16:27 +0000)]
Fix for bug 4875:
Don't hint at a local User's Gude when there isn't one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33267 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded "Hide Column" functionality.
stig [Sun, 20 Jun 2010 16:23:43 +0000 (16:23 +0000)]
Added "Hide Column" functionality.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33266 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded an expert info for "4 NOP in a row" in IP and TCP.
stig [Sun, 20 Jun 2010 16:22:51 +0000 (16:22 +0000)]
Added an expert info for "4 NOP in a row" in IP and TCP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33265 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert back to the old Flags entry.
stig [Sun, 20 Jun 2010 16:17:10 +0000 (16:17 +0000)]
Revert back to the old Flags entry.
Add number of bits used for Flags in the description.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33264 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2010-06-20]
gerald [Sun, 20 Jun 2010 15:03:42 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2010-06-20]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33260 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Holger Freyther:
jake [Sun, 20 Jun 2010 14:37:34 +0000 (14:37 +0000)]
From Holger Freyther:
The current implementation assumes that the IPA protocol header is three byte.
This is true for TCP but not for packets sent over UDP, which uses four bytes.

From me:
Improve heuristic and offset tracking.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33259 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom KATAOKA Toshihiro:
jake [Sun, 20 Jun 2010 12:21:45 +0000 (12:21 +0000)]
From KATAOKA Toshihiro:
The sequence number in 3GPP NAS EPS(TS24.301) cyphered PDU is outside of ciphered text.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33258 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom KATAOKA Toshihiro:
etxrab [Sun, 20 Jun 2010 10:25:26 +0000 (10:25 +0000)]
From KATAOKA Toshihiro:
3GPP Diameter S6a flags.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4893
Modified to use tfs_set_notset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33257 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom tieuthunhi via bug 4887:
stig [Sat, 19 Jun 2010 01:43:11 +0000 (01:43 +0000)]
From tieuthunhi via bug 4887:
Add support for Gigamon headers (timestamp, source port, length, etc)
that are inserted by Gigamon network equipments.

From me:
Various cleanup:
- Register to "eth.trailer" heuristics for trailer.
- Use standard dumping of timestamp.
- Rewrote gmhdr_plfm_str handling.
- Dump srcport details in a subtree.
- Removed packte-gmhdr.h.
- Ensure the while-loop will end.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33256 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse top level tree when using dissectors from "eth.trailer" heuristics.
stig [Sat, 19 Jun 2010 01:16:29 +0000 (01:16 +0000)]
Use top level tree when using dissectors from "eth.trailer" heuristics.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33255 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a few deprecated GObject fcns;
wmeier [Fri, 18 Jun 2010 22:17:43 +0000 (22:17 +0000)]
Add a few deprecated GObject fcns;
Fix some typos and capitalization.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33254 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jim Young:
etxrab [Fri, 18 Jun 2010 17:18:00 +0000 (17:18 +0000)]
From Jim Young:
The attached patch simply documents a long supported but hidden tshark -G
option.

Tshark's print_usage() has been augmented as well as the tshark man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33253 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix the check for disable_lua.
stig [Fri, 18 Jun 2010 15:25:41 +0000 (15:25 +0000)]
Fix the check for disable_lua.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33252 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd new strings/dissector function for signalling RRC messages that will add
martinm [Fri, 18 Jun 2010 07:07:55 +0000 (07:07 +0000)]
Add new strings/dissector function for signalling RRC messages that will add
lte_rrc root to the protocol tree. Makes filtering on call signalling easier.

TODO: same for other RRC entry points...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33251 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the Gigamon ethertype.
etxrab [Fri, 18 Jun 2010 04:18:08 +0000 (04:18 +0000)]
Add the Gigamon ethertype.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33250 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoOK, I checked the Microsoft spec; give some information on that.
guy [Fri, 18 Jun 2010 03:25:33 +0000 (03:25 +0000)]
OK, I checked the Microsoft spec; give some information on that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33249 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExpand some comments.
guy [Thu, 17 Jun 2010 21:41:03 +0000 (21:41 +0000)]
Expand some comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33248 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd deprecated from GLib 2.24
wmeier [Thu, 17 Jun 2010 18:12:46 +0000 (18:12 +0000)]
Add deprecated from GLib 2.24

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33247 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd GTK deprecated from GTK 2.20.
wmeier [Thu, 17 Jun 2010 17:51:52 +0000 (17:51 +0000)]
Add GTK deprecated from GTK 2.20.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33246 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCommit re-generated packet-fix.h (which now has $Id$).
wmeier [Thu, 17 Jun 2010 17:23:44 +0000 (17:23 +0000)]
Commit re-generated packet-fix.h (which now has $Id$).
(Left out from the previous commit).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33245 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInclude $Id$ when generating packet-fix.h;
wmeier [Thu, 17 Jun 2010 17:19:45 +0000 (17:19 +0000)]
Include $Id$ when generating packet-fix.h;
Commit re-generated packet-fix.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33244 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoEnable Lua by default.
stig [Thu, 17 Jun 2010 16:38:05 +0000 (16:38 +0000)]
Enable Lua by default.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33243 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWork out better whether RLC segment is a complete upper-layer PDU or not.
martinm [Thu, 17 Jun 2010 06:36:23 +0000 (06:36 +0000)]
Work out better whether RLC segment is a complete upper-layer PDU or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33242 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDon't refer to file-static variables as extern (my gcc didn't like it).
martinm [Thu, 17 Jun 2010 05:03:08 +0000 (05:03 +0000)]
Don't refer to file-static variables as extern (my gcc didn't like it).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33241 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle 64-bit file offsets in ReadAndX and WriteAndX.
guy [Wed, 16 Jun 2010 20:00:22 +0000 (20:00 +0000)]
Handle 64-bit file offsets in ReadAndX and WriteAndX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33240 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoGo back to 64-bit sizes, but, before passing those sizes to
guy [Wed, 16 Jun 2010 18:28:28 +0000 (18:28 +0000)]
Go back to 64-bit sizes, but, before passing those sizes to
g_try_malloc() or g_try_realloc(), check whether they fit in a gsize
and:

if not, just pretend the allocation failed;

if so, cast them to gsize to squelch compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33239 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove C++ comment.
stig [Wed, 16 Jun 2010 17:47:42 +0000 (17:47 +0000)]
Remove C++ comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33238 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse gsize for file offset.
stig [Wed, 16 Jun 2010 17:45:25 +0000 (17:45 +0000)]
Use gsize for file offset.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33237 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Hitoshi Irino via bug 4883:
stig [Wed, 16 Jun 2010 15:36:02 +0000 (15:36 +0000)]
From Hitoshi Irino via bug 4883:
Support NetFlow exported from Cisco ASA5500 series.

From me:
Fixed some hf description entries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33236 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse gsize for file sizes.
stig [Wed, 16 Jun 2010 15:26:47 +0000 (15:26 +0000)]
Use gsize for file sizes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33235 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoExport smb_fid_types.
guy [Wed, 16 Jun 2010 07:47:18 +0000 (07:47 +0000)]
Export smb_fid_types.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33234 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Joe Eykholt via bug 4882:
stig [Wed, 16 Jun 2010 05:54:11 +0000 (05:54 +0000)]
From Joe Eykholt via bug 4882:
Adds decodes for the FCoE Initialization Protocol features being added for
VN_port to VN_port (VN2VN) point-to-multipoint support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33233 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCast bytes_left down to an int once we've established it will fit.
guy [Wed, 16 Jun 2010 03:09:16 +0000 (03:09 +0000)]
Cast bytes_left down to an int once we've established it will fit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33232 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoHandle WTAP_ERR_SHORT_WRITE in file_write_error_message().
guy [Wed, 16 Jun 2010 01:30:29 +0000 (01:30 +0000)]
Handle WTAP_ERR_SHORT_WRITE in file_write_error_message().

In eo_save_entry(), don't assume you can write the entire object in a
single write call - if the object is big enough (which would require a
64-bit address space), and you're not lucky enough to be running on
UN*X (which means LP64, so size_t and ssize_t are big enough for the
entire object), you can't.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33231 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCleanup header file define guards.
stig [Tue, 15 Jun 2010 21:18:31 +0000 (21:18 +0000)]
Cleanup header file define guards.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33230 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChanged Jose Pico's email, added David Perez as co-author.
stig [Tue, 15 Jun 2010 18:48:08 +0000 (18:48 +0000)]
Changed Jose Pico's email, added David Perez as co-author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33229 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove #include <inttypes.h>.
stig [Tue, 15 Jun 2010 15:32:19 +0000 (15:32 +0000)]
Remove #include <inttypes.h>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33228 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom David Perez & Jose Pico from Taddong S.L. via bug 4451:
stig [Tue, 15 Jun 2010 14:03:49 +0000 (14:03 +0000)]
From David Perez & Jose Pico from Taddong S.L. via bug 4451:
This functionality keeps track of all SMB objects contained in a capture,
and is able to export to a file a full or partial captured file that has
been transfered through the SMB protocol. In a partial capture, the holes
produced by the non-captured information are filled out with zeros.
It includes the needed modifications of the SMB dissector in the way it keeps
track of the opened SMB files and also to feed the eo_smb tap listener.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33227 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Holger Freyther:
etxrab [Tue, 15 Jun 2010 13:36:11 +0000 (13:36 +0000)]
From Holger Freyther:
Cosmetic patch to fix Optional/Conditional mismatch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33226 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate SCTP PPIDs.
tuexen [Mon, 14 Jun 2010 21:49:23 +0000 (21:49 +0000)]
Update SCTP PPIDs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33225 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jouni Malinen: Fix: RSN capabilities field in IEEE 802.11 RSN IE is parsed...
wmeier [Mon, 14 Jun 2010 14:34:32 +0000 (14:34 +0000)]
From Jouni Malinen:  Fix: RSN capabilities field in IEEE 802.11 RSN IE is parsed in incorrect byte order
Note: this bug was introduced in SVN #32342 [3/31/10] and thus was only present
in Development Wireshark versions.

From me: Display 'mobility_domain_mdid' as little-endian (to be verified)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33224 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix Bug #4871: Wrong Ack value in TCP flow graph when using relative sequence numbers.
wmeier [Mon, 14 Jun 2010 12:37:43 +0000 (12:37 +0000)]
Fix Bug #4871: Wrong Ack value in TCP flow graph when using relative sequence numbers.
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4871

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33223 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThe .dmg packages can come in 32-bit and 64-bit flavors. Name them
gerald [Sun, 13 Jun 2010 23:02:18 +0000 (23:02 +0000)]
The .dmg packages can come in 32-bit and 64-bit flavors. Name them
accordingly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33222 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd packet-gopher.c from rev 33220.
jmayer [Sun, 13 Jun 2010 22:58:21 +0000 (22:58 +0000)]
Add packet-gopher.c from rev 33220.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33221 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a Gopher (RFC 1436) dissector.
gerald [Sun, 13 Jun 2010 20:30:43 +0000 (20:30 +0000)]
Add a Gopher (RFC 1436) dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33220 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd info to the "Enable OID resolution" tooltip that if 'True' then the 'SMI paths...
wmeier [Sun, 13 Jun 2010 20:27:21 +0000 (20:27 +0000)]
Add info to the "Enable OID resolution" tooltip that if 'True' then the 'SMI paths' and the 'SMI modules' preferences will be shown;
Fix a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33219 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2010-06-13]
gerald [Sun, 13 Jun 2010 15:03:31 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2010-06-13]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33215 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd Copy (to clipboard) to expert item popup menu.
martinm [Sun, 13 Jun 2010 14:55:11 +0000 (14:55 +0000)]
Add Copy (to clipboard) to expert item popup menu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33214 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRename some variables; At least one ('end') seemed to confuse the Windows debugger;
wmeier [Sun, 13 Jun 2010 14:31:11 +0000 (14:31 +0000)]
Rename some variables; At least one ('end') seemed to confuse the Windows debugger;
Also: Udate some coments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33213 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix Bug #4868; "Wireshark crash selecting Inter-Asterisk exchange v2 packet data"
wmeier [Sun, 13 Jun 2010 13:58:02 +0000 (13:58 +0000)]
Fix Bug #4868; "Wireshark crash selecting Inter-Asterisk exchange v2 packet data"
See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4868

A field length was being set incorrectly (too large) thus causing
packet_hex_apply_reverse_tag() to run off the end of a text_view buffer
(thus causing a crash) when attempting to highlight the field bytes
in the hex-view pane.

ToDo: Add some sanity checking in packet_hex_apply_reverse_tag().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33212 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove the header letter spacing. It make the Lua reference hard to read.
gerald [Sun, 13 Jun 2010 00:39:06 +0000 (00:39 +0000)]
Remove the header letter spacing. It make the Lua reference hard to read.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33211 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAndreas Schuler <andreas (A) schulerdev.de>
jmayer [Fri, 11 Jun 2010 16:11:42 +0000 (16:11 +0000)]
Andreas Schuler <andreas (A) schulerdev.de>
Updates to the DECT dissector:
- using proto_tree_add_none_format()/proto_tree_add_item() instead of
  proto_tree_add_uint_format() where it makes sense
- fixed display of full slot data
- added some references to documentation
- cleaned up packet length checking
- put descrambled bfield-data in a tree
- cleaned up some afield items
- use custom columns instead adding all infos to COL_INFO
- add some more infos to the columns

Me:
- Replace proto_tree_add_none_format(..., strvar) by
  proto_tree_add_none_format(..., "%s", strvar).
- Fix an unused variable warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33210 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix: Malformed packet if port is missing from path.
etxrab [Fri, 11 Jun 2010 11:49:01 +0000 (11:49 +0000)]
Fix: Malformed packet if port is missing from path.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33209 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSmall cleanup.
stig [Fri, 11 Jun 2010 09:14:25 +0000 (09:14 +0000)]
Small cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33208 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd the direction to so expert info texts.
martinm [Thu, 10 Jun 2010 15:28:41 +0000 (15:28 +0000)]
Add the direction to so expert info texts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33207 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDisplay RefuseReason in Info column.
stig [Thu, 10 Jun 2010 13:06:08 +0000 (13:06 +0000)]
Display RefuseReason in Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33206 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCheck if /usr/local exists before adding to CFLAGS/CPPFLAGS and LDFLAGS.
stig [Thu, 10 Jun 2010 10:31:46 +0000 (10:31 +0000)]
Check if /usr/local exists before adding to CFLAGS/CPPFLAGS and LDFLAGS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33205 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jim Young via bug 4862:
stig [Thu, 10 Jun 2010 10:13:34 +0000 (10:13 +0000)]
From Jim Young via bug 4862:
GLIB 2.14 necessary to compile Wireshark with Protocol help.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33204 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jason Burns: DHCP Dissector - Support for DHCP Option 150 TFTP Server Address
wmeier [Thu, 10 Jun 2010 01:33:02 +0000 (01:33 +0000)]
From Jason Burns:  DHCP Dissector - Support for DHCP Option 150 TFTP Server Address

"According to this document DHCP Option 150 is an array of IPv4 TFTP Server
Addresses

http://cisco.com/en/US/products/sw/voicesw/ps556/products_tech_note09186a00800942f4.shtml#tftp_option

I fixed the capitalization of this option in the bootp dissector and changed
the type to match the actual use of the option. (ipv4_list)"

From me: Add a pointer to a draft RFC about the DHCP "TFTP Server Address" option.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33203 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd dissector_table_foreach.
etxrab [Wed, 9 Jun 2010 20:25:50 +0000 (20:25 +0000)]
Add dissector_table_foreach.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33201 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a copy paste error.
etxrab [Wed, 9 Jun 2010 20:24:23 +0000 (20:24 +0000)]
Fix a copy paste error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33200 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo some constifying (based upon gcc -Wwrite-strings warnings)
wmeier [Wed, 9 Jun 2010 18:32:35 +0000 (18:32 +0000)]
Do some constifying (based upon gcc -Wwrite-strings warnings)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33199 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo some constifying [or other] based upon gcc -Wwrite-strings warnings.
wmeier [Wed, 9 Jun 2010 18:12:17 +0000 (18:12 +0000)]
Do some constifying [or other] based upon gcc -Wwrite-strings warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33198 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a gcc -Wstrict-prototypes warning
wmeier [Wed, 9 Jun 2010 17:56:37 +0000 (17:56 +0000)]
Fix a gcc -Wstrict-prototypes warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33195 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo some constifying (based upon gcc -Wwrite-strings warnings);
wmeier [Wed, 9 Jun 2010 17:40:03 +0000 (17:40 +0000)]
Do some constifying (based upon gcc -Wwrite-strings warnings);
Replace "4 space  tabs" by 4 spaces.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33194 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd idmp.
morriss [Wed, 9 Jun 2010 17:36:49 +0000 (17:36 +0000)]
Add idmp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33193 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDo some constifying (based upon gcc -Wwrite-strings warnings);
wmeier [Wed, 9 Jun 2010 17:24:58 +0000 (17:24 +0000)]
Do some constifying (based upon gcc -Wwrite-strings warnings);
Various minor ckeanup: remove some unecessary if statements & other
Move proto_reg_handoff... to the end of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33192 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevise code slightly; mostly: remove some unnecessary if tests ....
wmeier [Wed, 9 Jun 2010 17:16:33 +0000 (17:16 +0000)]
Revise code slightly; mostly: remove some unnecessary if tests ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33191 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInitialize dst_ref.
stig [Wed, 9 Jun 2010 16:02:34 +0000 (16:02 +0000)]
Initialize dst_ref.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33189 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoval of unused global variable.
gal [Wed, 9 Jun 2010 15:51:02 +0000 (15:51 +0000)]
Removal of unused global variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33188 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemoval of (hopefully!) the final warning.
gal [Wed, 9 Jun 2010 15:35:08 +0000 (15:35 +0000)]
Removal of (hopefully!) the final warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33187 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate for missing const for object identifier string and marking tree as unused.
gal [Wed, 9 Jun 2010 15:20:48 +0000 (15:20 +0000)]
Update for missing const for object identifier string and marking tree as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33186 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded packet-idmp.h.
stig [Wed, 9 Jun 2010 15:05:29 +0000 (15:05 +0000)]
Added packet-idmp.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33185 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBuild dependency x509ce.
stig [Wed, 9 Jun 2010 14:59:02 +0000 (14:59 +0000)]
Build dependency x509ce.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33184 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded default svn:ignore targets.
stig [Wed, 9 Jun 2010 14:47:39 +0000 (14:47 +0000)]
Added default svn:ignore targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33183 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdates to the ROS dissector to support IDMP and fix to IDMP for implicit declaration...
gal [Wed, 9 Jun 2010 14:45:38 +0000 (14:45 +0000)]
Updates to the ROS dissector to support IDMP and fix to IDMP for implicit declaration of return value of call_ros_oid_callback().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33182 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoBuild Makefile in asn1/idmp.
stig [Wed, 9 Jun 2010 14:40:35 +0000 (14:40 +0000)]
Build Makefile in asn1/idmp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33181 f5534014-38df-0310-8fa8-9805f1628bb7