s3: smbd: SMB1 reply_mv() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense.
authorJeremy Allison <jra@samba.org>
Tue, 29 Sep 2020 03:04:51 +0000 (20:04 -0700)
committerRalph Boehme <slow@samba.org>
Wed, 30 Sep 2020 20:46:39 +0000 (20:46 +0000)
There's either a wildcard in the last component or not. Always use
UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/reply.c

index b651bf4a3d6aaeddd304967ac2d232505be7a7c9..fcac68147b1c5df73ee91315cacd9884023e06f4 100644 (file)
@@ -8357,11 +8357,11 @@ void reply_mv(struct smb_request *req)
        uint32_t src_ucf_flags = ucf_flags_from_smb_request(req) |
                (req->posix_pathnames ?
                        UCF_UNIX_NAME_LOOKUP :
-                       UCF_COND_ALLOW_WCARD_LCOMP);
+                       UCF_ALWAYS_ALLOW_WCARD_LCOMP);
        uint32_t dst_ucf_flags = ucf_flags_from_smb_request(req) |
                (req->posix_pathnames ?
                        0 :
-                       UCF_COND_ALLOW_WCARD_LCOMP);
+                       UCF_ALWAYS_ALLOW_WCARD_LCOMP);
        bool stream_rename = false;
 
        START_PROFILE(SMBmv);