s3: smbd: SMB1 reply_unlink() - the UCF_COND_ALLOW_WCARD_LCOMP makes no sense.
authorJeremy Allison <jra@samba.org>
Tue, 29 Sep 2020 03:03:08 +0000 (20:03 -0700)
committerRalph Boehme <slow@samba.org>
Wed, 30 Sep 2020 20:46:39 +0000 (20:46 +0000)
There's either a wildcard in the last component or not. Always use
UCF_ALWAYS_ALLOW_WCARD_LCOMP for calls that can take a wildcard.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/reply.c

index f10a92ec2ac74abf5baeef6d7bfd97d648faa16a..b651bf4a3d6aaeddd304967ac2d232505be7a7c9 100644 (file)
@@ -3609,7 +3609,7 @@ void reply_unlink(struct smb_request *req)
        uint32_t dirtype;
        NTSTATUS status;
        bool path_contains_wcard = False;
-       uint32_t ucf_flags = UCF_COND_ALLOW_WCARD_LCOMP |
+       uint32_t ucf_flags = UCF_ALWAYS_ALLOW_WCARD_LCOMP |
                        ucf_flags_from_smb_request(req);
        TALLOC_CTX *ctx = talloc_tos();