nsswitch: cppcheck: Fix memleakOnRealloc errors

Fixes the following errors

nsswitch/nsstest.c:192: error: memleakOnRealloc: Common realloc mistake: 'buf' nulled but not freed upon failure <--[cppcheck]
nsswitch/nsstest.c:230: error: memleakOnRealloc: Common realloc mistake: 'buf' nulled but not freed upon failure <--[cppcheck]
nsswitch/nsstest.c:269: error: memleakOnRealloc: Common realloc mistake: 'buf' nulled but not freed upon failure <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/nsswitch/nsstest.c b/nsswitch/nsstest.c
index 6d92806cffcbcd0db332d121c421ad9f4a93f5e5..e8c4306441d6380b98b0ae2c5d6c056caa0a1e45 100644 (file)
--- a/nsswitch/nsstest.c
+++ b/nsswitch/nsstest.c
@@ -188,9 +188,11 @@ static struct group *nss_getgrent(void)
 again:
        status = _nss_getgrent_r(&grp, buf, buflen, &nss_errno);
        if (status == NSS_STATUS_TRYAGAIN) {
+               char *oldbuf = buf;
                buflen *= 2;
                buf = (char *)realloc(buf, buflen);
                if (!buf) {
+                       SAFE_FREE(oldbuf);
                        return NULL;
                }
                goto again;
@@ -226,9 +228,11 @@ static struct group *nss_getgrnam(const char *name)
 again:
        status = _nss_getgrnam_r(name, &grp, buf, buflen, &nss_errno);
        if (status == NSS_STATUS_TRYAGAIN) {
+               char *oldbuf = buf;
                buflen *= 2;
                buf = (char *)realloc(buf, buflen);
                if (!buf) {
+                       SAFE_FREE(oldbuf);
                        return NULL;
                }
                goto again;
@@ -265,9 +269,11 @@ static struct group *nss_getgrgid(gid_t gid)
 again:
        status = _nss_getgrgid_r(gid, &grp, buf, buflen, &nss_errno);
        if (status == NSS_STATUS_TRYAGAIN) {
+               char *oldbuf = buf;
                buflen *= 2;
                buf = (char *)realloc(buf, buflen);
                if (!buf) {
+                       SAFE_FREE(oldbuf);
                        return NULL;
                }
                goto again;