pdb: Fix CID 1427620 Resource leak

It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13263

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
(cherry picked from commit 4e5c9427085f001941adaf761b18740a2e169240)

diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
index b06267b2d64feecae1fa17d8452c2dd244dbe514..4e55a15a0cc0cd4dd06df3e331d32bc8bbc7cc9a 100644 (file)
--- a/source3/passdb/pdb_samba_dsdb.c
+++ b/source3/passdb/pdb_samba_dsdb.c
@@ -3741,7 +3741,8 @@ static NTSTATUS pdb_samba_dsdb_enum_trusted_domains(struct pdb_methods *m,
                domains[di++] = d;
        }
 
-       talloc_realloc(domains, domains, struct pdb_trusted_domain *, di);
+       domains = talloc_realloc(domains, domains, struct pdb_trusted_domain *,
+                                di);
        *_domains = talloc_move(mem_ctx, &domains);
        *_num_domains = di;
        TALLOC_FREE(tmp_ctx);