s3-libnetjoin: add machine_name length check.
authorGünther Deschner <gd@samba.org>
Thu, 6 Nov 2008 10:40:03 +0000 (11:40 +0100)
committerAndreas Schneider <asn@samba.org>
Mon, 5 Aug 2013 08:30:01 +0000 (10:30 +0200)
Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/libnet/libnet_join.c

index 4582158fca49df163725eebb43c02b2d5d84478d..df3a86d092d7f7f596abbe8cdb366e5f2563ede7 100644 (file)
@@ -1715,6 +1715,15 @@ static WERROR libnet_join_pre_processing(TALLOC_CTX *mem_ctx,
                return WERR_INVALID_PARAM;
        }
 
+       if (strlen(r->in.machine_name) > 15) {
+               libnet_join_set_error_string(mem_ctx, r,
+                       "Our netbios name can be at most 15 chars long, "
+                         "\"%s\" is %u chars long\n",
+                         r->in.machine_name,
+                        (unsigned int)strlen(r->in.machine_name));
+               return WERR_INVALID_PARAM;
+        }
+
        if (!libnet_parse_domain_dc(mem_ctx, r->in.domain_name,
                                    &r->in.domain_name,
                                    &r->in.dc_name)) {