ctdb-eventscripts: Remove special case for virtio_net
authorMartin Schwenke <martin@meltin.net>
Tue, 29 Jul 2014 05:08:36 +0000 (15:08 +1000)
committerAmitay Isaacs <amitay@samba.org>
Thu, 31 Jul 2014 11:08:47 +0000 (13:08 +0200)
The current check is incorrect in 2 ways:

* Commit be71a84565e9e7532a77c175732b764d1f42c1cd contained a thinko
  that stops virtio_net interfaces from simply being marked up

* virtio_net interfaces can actually be down

virtio_net has supported ethtool since Linux 2.6.29, so just remove
the special case.  This means that testing CTDB on very old virtual
machines is not supported.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Jul 31 13:08:47 CEST 2014 on sn-devel-104

ctdb/config/events.d/10.interface

index 979fa7b7e06321dc10ddea4ea82420a21f067896..018f767e4447f53f299aa97ecc35ef16f80b1cf1 100755 (executable)
@@ -110,11 +110,6 @@ monitor_interfaces()
                mark_up $iface
                ;;
            *)
-               # Ignore virtio_net devices, assume they're always up
-               _driver_path="/sys/class/net/$iface/device/driver"
-               _driver=$(basename $(readlink "$_driver_path") 2>/dev/null)
-               [ "$_driver" = "virtio_net" ] && continue
-
                ethtool $iface | grep -q 'Link detected: yes' || {
                    # On some systems, this is not successful when a
                    # cable is plugged but the interface has not been