dsdb: Fix CID 1436920 Unchecked return value
authorVolker Lendecke <vl@samba.org>
Tue, 12 Jun 2018 19:09:40 +0000 (21:09 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 13 Jun 2018 08:30:15 +0000 (10:30 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/audit_log.c

index fd2387699d3bedf6f637cd9fa49a04f813f7b24a..23b4651b32d05940ff736aa30d6132bece529985 100644 (file)
@@ -1172,6 +1172,7 @@ static int add_transaction_id(
                talloc_get_type(ldb_module_get_private(module),
                                struct audit_context);
        struct dsdb_control_transaction_identifier *transaction_id;
+       int ret;
 
        transaction_id = talloc_zero(
                req,
@@ -1181,11 +1182,11 @@ static int add_transaction_id(
                return ldb_oom(ldb);
        }
        transaction_id->transaction_guid = ac->transaction_guid;
-       ldb_request_add_control(req,
-                               DSDB_CONTROL_TRANSACTION_IDENTIFIER_OID,
-                               false,
-                               transaction_id);
-       return LDB_SUCCESS;
+       ret = ldb_request_add_control(req,
+                                     DSDB_CONTROL_TRANSACTION_IDENTIFIER_OID,
+                                     false,
+                                     transaction_id);
+       return ret;
 
 }