nbt_server: Avoid an "else" branch
authorVolker Lendecke <vl@samba.org>
Sat, 17 Feb 2018 19:04:23 +0000 (20:04 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 27 Feb 2018 08:14:18 +0000 (09:14 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/nbt_server/dgram/netlogon.c

index d37f914fa68cbd569aefb6b61b773ace92f53906..4753ca88a3dadb2d89a7e14201ca1bbd33f57cd6 100644 (file)
@@ -114,7 +114,7 @@ static NTSTATUS nbtd_netlogon_samlogon(
        struct nbt_netlogon_response **presponse)
 {
        struct ldb_context *samctx;
-       struct dom_sid *sid;
+       struct dom_sid *sid = NULL;
        struct nbt_netlogon_response *response;
        NTSTATUS status;
 
@@ -126,10 +126,8 @@ static NTSTATUS nbtd_netlogon_samlogon(
 
        samctx = nbtsrv->sam_ctx;
 
-       if (netlogon->req.logon.sid_size) {
+       if (netlogon->req.logon.sid_size != 0) {
                sid = &netlogon->req.logon.sid;
-       } else {
-               sid = NULL;
        }
 
        response = talloc_zero(mem_ctx, struct nbt_netlogon_response);