r20333: Fix a couple of Coverity errors in one run, this was a potential NULL dereference
authorVolker Lendecke <vlendec@samba.org>
Sat, 23 Dec 2006 16:47:50 +0000 (16:47 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 17:16:41 +0000 (12:16 -0500)
source/libsmb/libsmbclient.c

index 0f0e0b834f89aa8894c55bc464cc1f7df92bb7e1..d9a39b12494ed702a7c01507fc8d01ccaa1bd072 100644 (file)
@@ -4246,11 +4246,14 @@ dos_attr_parse(SMBCCTX *context,
                        continue;
                }
 
-                n = strlen(attr_strings.create_time_attr);
-                if (attr_strings.create_time_attr != NULL &&
-                    StrnCaseCmp(tok, attr_strings.create_time_attr, n) == 0) {
-                        dad->create_time = (time_t)strtol(tok+n+1, NULL, 10);
-                       continue;
+               if (attr_strings.create_time_attr != NULL) {
+                       n = strlen(attr_strings.create_time_attr);
+                       if (StrnCaseCmp(tok, attr_strings.create_time_attr,
+                                       n) == 0) {
+                               dad->create_time = (time_t)strtol(tok+n+1,
+                                                                 NULL, 10);
+                               continue;
+                       }
                }
 
                if (StrnCaseCmp(tok, "INODE:", 6) == 0) {