KCC: Add fake transport EDGE_TYPE_ALL at most once
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 30 Apr 2015 00:41:34 +0000 (12:41 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 12 Jun 2015 04:57:14 +0000 (06:57 +0200)
It was being added in a loop which only ever looped once (because
we only do one transport, IP), so this makes no actual difference
but it is the correct thing.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/kcc/__init__.py

index 61e16c9bd816462a2a489f22a6c5e9d82a52174f..0ac357d2d7d1954b7d51b871b349df2d27edcbff 100644 (file)
@@ -1644,9 +1644,9 @@ class KCC(object):
             vertex.accept_red_red.append(t_guid)
             vertex.accept_black.append(t_guid)
 
-            # Add additional transport to allow another run of Dijkstra
-            vertex.accept_red_red.append("EDGE_TYPE_ALL")
-            vertex.accept_black.append("EDGE_TYPE_ALL")
+        # Add additional transport to allow another run of Dijkstra
+        vertex.accept_red_red.append("EDGE_TYPE_ALL")
+        vertex.accept_black.append("EDGE_TYPE_ALL")
 
         return found_failed