replace getpwnam_alloc with plain getpwnam.
authorSimo Sorce <idra@samba.org>
Mon, 21 Jan 2002 07:51:26 +0000 (07:51 +0000)
committerSimo Sorce <idra@samba.org>
Mon, 21 Jan 2002 07:51:26 +0000 (07:51 +0000)
We are not going to reuse any getpw* call, so the extra alloc,copy and free
only uses extra memory and extra cpu time for nothing.
(This used to be commit 5c0bb0487bec00df494b72b64ddf274f42bfefea)

source3/passdb/pdb_tdb.c

index 3d3b620f50416311681520d7a327af4ef0bd8ff5..d7bfbb8026780e86ceddce361711d4e20960e825 100644 (file)
@@ -140,7 +140,7 @@ static BOOL init_sam_from_buffer (struct tdbsam_privates *tdb_state,
                 * getpwnam() is used instead of Get_Pwnam() as we do not need
                 * to try case permutations
                 */
-               if (!username || !(pw=getpwnam_alloc(username))) {
+               if (!username || !(pw=getpwnam(username))) {
                        DEBUG(0,("tdb_sam: getpwnam_alloc(%s) return NULL.  User does not exist!\n", 
                                  username?username:"NULL"));
                        ret = False;
@@ -149,7 +149,6 @@ static BOOL init_sam_from_buffer (struct tdbsam_privates *tdb_state,
                pdb_set_uid(sampass, pw->pw_uid);
                gid = pw->pw_gid;
                pdb_set_gid(sampass, gid);
-               passwd_free(&pw);
        }
 
        pdb_set_logon_time(sampass, logon_time);