git.samba.org / sfrench / samba-autobuild / .git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
lib/param: handle non-constant strings properly by passing in a memory context
[sfrench/samba-autobuild/.git] / source4 / nbt_server / wins / winsdb.c
diff --git a/source4/nbt_server/wins/winsdb.c b/source4/nbt_server/wins/winsdb.c
index 5c3efe2b83c9803b0de0e6365962381680fd3d24..fa9a6154b9a80f0471914d65c4a1238d5586bf9b 100644 (file)
--- a/source4/nbt_server/wins/winsdb.c
+++ b/source4/nbt_server/wins/winsdb.c
@@ -23,8 +23,8 @@
 #include "includes.h"
 #include "nbt_server/nbt_server.h"
 #include "nbt_server/wins/winsdb.h"
-#include "lib/ldb/include/ldb.h"
-#include "lib/ldb/include/ldb_errors.h"
+#include <ldb.h>
+#include <ldb_errors.h>
 #include "librpc/gen_ndr/ndr_nbt.h"
 #include "system/time.h"
 #include "ldb_wrap.h"
@@ -100,17 +100,17 @@ uint64_t winsdb_set_maxVersion(struct winsdb_handle *h, uint64_t newMaxVersion)
 
 
        ret = ldb_msg_add_empty(msg, "objectClass", LDB_FLAG_MOD_REPLACE, NULL);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
        ret = ldb_msg_add_string(msg, "objectClass", "winsMaxVersion");
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
        ret = ldb_msg_add_empty(msg, "maxVersion", LDB_FLAG_MOD_REPLACE, NULL);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
        ret = ldb_msg_add_fmt(msg, "maxVersion", "%llu", (long long)newMaxVersion);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
 
        ret = ldb_modify(wins_db, msg);
-       if (ret != 0) ret = ldb_add(wins_db, msg);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) ret = ldb_add(wins_db, msg);
+       if (ret != LDB_SUCCESS) goto failed;
 
        trans = ldb_transaction_commit(wins_db);
        if (trans != LDB_SUCCESS) goto failed;
@@ -124,32 +124,6 @@ failed:
        return 0;
 }
 
-uint64_t winsdb_get_seqnumber(struct winsdb_handle *h)
-{
-       int ret;
-       struct ldb_context *ldb = h->ldb;
-       struct ldb_dn *dn;
-       struct ldb_result *res = NULL;
-       TALLOC_CTX *tmp_ctx = talloc_new(ldb);
-       uint64_t seqnumber = 0;
-
-       dn = ldb_dn_new(tmp_ctx, ldb, "@BASEINFO");
-       if (!dn) goto failed;
-
-       /* find the record in the WINS database */
-       ret = ldb_search(ldb, tmp_ctx, &res, dn, LDB_SCOPE_BASE, NULL, NULL);
-       if (ret != LDB_SUCCESS) goto failed;
-       if (res->count > 1) goto failed;
-
-       if (res->count == 1) {
-               seqnumber = ldb_msg_find_attr_as_uint64(res->msgs[0], "sequenceNumber", 0);
-       }
-
-failed:
-       talloc_free(tmp_ctx);
-       return seqnumber;
-}
-
 /*
   return a DN for a nbt_name
 */
@@ -249,7 +223,7 @@ static NTSTATUS winsdb_addr_decode(struct winsdb_handle *h, struct winsdb_record
        if (!p) {
                /* support old entries, with only the address */
                addr->address           = (const char *)talloc_steal(addr, val->data);
-               addr->wins_owner        = talloc_reference(addr, rec->wins_owner);
+               addr->wins_owner        = talloc_strdup(addr, rec->wins_owner);
                if (!addr->wins_owner) {
                        status = NT_STATUS_NO_MEMORY;
                        goto failed;
@@ -259,7 +233,7 @@ static NTSTATUS winsdb_addr_decode(struct winsdb_handle *h, struct winsdb_record
                return NT_STATUS_OK;
        }
 
-       *p = '\0';p++;
+       *p = '\0'; p++;
        addr->address = talloc_strdup(addr, address);
        if (!addr->address) {
                status = NT_STATUS_NO_MEMORY;
@@ -319,27 +293,23 @@ failed:
 static int ldb_msg_add_winsdb_addr(struct ldb_message *msg, struct winsdb_record *rec,
                                   const char *attr_name, struct winsdb_addr *addr)
 {
-       struct ldb_val val;
        const char *str;
 
        if (rec->is_static) {
                str = talloc_strdup(msg, addr->address);
-               if (!str) return -1;
+               if (!str) return LDB_ERR_OPERATIONS_ERROR;
        } else {
                char *expire_time;
                expire_time = ldb_timestring(msg, addr->expire_time);
-               if (!expire_time) return -1;
+               if (!expire_time) return LDB_ERR_OPERATIONS_ERROR;
                str = talloc_asprintf(msg, "%s;winsOwner:%s;expireTime:%s;",
                                      addr->address, addr->wins_owner,
                                      expire_time);
                talloc_free(expire_time);
-               if (!str) return -1;
+               if (!str) return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       val.data = discard_const_p(uint8_t, str);
-       val.length = strlen(str);
-
-       return ldb_msg_add_value(msg, attr_name, &val, NULL);
+       return ldb_msg_add_string(msg, attr_name, str);
 }
 
 struct winsdb_addr **winsdb_addr_list_make(TALLOC_CTX *mem_ctx)
@@ -507,7 +477,7 @@ add_new_addr:
 
        addresses[len+1] = NULL;
 
-       ldb_qsort(addresses, len+1 , sizeof(addresses[0]), h, (ldb_qsort_cmp_fn_t)winsdb_addr_sort_list);
+       LDB_TYPESAFE_QSORT(addresses, len+1, h, winsdb_addr_sort_list);
 
        return addresses;
 }
@@ -750,7 +720,7 @@ static struct ldb_message *winsdb_message(struct ldb_context *ldb,
                                          struct winsdb_record *rec,
                                          TALLOC_CTX *mem_ctx)
 {
-       int i, ret=0;
+       int i, ret;
        size_t addr_count;
        const char *expire_time;
        struct ldb_message *msg = ldb_msg_new(mem_ctx);
@@ -772,7 +742,7 @@ static struct ldb_message *winsdb_message(struct ldb_context *ldb,
 
        msg->dn = winsdb_dn(msg, ldb, rec->name);
        if (msg->dn == NULL) goto failed;
-       ret |= ldb_msg_add_fmt(msg, "type", "0x%02X", rec->name->type);
+       ret = ldb_msg_add_fmt(msg, "type", "0x%02X", rec->name->type);
        if (rec->name->name && *rec->name->name) {
                ret |= ldb_msg_add_string(msg, "name", rec->name->name);
        }
@@ -794,11 +764,11 @@ static struct ldb_message *winsdb_message(struct ldb_context *ldb,
        for (i=0;rec->addresses[i];i++) {
                ret |= ldb_msg_add_winsdb_addr(msg, rec, "address", rec->addresses[i]);
        }
-       ret |= ldb_msg_add_empty(msg, "registeredBy", 0, NULL);
        if (rec->registered_by) {
+               ret |= ldb_msg_add_empty(msg, "registeredBy", 0, NULL);
                ret |= ldb_msg_add_string(msg, "registeredBy", rec->registered_by);
-               if (ret != 0) goto failed;
        }
+       if (ret != LDB_SUCCESS) goto failed;
        return msg;
 
 failed:
@@ -815,7 +785,7 @@ uint8_t winsdb_add(struct winsdb_handle *h, struct winsdb_record *rec, uint32_t
        struct ldb_context *wins_db = h->ldb;
        TALLOC_CTX *tmp_ctx = talloc_new(wins_db);
        int trans = -1;
-       int ret = 0;
+       int ret;
 
        trans = ldb_transaction_start(wins_db);
        if (trans != LDB_SUCCESS) goto failed;
@@ -832,7 +802,7 @@ uint8_t winsdb_add(struct winsdb_handle *h, struct winsdb_record *rec, uint32_t
        msg = winsdb_message(wins_db, rec, tmp_ctx);
        if (msg == NULL) goto failed;
        ret = ldb_add(wins_db, msg);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
 
        trans = ldb_transaction_commit(wins_db);
        if (trans != LDB_SUCCESS) goto failed;
@@ -859,7 +829,7 @@ uint8_t winsdb_modify(struct winsdb_handle *h, struct winsdb_record *rec, uint32
        TALLOC_CTX *tmp_ctx = talloc_new(wins_db);
        int trans;
        int ret;
-       int i;
+       unsigned int i;
 
        trans = ldb_transaction_start(wins_db);
        if (trans != LDB_SUCCESS) goto failed;
@@ -881,7 +851,7 @@ uint8_t winsdb_modify(struct winsdb_handle *h, struct winsdb_record *rec, uint32
        }
 
        ret = ldb_modify(wins_db, msg);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
 
        trans = ldb_transaction_commit(wins_db);
        if (trans != LDB_SUCCESS) goto failed;
@@ -916,7 +886,7 @@ uint8_t winsdb_delete(struct winsdb_handle *h, struct winsdb_record *rec)
        if (dn == NULL) goto failed;
 
        ret = ldb_delete(wins_db, dn);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
 
        trans = ldb_transaction_commit(wins_db);
        if (trans != LDB_SUCCESS) goto failed;
@@ -933,7 +903,8 @@ failed:
 }
 
 static bool winsdb_check_or_add_module_list(struct tevent_context *ev_ctx, 
-                                           struct loadparm_context *lp_ctx, struct winsdb_handle *h)
+                                           struct loadparm_context *lp_ctx, struct winsdb_handle *h,
+                                           const char *wins_path)
 {
        int trans;
        int ret;
@@ -962,10 +933,10 @@ static bool winsdb_check_or_add_module_list(struct tevent_context *ev_ctx,
        msg->dn = dn;
 
        ret = ldb_msg_add_string(msg, "@LIST", "wins_ldb");
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
 
        ret = ldb_add(h->ldb, msg);
-       if (ret != 0) goto failed;
+       if (ret != LDB_SUCCESS) goto failed;
 
        trans = ldb_transaction_commit(h->ldb);
        if (trans != LDB_SUCCESS) goto failed;
@@ -975,12 +946,12 @@ static bool winsdb_check_or_add_module_list(struct tevent_context *ev_ctx,
        talloc_free(h->ldb);
        h->ldb = NULL;
 
-       if (lp_parm_bool(lp_ctx, NULL,"winsdb", "nosync", false)) {
+       if (lpcfg_parm_bool(lp_ctx, NULL,"winsdb", "nosync", false)) {
                flags |= LDB_FLG_NOSYNC;
        }
 
-       h->ldb = ldb_wrap_connect(h, ev_ctx, lp_ctx, lock_path(h, lp_ctx, lp_wins_url(lp_ctx)),
-                                 NULL, NULL, flags, NULL);
+       h->ldb = ldb_wrap_connect(h, ev_ctx, lp_ctx, wins_path,
+                                 NULL, NULL, flags);
        if (!h->ldb) goto failed;
 
        talloc_free(tmp_ctx);
@@ -1007,26 +978,29 @@ struct winsdb_handle *winsdb_connect(TALLOC_CTX *mem_ctx,
        unsigned int flags = 0;
        bool ret;
        int ldb_err;
+       char *wins_path;
 
        h = talloc_zero(mem_ctx, struct winsdb_handle);
        if (!h) return NULL;
 
-       if (lp_parm_bool(lp_ctx, NULL,"winsdb", "nosync", false)) {
+       wins_path = lpcfg_state_path(h, lp_ctx, "wins.ldb");
+
+       if (lpcfg_parm_bool(lp_ctx, NULL,"winsdb", "nosync", false)) {
                flags |= LDB_FLG_NOSYNC;
        }
 
-       h->ldb = ldb_wrap_connect(h, ev_ctx, lp_ctx, lock_path(h, lp_ctx, lp_wins_url(lp_ctx)),
-                                 NULL, NULL, flags, NULL);
-       if (!h->ldb) goto failed;       
+       h->ldb = ldb_wrap_connect(h, ev_ctx, lp_ctx, wins_path,
+                                 NULL, NULL, flags);
+       if (!h->ldb) goto failed;
 
        h->caller = caller;
-       h->hook_script = lp_wins_hook(lp_ctx);
+       h->hook_script = lpcfg_wins_hook(lp_ctx, h);
 
        h->local_owner = talloc_strdup(h, owner);
        if (!h->local_owner) goto failed;
 
        /* make sure the module list is available and used */
-       ret = winsdb_check_or_add_module_list(ev_ctx, lp_ctx, h);
+       ret = winsdb_check_or_add_module_list(ev_ctx, lp_ctx, h, wins_path);
        if (!ret) goto failed;
 
        ldb_err = ldb_set_opaque(h->ldb, "winsdb_handle", h);
@@ -1037,3 +1011,4 @@ failed:
        talloc_free(h);
        return NULL;
 }
+
Unnamed repository; edit this file 'description' to name the repository.