net: mvpp2: cls: Report an error for unsupported flow types
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Fri, 5 Jul 2019 12:09:12 +0000 (14:09 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 Jul 2019 22:50:06 +0000 (15:50 -0700)
Add a missing check to detect flow types that we don't support, so that
user can be informed of this.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c

index b195fb5d61f4aa131a19b3f4bd269e50749563ab..6c088c903c15b66a31fa9d96af7f52c00cbba18c 100644 (file)
@@ -1373,6 +1373,10 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port,
 
        efs->rule.flow = ethtool_rule->rule;
        efs->rule.flow_type = mvpp2_cls_ethtool_flow_to_type(info->fs.flow_type);
+       if (efs->rule.flow_type < 0) {
+               ret = efs->rule.flow_type;
+               goto clean_rule;
+       }
 
        ret = mvpp2_cls_rfs_parse_rule(&efs->rule);
        if (ret)