x86/io_delay: Break instead of fallthrough in switch statement
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 21 May 2019 07:22:10 +0000 (16:22 +0900)
committerIngo Molnar <mingo@kernel.org>
Fri, 24 May 2019 06:46:06 +0000 (08:46 +0200)
The current code is fine since 'case CONFIG_IO_DELAY_TYPE_NONE'
does nothing, but scripts/checkpatch.pl complains about this:

  warning: Possible switch case/default not preceded by break or fallthrough comment

I like break statement better than a fallthrough comment here.
It avoids the warning and clarify the code.

No behavior change is intended.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20190521072211.21014-1-yamada.masahiro@socionext.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/io_delay.c

index 805b7a341aca2e773b67317aea90f334ea0f96d6..3dc874d5d43bc15a0bd3221864e6afbaa713593d 100644 (file)
@@ -39,6 +39,7 @@ void native_io_delay(void)
                 * are shorter until calibrated):
                 */
                udelay(2);
+               break;
        case CONFIG_IO_DELAY_TYPE_NONE:
                break;
        }