ALSA: hda/realtek - Dell headphone has noise on unmute for ALC236
authorKailang Yang <kailang@realtek.com>
Tue, 26 Nov 2019 09:04:23 +0000 (17:04 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 28 Nov 2019 07:11:36 +0000 (08:11 +0100)
headphone have noise even the volume is very small.
Let it fill up pcbeep hidden register to default value.
The issue was gone.

Fixes: 4344aec84bd8 ("ALSA: hda/realtek - New codec support for ALC256")
Fixes: 736f20a70608 ("ALSA: hda/realtek - Add support for ALC236/ALC3204")
Signed-off-by: Kailang Yang <kailang@realtek.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/9ae47f23a64d4e41a9c81e263cd8a250@realtek.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index d2bf70a1d2fd229f999410001d83bb9dac84b3e5..9f355b2f7d7be5cd4cf65f47bbf092531bc23ef7 100644 (file)
@@ -367,9 +367,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
        case 0x10ec0215:
        case 0x10ec0233:
        case 0x10ec0235:
-       case 0x10ec0236:
        case 0x10ec0255:
-       case 0x10ec0256:
        case 0x10ec0257:
        case 0x10ec0282:
        case 0x10ec0283:
@@ -381,6 +379,11 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
        case 0x10ec0300:
                alc_update_coef_idx(codec, 0x10, 1<<9, 0);
                break;
+       case 0x10ec0236:
+       case 0x10ec0256:
+               alc_write_coef_idx(codec, 0x36, 0x5757);
+               alc_update_coef_idx(codec, 0x10, 1<<9, 0);
+               break;
        case 0x10ec0275:
                alc_update_coef_idx(codec, 0xe, 0, 1<<0);
                break;