ARM: davinci: PM: Do not free useful resources in normal path in 'davinci_pm_init'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 13 May 2017 11:40:20 +0000 (13:40 +0200)
committerSekhar Nori <nsekhar@ti.com>
Wed, 17 May 2017 09:55:18 +0000 (15:25 +0530)
It is wrong to iounmap resources in the normal path of davinci_pm_init()

The 3 ioremap'ed fields of 'pm_config' can be accessed later on in other
functions, so we should return 'success' instead of unrolling everything.

Fixes: aa9aa1ec2df6 ("ARM: davinci: PM: rework init, remove platform device")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[nsekhar@ti.com: commit message and minor style fixes]
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
arch/arm/mach-davinci/pm.c

index d282b0783ecfc3c39abfde594e27164348379754..b5cc05dc2cb27c9e20e5f8290b65fff2efeec8ec 100644 (file)
@@ -162,6 +162,8 @@ int __init davinci_pm_init(void)
 
        suspend_set_ops(&davinci_pm_ops);
 
+       return 0;
+
 no_sram_mem:
        iounmap(pm_config.ddrpsc_reg_base);
 no_ddrpsc_mem: