gpiolib: Consistent use of ->get_direction() inside gpiolib
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 9 Jul 2018 18:47:21 +0000 (21:47 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 13 Jul 2018 07:01:46 +0000 (09:01 +0200)
Two out of three calls to ->get_direction (excluding, of course,
gpiod_get_direction() itself) are using gpiod_get_direction() and
one is still open coded.

Replace the latter one to use same API for sake of consistency.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c

index a9a290999990edd54c65edf42f3f2a890837dc98..cbc071423f308b113cfdad2c3accdc758720f08a 100644 (file)
@@ -3260,18 +3260,13 @@ int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset)
         * behind our back
         */
        if (!chip->can_sleep && chip->get_direction) {
-               int dir = chip->get_direction(chip, offset);
+               int dir = gpiod_get_direction(desc);
 
                if (dir < 0) {
                        chip_err(chip, "%s: cannot get GPIO direction\n",
                                 __func__);
                        return dir;
                }
-
-               if (dir)
-                       clear_bit(FLAG_IS_OUT, &desc->flags);
-               else
-                       set_bit(FLAG_IS_OUT, &desc->flags);
        }
 
        if (test_bit(FLAG_IS_OUT, &desc->flags)) {