Input: mxs-lradc - use correct error check
authorPan Bian <bianpan2016@163.com>
Mon, 14 Aug 2017 17:29:13 +0000 (10:29 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 15 Aug 2017 03:23:47 +0000 (20:23 -0700)
Function devm_ioremap() will return a NULL pointer on failure. However,
in function mxs_lradc_ts_probe(), its return value is checked with
IS_ERR(), which cannot detect the exceptional case.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/mxs-lradc-ts.c

index 71bf493e8b58d9ff666c82c375e45b7d45add6ae..816f5c8c101debcc8a6e643771eae302f7e313ec 100644 (file)
@@ -633,8 +633,8 @@ static int mxs_lradc_ts_probe(struct platform_device *pdev)
        if (!iores)
                return -EINVAL;
        ts->base = devm_ioremap(dev, iores->start, resource_size(iores));
-       if (IS_ERR(ts->base))
-               return PTR_ERR(ts->base);
+       if (!ts->base)
+               return -ENOMEM;
 
        ret = of_property_read_u32(node, "fsl,lradc-touchscreen-wires",
                                   &ts_wires);