audit_get_nd(): don't unlock parent too early
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 2 Nov 2019 17:11:41 +0000 (13:11 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 10 Nov 2019 16:56:55 +0000 (11:56 -0500)
if the child has been negative and just went positive
under us, we want coherent d_is_positive() and ->d_inode.
Don't unlock the parent until we'd done that work...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
kernel/audit_watch.c

index 1f31c2f1e6fc19ad9eecc957d7f2cb9a6154a032..4508d5e0cf6966b89ac1f59bd3348b93c833e757 100644 (file)
@@ -351,12 +351,12 @@ static int audit_get_nd(struct audit_watch *watch, struct path *parent)
        struct dentry *d = kern_path_locked(watch->path, parent);
        if (IS_ERR(d))
                return PTR_ERR(d);
-       inode_unlock(d_backing_inode(parent->dentry));
        if (d_is_positive(d)) {
                /* update watch filter fields */
                watch->dev = d->d_sb->s_dev;
                watch->ino = d_backing_inode(d)->i_ino;
        }
+       inode_unlock(d_backing_inode(parent->dentry));
        dput(d);
        return 0;
 }