dm ioctl: use offsetof() instead of open-coding it

Subtracting sizes is a fragile approach because the result is only
correct if the compiler has not added any padding at the end of the
structure. Hence use offsetof() instead of size subtraction. An
additional advantage of offsetof() is that it makes the intent more
clear.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 966eb4b61aed565c7621958c55174140d19824a8..c72a77048b73befd6ad3de81ebc2be18349958dd 100644 (file)
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1697,7 +1697,7 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern
 {
        struct dm_ioctl *dmi;
        int secure_data;
-       const size_t minimum_data_size = sizeof(*param_kernel) - sizeof(param_kernel->data);
+       const size_t minimum_data_size = offsetof(struct dm_ioctl, data);
 
        if (copy_from_user(param_kernel, user, minimum_data_size))
                return -EFAULT;