parisc: Remove pte_inserted define
authorJohn David Anglin <dave.anglin@bell.net>
Sat, 20 Oct 2018 00:33:29 +0000 (20:33 -0400)
committerHelge Deller <deller@gmx.de>
Sat, 20 Oct 2018 19:09:30 +0000 (21:09 +0200)
The attached change removes the pte_inserted from pgtable.h.  As a
result, we always flush the TLB entry when the associated page table
entry is changed.

This change doesn't impact performance signifcantly and it may catch
some cases where the TLB needs flushing but wasn't.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
Signed-off-by: Helge Deller <deller@gmx.de>
arch/parisc/include/asm/pgtable.h

index 94c0ef7a9e030f78406369994d972eea1e3493f4..b941ac7d4e70b35181351565136a9c25e7ee66f0 100644 (file)
@@ -55,10 +55,6 @@ static inline void purge_tlb_entries(struct mm_struct *mm, unsigned long addr)
                 *(pteptr) = (pteval);                           \
         } while(0)
 
-#define pte_inserted(x)                                                \
-       ((pte_val(x) & (_PAGE_PRESENT|_PAGE_ACCESSED))          \
-        == (_PAGE_PRESENT|_PAGE_ACCESSED))
-
 #define set_pte_at(mm, addr, ptep, pteval)                     \
        do {                                                    \
                pte_t old_pte;                                  \
@@ -66,8 +62,7 @@ static inline void purge_tlb_entries(struct mm_struct *mm, unsigned long addr)
                spin_lock_irqsave(&pa_tlb_lock, flags);         \
                old_pte = *ptep;                                \
                set_pte(ptep, pteval);                          \
-               if (pte_inserted(old_pte))                      \
-                       purge_tlb_entries(mm, addr);            \
+               purge_tlb_entries(mm, addr);                    \
                spin_unlock_irqrestore(&pa_tlb_lock, flags);    \
        } while (0)
 
@@ -493,8 +488,7 @@ static inline pte_t ptep_get_and_clear(struct mm_struct *mm, unsigned long addr,
        spin_lock_irqsave(&pa_tlb_lock, flags);
        old_pte = *ptep;
        set_pte(ptep, __pte(0));
-       if (pte_inserted(old_pte))
-               purge_tlb_entries(mm, addr);
+       purge_tlb_entries(mm, addr);
        spin_unlock_irqrestore(&pa_tlb_lock, flags);
 
        return old_pte;