devpts_pty_kill(): don't bother with d_delete()
authorAl Viro <viro@zeniv.linux.org.uk>
Sat, 27 Jul 2019 20:29:22 +0000 (16:29 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 3 Sep 2019 13:30:56 +0000 (09:30 -0400)
we are not retaining dentries there anyway (simple_dentry_operations),
so d_delete()+dput() == d_drop()+dput()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/devpts/inode.c

index beeadca23b05c85f5171c18d240f9580f496f1e4..42e5a766d33c7d1fea3ca9c05be73639c38c421e 100644 (file)
@@ -622,7 +622,7 @@ void devpts_pty_kill(struct dentry *dentry)
        dentry->d_fsdata = NULL;
        drop_nlink(dentry->d_inode);
        fsnotify_unlink(d_inode(dentry->d_parent), dentry);
-       d_delete(dentry);
+       d_drop(dentry);
        dput(dentry);   /* d_alloc_name() in devpts_pty_new() */
 }