SUNRPC: Replace division by multiplication in calculation of queue length

When checking whether or not a particular xprt queue length is shorter
than the average queue length for all xprts, prefer to use multiplication
rather than division for performance reasons.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

diff --git a/net/sunrpc/xprtmultipath.c b/net/sunrpc/xprtmultipath.c
index 9d66ce53355d9635b32520af5d349c946ba53579..5df4e7adedf073b0d7bbd67d572236898dd6a095 100644 (file)
--- a/net/sunrpc/xprtmultipath.c
+++ b/net/sunrpc/xprtmultipath.c
@@ -322,7 +322,6 @@ struct rpc_xprt *xprt_iter_next_entry_roundrobin(struct rpc_xprt_iter *xpi)
        struct rpc_xprt *xprt;
        unsigned long xprt_queuelen;
        unsigned long xps_queuelen;
-       unsigned long xps_avglen;
 
        do {
                xprt = xprt_iter_next_entry_multiple(xpi,
@@ -333,8 +332,8 @@ struct rpc_xprt *xprt_iter_next_entry_roundrobin(struct rpc_xprt_iter *xpi)
                if (xprt_queuelen <= 2)
                        break;
                xps_queuelen = atomic_long_read(&xps->xps_queuelen);
-               xps_avglen = DIV_ROUND_UP(xps_queuelen, xps->xps_nactive);
-       } while (xprt_queuelen > xps_avglen);
+               /* Exit loop if xprt_queuelen <= average queue length */
+       } while (xprt_queuelen * READ_ONCE(xps->xps_nactive) > xps_queuelen);
        return xprt;
 }