Input: ili210x - do not unconditionally mark touchscreen as wakeup source
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 4 Nov 2019 23:27:41 +0000 (15:27 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 12 Nov 2019 00:12:19 +0000 (16:12 -0800)
I2C devices that are supposed to be wakeup sources should be instantiated
with I2C_CLIENT_WAKE flag (which can be either set by in board info, or
retrieved from "wakeup-source" property); individual drivers should not be
marking devices as wakeup sources unconditionally.

Tested-by: Adam Ford <aford173@gmail.com> #imx6q-logicpd
Tested-by: Sven Van Asbroeck <TheSven73@gmail.com> # ILI2118A variant
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/ili210x.c

index 22811df82044a34701a2732d6da0ef8a8aac8307..ef0da2fc8bd3e3ce38e847abc375199bb29332e7 100644 (file)
@@ -439,8 +439,6 @@ static int ili210x_i2c_probe(struct i2c_client *client,
                return error;
        }
 
                return error;
        }
 
-       device_init_wakeup(dev, 1);
-
        dev_dbg(dev,
                "ILI210x initialized (IRQ: %d), firmware version %d.%d.%d",
                client->irq, firmware.id, firmware.major, firmware.minor);
        dev_dbg(dev,
                "ILI210x initialized (IRQ: %d), firmware version %d.%d.%d",
                client->irq, firmware.id, firmware.major, firmware.minor);