clk: x86: pmc-atom: Checking for IS_ERR() instead of NULL
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 22 Apr 2017 10:43:33 +0000 (13:43 +0300)
committerStephen Boyd <sboyd@codeaurora.org>
Mon, 1 May 2017 18:13:25 +0000 (11:13 -0700)
clkdev_hw_create() returns NULLs on error, it doesn't return error
pointers.

Fixes: 41ee7caf59e1 ("clk: x86: add "mclk" alias for Baytrail/Cherrytrail")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/x86/clk-pmc-atom.c

index fafc99120dc2e69587d98d8e5f4c484b18e4bfac..f99abc1106f0cb725ff7c63e9bc84b75596a4e75 100644 (file)
@@ -339,8 +339,8 @@ static int plt_clk_probe(struct platform_device *pdev)
                }
        }
        data->mclk_lookup = clkdev_hw_create(&data->clks[3]->hw, "mclk", NULL);
                }
        }
        data->mclk_lookup = clkdev_hw_create(&data->clks[3]->hw, "mclk", NULL);
-       if (IS_ERR(data->mclk_lookup)) {
-               err = PTR_ERR(data->mclk_lookup);
+       if (!data->mclk_lookup) {
+               err = -ENOMEM;
                goto err_unreg_clk_plt;
        }
 
                goto err_unreg_clk_plt;
        }