1 /* drivers/gpu/drm/exynos/exynos7_drm_decon.c
3 * Copyright (C) 2014 Samsung Electronics Co.Ltd
5 * Akshu Agarwal <akshua@gmail.com>
6 * Ajay Kumar <ajaykumar.rs@samsung.com>
8 * This program is free software; you can redistribute it and/or modify it
9 * under the terms of the GNU General Public License as published by the
10 * Free Software Foundation; either version 2 of the License, or (at your
11 * option) any later version.
15 #include <drm/exynos_drm.h>
17 #include <linux/clk.h>
18 #include <linux/component.h>
19 #include <linux/kernel.h>
21 #include <linux/of_address.h>
22 #include <linux/of_device.h>
23 #include <linux/platform_device.h>
24 #include <linux/pm_runtime.h>
26 #include <video/of_display_timing.h>
27 #include <video/of_videomode.h>
28 #include <video/exynos7_decon.h>
30 #include "exynos_drm_crtc.h"
31 #include "exynos_drm_plane.h"
32 #include "exynos_drm_drv.h"
33 #include "exynos_drm_fb.h"
34 #include "exynos_drm_iommu.h"
37 * DECON stands for Display and Enhancement controller.
40 #define MIN_FB_WIDTH_FOR_16WORD_BURST 128
44 struct decon_context {
46 struct drm_device *drm_dev;
47 struct exynos_drm_crtc *crtc;
48 struct exynos_drm_plane planes[WINDOWS_NR];
49 struct exynos_drm_plane_config configs[WINDOWS_NR];
55 unsigned long irq_flags;
58 wait_queue_head_t wait_vsync_queue;
59 atomic_t wait_vsync_event;
61 struct drm_encoder *encoder;
64 static const struct of_device_id decon_driver_dt_match[] = {
65 {.compatible = "samsung,exynos7-decon"},
68 MODULE_DEVICE_TABLE(of, decon_driver_dt_match);
70 static const uint32_t decon_formats[] = {
82 static const enum drm_plane_type decon_win_types[WINDOWS_NR] = {
83 DRM_PLANE_TYPE_PRIMARY,
84 DRM_PLANE_TYPE_CURSOR,
87 static void decon_wait_for_vblank(struct exynos_drm_crtc *crtc)
89 struct decon_context *ctx = crtc->ctx;
94 atomic_set(&ctx->wait_vsync_event, 1);
97 * wait for DECON to signal VSYNC interrupt or return after
98 * timeout which is set to 50ms (refresh rate of 20).
100 if (!wait_event_timeout(ctx->wait_vsync_queue,
101 !atomic_read(&ctx->wait_vsync_event),
103 DRM_DEBUG_KMS("vblank wait timed out.\n");
106 static void decon_clear_channels(struct exynos_drm_crtc *crtc)
108 struct decon_context *ctx = crtc->ctx;
109 unsigned int win, ch_enabled = 0;
111 DRM_DEBUG_KMS("%s\n", __FILE__);
113 /* Check if any channel is enabled. */
114 for (win = 0; win < WINDOWS_NR; win++) {
115 u32 val = readl(ctx->regs + WINCON(win));
117 if (val & WINCONx_ENWIN) {
118 val &= ~WINCONx_ENWIN;
119 writel(val, ctx->regs + WINCON(win));
124 /* Wait for vsync, as disable channel takes effect at next vsync */
126 decon_wait_for_vblank(ctx->crtc);
129 static int decon_ctx_initialize(struct decon_context *ctx,
130 struct drm_device *drm_dev)
132 ctx->drm_dev = drm_dev;
134 decon_clear_channels(ctx->crtc);
136 return drm_iommu_attach_device(drm_dev, ctx->dev);
139 static void decon_ctx_remove(struct decon_context *ctx)
141 /* detach this sub driver from iommu mapping if supported. */
142 drm_iommu_detach_device(ctx->drm_dev, ctx->dev);
145 static u32 decon_calc_clkdiv(struct decon_context *ctx,
146 const struct drm_display_mode *mode)
148 unsigned long ideal_clk = mode->htotal * mode->vtotal * mode->vrefresh;
151 /* Find the clock divider value that gets us closest to ideal_clk */
152 clkdiv = DIV_ROUND_UP(clk_get_rate(ctx->vclk), ideal_clk);
154 return (clkdiv < 0x100) ? clkdiv : 0xff;
157 static void decon_commit(struct exynos_drm_crtc *crtc)
159 struct decon_context *ctx = crtc->ctx;
160 struct drm_display_mode *mode = &crtc->base.state->adjusted_mode;
166 /* nothing to do if we haven't set the mode yet */
167 if (mode->htotal == 0 || mode->vtotal == 0)
171 int vsync_len, vbpd, vfpd, hsync_len, hbpd, hfpd;
172 /* setup vertical timing values. */
173 vsync_len = mode->crtc_vsync_end - mode->crtc_vsync_start;
174 vbpd = mode->crtc_vtotal - mode->crtc_vsync_end;
175 vfpd = mode->crtc_vsync_start - mode->crtc_vdisplay;
177 val = VIDTCON0_VBPD(vbpd - 1) | VIDTCON0_VFPD(vfpd - 1);
178 writel(val, ctx->regs + VIDTCON0);
180 val = VIDTCON1_VSPW(vsync_len - 1);
181 writel(val, ctx->regs + VIDTCON1);
183 /* setup horizontal timing values. */
184 hsync_len = mode->crtc_hsync_end - mode->crtc_hsync_start;
185 hbpd = mode->crtc_htotal - mode->crtc_hsync_end;
186 hfpd = mode->crtc_hsync_start - mode->crtc_hdisplay;
188 /* setup horizontal timing values. */
189 val = VIDTCON2_HBPD(hbpd - 1) | VIDTCON2_HFPD(hfpd - 1);
190 writel(val, ctx->regs + VIDTCON2);
192 val = VIDTCON3_HSPW(hsync_len - 1);
193 writel(val, ctx->regs + VIDTCON3);
196 /* setup horizontal and vertical display size. */
197 val = VIDTCON4_LINEVAL(mode->vdisplay - 1) |
198 VIDTCON4_HOZVAL(mode->hdisplay - 1);
199 writel(val, ctx->regs + VIDTCON4);
201 writel(mode->vdisplay - 1, ctx->regs + LINECNT_OP_THRESHOLD);
204 * fields of register with prefix '_F' would be updated
205 * at vsync(same as dma start)
207 val = VIDCON0_ENVID | VIDCON0_ENVID_F;
208 writel(val, ctx->regs + VIDCON0);
210 clkdiv = decon_calc_clkdiv(ctx, mode);
212 val = VCLKCON1_CLKVAL_NUM_VCLK(clkdiv - 1);
213 writel(val, ctx->regs + VCLKCON1);
214 writel(val, ctx->regs + VCLKCON2);
217 val = readl(ctx->regs + DECON_UPDATE);
218 val |= DECON_UPDATE_STANDALONE_F;
219 writel(val, ctx->regs + DECON_UPDATE);
222 static int decon_enable_vblank(struct exynos_drm_crtc *crtc)
224 struct decon_context *ctx = crtc->ctx;
230 if (!test_and_set_bit(0, &ctx->irq_flags)) {
231 val = readl(ctx->regs + VIDINTCON0);
233 val |= VIDINTCON0_INT_ENABLE;
236 val |= VIDINTCON0_INT_FRAME;
237 val &= ~VIDINTCON0_FRAMESEL0_MASK;
238 val |= VIDINTCON0_FRAMESEL0_VSYNC;
241 writel(val, ctx->regs + VIDINTCON0);
247 static void decon_disable_vblank(struct exynos_drm_crtc *crtc)
249 struct decon_context *ctx = crtc->ctx;
255 if (test_and_clear_bit(0, &ctx->irq_flags)) {
256 val = readl(ctx->regs + VIDINTCON0);
258 val &= ~VIDINTCON0_INT_ENABLE;
260 val &= ~VIDINTCON0_INT_FRAME;
262 writel(val, ctx->regs + VIDINTCON0);
266 static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned int win,
267 struct drm_framebuffer *fb)
272 val = readl(ctx->regs + WINCON(win));
273 val &= ~WINCONx_BPPMODE_MASK;
275 switch (fb->format->format) {
276 case DRM_FORMAT_RGB565:
277 val |= WINCONx_BPPMODE_16BPP_565;
278 val |= WINCONx_BURSTLEN_16WORD;
280 case DRM_FORMAT_XRGB8888:
281 val |= WINCONx_BPPMODE_24BPP_xRGB;
282 val |= WINCONx_BURSTLEN_16WORD;
284 case DRM_FORMAT_XBGR8888:
285 val |= WINCONx_BPPMODE_24BPP_xBGR;
286 val |= WINCONx_BURSTLEN_16WORD;
288 case DRM_FORMAT_RGBX8888:
289 val |= WINCONx_BPPMODE_24BPP_RGBx;
290 val |= WINCONx_BURSTLEN_16WORD;
292 case DRM_FORMAT_BGRX8888:
293 val |= WINCONx_BPPMODE_24BPP_BGRx;
294 val |= WINCONx_BURSTLEN_16WORD;
296 case DRM_FORMAT_ARGB8888:
297 val |= WINCONx_BPPMODE_32BPP_ARGB | WINCONx_BLD_PIX |
299 val |= WINCONx_BURSTLEN_16WORD;
301 case DRM_FORMAT_ABGR8888:
302 val |= WINCONx_BPPMODE_32BPP_ABGR | WINCONx_BLD_PIX |
304 val |= WINCONx_BURSTLEN_16WORD;
306 case DRM_FORMAT_RGBA8888:
307 val |= WINCONx_BPPMODE_32BPP_RGBA | WINCONx_BLD_PIX |
309 val |= WINCONx_BURSTLEN_16WORD;
311 case DRM_FORMAT_BGRA8888:
312 val |= WINCONx_BPPMODE_32BPP_BGRA | WINCONx_BLD_PIX |
314 val |= WINCONx_BURSTLEN_16WORD;
317 DRM_DEBUG_KMS("invalid pixel size so using unpacked 24bpp.\n");
319 val |= WINCONx_BPPMODE_24BPP_xRGB;
320 val |= WINCONx_BURSTLEN_16WORD;
324 DRM_DEBUG_KMS("bpp = %d\n", fb->format->cpp[0] * 8);
327 * In case of exynos, setting dma-burst to 16Word causes permanent
328 * tearing for very small buffers, e.g. cursor buffer. Burst Mode
329 * switching which is based on plane size is not recommended as
330 * plane size varies a lot towards the end of the screen and rapid
331 * movement causes unstable DMA which results into iommu crash/tear.
334 padding = (fb->pitches[0] / fb->format->cpp[0]) - fb->width;
335 if (fb->width + padding < MIN_FB_WIDTH_FOR_16WORD_BURST) {
336 val &= ~WINCONx_BURSTLEN_MASK;
337 val |= WINCONx_BURSTLEN_8WORD;
340 writel(val, ctx->regs + WINCON(win));
343 static void decon_win_set_colkey(struct decon_context *ctx, unsigned int win)
345 unsigned int keycon0 = 0, keycon1 = 0;
347 keycon0 = ~(WxKEYCON0_KEYBL_EN | WxKEYCON0_KEYEN_F |
348 WxKEYCON0_DIRCON) | WxKEYCON0_COMPKEY(0);
350 keycon1 = WxKEYCON1_COLVAL(0xffffffff);
352 writel(keycon0, ctx->regs + WKEYCON0_BASE(win));
353 writel(keycon1, ctx->regs + WKEYCON1_BASE(win));
357 * shadow_protect_win() - disable updating values from shadow registers at vsync
359 * @win: window to protect registers for
360 * @protect: 1 to protect (disable updates)
362 static void decon_shadow_protect_win(struct decon_context *ctx,
363 unsigned int win, bool protect)
367 bits = SHADOWCON_WINx_PROTECT(win);
369 val = readl(ctx->regs + SHADOWCON);
374 writel(val, ctx->regs + SHADOWCON);
377 static void decon_atomic_begin(struct exynos_drm_crtc *crtc)
379 struct decon_context *ctx = crtc->ctx;
385 for (i = 0; i < WINDOWS_NR; i++)
386 decon_shadow_protect_win(ctx, i, true);
389 static void decon_update_plane(struct exynos_drm_crtc *crtc,
390 struct exynos_drm_plane *plane)
392 struct exynos_drm_plane_state *state =
393 to_exynos_plane_state(plane->base.state);
394 struct decon_context *ctx = crtc->ctx;
395 struct drm_framebuffer *fb = state->base.fb;
397 unsigned long val, alpha;
400 unsigned int win = plane->index;
401 unsigned int bpp = fb->format->cpp[0];
402 unsigned int pitch = fb->pitches[0];
408 * SHADOWCON/PRTCON register is used for enabling timing.
410 * for example, once only width value of a register is set,
411 * if the dma is started then decon hardware could malfunction so
412 * with protect window setting, the register fields with prefix '_F'
413 * wouldn't be updated at vsync also but updated once unprotect window
417 /* buffer start address */
418 val = (unsigned long)exynos_drm_fb_dma_addr(fb, 0);
419 writel(val, ctx->regs + VIDW_BUF_START(win));
421 padding = (pitch / bpp) - fb->width;
424 writel(fb->width + padding, ctx->regs + VIDW_WHOLE_X(win));
425 writel(fb->height, ctx->regs + VIDW_WHOLE_Y(win));
427 /* offset from the start of the buffer to read */
428 writel(state->src.x, ctx->regs + VIDW_OFFSET_X(win));
429 writel(state->src.y, ctx->regs + VIDW_OFFSET_Y(win));
431 DRM_DEBUG_KMS("start addr = 0x%lx\n",
433 DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n",
434 state->crtc.w, state->crtc.h);
436 val = VIDOSDxA_TOPLEFT_X(state->crtc.x) |
437 VIDOSDxA_TOPLEFT_Y(state->crtc.y);
438 writel(val, ctx->regs + VIDOSD_A(win));
440 last_x = state->crtc.x + state->crtc.w;
443 last_y = state->crtc.y + state->crtc.h;
447 val = VIDOSDxB_BOTRIGHT_X(last_x) | VIDOSDxB_BOTRIGHT_Y(last_y);
449 writel(val, ctx->regs + VIDOSD_B(win));
451 DRM_DEBUG_KMS("osd pos: tx = %d, ty = %d, bx = %d, by = %d\n",
452 state->crtc.x, state->crtc.y, last_x, last_y);
455 alpha = VIDOSDxC_ALPHA0_R_F(0x0) |
456 VIDOSDxC_ALPHA0_G_F(0x0) |
457 VIDOSDxC_ALPHA0_B_F(0x0);
459 writel(alpha, ctx->regs + VIDOSD_C(win));
461 alpha = VIDOSDxD_ALPHA1_R_F(0xff) |
462 VIDOSDxD_ALPHA1_G_F(0xff) |
463 VIDOSDxD_ALPHA1_B_F(0xff);
465 writel(alpha, ctx->regs + VIDOSD_D(win));
467 decon_win_set_pixfmt(ctx, win, fb);
469 /* hardware window 0 doesn't support color key. */
471 decon_win_set_colkey(ctx, win);
474 val = readl(ctx->regs + WINCON(win));
475 val |= WINCONx_TRIPLE_BUF_MODE;
476 val |= WINCONx_ENWIN;
477 writel(val, ctx->regs + WINCON(win));
479 /* Enable DMA channel and unprotect windows */
480 decon_shadow_protect_win(ctx, win, false);
482 val = readl(ctx->regs + DECON_UPDATE);
483 val |= DECON_UPDATE_STANDALONE_F;
484 writel(val, ctx->regs + DECON_UPDATE);
487 static void decon_disable_plane(struct exynos_drm_crtc *crtc,
488 struct exynos_drm_plane *plane)
490 struct decon_context *ctx = crtc->ctx;
491 unsigned int win = plane->index;
497 /* protect windows */
498 decon_shadow_protect_win(ctx, win, true);
501 val = readl(ctx->regs + WINCON(win));
502 val &= ~WINCONx_ENWIN;
503 writel(val, ctx->regs + WINCON(win));
505 val = readl(ctx->regs + DECON_UPDATE);
506 val |= DECON_UPDATE_STANDALONE_F;
507 writel(val, ctx->regs + DECON_UPDATE);
510 static void decon_atomic_flush(struct exynos_drm_crtc *crtc)
512 struct decon_context *ctx = crtc->ctx;
518 for (i = 0; i < WINDOWS_NR; i++)
519 decon_shadow_protect_win(ctx, i, false);
520 exynos_crtc_handle_event(crtc);
523 static void decon_init(struct decon_context *ctx)
527 writel(VIDCON0_SWRESET, ctx->regs + VIDCON0);
529 val = VIDOUTCON0_DISP_IF_0_ON;
531 val |= VIDOUTCON0_RGBIF;
532 writel(val, ctx->regs + VIDOUTCON0);
534 writel(VCLKCON0_CLKVALUP | VCLKCON0_VCLKFREE, ctx->regs + VCLKCON0);
537 writel(VIDCON1_VCLK_HOLD, ctx->regs + VIDCON1(0));
540 static void decon_enable(struct exynos_drm_crtc *crtc)
542 struct decon_context *ctx = crtc->ctx;
547 pm_runtime_get_sync(ctx->dev);
551 /* if vblank was enabled status, enable it again. */
552 if (test_and_clear_bit(0, &ctx->irq_flags))
553 decon_enable_vblank(ctx->crtc);
555 decon_commit(ctx->crtc);
557 ctx->suspended = false;
560 static void decon_disable(struct exynos_drm_crtc *crtc)
562 struct decon_context *ctx = crtc->ctx;
569 * We need to make sure that all windows are disabled before we
570 * suspend that connector. Otherwise we might try to scan from
571 * a destroyed buffer later.
573 for (i = 0; i < WINDOWS_NR; i++)
574 decon_disable_plane(crtc, &ctx->planes[i]);
576 pm_runtime_put_sync(ctx->dev);
578 ctx->suspended = true;
581 static const struct exynos_drm_crtc_ops decon_crtc_ops = {
582 .enable = decon_enable,
583 .disable = decon_disable,
584 .enable_vblank = decon_enable_vblank,
585 .disable_vblank = decon_disable_vblank,
586 .atomic_begin = decon_atomic_begin,
587 .update_plane = decon_update_plane,
588 .disable_plane = decon_disable_plane,
589 .atomic_flush = decon_atomic_flush,
593 static irqreturn_t decon_irq_handler(int irq, void *dev_id)
595 struct decon_context *ctx = (struct decon_context *)dev_id;
598 val = readl(ctx->regs + VIDINTCON1);
600 clear_bit = ctx->i80_if ? VIDINTCON1_INT_I80 : VIDINTCON1_INT_FRAME;
602 writel(clear_bit, ctx->regs + VIDINTCON1);
604 /* check the crtc is detached already from encoder */
609 drm_crtc_handle_vblank(&ctx->crtc->base);
611 /* set wait vsync event to zero and wake up queue. */
612 if (atomic_read(&ctx->wait_vsync_event)) {
613 atomic_set(&ctx->wait_vsync_event, 0);
614 wake_up(&ctx->wait_vsync_queue);
621 static int decon_bind(struct device *dev, struct device *master, void *data)
623 struct decon_context *ctx = dev_get_drvdata(dev);
624 struct drm_device *drm_dev = data;
625 struct exynos_drm_plane *exynos_plane;
629 ret = decon_ctx_initialize(ctx, drm_dev);
631 DRM_ERROR("decon_ctx_initialize failed.\n");
635 for (i = 0; i < WINDOWS_NR; i++) {
636 ctx->configs[i].pixel_formats = decon_formats;
637 ctx->configs[i].num_pixel_formats = ARRAY_SIZE(decon_formats);
638 ctx->configs[i].zpos = i;
639 ctx->configs[i].type = decon_win_types[i];
641 ret = exynos_plane_init(drm_dev, &ctx->planes[i], i,
647 exynos_plane = &ctx->planes[DEFAULT_WIN];
648 ctx->crtc = exynos_drm_crtc_create(drm_dev, &exynos_plane->base,
649 EXYNOS_DISPLAY_TYPE_LCD, &decon_crtc_ops, ctx);
650 if (IS_ERR(ctx->crtc)) {
651 decon_ctx_remove(ctx);
652 return PTR_ERR(ctx->crtc);
656 exynos_dpi_bind(drm_dev, ctx->encoder);
662 static void decon_unbind(struct device *dev, struct device *master,
665 struct decon_context *ctx = dev_get_drvdata(dev);
667 decon_disable(ctx->crtc);
670 exynos_dpi_remove(ctx->encoder);
672 decon_ctx_remove(ctx);
675 static const struct component_ops decon_component_ops = {
677 .unbind = decon_unbind,
680 static int decon_probe(struct platform_device *pdev)
682 struct device *dev = &pdev->dev;
683 struct decon_context *ctx;
684 struct device_node *i80_if_timings;
685 struct resource *res;
691 ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
696 ctx->suspended = true;
698 i80_if_timings = of_get_child_by_name(dev->of_node, "i80-if-timings");
701 of_node_put(i80_if_timings);
703 ctx->regs = of_iomap(dev->of_node, 0);
707 ctx->pclk = devm_clk_get(dev, "pclk_decon0");
708 if (IS_ERR(ctx->pclk)) {
709 dev_err(dev, "failed to get bus clock pclk\n");
710 ret = PTR_ERR(ctx->pclk);
714 ctx->aclk = devm_clk_get(dev, "aclk_decon0");
715 if (IS_ERR(ctx->aclk)) {
716 dev_err(dev, "failed to get bus clock aclk\n");
717 ret = PTR_ERR(ctx->aclk);
721 ctx->eclk = devm_clk_get(dev, "decon0_eclk");
722 if (IS_ERR(ctx->eclk)) {
723 dev_err(dev, "failed to get eclock\n");
724 ret = PTR_ERR(ctx->eclk);
728 ctx->vclk = devm_clk_get(dev, "decon0_vclk");
729 if (IS_ERR(ctx->vclk)) {
730 dev_err(dev, "failed to get vclock\n");
731 ret = PTR_ERR(ctx->vclk);
735 res = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
736 ctx->i80_if ? "lcd_sys" : "vsync");
738 dev_err(dev, "irq request failed.\n");
743 ret = devm_request_irq(dev, res->start, decon_irq_handler,
744 0, "drm_decon", ctx);
746 dev_err(dev, "irq request failed.\n");
750 init_waitqueue_head(&ctx->wait_vsync_queue);
751 atomic_set(&ctx->wait_vsync_event, 0);
753 platform_set_drvdata(pdev, ctx);
755 ctx->encoder = exynos_dpi_probe(dev);
756 if (IS_ERR(ctx->encoder)) {
757 ret = PTR_ERR(ctx->encoder);
761 pm_runtime_enable(dev);
763 ret = component_add(dev, &decon_component_ops);
765 goto err_disable_pm_runtime;
769 err_disable_pm_runtime:
770 pm_runtime_disable(dev);
778 static int decon_remove(struct platform_device *pdev)
780 struct decon_context *ctx = dev_get_drvdata(&pdev->dev);
782 pm_runtime_disable(&pdev->dev);
786 component_del(&pdev->dev, &decon_component_ops);
792 static int exynos7_decon_suspend(struct device *dev)
794 struct decon_context *ctx = dev_get_drvdata(dev);
796 clk_disable_unprepare(ctx->vclk);
797 clk_disable_unprepare(ctx->eclk);
798 clk_disable_unprepare(ctx->aclk);
799 clk_disable_unprepare(ctx->pclk);
804 static int exynos7_decon_resume(struct device *dev)
806 struct decon_context *ctx = dev_get_drvdata(dev);
809 ret = clk_prepare_enable(ctx->pclk);
811 DRM_ERROR("Failed to prepare_enable the pclk [%d]\n", ret);
815 ret = clk_prepare_enable(ctx->aclk);
817 DRM_ERROR("Failed to prepare_enable the aclk [%d]\n", ret);
821 ret = clk_prepare_enable(ctx->eclk);
823 DRM_ERROR("Failed to prepare_enable the eclk [%d]\n", ret);
827 ret = clk_prepare_enable(ctx->vclk);
829 DRM_ERROR("Failed to prepare_enable the vclk [%d]\n", ret);
837 static const struct dev_pm_ops exynos7_decon_pm_ops = {
838 SET_RUNTIME_PM_OPS(exynos7_decon_suspend, exynos7_decon_resume,
842 struct platform_driver decon_driver = {
843 .probe = decon_probe,
844 .remove = decon_remove,
846 .name = "exynos-decon",
847 .pm = &exynos7_decon_pm_ops,
848 .of_match_table = decon_driver_dt_match,