s3/client: Restore '-E' handling

Sometimes we really do need to redirect output to stderr
e.g. when using the tar command to output the archive to stdout
we don't want debug or cmdline status messages straying into stdout.

was removed with commit: e4474ac0a540c56548b4d15e38f2e234455e19b6

remove known fail for the test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15075
Signed-off-by: Noel Power <noel.power@suse.com>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Tue May 24 10:29:27 UTC 2022 on sn-devel-184

diff --git a/selftest/knownfail.d/smbclient-smb3 b/selftest/knownfail.d/smbclient-smb3
index 4d884db50252a10dd37ee4dc4f3c6f3f5894694b..119e93e479af8078a4639b19b84ac86fc47efc6b 100644 (file)
--- a/selftest/knownfail.d/smbclient-smb3
+++ b/selftest/knownfail.d/smbclient-smb3
@@ -1,5 +1,4 @@
 ^samba3.blackbox.smbclient_s3.SMB3.*.creating.a.bad.symlink.and.deleting.it
-^samba3.blackbox.smbclient_s3.*.smbclient output goes to stderr when -E is passed
 ^samba3.blackbox.acl_xattr.SMB3.nt_affects_posix
 ^samba3.blackbox.acl_xattr.SMB3.nt_affects_chown
 ^samba3.blackbox.acl_xattr.SMB3.nt_affects_chgrp

diff --git a/source3/client/client.c b/source3/client/client.c
index 15e32d379f047f957a5890f804703357b1e009da..9f9954b7e96b2037cc9d10698a8a362f5704aad4 100644 (file)
--- a/source3/client/client.c
+++ b/source3/client/client.c
@@ -6552,6 +6552,11 @@ int main(int argc,char *argv[])
                                print_sockaddr(dest_ss_str, sizeof(dest_ss_str), &dest_ss);
                        }
                        break;
+               case 'E':
+                       setup_logging("smbclient", DEBUG_STDERR );
+                       display_set_stderr();
+                       break;
+
                case 'L':
                        query_host = talloc_strdup(frame, poptGetOptArg(pc));
                        if (!query_host) {