obnox/wireshark/wip.git
17 years agothat didn't help. try skipping the exntest to see if it's just that one.
richardv [Sat, 7 Apr 2007 04:35:39 +0000 (04:35 +0000)]
that didn't help. try skipping the exntest to see if it's just that one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21350 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomake the unit tests spam their output, in an attempt yo understand wtf the matter...
richardv [Sat, 7 Apr 2007 02:18:57 +0000 (02:18 +0000)]
make the unit tests spam their output, in an attempt yo understand wtf the matter with the buildbot is

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21349 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd a registration symbol cache to make-dissector-reg.py. When you
gerald [Fri, 6 Apr 2007 16:15:36 +0000 (16:15 +0000)]
Add a registration symbol cache to make-dissector-reg.py.  When you
update a dissector and recompile, make-dissector-reg.py can now pull
its list of registration routines from a cache instead of having to
scan through every dissector.  The time to create register.c has gone
from 20 to 30 seconds down to 2 on my desktop machine.

The cache file is a Python pickle data stream.  It should be portable
across architectures, so we may be able to add it to the distribution
at some point.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21348 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove build detritus
grahamb [Fri, 6 Apr 2007 15:51:36 +0000 (15:51 +0000)]
Remove build detritus

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21347 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoexport some desegmentation functions from TCP dissector to reuse them in SSL/TLS...
kukosa [Fri, 6 Apr 2007 07:01:01 +0000 (07:01 +0000)]
export some desegmentation functions from TCP dissector to reuse them in SSL/TLS desegmentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21346 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate of dissector to reflect wire format changes
sahlberg [Fri, 6 Apr 2007 05:02:41 +0000 (05:02 +0000)]
update of dissector to reflect wire format changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21345 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoinitial CTDB dissector
sahlberg [Fri, 6 Apr 2007 04:27:59 +0000 (04:27 +0000)]
initial CTDB dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21344 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for bug 1523. Offset handling was off in DialedNumberMessage presentation.
jake [Thu, 5 Apr 2007 23:42:44 +0000 (23:42 +0000)]
Fix for bug 1523. Offset handling was off in DialedNumberMessage presentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21343 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd the make-dissector-reg scripts to the dependency list for each copy
gerald [Thu, 5 Apr 2007 23:23:06 +0000 (23:23 +0000)]
Add the make-dissector-reg scripts to the dependency list for each copy
of plugin.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21342 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix a typo.
gerald [Thu, 5 Apr 2007 22:44:18 +0000 (22:44 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21341 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoLoosen up our restrictions so that plugins can compile.
gerald [Thu, 5 Apr 2007 22:42:34 +0000 (22:42 +0000)]
Loosen up our restrictions so that plugins can compile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21340 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoImplement proposed fix for Bug 1125
lego [Thu, 5 Apr 2007 22:16:12 +0000 (22:16 +0000)]
Implement proposed fix for Bug 1125

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21339 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoIn epan/dissectors/Makefile.nmake, fix a typo.
gerald [Thu, 5 Apr 2007 21:38:39 +0000 (21:38 +0000)]
In epan/dissectors/Makefile.nmake, fix a typo.

In make-dissector-reg.py, throw an error if we don't have enough files
to process, or if we don't generate enough registrations.  "Enough"
is arbitrarily set to 100.

This should de-purple the buildbot.  (I'm sure there's a "smoke on the
water" joke in there somewhere.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21338 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMegaco improvements:
lego [Wed, 4 Apr 2007 21:23:55 +0000 (21:23 +0000)]
Megaco improvements:
- Verify that we have a ber sequence before handing over to H.248
- Make the dissector more case insensitive (Fixes http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1517)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21337 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix a warning
sfisher [Wed, 4 Apr 2007 19:35:46 +0000 (19:35 +0000)]
Fix a warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21336 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix build failures due to windows.h being included before winsock2.h via other includes
grahamb [Wed, 4 Apr 2007 12:18:10 +0000 (12:18 +0000)]
Fix build failures due to windows.h being included before winsock2.h via other includes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21335 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoPreparations to be able to display dynamic payload type name in the stream analysis.
etxrab [Wed, 4 Apr 2007 06:58:12 +0000 (06:58 +0000)]
Preparations to be able to display dynamic payload type name in the stream analysis.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21334 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd wtap_nstime_to_sec.
etxrab [Wed, 4 Apr 2007 06:56:04 +0000 (06:56 +0000)]
Add wtap_nstime_to_sec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21333 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMake sure that when a windows exception is thrown ENDTRY gets evaluated.
lego [Tue, 3 Apr 2007 22:06:31 +0000 (22:06 +0000)]
Make sure that when a windows exception is thrown ENDTRY gets evaluated.

fix for one of the various issues that cause bug 1334

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21332 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom metatech :
standel [Tue, 3 Apr 2007 21:48:40 +0000 (21:48 +0000)]
From metatech :
  Dissector for the DRDA protocol. This is the protocol used by among
  others the DB2 database.

  modify his entry in AUTHORS

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21331 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix warnings on Linux/gcc 4.1.1
sfisher [Tue, 3 Apr 2007 21:17:13 +0000 (21:17 +0000)]
Fix warnings on Linux/gcc 4.1.1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21330 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove now useless definition of NO_YY_UNPUT
lego [Tue, 3 Apr 2007 21:09:29 +0000 (21:09 +0000)]
remove now useless definition of NO_YY_UNPUT

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21329 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoxFi a Ytpo
lego [Tue, 3 Apr 2007 20:52:37 +0000 (20:52 +0000)]
xFi a Ytpo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21328 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoCreation of ALL_DISSECTORS_SRC including all dissectors sources
standel [Tue, 3 Apr 2007 20:22:32 +0000 (20:22 +0000)]
Creation of ALL_DISSECTORS_SRC including all dissectors sources
 - used in Makefile.nmake instead of DISSECTOR_SRC
 - used for the target register.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21327 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodelete packet-drda.c
standel [Tue, 3 Apr 2007 20:12:05 +0000 (20:12 +0000)]
delete packet-drda.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21326 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix an 'unused parameter' warning
richardv [Tue, 3 Apr 2007 19:53:05 +0000 (19:53 +0000)]
fix an 'unused parameter' warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21325 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoepan/dissectors/Makefile is now building four libraries :
standel [Tue, 3 Apr 2007 19:50:04 +0000 (19:50 +0000)]
epan/dissectors/Makefile is now building four libraries :
  - asn dissectors : libasndissectors.la
  - pidl dissectors : libpidldissectors.la
  - normal dissectors : libdissectors.la *and* libcleandissectors.la. I
  separated it in two libraries temporarily. The source files used to build
  libcleandissectors.la do not generate warning anymore and the -Werror is used
  to compile them. If we patch a dissector and it doesn't generate warning
  anymore, we have to move the filename dissector from DISSECTOR_SRC to
  CLEAN_DISSECTOR_SRC in epan/dissectors/Makefile.common.

If you want to define specific cflags for one library type, let's say pidl, you
may define libpidldissectors_la_CFLAGS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21324 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodisable unput here, too
richardv [Tue, 3 Apr 2007 19:28:59 +0000 (19:28 +0000)]
disable unput here, too

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21323 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agominor changes in constants names
standel [Tue, 3 Apr 2007 19:13:06 +0000 (19:13 +0000)]
minor changes in constants names

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21322 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoImplement a proposal from Elefterios Gabriel for SCCP:
lego [Tue, 3 Apr 2007 19:08:00 +0000 (19:08 +0000)]
Implement a proposal from Elefterios Gabriel for SCCP:
Add a table of DPCs and SSNs that allow to override the protocol that would be choosen
so that the same SSN can use two different protocols in two different DPCs.

I did not believe it someone could have done it, then I saw the captures...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21321 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodisable generation of unput to avoid a compiler warning.
richardv [Tue, 3 Apr 2007 18:41:24 +0000 (18:41 +0000)]
disable generation of unput to avoid a compiler warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21320 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoSet $(LINK). I swear I'll get there in a minute with this.
richardv [Tue, 3 Apr 2007 17:30:02 +0000 (17:30 +0000)]
Set $(LINK). I swear I'll get there in a minute with this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21319 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agohmm, apparently $^ doesn't work for nmake
richardv [Tue, 3 Apr 2007 15:48:59 +0000 (15:48 +0000)]
hmm, apparently $^ doesn't work for nmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21318 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agompa_* stubs to make this link properly
richardv [Tue, 3 Apr 2007 13:56:19 +0000 (13:56 +0000)]
mpa_* stubs to make this link properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21317 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agorules for making the unit tests
richardv [Tue, 3 Apr 2007 13:24:20 +0000 (13:24 +0000)]
rules for making the unit tests

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21316 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoignore exntest
richardv [Tue, 3 Apr 2007 13:20:11 +0000 (13:20 +0000)]
ignore exntest

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21315 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoanother go at fixing the unit tests under windows - give a -f Makefile.nmake arg
richardv [Tue, 3 Apr 2007 13:03:07 +0000 (13:03 +0000)]
another go at fixing the unit tests under windows - give a -f Makefile.nmake arg

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21314 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agohopefully, fix reassemble_test by linking against libgcrypt
richardv [Tue, 3 Apr 2007 11:12:27 +0000 (11:12 +0000)]
hopefully, fix reassemble_test by linking against libgcrypt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21313 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agohopefully fix this for win32 by using nmake
richardv [Tue, 3 Apr 2007 10:53:38 +0000 (10:53 +0000)]
hopefully fix this for win32 by using nmake

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21312 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoPropset suite-unittests.sh and add executable to .sh files
jmayer [Tue, 3 Apr 2007 06:55:25 +0000 (06:55 +0000)]
Propset suite-unittests.sh and add executable to .sh files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21311 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix bug 1508:
morriss [Tue, 3 Apr 2007 06:27:18 +0000 (06:27 +0000)]
Fix bug 1508:

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1508

Dissect ISUP CIC as 14 bits in ANSI (instead of 12 bits like in ITU)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21310 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRun the epan unittests as part of the test suite
richardv [Tue, 3 Apr 2007 01:54:30 +0000 (01:54 +0000)]
Run the epan unittests as part of the test suite

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21309 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom me: make tvbtest return an exitcode appropriate to its success
richardv [Tue, 3 Apr 2007 01:53:52 +0000 (01:53 +0000)]
From me: make tvbtest return an exitcode appropriate to its success

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21308 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom me:
richardv [Tue, 3 Apr 2007 01:49:14 +0000 (01:49 +0000)]
From me:

disable failing composite tvb tests

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21307 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom me:
richardv [Tue, 3 Apr 2007 01:45:59 +0000 (01:45 +0000)]
From me:

fix compiler warnings in tvbtest.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21306 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Mike Duigou:
richardv [Tue, 3 Apr 2007 01:31:22 +0000 (01:31 +0000)]
From Mike Duigou:

The enclosed patch corrects a problem where jxta elements were being added to the protocol tree for segments that did not contain complete jxta frames. This patch ensures that the jxta proto elements are only added those the segments that end a complete, assembled jxta frame.

The patch has been fuzz tested with a broad selection of jxta captures and ran successfully overnight for over 4000 iterations.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21305 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Donald White:
sfisher [Mon, 2 Apr 2007 23:45:38 +0000 (23:45 +0000)]
From Donald White:

A partial RFC 2508 dissector for packet-ppp.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21304 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoThere are odd packet records in k15 generated files where the interface record does...
lego [Mon, 2 Apr 2007 22:17:15 +0000 (22:17 +0000)]
There are odd packet records in k15 generated files where the interface record does not match any given one.

I noticed that these records have the first byte changed so When a lookup fails mask the byte and lookup again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21303 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd decoding of TFO Codec and Codec List
lego [Mon, 2 Apr 2007 21:47:54 +0000 (21:47 +0000)]
Add decoding of TFO Codec and Codec List

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21302 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Use proto_tree_add_item instead of proto_tree_add_(u)int
jmayer [Mon, 2 Apr 2007 16:39:54 +0000 (16:39 +0000)]
- Use proto_tree_add_item instead of proto_tree_add_(u)int
  in many places.
- Seperate decoding of magic and version.
- Explicitely display the padding bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21301 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMake RX a new style dissector: return 0 if there isn't at least 28 bytes of message...
morriss [Mon, 2 Apr 2007 08:25:43 +0000 (08:25 +0000)]
Make RX a new style dissector: return 0 if there isn't at least 28 bytes of message or if it receives an unknown Type.  Add a check of tvb length to README.developer's cut-n-paste dissector code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21300 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd comments
etxrab [Mon, 2 Apr 2007 06:49:28 +0000 (06:49 +0000)]
Add comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21299 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd PN-IO FSHelloBlock and PN-DCP Device/AliasName
ulfl [Mon, 2 Apr 2007 05:18:31 +0000 (05:18 +0000)]
Add PN-IO FSHelloBlock and PN-DCP Device/AliasName

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21298 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFirst step of TCP dissector refactoring.
standel [Sun, 1 Apr 2007 16:04:04 +0000 (16:04 +0000)]
First step of TCP dissector refactoring.

I have a dream today.
I have a dream that one day the TCP dissector shall become human-readable. :)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21297 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoHave the prototypes of uat_esc and uat_unesc available to packet-snmp.c
lego [Sun, 1 Apr 2007 16:02:41 +0000 (16:02 +0000)]
Have the prototypes of uat_esc and uat_unesc available to packet-snmp.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21296 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Sake Blok :
standel [Sun, 1 Apr 2007 15:42:08 +0000 (15:42 +0000)]
From Sake Blok :
Fix for Bug 1136 (TCP Checksum Validation)

TCP cksum 0xffff should not appear in TCP headers. RFC 1624 explains that it
can be generated by a (not-so-good) algorithm for incremental updates to the
tcp-checksum.
New behavior of wireshark when having cksum == 0xffff :
  - use "Checksum: 0xffff [should be 0x0000 (See RFC 1624)]" in the
    packet-detail pane
  - set tcp.checksum_good to FALSE (just like checksum-offload packets)
  - set tcp.checksum_bad to FALSE (just like checksum-offload packets)
  - Generate an expert warning: "TCP Checksum 0xffff instead of 0x0000 (See RFC 1624)"
  - add "[TCP CHECKSUM 0xFFFF]" instead of "[TCP CHECKSUM BAD]" to COL_INFO

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21295 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix management of lstrings in uat code so that arbitrary chars (even '\0's) can be...
lego [Sun, 1 Apr 2007 14:55:25 +0000 (14:55 +0000)]
Fix management of lstrings in uat code so that arbitrary chars (even '\0's) can be used inside.
Fixes bug 1502

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21294 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom James Menzies:
sfisher [Sat, 31 Mar 2007 22:38:10 +0000 (22:38 +0000)]
From James Menzies:

This corrects two long standing issues with the Visual
Networks file type in PPP and ML-PPP environments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21293 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoCommon dissection of GOB.
etxrab [Sat, 31 Mar 2007 21:50:03 +0000 (21:50 +0000)]
Common dissection of GOB.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21292 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd a small section, that code should be warning free
ulfl [Sat, 31 Mar 2007 15:32:06 +0000 (15:32 +0000)]
add a small section, that code should be warning free

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21291 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd an explanation on SNMP hex passwords.
lego [Sat, 31 Mar 2007 12:30:18 +0000 (12:30 +0000)]
Add an explanation on SNMP hex passwords.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21290 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd Licence and TO DO list
lego [Sat, 31 Mar 2007 12:25:37 +0000 (12:25 +0000)]
Add Licence and TO DO list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21289 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoProperly NULL terminate string (str[0]='\0';)
etxrab [Sat, 31 Mar 2007 11:47:14 +0000 (11:47 +0000)]
Properly NULL terminate string (str[0]='\0';)
Let h263_proto_tree_add_bits return the value
Find more starcodes
Add picture type to Info col(P/I)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21288 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix "Gtk-CRITICAL **: gtk_tree_selection_get_selected: assertion
sfisher [Fri, 30 Mar 2007 22:14:33 +0000 (22:14 +0000)]
Fix "Gtk-CRITICAL **: gtk_tree_selection_get_selected: assertion
`selection->type != GTK_SELECTION_MULTIPLE' failed" error when
opening the User Specified Decodes with multiple decodes setup.
The problem is caused by the selection mode for the list being
set to multiple.  I changed it to none so that the user doesn't
get the false impression that you can select only certain items
and clear them (the clear button clears them all).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21287 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix more warnings
sfisher [Fri, 30 Mar 2007 21:20:57 +0000 (21:20 +0000)]
Fix more warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21286 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoChange GTK_MAJOR_VERSION >= 2 to GTK_CHECK_VERSION(2,4,0) for Follow
sfisher [Fri, 30 Mar 2007 20:50:08 +0000 (20:50 +0000)]
Change GTK_MAJOR_VERSION >= 2 to GTK_CHECK_VERSION(2,4,0) for Follow
TCP/SSL Stream dialog find buttons because one of the functions used
only works with GTK 2.4+.  Reported by Chris Maynard on -dev list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21285 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agouse setup target output of MSVC2005EE and not the older MSVC6, mention that the exact...
ulfl [Fri, 30 Mar 2007 17:57:04 +0000 (17:57 +0000)]
use setup target output of MSVC2005EE and not the older MSVC6, mention that the exact string may vary on the MSVC version

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21284 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- use of proto_tree_add_item whenever possible
standel [Fri, 30 Mar 2007 14:43:55 +0000 (14:43 +0000)]
- use of proto_tree_add_item whenever possible
- follows the same rules as the one in ipv4 dissector for
ipv6_[src|dst|addr][_host] items.
- use proto_tree_add_item for displaying the name of the parsed options.
- added header type value_string
- add an expert info for invalid jumbo value and invalid router alert
length.
- correction of invalid jumbo payload length
- get rid of variable declaration after statement

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21283 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agorevert back (void*) -> (void**) which will stop free-warning compilation with
standel [Fri, 30 Mar 2007 12:04:40 +0000 (12:04 +0000)]
revert back (void*) -> (void**) which will stop free-warning compilation with
gcc-4.1.2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21282 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoep_malloc -> ep_alloc !!
standel [Fri, 30 Mar 2007 08:27:20 +0000 (08:27 +0000)]
ep_malloc -> ep_alloc !!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21281 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove some g_malloc/g_free
standel [Fri, 30 Mar 2007 08:22:08 +0000 (08:22 +0000)]
remove some g_malloc/g_free

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21280 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove svn:executable
standel [Fri, 30 Mar 2007 00:54:39 +0000 (00:54 +0000)]
remove svn:executable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21279 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate of homeplug dissector with the use of ptvcursor subtree management
standel [Fri, 30 Mar 2007 00:38:58 +0000 (00:38 +0000)]
update of homeplug dissector with the use of ptvcursor subtree management
functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21278 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Sake Blok: fix bug 598 (http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=598)
wmeier [Fri, 30 Mar 2007 00:23:19 +0000 (00:23 +0000)]
From Sake Blok: fix bug 598 (bugs.wireshark.org/bugzilla/show_bug.cgi?id=598)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21277 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- new ptvcursor subtrees management functions :
standel [Fri, 30 Mar 2007 00:21:39 +0000 (00:21 +0000)]
- new ptvcursor subtrees management functions :
  * ptvcursor_push_subtree(), ptvcursor_pop_subtree() for pushing/popping
    subtrees. Multiple levels of subtrees (256 max.), allocation per 8 levels.
  * Two new functions creating an item in the tree and pushing a subtree at the
    same time. These two functions accept an undefined length
    (SUBTREE_UNDEFINED_LENGTH). The length of the item is set at the next pop.
        1) ptvcursor_add_with_subtree
2) ptvcursor_add_text_with_subtree
- get rid of potential memory leaks with g_new in ptvcursor_new().

- Documentation of the new ptvcursor functions in README.developer

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21276 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodelete megaco plugin trace
standel [Thu, 29 Mar 2007 23:36:11 +0000 (23:36 +0000)]
delete megaco plugin trace

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21275 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agostrict aliasing warnings fix : replace (void**) by (void*)
standel [Thu, 29 Mar 2007 22:58:02 +0000 (22:58 +0000)]
strict aliasing warnings fix : replace (void**) by (void*)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21274 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix some more warnings
sfisher [Thu, 29 Mar 2007 18:09:13 +0000 (18:09 +0000)]
Fix some more warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21273 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoChange mnemonic on Save All button from A to L to avoid overlapping
sfisher [Thu, 29 Mar 2007 18:07:36 +0000 (18:07 +0000)]
Change mnemonic on Save All button from A to L to avoid overlapping
with the mnemonic for the Save As (A) button in the Export Object
dialog.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21272 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoWhen there are multiple mtp3 packets on a single sctp packet (m2ua) have each one...
lego [Thu, 29 Mar 2007 12:25:50 +0000 (12:25 +0000)]
When there are multiple mtp3 packets on a single sctp packet (m2ua)  have each one has its own pcs and tap structure

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21271 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove debugging printf() calls left in the code.
lego [Thu, 29 Mar 2007 12:24:04 +0000 (12:24 +0000)]
remove debugging printf() calls left in the code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21270 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoManually add the patch mentioned in
jmayer [Thu, 29 Mar 2007 08:10:29 +0000 (08:10 +0000)]
Manually add the patch mentioned in
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21262

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21269 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUpdate from samba tree revision 21970 to 22006
jmayer [Thu, 29 Mar 2007 07:49:48 +0000 (07:49 +0000)]
Update from samba tree revision 21970 to 22006
============================ Samba log start ============
------------------------------------------------------------------------
r21995 | jelmer | 2007-03-28 01:04:08 +0200 (Wed, 28 Mar 2007) | 5 lines
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Patch from Ronnie Sahlberg.

Change the signatures for all functions it generates to specify
_U_ so that GCC "parameter not used" warnings are suppressed.

------------------------------------------------------------------------
r21996 | jelmer | 2007-03-28 01:22:41 +0200 (Wed, 28 Mar 2007) | 4 lines
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Fix a bug for invalid casts of pointers.

Patch by Ronnie Sahlberg.

------------------------------------------------------------------------
r22004 | jelmer | 2007-03-29 00:52:37 +0200 (Thu, 29 Mar 2007) | 4 lines
Changed paths:
   M /branches/SAMBA_4_0
   M /branches/SAMBA_4_0/source/pidl/lib/Parse/Pidl/Wireshark/NDR.pm

Check for dereferencing null pointers.

Patch by Ronnie Sahlberg.

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21268 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Add Makefile.common to EXTRA_DIST (spotted by Christopher Maynard)
jmayer [Thu, 29 Mar 2007 07:41:54 +0000 (07:41 +0000)]
- Add Makefile.common to EXTRA_DIST (spotted by Christopher Maynard)
- Replaced spaces at beginning of line by tab

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21267 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate WZCSVC idl and regenerate the dissector
sahlberg [Thu, 29 Mar 2007 04:24:17 +0000 (04:24 +0000)]
update WZCSVC idl and regenerate the dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21266 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate INITSHUTDOWN and SRVSVC and regenerate with patched PIDL
sahlberg [Thu, 29 Mar 2007 04:12:16 +0000 (04:12 +0000)]
update INITSHUTDOWN and SRVSVC and regenerate with patched PIDL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21265 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoregenerate the dissectors with an even newer patched version of pidl to add two more...
sahlberg [Thu, 29 Mar 2007 02:22:23 +0000 (02:22 +0000)]
regenerate the dissectors with an even newer patched version of pidl to add two more pragmas

you need this patch ontop of svn pidl to regenerate the files :

Index: lib/Parse/Pidl/Wireshark/NDR.pm
===================================================================
--- lib/Parse/Pidl/Wireshark/NDR.pm     (revision 22005)
+++ lib/Parse/Pidl/Wireshark/NDR.pm     (working copy)
@@ -916,6 +916,14 @@
        $res{headers} .= "#ifdef HAVE_CONFIG_H\n";
        $res{headers} .= "#include \"config.h\"\n";
        $res{headers} .= "#endif\n\n";
+
+       $res{headers} .= "#ifdef _MSC_VER\n";
+       $res{headers} .= "#pragma warning(disable:4005)\n";
+       $res{headers} .= "#pragma warning(disable:4013)\n";
+       $res{headers} .= "#pragma warning(disable:4018)\n";
+       $res{headers} .= "#pragma warning(disable:4101)\n";
+       $res{headers} .= "#endif\n\n";
+
        $res{headers} .= "#include <glib.h>\n";
        $res{headers} .= "#include <string.h>\n";
        $res{headers} .= "#include <epan/packet.h>\n\n";

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21262 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofixup the idl to always use pointer for out parameters
sahlberg [Thu, 29 Mar 2007 02:09:48 +0000 (02:09 +0000)]
fixup the idl to always use pointer for out parameters

regenerate with patched pidl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21261 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoregenerate these dissectors using a patched pidl to add some extra pragmas to keep...
sahlberg [Thu, 29 Mar 2007 01:38:59 +0000 (01:38 +0000)]
regenerate these dissectors using a patched pidl to add some extra pragmas to keep ms compilers happy

the pidl patch required :
Index: lib/Parse/Pidl/Wireshark/NDR.pm
===================================================================
--- lib/Parse/Pidl/Wireshark/NDR.pm     (revision 22005)
+++ lib/Parse/Pidl/Wireshark/NDR.pm     (working copy)
@@ -916,6 +916,14 @@
        $res{headers} .= "#ifdef HAVE_CONFIG_H\n";
        $res{headers} .= "#include \"config.h\"\n";
        $res{headers} .= "#endif\n\n";
+
+       $res{headers} .= "#ifdef _MSC_VER\n";
+       $res{headers} .= "#pragma warning(disable:4005)\n";
+       $res{headers} .= "#pragma warning(disable:4013)\n";
+       $res{headers} .= "#endif\n\n";
+
+
+
        $res{headers} .= "#include <glib.h>\n";
        $res{headers} .= "#include <string.h>\n";
        $res{headers} .= "#include <epan/packet.h>\n\n";

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21260 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate efs and fix conformance file to eliminate some warnings
sahlberg [Thu, 29 Mar 2007 01:06:51 +0000 (01:06 +0000)]
update efs  and fix conformance file to eliminate some warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21259 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate dfs and regenerate
sahlberg [Thu, 29 Mar 2007 00:58:35 +0000 (00:58 +0000)]
update dfs and regenerate

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21258 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate atsvc to latest idl
sahlberg [Thu, 29 Mar 2007 00:47:41 +0000 (00:47 +0000)]
update atsvc to latest idl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21257 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoupdate winreg to the latest idl
sahlberg [Thu, 29 Mar 2007 00:26:35 +0000 (00:26 +0000)]
update winreg to the latest idl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21256 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoregenerate winreg using the latest pidl. almost all warnings are now gone
sahlberg [Thu, 29 Mar 2007 00:15:41 +0000 (00:15 +0000)]
regenerate winreg using the latest pidl.    almost all warnings are now gone

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21255 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom
sahlberg [Wed, 28 Mar 2007 22:16:43 +0000 (22:16 +0000)]
From

Martin Sustrik

here's a patch to AMQP dissector. The only change is that when there are
seceral AMQP frames in single TCP packet, all of them are referred in
the info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21254 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove almost all of the casts I committed recently and in place of
sfisher [Wed, 28 Mar 2007 21:55:11 +0000 (21:55 +0000)]
Remove almost all of the casts I committed recently and in place of
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21253 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodo not pass a null string to proto_item_append_text()
lego [Wed, 28 Mar 2007 19:34:35 +0000 (19:34 +0000)]
do not pass a null string to proto_item_append_text()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21252 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodo not avoid redrawing the tap
lego [Wed, 28 Mar 2007 19:31:54 +0000 (19:31 +0000)]
do not avoid redrawing the tap
make sure we do not pass a null pointer to add_to_graph()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21251 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUSM can be any length not just 3
lego [Wed, 28 Mar 2007 19:30:24 +0000 (19:30 +0000)]
USM can be any length not just 3

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21250 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoImproved cleanup of build artifacts
grahamb [Wed, 28 Mar 2007 16:32:47 +0000 (16:32 +0000)]
Improved cleanup of build artifacts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21249 f5534014-38df-0310-8fa8-9805f1628bb7