obnox/wireshark/wip.git
15 years ago- Reintroduce heuristic dissector
etxrab [Tue, 21 Apr 2009 16:58:13 +0000 (16:58 +0000)]
- Reintroduce heuristic dissector
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3426
- Dissect TransportLayerAddress as IPv4 or IPv6 address
  https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3427
- Use call dissector_try_port_new()
- Update ASN1 descriptions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28109 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTurn on -Wshorten-64-to-32 by default, and fix some issues that turned
guy [Tue, 21 Apr 2009 16:57:52 +0000 (16:57 +0000)]
Turn on -Wshorten-64-to-32 by default, and fix some issues that turned
up (99 44/100% of which were assignments of double-precision
floating-point constants to floats).  Hopefully this will catch at least
some P64 issues on UN*X.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28108 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a typo.
etxrab [Tue, 21 Apr 2009 16:53:34 +0000 (16:53 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28107 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIntroduce call dissector_try_port_new() to be used when no protocol entry is to be...
etxrab [Tue, 21 Apr 2009 16:53:00 +0000 (16:53 +0000)]
Introduce call dissector_try_port_new() to be used when no protocol entry is to be made in the protocols list. Used by asn2wrs dissectors to avoid multiple entrys as calls are made
multiple times for the same PDU.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28106 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoinfiniband: Fix various issues mostly relating to protocol field display:
wmeier [Tue, 21 Apr 2009 13:52:00 +0000 (13:52 +0000)]
infiniband: Fix various issues mostly relating to protocol field display:
- Conform display of fields to Infiniband spec (1.2.1): E.G.: use correct bitmasks in hf[];
  (The verification/correction process is not complete: see packet-inifiniband.h);
- Comment out unused hf[] & related elements;
- hf[]: FT_BOOLEAN entries with bitmask: "BASE" should be "bitwidth of parent bitfield";
- packet-infiniband.c: Use consistent indentation;
-                      Move proto_register & proto_reg_handoff to the end of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28105 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAlso show number of RAR bodies/entries in stats.
martinm [Tue, 21 Apr 2009 12:35:50 +0000 (12:35 +0000)]
Also show number of RAR bodies/entries in stats.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28104 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSimplify headerfields a bit.
jake [Tue, 21 Apr 2009 05:59:01 +0000 (05:59 +0000)]
Simplify headerfields a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28103 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoConstify some more value_strings.
jake [Tue, 21 Apr 2009 05:58:31 +0000 (05:58 +0000)]
Constify some more value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28102 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoConstify some more value_strings.
jake [Tue, 21 Apr 2009 05:33:32 +0000 (05:33 +0000)]
Constify some more value_strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28101 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove some backslashes that were inadvertently continuing lines.
gerald [Mon, 20 Apr 2009 21:20:47 +0000 (21:20 +0000)]
Remove some backslashes that were inadvertently continuing lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28100 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSquelch some warnings.
guy [Mon, 20 Apr 2009 21:03:46 +0000 (21:03 +0000)]
Squelch some warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28099 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMore IE decoding, expect messages to be integrity protected.
etxrab [Mon, 20 Apr 2009 20:31:33 +0000 (20:31 +0000)]
More IE decoding, expect messages to be integrity protected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28098 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix build without HAVE_LIBGCRYPT.
jake [Mon, 20 Apr 2009 20:27:16 +0000 (20:27 +0000)]
Fix build without HAVE_LIBGCRYPT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28097 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMore constification to fix warnings.
guy [Mon, 20 Apr 2009 19:20:49 +0000 (19:20 +0000)]
More constification to fix warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28096 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd Naoyoshi Ueda to authors list.
jake [Mon, 20 Apr 2009 18:53:12 +0000 (18:53 +0000)]
Add Naoyoshi Ueda to authors list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28095 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMore constification, fewer warnings.
guy [Mon, 20 Apr 2009 18:45:02 +0000 (18:45 +0000)]
More constification, fewer warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28094 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoConstify some items to squelch some compiler warnings in the Windows
guy [Mon, 20 Apr 2009 18:34:06 +0000 (18:34 +0000)]
Constify some items to squelch some compiler warnings in the Windows
buildbot; based on a patch from Chris Maynard, with some additional
changes to squelch GCC warnings on UN*X.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28093 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a preference for allowing transparent RRC data (BCH, PCH, CCCH) to be decoded...
martinm [Mon, 20 Apr 2009 16:46:46 +0000 (16:46 +0000)]
Add a preference for allowing transparent RRC data (BCH, PCH, CCCH) to be decoded as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28092 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove code duplication.
jake [Mon, 20 Apr 2009 05:49:26 +0000 (05:49 +0000)]
Remove code duplication.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28091 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Chris A:
jake [Mon, 20 Apr 2009 05:48:04 +0000 (05:48 +0000)]
From Chris A:
Right now with DESEGMENT_UNTIL_FIN, the TCP dissector doesn't display the
fragment tree (the "Reassembled TCP segments" with links to the frames that
were reassembled).

Attached is one possible patch to packet-tcp.c to display the fragment tree.
Because DESEGMENT_UNTIL_FIN dissects the FIN packet as the high-level PDU, the
fragment tree also contains the FIN packet. It has 0 bytes of PDU data. Ugly but logical..

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28090 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Naoyoshi Ueda:
jake [Mon, 20 Apr 2009 05:40:58 +0000 (05:40 +0000)]
From Naoyoshi Ueda:
Currently wireshark has ability to decrypt ISAKMP IKEv1 packets, but not IKEv2
packets. With attached patch decryption of IKEv2 packets is now passible.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28089 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWhen a frame contains the remainder of a previous PDU and a new PDU, the
sake [Sun, 19 Apr 2009 20:28:18 +0000 (20:28 +0000)]
When a frame contains the remainder of a previous PDU and a new PDU, the
protocol tree would show two "Secure Socket Layer" branches and the INFO
column would fail to show the content type of the second PDU. Don't give
control back to TCP for the second PDU by just fetching the remaining bytes
of the first PDU, but ask for a whole new segment so that all processing
will be done within the SSL dissector itself.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28088 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago[Automatic manuf and enterprise-numbers update for 2009-04-19]
gerald [Sun, 19 Apr 2009 15:03:35 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-04-19]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28086 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to speed up lookup of LTE mac/rlc/pdcp dissectors
martinm [Sat, 18 Apr 2009 08:03:09 +0000 (08:03 +0000)]
Try to speed up lookup of LTE mac/rlc/pdcp dissectors

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28085 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom rspmn:
jake [Sat, 18 Apr 2009 06:34:58 +0000 (06:34 +0000)]
From rspmn:
Wireshark considers an Activate PDP Context Request which contains a
DNS Server Address Request parameter according to section 10.5.6.3 of
TS 24.008 to be a malformed packet.
The attached patch (against SVN revision 28067) fixes the problem for
the parameters DNS Server Address Request and P-CSCF Address Request.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28084 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemoved obsolete color legend.
rbalint [Fri, 17 Apr 2009 22:26:43 +0000 (22:26 +0000)]
Removed obsolete color legend.
This fixes bug 2957.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28083 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf our target is Win64, install into $PROGRAMFILES64\Wireshark by default.
gerald [Fri, 17 Apr 2009 22:09:26 +0000 (22:09 +0000)]
If our target is Win64, install into $PROGRAMFILES64\Wireshark by default.
(This doesn't work on my test system, but appears to be correct).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28082 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove some no-longer-needed casts.
gerald [Fri, 17 Apr 2009 22:07:50 +0000 (22:07 +0000)]
Remove some no-longer-needed casts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28081 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a note about LLP64 portability.
gerald [Fri, 17 Apr 2009 20:58:18 +0000 (20:58 +0000)]
Add a note about LLP64 portability.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28080 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse the CRT version appropriate for our target architecture.
gerald [Fri, 17 Apr 2009 19:02:56 +0000 (19:02 +0000)]
Use the CRT version appropriate for our target architecture.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28079 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to get Visual C++ 6.0 builds working again.
gerald [Fri, 17 Apr 2009 18:19:10 +0000 (18:19 +0000)]
Try to get Visual C++ 6.0 builds working again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28078 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to handle attempts at installing 64-bit Wireshark on a 32-bit system.
gerald [Fri, 17 Apr 2009 17:32:48 +0000 (17:32 +0000)]
Try to handle attempts at installing 64-bit Wireshark on a 32-bit system.
Fix Win64 package building.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28077 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix Win64 compilation.
gerald [Fri, 17 Apr 2009 16:21:33 +0000 (16:21 +0000)]
Fix Win64 compilation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28076 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofile_dlg_win32.c: A fix for VC6 compilation.
wmeier [Fri, 17 Apr 2009 15:56:53 +0000 (15:56 +0000)]
file_dlg_win32.c: A fix for VC6 compilation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28075 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jim Young <jyoung@gsu.edu>:
rbalint [Fri, 17 Apr 2009 15:21:46 +0000 (15:21 +0000)]
From Jim Young <jyoung@gsu.edu>:
- New duplicate packet removal options for editcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3168

I changed the patch a bit:
- Adapted to 80 chars wide screen
- Merged -w and -W parameters

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28074 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoShow RARs. For now show frame count in common channel section, although it may be...
martinm [Fri, 17 Apr 2009 13:27:25 +0000 (13:27 +0000)]
Show RARs.  For now show frame count in common channel section, although it may be possible to associate RAR bodies with UEs if the context info is available...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28073 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFor RAR PDUs, show RA-RNTI and subframe number in info column.
martinm [Fri, 17 Apr 2009 11:38:06 +0000 (11:38 +0000)]
For RAR PDUs, show RA-RNTI and subframe number in info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28072 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWhen building the wireshark-filter documentation on Windows, try to
gerald [Fri, 17 Apr 2009 03:53:19 +0000 (03:53 +0000)]
When building the wireshark-filter documentation on Windows, try to
figure out if we can run TShark. If we can't, just insert the dfref URL
in the documentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28071 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCheck for the existence of a couple of directories and add variables for DLL
gerald [Thu, 16 Apr 2009 21:34:44 +0000 (21:34 +0000)]
Check for the existence of a couple of directories and add variables for DLL
names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28070 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix bugs found with the aid of Gianluca Verin.
etxrab [Thu, 16 Apr 2009 19:02:52 +0000 (19:02 +0000)]
Fix bugs found with the aid of Gianluca Verin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28069 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Vincent Helfre and Me:
etxrab [Thu, 16 Apr 2009 19:01:31 +0000 (19:01 +0000)]
From Vincent Helfre and Me:
- Dissect GSM messages.
- Add functions to libwireshark needed by plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28068 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix (and likely re-break) the Windows builds:
gerald [Thu, 16 Apr 2009 18:14:38 +0000 (18:14 +0000)]
Fix (and likely re-break) the Windows builds:
  - Use the latest WinPcap Developer's Pack.
  - In file_dlg_win32.c, try to fix Visual C++ 6.0 compilation.
  - #if 0 out a bunch of definitions in capture_if_details_dlg_win32.c
    that already exist in Ntddndis.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28067 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jared Renzullo:
jake [Thu, 16 Apr 2009 17:24:56 +0000 (17:24 +0000)]
From Jared Renzullo:
The existing Wireshark Cops PCMM dissector does not support the new I04 fields fof PCMM.
I've added the new fields which are relevant to the policy server to the dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28066 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the last(?) of the Win64 compilation problems.
gerald [Thu, 16 Apr 2009 04:05:39 +0000 (04:05 +0000)]
Fix the last(?) of the Win64 compilation problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28065 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix Win64 compilation problems in the plugins directory.
gerald [Thu, 16 Apr 2009 03:38:23 +0000 (03:38 +0000)]
Fix Win64 compilation problems in the plugins directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28064 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the last of the Win64 problems in the gtk directory.
gerald [Thu, 16 Apr 2009 03:18:10 +0000 (03:18 +0000)]
Fix the last of the Win64 problems in the gtk directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28063 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMore Win64 fixes.
gerald [Thu, 16 Apr 2009 00:45:26 +0000 (00:45 +0000)]
More Win64 fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28062 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCheck for _WIN64 instead of _NTDDNDIS_.
gerald [Wed, 15 Apr 2009 23:47:46 +0000 (23:47 +0000)]
Check for _WIN64 instead of _NTDDNDIS_.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28061 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIn capture_if_details_dlg_win32.c, don't define a bunch of stuff if
gerald [Wed, 15 Apr 2009 23:23:21 +0000 (23:23 +0000)]
In capture_if_details_dlg_win32.c, don't define a bunch of stuff if
_NTDDNDIS_ is defined. In file_dlg_win32.c, use GetWindowLongPtr()
instead of GetWindowLong().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28060 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agosize_t fixes.
gerald [Wed, 15 Apr 2009 21:35:51 +0000 (21:35 +0000)]
size_t fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28059 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agopacket_sccp.c: Init an uninit'd variable which was the cause of intermittent crashes.
wmeier [Wed, 15 Apr 2009 20:01:45 +0000 (20:01 +0000)]
packet_sccp.c: Init an uninit'd variable which was the cause of intermittent crashes.
 Fixes Bug #3409 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3409)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28058 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix the Buildbot.
gerald [Wed, 15 Apr 2009 18:14:34 +0000 (18:14 +0000)]
Fix the Buildbot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28057 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAssociate .pcapng files with Wireshark.
gerald [Wed, 15 Apr 2009 18:10:30 +0000 (18:10 +0000)]
Associate .pcapng files with Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28056 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to fix bug 3279 (initialize a time_t to a sane value).
gerald [Wed, 15 Apr 2009 16:02:35 +0000 (16:02 +0000)]
Try to fix bug 3279 (initialize a time_t to a sane value).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28055 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDissect more than one Via entry if found in a single line.
martinm [Wed, 15 Apr 2009 13:10:55 +0000 (13:10 +0000)]
Dissect more than one Via entry if found in a single line.
Fixes bug 3406.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28054 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agopacket-rlc-lte.c: keep vc6 happy: use gboolean instead of guint8 in several places.
wmeier [Wed, 15 Apr 2009 02:28:55 +0000 (02:28 +0000)]
packet-rlc-lte.c: keep vc6 happy: use gboolean instead of guint8 in several places.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28053 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoep_strbuf usage: ep_strbuf_new_label("") --> ep_strbuf_new_label(NULL);
wmeier [Tue, 14 Apr 2009 18:31:02 +0000 (18:31 +0000)]
ep_strbuf usage: ep_strbuf_new_label("") --> ep_strbuf_new_label(NULL);
   ep_strbuf_append() --> ep_strbuf_append_c() in a few cases.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28052 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agocheckAPIs: Add additional GLib deprecated functions;
wmeier [Tue, 14 Apr 2009 18:22:43 +0000 (18:22 +0000)]
checkAPIs: Add additional GLib deprecated functions;
 Update comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28051 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoguint8 -> guint16
etxrab [Tue, 14 Apr 2009 18:14:24 +0000 (18:14 +0000)]
guint8 -> guint16

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28050 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDissect PDN address, fix typos.
etxrab [Tue, 14 Apr 2009 18:11:41 +0000 (18:11 +0000)]
Dissect PDN address, fix typos.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28049 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse G_GINT64_CONSTANT in stead of G_GUINT4_CONSTANT
etxrab [Tue, 14 Apr 2009 18:10:45 +0000 (18:10 +0000)]
Use G_GINT64_CONSTANT in stead of G_GUINT4_CONSTANT

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28048 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jakub Zawadzki: Fix a logic error.
gerald [Tue, 14 Apr 2009 17:52:22 +0000 (17:52 +0000)]
From Jakub Zawadzki: Fix a logic error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28047 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd a note for -z io,stat,<interval>,<filter>,<filter>,... to use "." as
sake [Tue, 14 Apr 2009 16:38:08 +0000 (16:38 +0000)]
Add a note for -z io,stat,<interval>,<filter>,<filter>,... to use "." as
a decimal separator, as the "," will make the command fail.

(of course it would be nice to have this fixed, but for now, it at least
informs the user how to work around the issue)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28046 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoBegin to do some per-channel sequence analysis (so far, only for UM).
martinm [Tue, 14 Apr 2009 14:38:20 +0000 (14:38 +0000)]
Begin to do some per-channel sequence analysis (so far, only for UM).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28045 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoep_strbuf: fix some bugs and additional changes
wmeier [Tue, 14 Apr 2009 14:08:19 +0000 (14:08 +0000)]
ep_strbuf: fix some bugs and additional changes
-Bugs
  * str->len not set correctly in some cases;
  * trailing '\0' not always accounted for;
  * (issues relating to determining when & how much
     to expand string buffer).
-Other
  * Change append, append_c, truncate to return
    pointer to ep_strbuf (similar to the corresponding
    GString functions);
  * Rename certain variables to clarify usage (as I understand
    the intended usage);
  * ep_strbuf_grow: use current allocated length and not current
    string length as the starting point;
  * Optimizations;
  * Add some additional comments to emem.h ep_strbuf section

  * Use consistent indentation throughout emem.c;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28044 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agodo not report encoding error for sequence extension with length 0
kukosa [Tue, 14 Apr 2009 07:38:02 +0000 (07:38 +0000)]
do not report encoding error for sequence extension with length 0
highlight one byte also for NULL type

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28043 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agosupport UINT64 constants for upper value bounds
kukosa [Tue, 14 Apr 2009 07:34:56 +0000 (07:34 +0000)]
support UINT64 constants for upper value bounds

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28042 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSection 11 of RFC 3550, "RTP over Network and Transport Protocols",
guy [Mon, 13 Apr 2009 22:37:35 +0000 (22:37 +0000)]
Section 11 of RFC 3550, "RTP over Network and Transport Protocols",
speaks only of destination ports; in the heuristic dissectors, don't
check whether the source port is even or odd.

The total length of an RTCP packet is in tvb_reported_length(), not
tvb_length() - the latter includes only the actual captured data, which
might be cut short by a snapshot length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28041 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd XiMeta Technology's ethertype.
etxrab [Mon, 13 Apr 2009 18:32:24 +0000 (18:32 +0000)]
Add XiMeta Technology's ethertype.
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3392)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28040 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Abhik Sarkar:
etxrab [Mon, 13 Apr 2009 18:14:25 +0000 (18:14 +0000)]
From Abhik Sarkar:
Diameter SRT stats - split by command
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3403

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28039 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to please the build bot, fix indentation.
etxrab [Mon, 13 Apr 2009 18:09:20 +0000 (18:09 +0000)]
Try to please the build bot, fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28038 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Andreas Heise:
etxrab [Mon, 13 Apr 2009 14:31:13 +0000 (14:31 +0000)]
From Andreas Heise:
add SIP URI PARTS dissection to packet-sip.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3399

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28037 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago[Automatic manuf and enterprise-numbers update for 2009-04-12]
gerald [Sun, 12 Apr 2009 15:03:32 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-04-12]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28035 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_label_get() --> gtk_label_get_text() with related code changes;
wmeier [Sat, 11 Apr 2009 18:03:11 +0000 (18:03 +0000)]
gtk_label_get() --> gtk_label_get_text() with related code changes;
Also: Fix indentation to be consistent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28034 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoprefs_dlg: gtk_label_get() --> gtk_label_get_text()
wmeier [Sat, 11 Apr 2009 15:14:55 +0000 (15:14 +0000)]
prefs_dlg: gtk_label_get() --> gtk_label_get_text()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28033 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGet rid of gtk_file_selection_new and gtk_file_selection_get_filename.
etxrab [Sat, 11 Apr 2009 14:47:55 +0000 (14:47 +0000)]
Get rid of gtk_file_selection_new and gtk_file_selection_get_filename.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28032 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGet the offset of the padding count correct (it has nothing to do with
guy [Sat, 11 Apr 2009 03:56:14 +0000 (03:56 +0000)]
Get the offset of the padding count correct (it has nothing to do with
the amount of captured packet data, so calculating it must not involve
tvb_length_remaining()), and, when processing the padding, count the
padding count octet in the offset, so that the length check is correct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28031 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding();
wmeier [Fri, 10 Apr 2009 18:31:01 +0000 (18:31 +0000)]
Remove unnecessary use of (deprecated) gtk_button_box_set_child_ipadding();
 (In each case the arg values used [4,0] were the same as the defaults).
checkAPIs.pl: gtk_button_box_set_child_ipadding: 'W' --> 'E'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28030 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agocolor filters dialog: Remove use of deprecated gtk_button_box_set_child_size().
wmeier [Fri, 10 Apr 2009 17:34:30 +0000 (17:34 +0000)]
color filters dialog: Remove use of deprecated gtk_button_box_set_child_size().
Also:
 - Handle buttons in the several vboxes in a consistent manner;
 - Use consistent indentation;
 - Fix some spelling in comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28029 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_widget_ref: 'W' --> 'E';
wmeier [Fri, 10 Apr 2009 14:12:29 +0000 (14:12 +0000)]
gtk_widget_ref:  'W' --> 'E';
Also: Add GTK 2.16.0 deprecated functions

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28028 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_widget_ref() --> g_object_ref()
wmeier [Fri, 10 Apr 2009 14:10:49 +0000 (14:10 +0000)]
gtk_widget_ref() --> g_object_ref()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28027 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoHandle PER constrained integer > 32 bits, show more internal PER fields.
etxrab [Fri, 10 Apr 2009 09:24:10 +0000 (09:24 +0000)]
Handle PER constrained integer > 32 bits, show more internal PER fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28026 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a typo.
etxrab [Thu, 9 Apr 2009 15:32:26 +0000 (15:32 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28023 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoStarting cleanup in earnest
jmayer [Thu, 9 Apr 2009 13:58:20 +0000 (13:58 +0000)]
Starting cleanup in earnest
- get rid of some structure accesses
- use _item functions where possible

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28022 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse consistent indentation.
wmeier [Thu, 9 Apr 2009 13:07:05 +0000 (13:07 +0000)]
Use consistent indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28021 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_set_usize: W --> E;
wmeier [Thu, 9 Apr 2009 13:04:15 +0000 (13:04 +0000)]
gtk_set_usize: W --> E;
Change 'usage' to list groups and default groups.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28020 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix two usages of non-ascii characters.
wmeier [Thu, 9 Apr 2009 12:41:40 +0000 (12:41 +0000)]
Fix two usages of non-ascii characters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28019 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Chris Costa:
etxrab [Thu, 9 Apr 2009 05:53:14 +0000 (05:53 +0000)]
From Chris Costa:
Patch for NDMP tape_get_state dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3394

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28018 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agogtk_widget_ref() -> g_object_ref()
etxrab [Thu, 9 Apr 2009 05:51:56 +0000 (05:51 +0000)]
gtk_widget_ref() -> g_object_ref()
GTK_SIGNAL_FUNC -> G_CALLBACK()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28017 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSmall indentation fix.
etxrab [Thu, 9 Apr 2009 05:51:15 +0000 (05:51 +0000)]
Small indentation fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28016 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoJust use g_strdup_printf() to construct a pathname - and use
guy [Wed, 8 Apr 2009 22:32:44 +0000 (22:32 +0000)]
Just use g_strdup_printf() to construct a pathname - and use
G_DIR_SEPARATOR_S as the pathname component separator.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28013 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry to make everyone happy about their size_t's.
gerald [Wed, 8 Apr 2009 20:18:39 +0000 (20:18 +0000)]
Try to make everyone happy about their size_t's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28011 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCompare size_t's with size_t's.
guy [Wed, 8 Apr 2009 19:50:15 +0000 (19:50 +0000)]
Compare size_t's with size_t's.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28010 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse consistent indentation
wmeier [Wed, 8 Apr 2009 19:47:09 +0000 (19:47 +0000)]
Use consistent indentation

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28009 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't assemble asm_utils_win32_x86 on x64. Export a dummy read_keytab_file
gerald [Wed, 8 Apr 2009 19:15:10 +0000 (19:15 +0000)]
Don't assemble asm_utils_win32_x86 on x64. Export a dummy read_keytab_file
if we're not using any encryption libraries on Windows.

This fixes the last Win64 compilation problems in epan.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28008 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd some more "copy" functionality:
sake [Wed, 8 Apr 2009 18:32:11 +0000 (18:32 +0000)]
Add some more "copy" functionality:

- Enabled "Copy Description" in the main menu and gave it
  accelerator key CTRL+SHIFT+D

- Added "Copy Fieldname" to copy the fieldname of the selected
  field in the detail view (Acc.Key: CTRL+SHIFT+F)

- Added "Copy Value" to copy the value of the selected
  field in the detail view (Acc.Key: CTRL+SHIFT+V)

- Updated documentation to reflect the changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28006 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agosize_t -> int.
gerald [Wed, 8 Apr 2009 18:24:08 +0000 (18:24 +0000)]
size_t -> int.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28005 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMore size_t fixes.
gerald [Wed, 8 Apr 2009 18:19:10 +0000 (18:19 +0000)]
More size_t fixes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28004 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd another Flex exception.
gerald [Wed, 8 Apr 2009 18:10:32 +0000 (18:10 +0000)]
Add another Flex exception.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28003 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDisable warnings-as-errors for Flex-generated output. Add a couple of gsize
gerald [Wed, 8 Apr 2009 18:08:25 +0000 (18:08 +0000)]
Disable warnings-as-errors for Flex-generated output. Add a couple of gsize
casts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28002 f5534014-38df-0310-8fa8-9805f1628bb7