gerald [Tue, 10 May 2005 03:10:09 +0000 (03:10 +0000)]
Make a field type check more strict. Remove some unnecessary code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14338
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 10 May 2005 03:08:36 +0000 (03:08 +0000)]
Make sure we don't feed a null string to strncmp(). Fixes bug 161.
Make sure we don't free static memory. Fix a small memory leak.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14337
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 9 May 2005 11:21:16 +0000 (11:21 +0000)]
I just found a packet with an option e. As the value looked very much
like the mac-address of the switch, I added decoding of option e as
mac address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14336
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Mon, 9 May 2005 01:21:41 +0000 (01:21 +0000)]
Add another sanity check to the new SIP URI parser.
Just to be sure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14335
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Mon, 9 May 2005 01:15:45 +0000 (01:15 +0000)]
Some fixes for the new SIP contact header parser.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14334
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Mon, 9 May 2005 00:11:03 +0000 (00:11 +0000)]
only lower-case ASCII letters, numbers,
underscores, and dots are allowed in the
preference name.
Fix it the camel dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14333
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sun, 8 May 2005 23:29:55 +0000 (23:29 +0000)]
Mark a function parameter as unused
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14332
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sun, 8 May 2005 22:39:38 +0000 (22:39 +0000)]
When saying that I remove the trailing white spaces I should do it, too.
So I do it now and do some more reindentation, too.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14331
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sun, 8 May 2005 22:19:18 +0000 (22:19 +0000)]
Improve dissection of SIP contact header and counting of bindings in REGISTER messages.
Introduce a function for disseting a sip uri in general
TODO:
- add dissection of contact and uri parameters
- simplify the ugly code for dissecting "to" and "from" headers
by using the new function for uri dissection
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14330
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sun, 8 May 2005 21:17:37 +0000 (21:17 +0000)]
Reindent dissect_sip_common() and remove trailing white spaces from packet-sip.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14329
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 8 May 2005 20:35:44 +0000 (20:35 +0000)]
From Javier Acuna:
Added some code to dissect DateAndTime.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14328
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 8 May 2005 20:34:57 +0000 (20:34 +0000)]
From Javier Acuna:
Added some code to dissect DateAndTime.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14327
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 7 May 2005 20:47:39 +0000 (20:47 +0000)]
add icons for the "File Set" menu items
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14326
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sat, 7 May 2005 00:14:11 +0000 (00:14 +0000)]
Increase size of an integer to prevent an integer overflow
Fixes Bug 162
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14325
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 6 May 2005 10:11:08 +0000 (10:11 +0000)]
prettify YPSERV
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14324
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 6 May 2005 02:08:30 +0000 (02:08 +0000)]
A fix for the previous fix for the infinite loop in bootp, bug #160.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14323
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Fri, 6 May 2005 01:56:40 +0000 (01:56 +0000)]
Check the offset delta while we loop through the options.
Make sure the delta is > 0.
This intends to fix bug 160, although with a capture file
to test it, I can't be totally sure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14322
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 5 May 2005 17:07:58 +0000 (17:07 +0000)]
Change 802.11f -> F, 802.1d -> D, 802.1x -> X, 802.1q -Q, 802.1P -> p
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14321
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 5 May 2005 15:25:04 +0000 (15:25 +0000)]
add GetWindowsVersion.nsh to the additional packaging files
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14320
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 5 May 2005 13:48:34 +0000 (13:48 +0000)]
make tethereal compile when plugins are disabled
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14319
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 11:08:20 +0000 (11:08 +0000)]
Fix a call to dereference a pointer (found by a compiler warning).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14318
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 11:07:22 +0000 (11:07 +0000)]
Don't explicitly initialize "h245_labels", as it's hard to initialize
all of it correctly, and as if you don't initialize all of it you get a
compiler warning.
Add an assignment to squelch a compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14317
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 11:06:08 +0000 (11:06 +0000)]
Fix a test (bug found by a compiler warning).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14316
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 11:05:15 +0000 (11:05 +0000)]
Change some data types, and add initializations, to squelch compiler
warnings.
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14315
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 11:03:46 +0000 (11:03 +0000)]
Change data types to match those of "iconv()", at least on OS X.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14314
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 11:02:31 +0000 (11:02 +0000)]
Squelch a compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14313
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 10:00:29 +0000 (10:00 +0000)]
Re-parenthesize an expression, to squelch a compiler warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14312
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 5 May 2005 09:40:24 +0000 (09:40 +0000)]
"oid_to_str()" and "oid_to_str_buf()" don't modify what the "oid"
argument points to, so make it a "const" pointer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14311
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 4 May 2005 17:02:56 +0000 (17:02 +0000)]
Don't try to feed a null pointer to strncmp(). Fixes bug 158.
Shouldn't the number of fuzz bugs decrease asymptotically at some
point?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14306
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 4 May 2005 16:40:30 +0000 (16:40 +0000)]
From Lars Roland:
Make sure a hash table exists before trying to access it. Fixes bug 105.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14305
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 4 May 2005 15:35:21 +0000 (15:35 +0000)]
Don't roll our own buffer-overflow-able string_to_hex() routine
when there's a perfectly good tvb_bytes_to_str() lying around, just
_begging_ to be used.
Fix up white space.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14304
f5534014-38df-0310-8fa8-
9805f1628bb7
girlich [Wed, 4 May 2005 13:09:46 +0000 (13:09 +0000)]
Added RPC/ONC SYSTEM_ERROR accept state.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14303
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 3 May 2005 20:53:21 +0000 (20:53 +0000)]
Dissect GPRS user data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14302
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 3 May 2005 19:58:05 +0000 (19:58 +0000)]
add a *lot* more dissections of the various PN-IO blocks
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14301
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 3 May 2005 19:33:02 +0000 (19:33 +0000)]
In proto_tree_set_string(), don't set a null fvalue or Ethereal will throw
a hissy fit. Fixes bug 157.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14299
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 3 May 2005 18:43:06 +0000 (18:43 +0000)]
Back out all of the tvb_ensure_bytes_exist() calls. They shouldn't be
neccessary any more, and were causing problems.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14298
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Tue, 3 May 2005 14:36:08 +0000 (14:36 +0000)]
Fix two places where we might loop infinitely, including the one found in
bug 155. Fix a couple of compiler warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14289
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Tue, 3 May 2005 08:34:11 +0000 (08:34 +0000)]
Base the assoc search on port/vtags only.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14288
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 3 May 2005 05:22:43 +0000 (05:22 +0000)]
From Nils O. Sel?sdal:
- Decodes all the remaining bitfields in 9P
- Tidies up display a bit (using more subtrees)
- Fixes a few fields that are better off displayed as decimal/octal.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14287
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Tue, 3 May 2005 02:07:26 +0000 (02:07 +0000)]
Fix typos in error messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14286
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 3 May 2005 01:39:00 +0000 (01:39 +0000)]
move the pn-dcp dissector into the profinet plugin
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14285
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Tue, 3 May 2005 01:03:33 +0000 (01:03 +0000)]
add the new target "install-plugins" to nmake makefile
in the plugins subdirectory. This target will copy all plugins to plugins/$(VERSION), thus (t)ethereal will
find and load the plugins when called from within the source tree.
call this target from the main nmake makefile after
installing other dependencies. call it from the nmake makefile
in the doc subdirectory before calling "tethereal -G".
This way "tethereal -G" will recognize the filterable
fields from the plugins, too.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14284
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Tue, 3 May 2005 00:19:08 +0000 (00:19 +0000)]
add another lenght check in the megaco dissector.
Fixes bug 150.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14283
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 2 May 2005 22:15:00 +0000 (22:15 +0000)]
Get profinet compiling on Unix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14282
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 21:56:40 +0000 (21:56 +0000)]
From Rich Coe:
- fix memory leak when Assoc packet is processed repeatedly in ethereal
- removed unused partial packet flag
- added better support for DICOM VR
- sequences
- report actual VR in packet display, if supplied by xfer syntax
- show that we are not displaying entire tag string with '[...]',
some tags can hold up to 2^32-1 chars
- remove my goofy attempt at trying to get access to the fragmented packets
(anyone have an idea on how to fix this ???)
- process all the data in the Assoc packet even if display is off
- limit display of data in Assoc packet to defined size of the data even
if reported size is larger
- show the last tag in a packet as [incomplete] if we don't have all the data
- added framework for reporting DICOM async negotiation (not finished)
(I'm not aware of an implementation which currently supports this)
- still need to fix display of continuation packets
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14280
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 2 May 2005 20:45:22 +0000 (20:45 +0000)]
Provide an indication to taps if the verification tag is reflected.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14278
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 20:30:56 +0000 (20:30 +0000)]
Break out of an infinite loop. Fixes bug 154.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14277
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 2 May 2005 20:26:56 +0000 (20:26 +0000)]
Dissect URLC correctly and add dissection of LCC PDU.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14276
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 20:05:03 +0000 (20:05 +0000)]
In dissect_mgcp_firstline(), throw an exception if tokenlen > 4. This fixes
bug 145, but may not be the best solution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14275
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 2 May 2005 18:32:57 +0000 (18:32 +0000)]
Add dissection of Q.850 cause.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14274
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 2 May 2005 18:32:00 +0000 (18:32 +0000)]
Add dissection of q850 cause.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14273
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 2 May 2005 18:31:15 +0000 (18:31 +0000)]
Correct some AVP:s and minor updates from iana.org
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14272
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 2 May 2005 18:30:14 +0000 (18:30 +0000)]
Use the correct parameters in a function call.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14271
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 16:34:24 +0000 (16:34 +0000)]
Prep for the next release. ETA Wednesday (the 4th).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14270
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 14:45:43 +0000 (14:45 +0000)]
From Cvetan Ivanov:
This patch fixes the slightly broken logic in the loop which searches
for establisted call in isup_calls_packet.
The problem is that (right_pair) is set to false if we see call on the
same CIC as existing conversation, but with different opc/dpc pair:
at this point dpc/opc pair is not checked, so any call with the same
CIC matches:
voip_call.c:851
else{
right_pair = FALSE;
}
and then the correct conversation is never found, because right_pair is
never reset for this packet, which leads to total confusion of the call
tracking logic
Fixed by initializing right_pair = TRUE for every loop iteration
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14269
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 14:41:07 +0000 (14:41 +0000)]
From Cvetan Ivanov:
1) dissect_isup_calling_party_number_parameter reported malformed packet
if the calling party number IE contains empty number (possibly with
presentation set to 'number not available')
I've basicly added if(length > 0) around the digits tree dissector,
which may not be obvious from the patch becase of the indenting of the
entire block.
2) As the tap_calling_number is static, if there is call with missing
calling_party_number IE, it gets assigned the calling party number of
the previuos call containing such IE.
fixed by adding tap_calling_number = NULL;
in the beginning of dissect_isup_message, and
tap_rec.calling_number=tap_calling_number?tap_calling_number:g_strdup("");
in the end to avoid segfault
Those things may not happen too often in the telecom world, but happen
all the time with VoIP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14268
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 14:24:09 +0000 (14:24 +0000)]
Add "plugins/profinet/Makefile" to configure.in.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14267
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 14:12:42 +0000 (14:12 +0000)]
Check for a few more integer overflows. Found during fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14266
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 2 May 2005 14:07:33 +0000 (14:07 +0000)]
- Add support for libpcap files for MTP2 with a per packet header
indicating the direction, narrowband/broadband, and interface number.
- Add support to display the direction and interface number.
- Add support to packet-mtp2.c to use the broadband/narrowband indication.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14265
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 2 May 2005 14:04:25 +0000 (14:04 +0000)]
Fix a bug in counting DATA chunks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14264
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Mon, 2 May 2005 10:59:51 +0000 (10:59 +0000)]
Get rid of trailing \
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14263
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 2 May 2005 10:47:12 +0000 (10:47 +0000)]
as Thomas Boehne suggested, put each plugin target into it's own line, so private plugins can better keep in track with the official Makefile's
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14262
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 2 May 2005 10:35:37 +0000 (10:35 +0000)]
added the profinet plugin
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14261
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 2 May 2005 00:57:44 +0000 (00:57 +0000)]
Fix a couple of infinite loops. Make similar changes elsewhere to keep the
code consistent.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14260
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sun, 1 May 2005 23:03:45 +0000 (23:03 +0000)]
Add an install-deps target to the nmake makefiles.
This target will copy all files, mainly dlls, which
are necessary to run (t)ethereal to the source tree.
After copying all necessary dlls to the source tree,
you can run (t)ethereal directly from the source tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14259
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 21:00:26 +0000 (21:00 +0000)]
Fix chunk length handling. Go back to initial concept that
the chunk_length always is the length indicated in the packet header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14258
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 13:59:07 +0000 (13:59 +0000)]
Get rid of some debug code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14257
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 13:55:09 +0000 (13:55 +0000)]
Editorial stuff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14256
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 13:53:53 +0000 (13:53 +0000)]
Editorial stuff
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14255
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 1 May 2005 13:52:15 +0000 (13:52 +0000)]
Make sure we pass a positive length to proto_item_set_len().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14254
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 13:52:05 +0000 (13:52 +0000)]
Editorial stuff.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14253
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 13:51:07 +0000 (13:51 +0000)]
Editorial cleanups
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14252
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Sun, 1 May 2005 13:50:02 +0000 (13:50 +0000)]
Editorial cleanups.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14251
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 1 May 2005 13:36:00 +0000 (13:36 +0000)]
Break out of another infinite loop. Found during fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14250
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 30 Apr 2005 20:55:21 +0000 (20:55 +0000)]
set subversion attributes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14249
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 30 Apr 2005 20:52:20 +0000 (20:52 +0000)]
move the profinet related files to a plugin (step by step), to make prototyping and further development easier (at least for me :-)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14248
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 30 Apr 2005 19:37:03 +0000 (19:37 +0000)]
Fix a buffer overflow found during fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14247
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 30 Apr 2005 17:23:33 +0000 (17:23 +0000)]
removed various gcc warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14246
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 30 Apr 2005 16:42:04 +0000 (16:42 +0000)]
Check for an integer overflow. Fixes bug 149.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14245
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 30 Apr 2005 16:29:03 +0000 (16:29 +0000)]
From Miklos Szurdi :
update to GSM_A to display the maximum bit rate properly
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14244
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 30 Apr 2005 16:14:57 +0000 (16:14 +0000)]
once we know a conversation is iscsi, use conversation_set_dissector()
so that we block any heuristic dissectors from attempring and mistaking this conversation from being it.
In particular: DCERPC often mistakes iscsi DataOut PDUs for being DCERPC.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14243
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 30 Apr 2005 16:08:29 +0000 (16:08 +0000)]
Don't call proto_item_set_len() with a negative length. Found during
fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14242
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 30 Apr 2005 15:39:40 +0000 (15:39 +0000)]
(hopefully) removed various gcc warnings
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14241
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 30 Apr 2005 12:56:40 +0000 (12:56 +0000)]
fix buildbot reported problems (unix related), part 4, more GLib 1.x related
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14240
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 30 Apr 2005 11:24:52 +0000 (11:24 +0000)]
fix buildbot reported problems (unix related), part 3, don't use GError with GLib 1.x
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14239
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 30 Apr 2005 04:30:32 +0000 (04:30 +0000)]
Make sure we don't recurse into oblivion. Fixes bug 147.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14238
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 30 Apr 2005 04:09:28 +0000 (04:09 +0000)]
Make sure we don't pass an invalid length to proto_tree_add_item(). Found
during fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14237
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 30 Apr 2005 00:28:05 +0000 (00:28 +0000)]
The previous changes were causing weird exception errors. Back them out,
and simply check the length of each buffer.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14236
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 29 Apr 2005 22:06:47 +0000 (22:06 +0000)]
fix buildbot reported problems (unix related), part 2, add some missing #includes
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14235
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 29 Apr 2005 20:05:39 +0000 (20:05 +0000)]
fix buildbot reported problems (unix related), part 1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14234
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Apr 2005 16:39:20 +0000 (16:39 +0000)]
Use GStrings instead of character arrays, so that we don't overflow any
buffers. Found during fuzz testing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14233
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Apr 2005 14:52:45 +0000 (14:52 +0000)]
When printing an error message, make sure we're using a valid tree. Fixes
bug 144.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14232
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 29 Apr 2005 14:51:52 +0000 (14:51 +0000)]
add a new feature: list the files of a "File Set" (set of files generated by capturing "Multiple Files"/ringbuffer) and jump from one file of it to the next/previous one
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14231
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Apr 2005 14:40:04 +0000 (14:40 +0000)]
Make sure we're passing the proper lengths to proto_tree_add_item(). Fixes
bug 142.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14230
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Apr 2005 14:25:07 +0000 (14:25 +0000)]
Break out of another large-but-not-infinite loop. Fixes bug 143.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14229
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 29 Apr 2005 08:02:44 +0000 (08:02 +0000)]
add the missing MODE field in mover_get_state that was introduced in version 4.
also change bytes_left_to_read to be a INT64 and not a UINT64.
It iss supposed to be an UINT64 but some implementations are buggy and it is easier to make sense of this field one for those buggy clients if it is printed as an INT64.
This change/violation will not affect any correct/valid NDMP implementation or how ethereal decodes its output unless your entire backup is > 2**63 bytes in size.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14228
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Apr 2005 03:35:38 +0000 (03:35 +0000)]
Force the query interval and robustness variable to be 2. Fixes bug 141.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14227
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 29 Apr 2005 00:16:22 +0000 (00:16 +0000)]
Break out of a really large (but not infinite) loop.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14226
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Fri, 29 Apr 2005 00:00:42 +0000 (00:00 +0000)]
From Martin Mathieson:
- added support for local connection options
- added missing "Response Acknowledgement (000)" response code
- got rid of "display_dissect_tree" preference and code
- increased version number in moduleinfo.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14225
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 28 Apr 2005 22:02:05 +0000 (22:02 +0000)]
Don't try to access past the end of an array. Fixes bug 140.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14224
f5534014-38df-0310-8fa8-
9805f1628bb7