obnox/wireshark/wip.git
20 years agoFrom Erwin Rol:
guy [Sun, 17 Aug 2003 01:05:21 +0000 (01:05 +0000)]
From Erwin Rol:

Update e-mail address.

Register the ARP dissector, as the RT-Net dissector tries to
find it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8176 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Shiang-Ming Huang: STUN (RFC 3489) support.
guy [Sun, 17 Aug 2003 00:54:25 +0000 (00:54 +0000)]
From Shiang-Ming Huang: STUN (RFC 3489) support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8175 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSigh. I think I once tried making the last argument to "col_set_str()"
guy [Sun, 17 Aug 2003 00:52:03 +0000 (00:52 +0000)]
Sigh.  I think I once tried making the last argument to "col_set_str()"
be a "const gchar *", and it ended up being like pulling a thread out of
a sweater - more things had to change, which meant still more things had
to change, and I might've even run into something that didn't change
very well at all.  (Or perhaps that was constifying something else.)

For now, we just cast away the constness in calls to "col_set_str()";
the column code won't actually overwrite the string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8174 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Joakim Wiberg: various fixes and cleanups, including fixes to
guy [Sat, 16 Aug 2003 01:53:41 +0000 (01:53 +0000)]
From Joakim Wiberg: various fixes and cleanups, including fixes to
malformed packets caused by unconnected send and support for connected
class 3 data.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8173 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Ronnie Sahlberg: patch to set up conversations to use RTP and RTCP
guy [Sat, 16 Aug 2003 00:51:04 +0000 (00:51 +0000)]
From Ronnie Sahlberg: patch to set up conversations to use RTP and RTCP
based on H.245 information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8172 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThere's no such function as "delete_giop_user_module()", so don't put it
guy [Sat, 16 Aug 2003 00:38:28 +0000 (00:38 +0000)]
There's no such function as "delete_giop_user_module()", so don't put it
in the list of exported functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8171 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of an unused variable.
guy [Sat, 16 Aug 2003 00:31:16 +0000 (00:31 +0000)]
Get rid of an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8170 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Alfred Koebler:
guy [Sat, 16 Aug 2003 00:29:15 +0000 (00:29 +0000)]
From Alfred Koebler:

add interpretation of chain position;

add a preference to interpret the new file format used by fw
monitor options -u/-s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8169 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake the AH and ESP sequence numbers BASE_DEC, since no one objected to
gerald [Sat, 16 Aug 2003 00:11:07 +0000 (00:11 +0000)]
Make the AH and ESP sequence numbers BASE_DEC, since no one objected to
http://www.ethereal.com/lists/ethereal-dev/200308/msg00189.html.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8168 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn "dissect_transaction2_request_parameters()", "bc" gets decremented as
guy [Fri, 15 Aug 2003 23:57:52 +0000 (23:57 +0000)]
In "dissect_transaction2_request_parameters()", "bc" gets decremented as
we go through the data, so we can't compare it with the current offset
minus the starting offset - we should just test, and use, its value
directly, as, at the end, it reflects the amount of data left.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8167 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSome fixes for UNIX CIFS extensions. There's still a problem in the trans2
tpot [Fri, 15 Aug 2003 03:23:31 +0000 (03:23 +0000)]
Some fixes for UNIX CIFS extensions.  There's still a problem in the trans2
find response and we end up displaying malformed frame even though all data
has been dissected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8166 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoApply Greg Morris' buffer overflow prevention patch to the find enhancements.
sharpe [Thu, 14 Aug 2003 22:32:45 +0000 (22:32 +0000)]
Apply Greg Morris' buffer overflow prevention patch to the find enhancements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8165 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemoved references to CIFS TR section numbers from various value_strings.
tpot [Thu, 14 Aug 2003 00:24:13 +0000 (00:24 +0000)]
Removed references to CIFS TR section numbers from various value_strings.
The strings are now in COL_INFO and the section numbers were cluttering it
up.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8164 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake some abbreviations to some value_strings to save COL_INFO real estate:
tpot [Wed, 13 Aug 2003 04:03:11 +0000 (04:03 +0000)]
Make some abbreviations to some value_strings to save COL_INFO real estate:
transaction -> trans, information -> info.

Put value_string data in COL_INFO for trans2 query{path,file}info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8163 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFixes for testing all variations of query fsinfo. There were a few
tpot [Wed, 13 Aug 2003 00:05:00 +0000 (00:05 +0000)]
Fixes for testing all variations of query fsinfo.  There were a few
transpositions of subcommand numbers, and the query object id case was not
implemented.  I'm not sure about the query fs label info as it doesn't seem
to exist as a server procedure except in Samba.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8162 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut CLDAP instead of LDAP in COL_INFO for LDAP over UDP.
tpot [Tue, 12 Aug 2003 20:14:05 +0000 (20:14 +0000)]
Put CLDAP instead of LDAP in COL_INFO for LDAP over UDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8161 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoSave and restore the value of pinfo->current_proto when calling a
tpot [Tue, 12 Aug 2003 20:09:38 +0000 (20:09 +0000)]
Save and restore the value of pinfo->current_proto when calling a
dissector in call_dissector_through_handle().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8160 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange the control message names, error codes, and result codes to more
gerald [Tue, 12 Aug 2003 02:05:41 +0000 (02:05 +0000)]
Change the control message names, error codes, and result codes to more
closely match what's in RFC 2637.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8159 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoApplied the "Updated find capabilities...." from Greg Morris.
sharpe [Mon, 11 Aug 2003 22:41:10 +0000 (22:41 +0000)]
Applied the "Updated find capabilities...." from Greg Morris.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8158 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Roland:
guy [Sun, 10 Aug 2003 19:43:25 +0000 (19:43 +0000)]
From Lars Roland:

enable decoding of fastStart elements;

make the output in the Protocol and Info columns look like the
old plugin's output.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8157 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut an item into the protocol tree for the non-ESP marker.
guy [Sun, 10 Aug 2003 19:08:02 +0000 (19:08 +0000)]
Put an item into the protocol tree for the non-ESP marker.

Set the protocol tree item for IPSEC-over-UDP to the length of the
IPSEC-over-UDP header - i.e., don't include the actual ISAKMP or ESP
data in that item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8156 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRegister the dissector by name - the "UDP Encapsulation of IPsec
guy [Fri, 8 Aug 2003 23:08:02 +0000 (23:08 +0000)]
Register the dissector by name - the "UDP Encapsulation of IPsec
Packets" dissector uses it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8155 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoHandle NAT-keepalive packets.
guy [Fri, 8 Aug 2003 23:06:47 +0000 (23:06 +0000)]
Handle NAT-keepalive packets.

Clear the Info column before dissecting.

Use "proto_tree_add_item()" to create the top-level entry - the string
used in the "proto_tree_add_protocol_format()" call was the protocol's
long name, so "proto_tree_add_item()" would use it.

Don't register the dissector by name - nobody uses it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8154 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange Lo�c Minier's e-mail address.
guy [Fri, 8 Aug 2003 22:49:00 +0000 (22:49 +0000)]
Change Lo�c Minier's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8153 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Niels Koot: fix to SUA subdissection code:
guy [Fri, 8 Aug 2003 18:05:03 +0000 (18:05 +0000)]
From Niels Koot: fix to SUA subdissection code:

do subdissection even if no protocol tree is being built;

don't put subdissection data in global variables.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8152 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe InterSwitch Link Frame Format document on the Cisco site moved.
guy [Fri, 8 Aug 2003 17:57:44 +0000 (17:57 +0000)]
The InterSwitch Link Frame Format document on the Cisco site moved.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8151 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoA bufsize of 0 makes no sense in either "tvb_get_nstringz()" or
guy [Fri, 8 Aug 2003 08:19:50 +0000 (08:19 +0000)]
A bufsize of 0 makes no sense in either "tvb_get_nstringz()" or
"tvb_get_nstringz0()", as it means there's no room even for the
terminating NUL; abort if "_tvb_get_nstringz()" is passed a bufsize of
0.

Don't throw an exception in "tvb_get_nstringz0()" if
"_tvb_get_nstringz()" returns 0 - that just means we have an empty
string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8150 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Ronnie Sahlberg: use conversations for messages with port numbers
guy [Thu, 7 Aug 2003 21:31:39 +0000 (21:31 +0000)]
From Ronnie Sahlberg: use conversations for messages with port numbers
and IP addresses specifying the addresses and ports for future RTP/RTCP
traffic.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8149 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Brad Hards: supply the full list of IP protocol numbers from IANA.
guy [Thu, 7 Aug 2003 21:08:07 +0000 (21:08 +0000)]
From Brad Hards: supply the full list of IP protocol numbers from IANA.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8148 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lo�c Minier: allow packets with no payload to participate in
guy [Thu, 7 Aug 2003 18:28:33 +0000 (18:28 +0000)]
From Lo�c Minier: allow packets with no payload to participate in
reassembly, as the last packet of a fragmented WTP message can have a
payload length of 0.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8147 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix up the handling of end-of-line comments if there's white space
guy [Thu, 7 Aug 2003 01:05:06 +0000 (01:05 +0000)]
Fix up the handling of end-of-line comments if there's white space
between a protocol name and a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8146 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDocument the disabled_protos file and the fact that you can save the
guy [Thu, 7 Aug 2003 00:56:30 +0000 (00:56 +0000)]
Document the disabled_protos file and the fact that you can save the
list of disabled protocols.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8145 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Michael Lum: add the ability to have a preferences file containing
guy [Thu, 7 Aug 2003 00:41:28 +0000 (00:41 +0000)]
From Michael Lum: add the ability to have a preferences file containing
a list of disabled protocols, and to save that list from the Edit >
Protocols dialog box.

Add checks for read errors in "read_prefs()".

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8144 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAs per Bernd Becker's suggestion, add "register_giop_user_module()" and
guy [Wed, 6 Aug 2003 18:16:21 +0000 (18:16 +0000)]
As per Bernd Becker's suggestion, add "register_giop_user_module()" and
"delete_giop_user_module()" to the list of exported functions on
platforms where a run-time loaded module can't directly access functions
from the main program.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8143 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't trust the payload length in SCTP DATA chunks to be bigger than the
guy [Wed, 6 Aug 2003 07:17:58 +0000 (07:17 +0000)]
Don't trust the payload length in SCTP DATA chunks to be bigger than the
data chunk header length.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8142 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove the reference to the nonexistent packet-lwres.h; it was tripping up
gerald [Wed, 6 Aug 2003 03:04:24 +0000 (03:04 +0000)]
Remove the reference to the nonexistent packet-lwres.h; it was tripping up
distcheck.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8141 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Solomon Peachy: signal strength is signed, not unsigned.
guy [Tue, 5 Aug 2003 19:09:27 +0000 (19:09 +0000)]
From Solomon Peachy: signal strength is signed, not unsigned.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8140 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix up white space.
guy [Tue, 5 Aug 2003 17:45:52 +0000 (17:45 +0000)]
Fix up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8139 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Tomas Kukosa:
guy [Tue, 5 Aug 2003 17:39:23 +0000 (17:39 +0000)]
From Tomas Kukosa:

use the codeset value;

allow subdissectors for user-specific IEs, and for codesets, to
be registered.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8138 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Roland: get rid of "ip_to_str()", as it's just a copy of the
guy [Tue, 5 Aug 2003 17:12:07 +0000 (17:12 +0000)]
From Lars Roland: get rid of "ip_to_str()", as it's just a copy of the
standard one in the Ethereal core, so that the plugin compiles on
Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8137 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Roland: make Makefile.nmake for lwres resemble the newer
guy [Tue, 5 Aug 2003 17:09:54 +0000 (17:09 +0000)]
From Lars Roland: make Makefile.nmake for lwres resemble the newer
Makefile.nmakes for other plugins, to make it build on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8136 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe source and destination networks are FT_IPXNET, not an integral type,
guy [Tue, 5 Aug 2003 05:45:04 +0000 (05:45 +0000)]
The source and destination networks are FT_IPXNET, not an integral type,
so use "proto_tree_add_ipxnet" routines, not "proto_tree_add_uint"
routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8135 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd the usual .cvsignore file.
guy [Tue, 5 Aug 2003 05:11:44 +0000 (05:11 +0000)]
Add the usual .cvsignore file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8134 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoLWRES support, from Oleg Terletsky.
guy [Tue, 5 Aug 2003 05:09:37 +0000 (05:09 +0000)]
LWRES support, from Oleg Terletsky.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8133 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Greg Morris: add support for case-insensitive full-text searches.
guy [Tue, 5 Aug 2003 00:01:27 +0000 (00:01 +0000)]
From Greg Morris: add support for case-insensitive full-text searches.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8132 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Greg Morris, with some changes: add "ipx.net", "ipx.node", and
guy [Mon, 4 Aug 2003 23:55:39 +0000 (23:55 +0000)]
From Greg Morris, with some changes: add "ipx.net", "ipx.node", and
"ipx.socket" hidden fields, which appear both for the source and
destination addresses and socket numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8131 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lo�c Minier: if the field name for "x-wap.tod" is shown as a text
guy [Mon, 4 Aug 2003 23:36:13 +0000 (23:36 +0000)]
From Lo�c Minier: if the field name for "x-wap.tod" is shown as a text
string, decode the value as a text string, as per 1.0, section 8.4.1.2
("Field Values"):

If the field name is encoded in text format, textual values MUST
be used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8130 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRegister as a heuristic subdissector of SCTP.
guy [Mon, 4 Aug 2003 23:13:39 +0000 (23:13 +0000)]
Register as a heuristic subdissector of SCTP.

Doing so obviates the need to register the dissector by name (that was
done to let the SCTP dissector explicitly call the SIP dissector), so
don't bother doing so.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8129 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDissect some more set attr calls ...
sharpe [Mon, 4 Aug 2003 22:28:57 +0000 (22:28 +0000)]
Dissect some more set attr calls ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8128 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAllow hyphens in preference module names, as the WAP protocols have IANA
guy [Mon, 4 Aug 2003 17:32:46 +0000 (17:32 +0000)]
Allow hyphens in preference module names, as the WAP protocols have IANA
names, which include hyphens.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8127 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoBuild with Glib 2.0 and GTK+ 1.3 by default. Don't build with zlib 1.13.
gerald [Mon, 4 Aug 2003 14:34:17 +0000 (14:34 +0000)]
Build with Glib 2.0 and GTK+ 1.3 by default.  Don't build with zlib 1.13.
Add minor updates to README.win32.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8126 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Roland: add support for GTK+ 1.3 with GLib 2.0 (the latest
guy [Mon, 4 Aug 2003 08:10:33 +0000 (08:10 +0000)]
From Lars Roland: add support for GTK+ 1.3 with GLib 2.0 (the latest
GTK+ 1.3[.x]-for-Win32, which fixes several GTK+ problems, requires GLib
2.0, not GLib 1.3).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8125 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUCD SNMP sometimes puts newlines into the printable form of an SNMP
guy [Mon, 4 Aug 2003 07:38:15 +0000 (07:38 +0000)]
UCD SNMP sometimes puts newlines into the printable form of an SNMP
value; turn those newlines into spaces, as the text for a protocol tree
item shouldn't contain newlines (or tabs, or any other non-printable
characters).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8124 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGuy suggested that the dcerpc opnum value_string code could be simplified
tpot [Mon, 4 Aug 2003 02:49:04 +0000 (02:49 +0000)]
Guy suggested that the dcerpc opnum value_string code could be simplified
somewhat.  Now the dynamic initialisation of the value_string is contained
in the value_string_from_subdissectors() function instead of being
distributed amongst the dcerpc dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8123 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd packet-h245.h to the distribution.
gerald [Mon, 4 Aug 2003 00:17:55 +0000 (00:17 +0000)]
Add packet-h245.h to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8122 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a heuristic dissector list for SCTP.
guy [Sat, 2 Aug 2003 01:00:06 +0000 (01:00 +0000)]
Add a heuristic dissector list for SCTP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8121 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agomake h225 register detected h245 tcp ports so that h245 dissector is called.
sahlberg [Fri, 1 Aug 2003 10:11:54 +0000 (10:11 +0000)]
make h225 register detected h245 tcp ports so that h245 dissector is called.

it is currently done in a way too crude way,
when a h245 endpoint is found,  it calls dissector_add("tcp.port",...) and
thus registers it globally for this port for ALL ip addresses.

if someone knows how to change it to only register it for
<ipaddress><tcpport> instead, that would be much better.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8120 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix bug on how the H.225 CS routines were registered so that H225 CS over Q931 now...
sahlberg [Fri, 1 Aug 2003 09:16:47 +0000 (09:16 +0000)]
Fix bug on how the H.225 CS routines were registered  so that H225 CS over Q931 now works

Still something wrong with NonStandardParameter,   I cant find why ethereal is
wrong but it misses misses one bit in the decoding causing malformed frames.
I cant see what is wrong when looking at the packets.   need furhter investigations.

Make h225 compile in as default

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8119 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Chris Heath: fix up the check for printable ASCII done on Windows
guy [Fri, 1 Aug 2003 01:39:01 +0000 (01:39 +0000)]
From Chris Heath: fix up the check for printable ASCII done on Windows
not to include DEL as printable ASCII.

Also change the check in strutil.c to do it by redefining "isprint()",
as is done in "gtk/gtkglobals.h", rather than by #ifdeffing the point at
which the test is done.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8118 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Tomas Kukosa: set FD_DEGRAGMENTED even if there's only one
guy [Thu, 31 Jul 2003 21:55:22 +0000 (21:55 +0000)]
From Tomas Kukosa: set FD_DEGRAGMENTED even if there's only one
fragment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8117 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Tomas Kukosa: add "find_dissector_table()",
guy [Thu, 31 Jul 2003 18:34:52 +0000 (18:34 +0000)]
From Tomas Kukosa: add "find_dissector_table()",
"dissector_get_port_handle()", "dissector_handle_get_short_name()",
"dissector_handle_get_protocol_index()", "new_register_dissector()", and
"new_create_dissector_handle()" to the list of APIs available to
plugins on platforms where plugins have to call core Ethereal routines
through pointers.

"extern"alize the remaining routines in "epan/packet.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8116 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Ruud Linders:
guy [Thu, 31 Jul 2003 18:14:02 +0000 (18:14 +0000)]
From Ruud Linders:

"UPDATE" is now a valid sip method;

register the SIP decoder so it can be called from other
protocols (i.e. SCTP).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8115 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Bernd Leibing: catch another place where we weren't checking
guy [Thu, 31 Jul 2003 18:09:08 +0000 (18:09 +0000)]
From Bernd Leibing: catch another place where we weren't checking
whether the domain name was null before putting it into the Info column.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8114 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoinitial test h225 dissector.
sahlberg [Thu, 31 Jul 2003 10:35:07 +0000 (10:35 +0000)]
initial test h225 dissector.
not enabled yet by default.

to test it you have to edit the makefiles and recompile.
still buggy and incomplete but feel free to test it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8113 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdated some restricted character set alphabets so that the characters are in the...
sahlberg [Thu, 31 Jul 2003 10:28:12 +0000 (10:28 +0000)]
Updated some restricted character set alphabets so that the characters are in the correct order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8112 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdates to OCTET STRING so that it can handle FT_STRING and not just FT_BYTES
sahlberg [Thu, 31 Jul 2003 10:26:36 +0000 (10:26 +0000)]
Updates to OCTET STRING so that it can handle FT_STRING and not just FT_BYTES

Added decoding of unicode strings in BMPString dissector helper

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8111 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGive FT_IPv4 val_repr_len and val_to_repr methods, and use them for
guy [Thu, 31 Jul 2003 04:18:01 +0000 (04:18 +0000)]
Give FT_IPv4 val_repr_len and val_to_repr methods, and use them for
generating display filters from FT_IPv4 fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8110 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd val_repr_len and val_to_repr methods for FT_FLOAT and FT_DOUBLE, and
guy [Thu, 31 Jul 2003 03:52:43 +0000 (03:52 +0000)]
Add val_repr_len and val_to_repr methods for FT_FLOAT and FT_DOUBLE, and
use them when generating display filters to match field values.  Use
"%{FLT_DIG}g" rather than "%{FLT_DIG}f" for FT_FLOAT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8109 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a typo.
guy [Wed, 30 Jul 2003 23:18:55 +0000 (23:18 +0000)]
Fix a typo.

Wrap text to 80 columns.

Add myself to the authors list (e.g. for the portability section).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8108 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGive FT_ABSOLUTE_TIME and FT_RELATIVE_TIME val_repr_len and val_to_repr
guy [Wed, 30 Jul 2003 22:50:39 +0000 (22:50 +0000)]
Give FT_ABSOLUTE_TIME and FT_RELATIVE_TIME val_repr_len and val_to_repr
methods, and use them when constructing display filters.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8107 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoEscape double-quotes, while you're at it.
guy [Wed, 30 Jul 2003 22:25:35 +0000 (22:25 +0000)]
Escape double-quotes, while you're at it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8106 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoEscape backslashes in strings when generating the dfilter representation
guy [Wed, 30 Jul 2003 22:20:04 +0000 (22:20 +0000)]
Escape backslashes in strings when generating the dfilter representation
of the string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8105 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a typo.
guy [Wed, 30 Jul 2003 22:08:45 +0000 (22:08 +0000)]
Fix a typo.

Note that, inside double quotes, you must escape backslashes with
backslashes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8104 f5534014-38df-0310-8fa8-9805f1628bb7

20 years ago"read_string()" can return a null pointer for the string, so check for
guy [Wed, 30 Jul 2003 08:08:52 +0000 (08:08 +0000)]
"read_string()" can return a null pointer for the string, so check for
that.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8103 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCrude workaround for a deficiency in the MEGACO parser - it assumes that
guy [Wed, 30 Jul 2003 06:28:55 +0000 (06:28 +0000)]
Crude workaround for a deficiency in the MEGACO parser - it assumes that
all packets have an "=" in them, which TransactionResponseAcks do not.
Check some of the "tvb_find_guint8()" replies and give up if they return
-1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8102 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut "WTP" into the Info column for segmented invoke/result PDUs on which
guy [Tue, 29 Jul 2003 22:10:18 +0000 (22:10 +0000)]
Put "WTP" into the Info column for segmented invoke/result PDUs on which
we don't try to do reassembly, just as it's put in for other PDUs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8101 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Georg von Zezschwitz: don't pass segments other than the first
guy [Tue, 29 Jul 2003 22:02:38 +0000 (22:02 +0000)]
From Georg von Zezschwitz: don't pass segments other than the first
segment of a segmented invoke or result to subdissectors.

Show the payload of fragments other than the one that finishes
reassembly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8100 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAs suggested by Georg von Zezschwitz, check whether all the bytes of the
guy [Tue, 29 Jul 2003 21:30:32 +0000 (21:30 +0000)]
As suggested by Georg von Zezschwitz, check whether all the bytes of the
URI are present before processing it, to catch bogus length values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8099 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse GLib's macros for converting from host byte order to little-endian.
guy [Tue, 29 Jul 2003 20:50:39 +0000 (20:50 +0000)]
Use GLib's macros for converting from host byte order to little-endian.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8098 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoClean up argument names.
guy [Tue, 29 Jul 2003 20:49:32 +0000 (20:49 +0000)]
Clean up argument names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8097 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse GLib's macros for converting from host byte order to little-endian.
guy [Tue, 29 Jul 2003 20:41:19 +0000 (20:41 +0000)]
Use GLib's macros for converting from host byte order to little-endian.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8096 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't free "wdh->dump.opaque" in the close routine - "wtap_dump_close()"
guy [Tue, 29 Jul 2003 20:30:00 +0000 (20:30 +0000)]
Don't free "wdh->dump.opaque" in the close routine - "wtap_dump_close()"
does it for you.

"wdh->dump.opaque" should never be null, so unconditionally call
"lanalyzer_dump_header()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8095 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse "guint16" and "guint32" for items in data records, rather than
guy [Tue, 29 Jul 2003 20:26:34 +0000 (20:26 +0000)]
Use "guint16" and "guint32" for items in data records, rather than
"unsigned short", "unsigned int" (or "int", as the items appear to be
unsigned), or "unsigned long".

Convert data to and from the appropriate byte order.

Don't free the private data structure in the dumper's close routine -
"wtap_dump_close()" does that for you.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8094 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Thierry Martin: support for reading files from Accellent 5Views LAN
guy [Tue, 29 Jul 2003 19:42:01 +0000 (19:42 +0000)]
From Thierry Martin: support for reading files from Accellent 5Views LAN
agents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8093 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agofix minor bugs in h245 decoding
sahlberg [Tue, 29 Jul 2003 08:59:14 +0000 (08:59 +0000)]
fix minor bugs in h245 decoding

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8092 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate PER so that the bit that indicates whether an extension is encoded or not
sahlberg [Tue, 29 Jul 2003 07:57:22 +0000 (07:57 +0000)]
Update PER so that the bit that indicates whether an extension is encoded or not
is displayed in the tree for CHOICE constructs when internal PER fields are displayed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8091 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate to RPC, prettiry the presentation of duplicates.
sahlberg [Tue, 29 Jul 2003 07:30:58 +0000 (07:30 +0000)]
Update to RPC,  prettiry the presentation of duplicates.
Only cosmetic changes, no functionality change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8090 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoupdate to PER to decode PrintableString properly
sahlberg [Tue, 29 Jul 2003 07:25:14 +0000 (07:25 +0000)]
update to PER to decode PrintableString properly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8089 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe NetInfo parent server address is an IPv4 address, and the NetInfo
guy [Tue, 29 Jul 2003 00:35:55 +0000 (00:35 +0000)]
The NetInfo parent server address is an IPv4 address, and the NetInfo
parent server tag is a string.

Also, it's "NetInfo", not "Netinfo".

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8088 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdates to the MEGACO plugin so that it will call the H.245 dissector for some
sahlberg [Sat, 26 Jul 2003 04:51:08 +0000 (04:51 +0000)]
Updates to the MEGACO plugin so that it will call the H.245 dissector for some
instancews where megaco encapsulates h.245

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8087 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of carriage returns - some compilers don't like them.
guy [Fri, 25 Jul 2003 17:57:09 +0000 (17:57 +0000)]
Get rid of carriage returns - some compilers don't like them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8086 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove some warnings from gcc.
gram [Fri, 25 Jul 2003 04:17:37 +0000 (04:17 +0000)]
Remove some warnings from gcc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8085 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix signed/unsigned comparison warnings.
gram [Fri, 25 Jul 2003 04:11:51 +0000 (04:11 +0000)]
Fix signed/unsigned comparison warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8084 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd to the fundamental types passed between the scanner and the parser.
gram [Fri, 25 Jul 2003 03:44:05 +0000 (03:44 +0000)]
Add to the fundamental types passed between the scanner and the parser.
Besides "STRING", there is now "UNPARSED_STRING", where the distinction
is that "STRING" was a double-quoted string and "UNPARSED_STRING" is just
a sequence of characters that the scanner didn't know how to scan/parse,
so it's up to the Ftype to parse it.

This gives us more flexibility and prepares the dfilter parsing engine
for the upcoming addition of the "contains" operator.

In the process of doing this, I also re-did the double-quoted string
support in the scanner, so that instead of the naively-simple support we
used to have, double-quoted strings now can have embedded dobule-quotes,
embedded octal sequences, and embedded hexadecimal sequences:
    "\""    embedded double-quote
    "\110"  embedded octal
    "\x48"  embedded hex

Enhance the dfilter unit test script to be able to run a single collection
of tests instead of having to run all of them all the time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8083 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lars Roland: add a preference to control whether, in the TCP
guy [Thu, 24 Jul 2003 21:11:20 +0000 (21:11 +0000)]
From Lars Roland: add a preference to control whether, in the TCP
dissector, heuristic dissectors should be checked before, or after,
dissectors for specific port numbers.

Add a similar preference for UDP.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8082 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Markus Seehofer: check the correct byte (the second byte, not the
guy [Thu, 24 Jul 2003 20:46:26 +0000 (20:46 +0000)]
From Markus Seehofer: check the correct byte (the second byte, not the
first byte) in a host membership query to distinguish between IGMPv1 and
IGMPv2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8081 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jean-Baptiste Marchand: add descriptions of permissions for
guy [Thu, 24 Jul 2003 20:33:22 +0000 (20:33 +0000)]
From Jean-Baptiste Marchand: add descriptions of permissions for
SAM_SERVER and SAM_USER objects in SAMR.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8080 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoInitial Laplink support, from Brad Hards.
guy [Thu, 24 Jul 2003 20:22:50 +0000 (20:22 +0000)]
Initial Laplink support, from Brad Hards.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8079 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove an extra comma.
gerald [Thu, 24 Jul 2003 01:41:34 +0000 (01:41 +0000)]
Remove an extra comma.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8078 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFinal updates for 0.9.14.
gerald [Wed, 23 Jul 2003 23:14:57 +0000 (23:14 +0000)]
Final updates for 0.9.14.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@8076 f5534014-38df-0310-8fa8-9805f1628bb7