obnox/wireshark/wip.git
17 years agoFix for bug 1098. Add BPDU dissector to ethertype 0x8181.
jake [Tue, 12 Sep 2006 12:58:16 +0000 (12:58 +0000)]
Fix for bug 1098. Add BPDU dissector to ethertype 0x8181.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19211 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofrom Taner Kurtulus and Menno Andriesse
sahlberg [Tue, 12 Sep 2006 12:08:34 +0000 (12:08 +0000)]
from Taner Kurtulus and Menno Andriesse

Hi folks,
We think we've found a bug in STANAG 5066 SIS layer dissector.

Problem is at S_EXPEDITED_UNIDATA_INDICATION S_Prim's parser
and occurs when we receive a U_PDU via expedited unidata channel.
Dissector tries to parse first 2 bytes of U_PDU as a header size of  type
21 s_prim (S_UNIDATA_INDICATION). But, this is not an wanted  process on
that parser. Maybe, it was forgotten unchanged from
S_UNIDATA_INDICATION dissector while copying it. So it shows
data (U_PDU) 2 bytes short. Moreover, if data is just 1-byte, TCP datagrams
receive TCP checksum error.

Confirmed.

It was indeed a "copy-paste-did not edit correctly" bug.

While going over the code once more, I found:

1 - One bug in the heuristic. (Changed '&&' to '||')
2 - One to-do that was already done. (Removed the /* TODO */)
3 - One to-do that is now done. ;-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19210 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofrom Florian Lohoff
sahlberg [Tue, 12 Sep 2006 11:51:48 +0000 (11:51 +0000)]
from Florian Lohoff

Hi,
after using the redback dissector again i found some more protocol
types:

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19209 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofrom bryant eastham
sahlberg [Tue, 12 Sep 2006 11:39:51 +0000 (11:39 +0000)]
from bryant eastham

Also, there is still an outstanding issue regarding the default use of
the "media" dissector. The way it is currently coded there is no way to
have a heuristic decoder when a content-type header is specified.

In this way if there is a decoder for a specific content-type then it
will be used, then the heuristic decoders have a chance, and finally the
default of either the media-type decoder of the http_payload decoder.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19208 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoVarious small fixes and prettifications
martinm [Tue, 12 Sep 2006 11:36:42 +0000 (11:36 +0000)]
Various small fixes and prettifications

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19207 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoput the ah and esp payload as its own top level expansion in the tree instead of...
sahlberg [Tue, 12 Sep 2006 10:04:11 +0000 (10:04 +0000)]
put the ah and esp payload as its own top level expansion in the tree instead of as an expansion inside the ah/esp layer.

since source/dest/protocol/info is updated by the content of the payload    it doesnt make sense to hide the actual payload inside esp/ah
it just would look confusing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19206 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agothe name of the protocol is IPsec, not IP-sec
sahlberg [Tue, 12 Sep 2006 10:02:28 +0000 (10:02 +0000)]
the name of the protocol is IPsec, not IP-sec

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19205 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoprettify dissection of ESP
sahlberg [Tue, 12 Sep 2006 09:53:10 +0000 (09:53 +0000)]
prettify dissection of ESP

show the IV as a hexadecimal
show the protocol name for the Next header field inside ESP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19204 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Replace the ELINKS variable by HTML2TEXT and include the parameters
jmayer [Tue, 12 Sep 2006 09:35:29 +0000 (09:35 +0000)]
- Replace the ELINKS variable by HTML2TEXT and include the parameters
  into the variable to make this actually portable.
- Some whitespace changes between filenames and the \

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19203 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd a missing dependency from wiretap to the image dir, otherwise image/wiretap.res...
ulfl [Tue, 12 Sep 2006 08:24:01 +0000 (08:24 +0000)]
add a missing dependency from wiretap to the image dir, otherwise image/wiretap.res can't be generated for some targets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19202 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agowireshark.res is generated in the image dir, so the paths for includes should be...
ulfl [Tue, 12 Sep 2006 08:22:02 +0000 (08:22 +0000)]
wireshark.res is generated in the image dir, so the paths for includes should be relative to /image and not to /

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19201 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd a comment, that .res files are generated using an implicit (built in) nmake rule
ulfl [Tue, 12 Sep 2006 08:19:39 +0000 (08:19 +0000)]
add a comment, that .res files are generated using an implicit (built in) nmake rule

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19200 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoHmmm, don't optimize too much :-)
ulfl [Tue, 12 Sep 2006 01:04:35 +0000 (01:04 +0000)]
Hmmm, don't optimize too much :-)

also fix the clean_setup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19199 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agovarious nmake related build file cleanups
ulfl [Tue, 12 Sep 2006 00:27:03 +0000 (00:27 +0000)]
various nmake related build file cleanups

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19198 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremove obsolete "HAVE_AIRPCAP_API" comment
ulfl [Tue, 12 Sep 2006 00:23:46 +0000 (00:23 +0000)]
remove obsolete "HAVE_AIRPCAP_API" comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19197 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agotweak the nmake build so the NET-SNMP library is in fact optional (as it is in the...
ulfl [Mon, 11 Sep 2006 22:47:57 +0000 (22:47 +0000)]
tweak the nmake build so the NET-SNMP library is in fact optional (as it is in the UNIX builds)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19196 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agolet the user only specify the PortAudio version and do the "ugly details" in the...
ulfl [Mon, 11 Sep 2006 22:43:00 +0000 (22:43 +0000)]
let the user only specify the PortAudio version and do the "ugly details" in the part below, just as we do it for most other libs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19195 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoa proxy might also be specified using .wgetrc, so don't switch off the proxy explicitly
ulfl [Mon, 11 Sep 2006 22:37:46 +0000 (22:37 +0000)]
a proxy might also be specified using .wgetrc, so don't switch off the proxy explicitly

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19194 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAs no one seems to update the install information in this file (including me), remove...
ulfl [Mon, 11 Sep 2006 22:34:29 +0000 (22:34 +0000)]
As no one seems to update the install information in this file (including me), remove most of the installation text and mention the User's Guide instead.

Some minor updates in the development section as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19193 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd missing libraries: GNUTLS, Gcrypt, Kerberos, LUA, PortAudio (please check if...
ulfl [Mon, 11 Sep 2006 22:30:12 +0000 (22:30 +0000)]
add missing libraries: GNUTLS, Gcrypt, Kerberos, LUA, PortAudio (please check if it's correct)

fix a lot of broken URL's

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19192 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd the LUA plugin install option
ulfl [Mon, 11 Sep 2006 20:41:32 +0000 (20:41 +0000)]
add the LUA plugin install option

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19191 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091
etxrab [Mon, 11 Sep 2006 20:35:24 +0000 (20:35 +0000)]
Fix bug bugs.wireshark.org/bugzilla/show_bug.cgi?id=1091

h248_handle was declared localy, udp port was not added at register.

Added a few more packagenames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19190 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdded E-DCH (HSUPA) channels to FP.
martinm [Mon, 11 Sep 2006 12:03:29 +0000 (12:03 +0000)]
Added E-DCH (HSUPA) channels to FP.
Also show VPI/VCI/CID in ATM protocol label.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19189 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoVRRPver3 support fixed: Count restored, Auth Type is reserved field.
jake [Sun, 10 Sep 2006 18:48:33 +0000 (18:48 +0000)]
VRRPver3 support fixed: Count restored, Auth Type is reserved field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19188 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Alejandro Vaquero:
etxrab [Sun, 10 Sep 2006 18:03:22 +0000 (18:03 +0000)]
From Alejandro Vaquero:
Need to use HAVE_LIBPORTAUDIO instead
of PORTAUDIO_DIR in voip_calls.c

And build the windows version with Port audio.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19187 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for bug 1045
sahlberg [Sun, 10 Sep 2006 14:34:57 +0000 (14:34 +0000)]
fix for bug 1045

windows in SYN and SYN+ACK packets are not scaled so dont apply window scaling to them when displaying them in the tree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19186 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoimplement support to reassemble tcp sessions until the end of the session (FIN)
sahlberg [Sun, 10 Sep 2006 14:03:08 +0000 (14:03 +0000)]
implement support to reassemble tcp sessions until the end of the session (FIN)

add required code to the http (and others) code in req_resp_hdrs.c to signal to tcp
when it wants a session to be reassembled to the FIN.

This is currently done for all HTTP packets where we have a Content-type in the header but no content-length.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19185 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agominor cleanup for making codecs
wmeier [Sun, 10 Sep 2006 13:37:42 +0000 (13:37 +0000)]
minor cleanup for making codecs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19184 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoswitch off draft mode, so the PDF generation won't try to load a draft image from...
ulfl [Fri, 8 Sep 2006 07:45:22 +0000 (07:45 +0000)]
switch off draft mode, so the PDF generation won't try to load a draft image from the web

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19183 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd dependency to custom_layer_pdf.xsl for all fo files
ulfl [Fri, 8 Sep 2006 07:44:22 +0000 (07:44 +0000)]
add dependency to custom_layer_pdf.xsl for all fo files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19182 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Frédéric Roudaut:
etxrab [Fri, 8 Sep 2006 07:32:13 +0000 (07:32 +0000)]
From Frédéric Roudaut:
as requested  here is a patch  in order to take into account  Encryption
and Authentication keys for ESP in hexa.
You only have to write your key with 0x first. In this case if the key
is not in 8-bit unit, it will be considered as starting with a "0" (4 bits). Excepted this case, the key should be completely written, even if it
starts with "0x00".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19181 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMove the code to handle ISO protocols over TCP/TPKT to packet-osi.c where it belongs.
etxrab [Fri, 8 Sep 2006 06:58:40 +0000 (06:58 +0000)]
Move the code to handle ISO protocols over TCP/TPKT to packet-osi.c where it belongs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19180 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago. is not necessarily in /home/jmayer/bin:/usr/local/bin:/usr/bin:/usr/X11R6/bin:...
jmayer [Fri, 8 Sep 2006 02:25:55 +0000 (02:25 +0000)]
. is not necessarily in /home/jmayer/bin:/usr/local/bin:/usr/bin:/usr/X11R6/bin:/bin:/usr/games:/opt/gnome/bin:/opt/kde3/bin:/opt/cross/bin:/usr/lib/jvm/jre/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin:/sbin:/usr/sbin:/usr/local/sbin:/sbin:/usr/sbin:/usr/local/sbin, so add it

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19179 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agopropset svn:executable
jmayer [Thu, 7 Sep 2006 23:44:22 +0000 (23:44 +0000)]
propset svn:executable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19178 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoremoved options.
lego [Thu, 7 Sep 2006 22:38:16 +0000 (22:38 +0000)]
removed options.

now it can either be called as

make-sminmpec.pl

so it will fetch the file only if it has been modified since we last loaded it

or

make-sminmpec.pl enterprise-numbers

to regenerate the C file from the given file.

Luis

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19177 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agotweak some expert infos so they better work with the composite dialog (e.g. remove...
ulfl [Thu, 7 Sep 2006 20:35:26 +0000 (20:35 +0000)]
tweak some expert infos so they better work with the composite dialog (e.g. remove some minor details)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19176 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd some probable protocol IDs from the DCOM specs
ulfl [Thu, 7 Sep 2006 20:33:02 +0000 (20:33 +0000)]
add some probable protocol IDs from the DCOM specs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19175 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agodistinguish between things "ToBeDone" and "NoSpecificationAvailable" as some DCOM...
ulfl [Thu, 7 Sep 2006 20:30:48 +0000 (20:30 +0000)]
distinguish between things "ToBeDone" and "NoSpecificationAvailable" as some DCOM things are just unknown and cannot be implemented therefore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19174 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix bug #842: "make" now won't try to rebuild again if nothing changed since the...
ulfl [Thu, 7 Sep 2006 20:01:07 +0000 (20:01 +0000)]
fix bug #842: "make" now won't try to rebuild again if nothing changed since the last make call.
Other minor dependency fixes.

I didn't found a way to implement the SVN version check using make, so using a new shell script instead ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19173 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Andrew Feren:
lego [Thu, 7 Sep 2006 16:16:51 +0000 (16:16 +0000)]
From Andrew Feren:
This adds some features to update enterprise-numbers from the web.

As used in the Makefile currently
 make-sminmpec.pl <infile> <outfile.c>

works exactly the same.  Additionally <infile> can be a URL to an infile in
the expected format.

Using the new "-gen" switch will create a new <infile>

example:
make-sminmpec.pl -gen \
   http://www.iana.org/assignments/enterprise-numbers \
   enterprise-numbers

other than that I modified so that calling it like
make-sminmpec.pl -gen
be like
make-sminmpec.pl -gen \
 http://www.iana.org/assignments/enterprise-numbers \
 sminmpec.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19172 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUpdate from samba tree revision 17666 to 18221
jmayer [Thu, 7 Sep 2006 13:22:45 +0000 (13:22 +0000)]
Update from samba tree revision 17666 to 18221
============================ Samba log start ============
svn: When specifying working copy paths, only one target may be given
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19171 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago pidl now handles empty bitmaps properly so no need for the dummy (dont trigger empty...
sahlberg [Thu, 7 Sep 2006 10:53:32 +0000 (10:53 +0000)]
 pidl now handles empty bitmaps properly so no need for the dummy (dont trigger empty bitmapbug entry)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19170 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoThe last update to FindGTK2.cmake was incompatible with it's use.
jmayer [Wed, 6 Sep 2006 22:59:25 +0000 (22:59 +0000)]
The last update to FindGTK2.cmake was incompatible with it's use.
Fix a bug and adapt CMakeLists.txt to the new usage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19169 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agocmake/
jmayer [Wed, 6 Sep 2006 22:28:19 +0000 (22:28 +0000)]
cmake/
Add some more (hackish) tests.
Add a LICENSE file until I find the time to add it to all
files individually.

CMakeLists.txt
Add some addiotional stuff regarding options.
Add (non-working) code to generate config.h
Handle GTK1 vs GTK2 and GLIB1 vs GLIB2

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19168 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd cmake-modules URL
jmayer [Wed, 6 Sep 2006 22:14:20 +0000 (22:14 +0000)]
Add cmake-modules URL

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19167 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUpdate to newer version of the file from
jmayer [Wed, 6 Sep 2006 22:13:52 +0000 (22:13 +0000)]
Update to newer version of the file from
http://cmake-modules.googlecode.com/svn/trunk/

This update adds a license text (dual: GPLv2 and 3 clause BSD)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19166 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUpdate enterprise-numbers
jake [Wed, 6 Sep 2006 21:08:24 +0000 (21:08 +0000)]
Update enterprise-numbers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19165 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoDissect some more common control messages
martinm [Wed, 6 Sep 2006 14:08:40 +0000 (14:08 +0000)]
Dissect some more common control messages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19164 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for the typo in bug 1094
sahlberg [Wed, 6 Sep 2006 08:36:13 +0000 (08:36 +0000)]
fix for the typo in bug 1094

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19163 f5534014-38df-0310-8fa8-9805f1628bb7

17 years ago- Make options filterable
jmayer [Wed, 6 Sep 2006 08:24:36 +0000 (08:24 +0000)]
- Make options filterable
- Display options in info column
- Only remember blksize from OACK packets
- Add some rfc numbers
- Move tftp_dissect_options in front of dissect_tftp
  (I forgot to fix the forward decl once too often ;)
- Warning fixes
- Add expert error in case of tftp-error pdu

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19162 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd comments about PORTAUDIO API version comment out use of PORTAUDIO library for...
etxrab [Wed, 6 Sep 2006 05:23:38 +0000 (05:23 +0000)]
Add comments about PORTAUDIO API version comment out use of PORTAUDIO library for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19161 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoNAME can also contain '_'
etxrab [Wed, 6 Sep 2006 05:22:05 +0000 (05:22 +0000)]
NAME can also contain '_'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19160 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoHandle PORTAUDIO_API_1 and add clean-deps target to distclean.
etxrab [Tue, 5 Sep 2006 20:35:41 +0000 (20:35 +0000)]
Handle PORTAUDIO_API_1 and add clean-deps target to distclean.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19159 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agooption name "blksize" is case in-sensitive
jmayer [Tue, 5 Sep 2006 16:09:49 +0000 (16:09 +0000)]
option name "blksize" is case in-sensitive

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19158 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMake smrse & radius dissectors findable by name
martinm [Tue, 5 Sep 2006 16:06:41 +0000 (16:06 +0000)]
Make smrse & radius dissectors findable by name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19157 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFor DCT2000, show better transport info:
martinm [Tue, 5 Sep 2006 16:05:23 +0000 (16:05 +0000)]
For DCT2000, show better transport info:
- for FP over AAL2, add CID to AAL tree
- for IPPRIM protocols, show IPV4 addresses in src & dst columns

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19156 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1092
jmayer [Tue, 5 Sep 2006 15:58:11 +0000 (15:58 +0000)]
Fix for bugs.wireshark.org/bugzilla/show_bug.cgi?id=1092
Actually, this was a feature request:

Store the value of the blksize option in the conversation data
and use that information to compare whether we have reached the
last packet.

Includes the cleanup ideas from Ronnie.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19155 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for bug 1054
sahlberg [Tue, 5 Sep 2006 15:13:39 +0000 (15:13 +0000)]
fix for bug 1054

there were instances where the function dissect_nt_sid() would not fill in the return pointer for the sid string
causing callers that rely on that this string will ALWAYS be assigned try to access and g_free() an uninitialized pointer.

dissect_nt_sid() should be changed to use and return ep allocated memory instead of gmalloced memory

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19154 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agofix for bug 1079
sahlberg [Tue, 5 Sep 2006 14:32:15 +0000 (14:32 +0000)]
fix for bug 1079

verify that stat_info->request_uri is non null before doing string manipulations on it
so that we dont try to dereference a null pointer further down the code

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19153 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix for bug 1093, as proposed by Atsushi Fukumoto
jake [Tue, 5 Sep 2006 12:22:44 +0000 (12:22 +0000)]
Fix for bug 1093, as proposed by Atsushi Fukumoto

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19152 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd some links for further reading
jmayer [Tue, 5 Sep 2006 12:04:46 +0000 (12:04 +0000)]
Add some links for further reading

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19151 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agopropset, add $Id: $ and copyright headers
jmayer [Tue, 5 Sep 2006 09:50:45 +0000 (09:50 +0000)]
propset, add $Id: $ and copyright headers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19150 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoOK, as I haven't had any negative feedback, I'm adding my work
jmayer [Tue, 5 Sep 2006 09:27:22 +0000 (09:27 +0000)]
OK, as I haven't had any negative feedback, I'm adding my work
to use cmake as a build system. It's in no way complete, I'd
just like others to be able to participate in playing with cmake
and to document what I'm doing.

Please read the README.cmake for what can be done right now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19149 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agortp_player.c will now compile with the new API, although it will not
jmayer [Tue, 5 Sep 2006 09:17:55 +0000 (09:17 +0000)]
rtp_player.c will now compile with the new API, although it will not
actually do something useful except to print that the new API is not
supported.

Adapt acinclude.m4 to provide PORTAUDIO_API_1 and add back the
check_message to indicate *why* we are checking for the type.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19148 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdded some files to svn:ignore
jmayer [Tue, 5 Sep 2006 09:14:18 +0000 (09:14 +0000)]
Added some files to svn:ignore

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19147 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMove the include of rtp_player.h after the include of stuff it needs,
guy [Tue, 5 Sep 2006 07:58:14 +0000 (07:58 +0000)]
Move the include of rtp_player.h after the include of stuff it needs,
and include rtp_analysis.h as well, as it declares something else
rtp_player.h needs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19146 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Stephen Fisher:
etxrab [Tue, 5 Sep 2006 05:38:11 +0000 (05:38 +0000)]
From Stephen Fisher:
A patch to bring the VNC dissector almost to completion.

I have not had a chance to finish the server message type "frame buffer
update," which are the pixel values for screen rectangle updates.
Everything else is there - tracking the keys the user is pushing,
ringing a bell on the client, mouse button pushes/pointer movements,
etc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19145 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoComment #endifs so you can tell what they match.
guy [Mon, 4 Sep 2006 23:23:16 +0000 (23:23 +0000)]
Comment #endifs so you can tell what they match.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19144 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoBuild with rtp_player.c.
guy [Mon, 4 Sep 2006 23:22:39 +0000 (23:22 +0000)]
Build with rtp_player.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19143 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd RCS IDs, introductory comments, and multiple-include protection.
guy [Mon, 4 Sep 2006 23:21:52 +0000 (23:21 +0000)]
Add RCS IDs, introductory comments, and multiple-include protection.
Remove extra blank lines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19142 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoDeclare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
guy [Mon, 4 Sep 2006 23:20:52 +0000 (23:20 +0000)]
Declare "dissect_h248_Name()" and "dissect_h248_Value()" before they're
used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19141 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAC_CHECK_TYPE outputs a "Checking..." message; we don't need to issue
guy [Mon, 4 Sep 2006 22:47:16 +0000 (22:47 +0000)]
AC_CHECK_TYPE outputs a "Checking..." message; we don't need to issue
one ourselves.

The documentation for autoconf isn't very clear on the "includes"
argument to AC_CHECK_TYPE - it's in the form of a list of #include
statements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19140 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix(?) bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
etxrab [Mon, 4 Sep 2006 21:07:35 +0000 (21:07 +0000)]
Fix(?) bug bugs.wireshark.org/bugzilla/show_bug.cgi?id=1042
Does the string need to be freed ad destruction of the hashtable?

Surplus add_text removed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19139 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAlways dissect SDP info to set up RTP conversation.
etxrab [Mon, 4 Sep 2006 20:36:52 +0000 (20:36 +0000)]
Always dissect SDP info to set up RTP conversation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19138 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix a typo for rtp_player
etxrab [Mon, 4 Sep 2006 18:11:02 +0000 (18:11 +0000)]
Fix a typo for rtp_player

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19137 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Oleg Kostenko:
etxrab [Mon, 4 Sep 2006 18:10:14 +0000 (18:10 +0000)]
From Oleg Kostenko:
This patch will add the following functionality to the H.248
 dissector:

 1. Dissection of properties from Annex C.11 SDP equivalents.

 2. Dissection of EventNames and SignalNames from Annex E Basic
Packages.

 3. Dissection of event and signal parameters from Annex E.9 Analog
 Line Supervision Package.

 4. Dissection of statistics from Annex E.11 Network Package and
 Annex E.12 RTP Package.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19136 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoCorrect some typos and add some comments.
etxrab [Mon, 4 Sep 2006 18:04:10 +0000 (18:04 +0000)]
Correct some typos and add some comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19135 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoThe previous way of (not) including portaudio support didn't
jmayer [Mon, 4 Sep 2006 14:19:12 +0000 (14:19 +0000)]
The previous way of (not) including portaudio support didn't
work reliably (at least it didn't work on my system).
Change it to just wrap the rtp_player.[hc] files into a
#if defined(...) #endif.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19134 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAfter some reading it is clear that the code was written for
jmayer [Mon, 4 Sep 2006 14:16:50 +0000 (14:16 +0000)]
After some reading it is clear that the code was written for
portaudio versions <= 18. At least Suse 10.1 provides a snapshot
of version 19, which, in turn has the brand new and incompatible
version 2.0 of the API. Change the error message to tell the
user that he needs portaudio <= 18.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19133 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom Donald White:
jake [Mon, 4 Sep 2006 14:12:26 +0000 (14:12 +0000)]
From Donald White:
First, the length of the header of a sub-frame may be miscalculated if
if the PID field is not present, but was present in a previous
sub-frame.  The calculation of the header length will use the value from
the previous sub-frame.

Second, correct the typo "ength" to "length".

Third, the length of the current sub-frame was not passed as the
reported length to a sub-dissector.  When the sub-dissector calls
tvb_reported_length(), the function returns the length of the complete
frame and not the length of the sub-frame to be dissected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19132 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoUse portaudio if it's there. Check that we have the right version.
jmayer [Mon, 4 Sep 2006 13:34:48 +0000 (13:34 +0000)]
Use portaudio if it's there. Check that we have the right version.
Note: This check is currently carried out by checking that the include
defines PortAudioStream. If you know of any better check, please let
me know.

acinclude.m4:
Replace sequences of 8 spaces by tab

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19131 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoPartial implementation of UMTS FP. Currently only works with Catapult DCT2000 format...
martinm [Mon, 4 Sep 2006 11:04:14 +0000 (11:04 +0000)]
Partial implementation of UMTS FP.  Currently only works with Catapult DCT2000 format files, as need extra information about packet when decoding.  There are a few TODOs (notably E-DCH channels), but the current version gives OK coverage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19130 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agokrb4 is a new style dissector and is called through a handle from krb5 which is also...
sahlberg [Mon, 4 Sep 2006 08:18:52 +0000 (08:18 +0000)]
krb4 is a new style dissector and is called through a handle from krb5 which is also new style.

use call_dissector_only()  which is new-style aware and not call_dissector() which is not.

this fixes a recent bug found on the heimdal list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19129 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agomake the heuristics for detecting kerberos4 stronger
sahlberg [Mon, 4 Sep 2006 07:44:30 +0000 (07:44 +0000)]
make the heuristics for detecting kerberos4 stronger

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19128 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAd $Id: § and reorder and reformat some comments in the header.
jmayer [Sun, 3 Sep 2006 15:41:42 +0000 (15:41 +0000)]
Ad $Id: § and reorder and reformat some comments in the header.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19127 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoComment out debug code.
etxrab [Sat, 2 Sep 2006 23:21:59 +0000 (23:21 +0000)]
Comment out debug code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19126 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFrom David Buechi
sahlberg [Sat, 2 Sep 2006 23:18:38 +0000 (23:18 +0000)]
From David Buechi
New protocol: epl v1

Hi,

in addition to the recently submitted dissector for the EPL v2 protocol,
this is the dissector for the first version of the EPL protocol.

Best Regards,
David

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19125 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoPackages can have digits and '/' in their names...
etxrab [Sat, 2 Sep 2006 16:56:22 +0000 (16:56 +0000)]
Packages can have digits and '/' in their names...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19124 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoInclude codecs in the all target.
etxrab [Sat, 2 Sep 2006 16:55:31 +0000 (16:55 +0000)]
Include codecs in the all target.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19123 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoRemove some extra output for MediaDescriptor.
etxrab [Sat, 2 Sep 2006 16:05:03 +0000 (16:05 +0000)]
Remove some extra output for MediaDescriptor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19122 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1080.
etxrab [Sat, 2 Sep 2006 15:50:24 +0000 (15:50 +0000)]
Fix bugs.wireshark.org/bugzilla/show_bug.cgi?id=1080.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19121 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoFix path and name.
etxrab [Sat, 2 Sep 2006 14:18:47 +0000 (14:18 +0000)]
Fix path and name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19120 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoadd primitive reassembly of gssapi
sahlberg [Sat, 2 Sep 2006 11:46:15 +0000 (11:46 +0000)]
add primitive reassembly of gssapi

this will allow reassembly of gssapi blobs that span multiple smb/sessionsetup command pdus

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19119 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoSquelch compiler warnings, and get rid of unused variables and
guy [Sat, 2 Sep 2006 07:18:16 +0000 (07:18 +0000)]
Squelch compiler warnings, and get rid of unused variables and
declarations.

Define functions with no arguments as such.

Clean up white space.

Declare tables in the codec .h files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19118 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoMove the codecs into a top-level "codecs" subdirectory; there's no
guy [Sat, 2 Sep 2006 06:39:43 +0000 (06:39 +0000)]
Move the codecs into a top-level "codecs" subdirectory; there's no
guarantee that all programs using the codecs will necessarily be using
GTK+.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19117 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoClean up indentation, etc.
guy [Sat, 2 Sep 2006 06:39:09 +0000 (06:39 +0000)]
Clean up indentation, etc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19116 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd a common routine for adding session IDs. Have it handle session IDs
guy [Sat, 2 Sep 2006 06:38:21 +0000 (06:38 +0000)]
Add a common routine for adding session IDs.  Have it handle session IDs
from 1 to 8 bytes, and not only handle 0-byte session IDs as special,
have it handle session IDs > 8 bytes as special as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19115 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoAdd brackets to squelch a compiler warning.
guy [Sat, 2 Sep 2006 06:36:42 +0000 (06:36 +0000)]
Add brackets to squelch a compiler warning.

Fix indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19114 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agobreak out the handling of conversation specific data so that we will always have...
sahlberg [Sat, 2 Sep 2006 02:03:26 +0000 (02:03 +0000)]
break out the handling of conversation specific data so that we will always have one such struct (and not an value pointer to an oid struct)
so that it is easier to attach other useage to the conversation specific state

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19113 f5534014-38df-0310-8fa8-9805f1628bb7

17 years agoresolve the oid to a variable before we check it in the conditional so that
sahlberg [Sat, 2 Sep 2006 00:43:19 +0000 (00:43 +0000)]
resolve the oid to a variable before we check it in the conditional so that
we can add code to check that it looks sane (for better heuristics) when
we start adding GSS-KRB reassembly.

we need this for some transports such as SMB/SessionSetup that will transport GSS-KRB blobs inside multiple PDUs (multiple different SMB/SessionSetups) so we can reassemble the blobs before decoding them.

this probably only happens for SMB/SessionSetup   but the design of that command is so "nice" that you can not tell whether the blob is fragmented or not or how big it is supposed to be by looking at the SMB layer itself, one needs to know the BER length field for the BER APPLICATION tag. :-(

to make things worse, the only way match multiple such fragments together one will need not just the fragments from the SessionSetup requests  but also the UID that is returned in the response to the initial request.
perverse design.

lets assume that there will almost never be multiple sessionsetups on the same tcp session in real traces    so to make things easier just ignore the UID for now when reassembling. (well reassembly is not added yet but will be)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19112 f5534014-38df-0310-8fa8-9805f1628bb7