obnox/wireshark/wip.git
19 years agoadd details for doxygen
ulfl [Mon, 31 May 2004 15:47:34 +0000 (15:47 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11046 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd details for doxygen
ulfl [Mon, 31 May 2004 13:42:58 +0000 (13:42 +0000)]
add details for doxygen

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11045 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosplit doxygen.cfg into common Ethereal things and module specifics
ulfl [Mon, 31 May 2004 13:42:17 +0000 (13:42 +0000)]
split doxygen.cfg into common Ethereal things and module specifics

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11044 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't try to destroy a dialog twice
ulfl [Mon, 31 May 2004 13:35:49 +0000 (13:35 +0000)]
bugfix: don't try to destroy a dialog twice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11043 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agodirectly use the file selection dialog instead of using an additional custom dialog
ulfl [Mon, 31 May 2004 12:06:28 +0000 (12:06 +0000)]
directly use the file selection dialog instead of using an additional custom dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11042 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosome more dialog redesign and code cleanup
ulfl [Mon, 31 May 2004 11:22:58 +0000 (11:22 +0000)]
some more dialog redesign and code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11041 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a routine that indicates where there are any tap listeners
guy [Mon, 31 May 2004 09:53:21 +0000 (09:53 +0000)]
Add a routine that indicates where there are any tap listeners
registered (not whether there are any tap *filters* registered).

Do dissection in Tethereal iff:

we're printing information about each packet;

we're using a read filter on the packets;

there are any tap listeners registered (even if there are no tap
filters registered - not all taps use filters).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11040 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agointerface options preference dialog: remove confusing second interface clist,
ulfl [Mon, 31 May 2004 09:23:14 +0000 (09:23 +0000)]
interface options preference dialog: remove confusing second interface clist,
fix a bug making garbage of user supplied interface description

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11039 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "-q" suppress packet printing when you're reading a capture file
guy [Mon, 31 May 2004 08:41:32 +0000 (08:41 +0000)]
Make "-q" suppress packet printing when you're reading a capture file
and not writing to another capture file, for use with "-z" options.

Note that "-z proto" *doesn't* print statistics at the end - it modifies
the packet summary output.

Note that on at least some BSDs the "status" character is set to "off"
by default, so you have to set it explicitly in order to be able to ^T
an application such as Tethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11038 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMove the packet counting, dissecting, and filtering out of the "write
guy [Mon, 31 May 2004 07:52:27 +0000 (07:52 +0000)]
Move the packet counting, dissecting, and filtering out of the "write
packet" and "print packet" callbacks into a common routine, so that we
don't count packets twice if we're counting and dissecting.

Print the packet count with ^T iff we're not updating a displayed packet
count as packets arrive, regardless of whether we're printing packet
information, saving packets to a file, or both (tcpdump prints it
regardless of whether it's printing packet information or saving packets
to a file).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11037 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe "key" argument to "write_recent_geom()" is required (as it's called
guy [Mon, 31 May 2004 02:42:39 +0000 (02:42 +0000)]
The "key" argument to "write_recent_geom()" is required (as it's called
through a pointer), but isn't used - mark it as unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11036 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd support for Exif decoding (initial framework).
obiot [Mon, 31 May 2004 01:24:03 +0000 (01:24 +0000)]
Add support for Exif decoding (initial framework).
Still lots of work to do here :)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11035 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosort saved preference settings by appearance in dialog
ulfl [Sun, 30 May 2004 18:27:52 +0000 (18:27 +0000)]
sort saved preference settings by appearance in dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11034 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders patch adds sub parameter dissection to the MGCP plugin
etxrab [Sun, 30 May 2004 17:58:35 +0000 (17:58 +0000)]
From Thomas Anders patch adds sub parameter dissection to the MGCP plugin
(plugins/mgcp/packet-mgcp.c), initially for the ConnectionParameters(P),
and updates/adds some specification references.

This patch makes the sub parameter values filterable as numbers and
may allow for improved MGCP statistics in the future.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11033 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosave window position/size/maximized state into recent file
ulfl [Sun, 30 May 2004 11:54:37 +0000 (11:54 +0000)]
save window position/size/maximized state into recent file
(only help dialog for now)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11032 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen we create a tvbuff for a security blob, set its reported length to
guy [Sat, 29 May 2004 06:55:52 +0000 (06:55 +0000)]
When we create a tvbuff for a security blob, set its reported length to
the reported length of the blob, not the amount of data available from
the blob.

Use "tvb_strneql()" when checking for strings, so that we don't throw an
exception if there's less data in the tvbuff than there are bytes in the
string, we just say "not equal".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11031 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Nathan Alger: update the VSA attributes for Juniper and
guy [Sat, 29 May 2004 04:41:25 +0000 (04:41 +0000)]
From Nathan Alger: update the VSA attributes for Juniper and
Juniper/Unisphere routers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11030 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSquelch a compiler warning by removing a "/*" from the middle of a
guy [Sat, 29 May 2004 04:34:51 +0000 (04:34 +0000)]
Squelch a compiler warning by removing a "/*" from the middle of a
comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11029 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agocheck in Thomas Anders patch to SNMP to allow ethereal to dissect
sahlberg [Sat, 29 May 2004 01:00:59 +0000 (01:00 +0000)]
check in Thomas Anders patch to SNMP to allow ethereal to dissect
properly COUNTER64 objects that are not spanning a full 64 bit on the wire

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11028 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoconnectionless cancel PDU's don't have a dg_server_accepting_cancels field
ulfl [Fri, 28 May 2004 20:59:56 +0000 (20:59 +0000)]
connectionless cancel PDU's don't have a dg_server_accepting_cancels field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11027 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoenable postcript printing if selected in prefs,
ulfl [Thu, 27 May 2004 23:09:09 +0000 (23:09 +0000)]
enable postcript printing if selected in prefs,
correctly remove temporary file on close dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11026 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfixes: fixed printing on win32,
ulfl [Thu, 27 May 2004 21:55:59 +0000 (21:55 +0000)]
bugfixes: fixed printing on win32,
and convert none printable characters, so printing will work on binary output as well
(like in the GUI output)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11025 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agowin_printer is gboolean, not an int
ulfl [Thu, 27 May 2004 21:52:07 +0000 (21:52 +0000)]
win_printer is gboolean, not an int

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11024 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded a small comment
ulfl [Thu, 27 May 2004 21:48:10 +0000 (21:48 +0000)]
added a small comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11023 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoTag the "has_child" argument to "prefs_tree_page_add()" as unused when
guy [Thu, 27 May 2004 21:42:54 +0000 (21:42 +0000)]
Tag the "has_child" argument to "prefs_tree_page_add()" as unused when
building with GTK+ 2.x or later, as it's only needed and only used for
1.2[.x].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11022 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouse gtk_window_set_default_size() instead of WIDGET_SET_SIZE() for the dialogs,
ulfl [Thu, 27 May 2004 19:59:50 +0000 (19:59 +0000)]
use gtk_window_set_default_size() instead of WIDGET_SET_SIZE() for the dialogs,
as WIDGET_SET_SIZE() will prevent the user from shrinking the dialog,
and gtk_window_set_default_size() will not

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11021 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of an unused variable.
guy [Thu, 27 May 2004 18:12:58 +0000 (18:12 +0000)]
Get rid of an unused variable.

Mark as unused a required argument that's unused.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11020 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded a small comment
ulfl [Thu, 27 May 2004 17:26:46 +0000 (17:26 +0000)]
added a small comment

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11019 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't try to destroy a window, when it's already being destroyed
ulfl [Thu, 27 May 2004 17:08:50 +0000 (17:08 +0000)]
bugfix: don't try to destroy a window, when it's already being destroyed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11018 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoa lot of code cleanup
ulfl [Thu, 27 May 2004 16:50:16 +0000 (16:50 +0000)]
a lot of code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11017 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agobugfix: don't try to destroy a window, when it's already being destroyed
ulfl [Thu, 27 May 2004 16:48:36 +0000 (16:48 +0000)]
bugfix: don't try to destroy a window, when it's already being destroyed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11016 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadded some tooltips
ulfl [Thu, 27 May 2004 16:43:01 +0000 (16:43 +0000)]
added some tooltips

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11015 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't point to the manpage for the list of authors, it's in the about dialog now
ulfl [Thu, 27 May 2004 16:41:33 +0000 (16:41 +0000)]
Don't point to the manpage for the list of authors, it's in the about dialog now

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11014 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agothe isns timestamp is in fact a 64 bit integer and not a 32 bit integer.
sahlberg [Thu, 27 May 2004 08:33:22 +0000 (08:33 +0000)]
the isns timestamp is in fact a 64 bit integer and not a 32 bit integer.

declaring it properly will make ethereal dissect it properly as well
instead of crashing

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11013 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomake KRB_SAFE more consistent with the other PDUs by removing the SAFE expansion.
sahlberg [Thu, 27 May 2004 08:22:04 +0000 (08:22 +0000)]
make KRB_SAFE more consistent with the other PDUs by removing the SAFE expansion.

cosmetic: Put the application type on the kerberos subtree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11012 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't compile in "follow_save_as_destroy_cb()" for GTK+ 2.4 and later,
guy [Wed, 26 May 2004 21:23:20 +0000 (21:23 +0000)]
Don't compile in "follow_save_as_destroy_cb()" for GTK+ 2.4 and later,
as it's not used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11011 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake gtk2 the default. Use --disable-gtk2 to use glib1/gtk1 instead
jmayer [Wed, 26 May 2004 12:08:15 +0000 (12:08 +0000)]
Make gtk2 the default. Use --disable-gtk2 to use glib1/gtk1 instead

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11010 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange C++ style comments
jmayer [Wed, 26 May 2004 11:37:36 +0000 (11:37 +0000)]
Change C++ style comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11009 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoin dissect_ber_bitstring32()
sahlberg [Wed, 26 May 2004 11:25:20 +0000 (11:25 +0000)]
in dissect_ber_bitstring32()
It is not neccessary that the encoded bitstring is actually encoded as 4 bytes.

Make sure, that if the bistring is encoded in less than 4 bytes that we
still do the right thing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11008 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove the SAFE_BODY expansion to make KRB5_MSG_SAFE look more consistent
sahlberg [Wed, 26 May 2004 11:04:15 +0000 (11:04 +0000)]
remove the SAFE_BODY expansion to make KRB5_MSG_SAFE look more consistent
with the other application dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11007 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRun libtoolize after aclocal.m4 has been generated
jmayer [Wed, 26 May 2004 10:41:14 +0000 (10:41 +0000)]
Run libtoolize after aclocal.m4 has been generated

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11006 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoimplementation of the KRB_SAFE application
sahlberg [Wed, 26 May 2004 08:53:45 +0000 (08:53 +0000)]
implementation of the KRB_SAFE application

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11005 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of some declarations of routines that no longer exist.
guy [Wed, 26 May 2004 04:21:49 +0000 (04:21 +0000)]
Get rid of some declarations of routines that no longer exist.

Fix up some declarations of other routines to match the definitions of
those routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11004 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomore code cleanup from dialog things:
ulfl [Wed, 26 May 2004 03:49:24 +0000 (03:49 +0000)]
more code cleanup from dialog things:
changed window_xy (dialog) function calling in a lot of gtk files
cleanup of file selection code
cleanup in dlg_utils/file_dlg/ui_util
Please report any problems!!!

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11003 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't capitalize "Filter" in "Display Filter" in the "Find" dialog box,
guy [Wed, 26 May 2004 02:33:37 +0000 (02:33 +0000)]
Don't capitalize "Filter" in "Display Filter" in the "Find" dialog box,
just as we don't capitalize "value" in "Hex value" in the same set of
radio buttons.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11002 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe function pointer in a "per_choice_t" or a "per_sequence_t" is to a
guy [Tue, 25 May 2004 21:27:02 +0000 (21:27 +0000)]
The function pointer in a "per_choice_t" or a "per_sequence_t" is to a
function that returns "int", not "guint32"; declare one such function as
such, and note that the function it calls should perhaps also use "int"
for packet-offset arguments and return values (or, rather, that the code
that generated it should generate functions that do so).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11001 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe function pointer in a "per_choice_t" or a "per_sequence_t" is to a
guy [Tue, 25 May 2004 21:24:03 +0000 (21:24 +0000)]
The function pointer in a "per_choice_t" or a "per_sequence_t" is to a
function that returns "int", not "guint32"; re-generate "packet-h235.c",
from the new "asn2eth.py", to define those functions to return "int".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11000 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe function pointer in a "per_choice_t" or a "per_sequence_t" is to a
guy [Tue, 25 May 2004 21:23:09 +0000 (21:23 +0000)]
The function pointer in a "per_choice_t" or a "per_sequence_t" is to a
function that returns "int", not "guint32"; define those functions to
return "int".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10999 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDeclare the "value_string" tables as "extern", to avoid problems when
guy [Tue, 25 May 2004 21:08:33 +0000 (21:08 +0000)]
Declare the "value_string" tables as "extern", to avoid problems when
building a shared libethereal on some platforms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10998 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"NOT_DECODED_YET()" was replaced by "PER_NOT_DECODED_YET()" and
guy [Tue, 25 May 2004 21:07:43 +0000 (21:07 +0000)]
"NOT_DECODED_YET()" was replaced by "PER_NOT_DECODED_YET()" and
"BER_NOT_DECODED_YET()"; use the right one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10997 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoReplace some Windows dash/hyphen character with a "-" in some comments.
guy [Tue, 25 May 2004 21:06:54 +0000 (21:06 +0000)]
Replace some Windows dash/hyphen character with a "-" in some comments.

Make the header files declare the "value_string" arrays as "extern", so
as to prevent problems on some platforms when building a shared
libethereal.

Note that, at least currently, we have separate "PER_NOT_DECODED_YET()"
and "BER_NOT_DECODED_YET()" macros, rather than a common
"NOT_DECODED_YET()" macro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10996 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofix the timestamp problem in h225
sahlberg [Tue, 25 May 2004 19:48:40 +0000 (19:48 +0000)]
fix the timestamp problem in h225

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10995 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoget rid of some compiler warnings
sahlberg [Tue, 25 May 2004 10:17:34 +0000 (10:17 +0000)]
get rid of some compiler warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10994 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoH.235 dissector from Tomas compiler script.
sahlberg [Tue, 25 May 2004 10:09:04 +0000 (10:09 +0000)]
H.235 dissector from Tomas compiler script.

This should make H.235 semicomplete and make a lot more H.225 packets dissect properly.

Please test.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10993 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders: add support for Rekey and Error Reply messages.
guy [Tue, 25 May 2004 09:41:03 +0000 (09:41 +0000)]
From Thomas Anders: add support for Rekey and Error Reply messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10992 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of some extra blanks.
guy [Tue, 25 May 2004 02:59:14 +0000 (02:59 +0000)]
Get rid of some extra blanks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10991 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agogive the user a hint what to do (save his/her preferences),
ulfl [Mon, 24 May 2004 18:14:58 +0000 (18:14 +0000)]
give the user a hint what to do (save his/her preferences),
when somethings wrong with the preferences,
as it's always a good idea to give a helping hand :-)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10990 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agodlg_destroy_cb() is static
ulfl [Mon, 24 May 2004 17:41:26 +0000 (17:41 +0000)]
dlg_destroy_cb() is static

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10989 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoEven with GTK+ 2.x the arguments to "dlg_destroy_cb()" aren't used.
guy [Mon, 24 May 2004 17:32:12 +0000 (17:32 +0000)]
Even with GTK+ 2.x the arguments to "dlg_destroy_cb()" aren't used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10988 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders: display DHCP option 43 suboption 8 as an octet
guy [Mon, 24 May 2004 16:38:29 +0000 (16:38 +0000)]
From Thomas Anders: display DHCP option 43 suboption 8 as an octet
string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10987 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoupdated two mail addresses
ulfl [Mon, 24 May 2004 16:17:22 +0000 (16:17 +0000)]
updated two mail addresses

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10986 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInclude <string.h> to declare "strlen()".
guy [Mon, 24 May 2004 09:00:52 +0000 (09:00 +0000)]
Include <string.h> to declare "strlen()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10985 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Tomas,
sahlberg [Mon, 24 May 2004 08:42:29 +0000 (08:42 +0000)]
From Tomas,

sourcefiles to generate H235 dissector using Tomas's ASN1 to Ethereal compiler

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10984 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Tomas Kukosa
sahlberg [Mon, 24 May 2004 08:33:09 +0000 (08:33 +0000)]
From Tomas Kukosa

ASN2ETH compiler and support script for lexical and syntactic analysis.

Will later be used for all those ASN.1 protocols we havent implemented yet

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10983 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHave two strings in an enum_val_t - one that's a short string that is
guy [Mon, 24 May 2004 02:25:21 +0000 (02:25 +0000)]
Have two strings in an enum_val_t - one that's a short string that is
convenient to put into a command line (no capital letters, no spaces to
require quotes), and one that's a detailed description for use in the
UI.  Allow either of them in the preferences file or "-o" option; use
the detailed description in the UI, and also use it when writing the
preferences out, so that the preference will be readable by older
versions of Ethereal (assuming the preference existed in that version).

Update "README.developer" to give more detail about an enum_val_t (and
to put the _t in), and to give a more detailed description of the
"radio_buttons" argument to "prefs_register_enum_preference()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10982 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake the XPM text "const", to get rid of some compiler warnings.
guy [Mon, 24 May 2004 02:06:01 +0000 (02:06 +0000)]
Make the XPM text "const", to get rid of some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10981 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"dlg_destroy_cb()" doesn't use its arguments when built with GTK+
guy [Mon, 24 May 2004 01:58:06 +0000 (01:58 +0000)]
"dlg_destroy_cb()" doesn't use its arguments when built with GTK+
1.2[.x], so add _U_ in that case.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10980 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agouse new functions in window API (ui_util.h),
ulfl [Sun, 23 May 2004 23:24:07 +0000 (23:24 +0000)]
use new functions in window API (ui_util.h),
use window_new instead of dlg_window_new for the statistics windows
(as these are no dialog windows)
do some code cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10979 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Matthew Bradley: add an option to control how to display TSAPs
guy [Sun, 23 May 2004 23:07:17 +0000 (23:07 +0000)]
From Matthew Bradley: add an option to control how to display TSAPs
(always as strings, always as raw bytes, or as strings iff all bytes are
printable ASCII), and put the destination and source TSAPs into the
protocol tree so they can be filtered on.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10978 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoEnable building dftest by default
jmayer [Sun, 23 May 2004 22:34:44 +0000 (22:34 +0000)]
Enable building dftest by default

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10977 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Lars Roland: define an "installation" version of GTK+ 2.x and Pango
guy [Sun, 23 May 2004 22:21:30 +0000 (22:21 +0000)]
From Lars Roland: define an "installation" version of GTK+ 2.x and Pango
in "config.nmake", and use that in the NSIS script when generating the
NSIS installer, so it puts GTK+ and Pango in the appropriate
subdirectories.  Also, when uninstalling, remove both of the sets of
subdirectories.

As per his suggestion, get rid of the "GTK1_VERSION" and "GTK2_VERSION"
macros, and just directly insert the values where those macros were used
- "GTK1_VERSION" wasn't used at all, and "GTK2_VERSION" was only used
immediately below where it was defined, and stuff elsewhere, such as in
the NSIS script, didn't use them and would break if you changed them
anyway.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10976 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Lars Roland: add some more .cvsignore items.
guy [Sun, 23 May 2004 22:06:33 +0000 (22:06 +0000)]
From Lars Roland: add some more .cvsignore items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10975 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agonext step to save the size and postition of the dialogs (using a hashtable)
ulfl [Sun, 23 May 2004 17:37:36 +0000 (17:37 +0000)]
next step to save the size and postition of the dialogs (using a hashtable)
move the get/set window size functionality from main to ui_util,
add some functions to handle windows/dialogs.

changed help and about dialog to suit the current window API

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10974 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd some comments about using WIDGET_SET_SIZE() macro
ulfl [Sun, 23 May 2004 15:03:09 +0000 (15:03 +0000)]
add some comments about using WIDGET_SET_SIZE() macro

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10973 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd translation of result codes
etxrab [Sun, 23 May 2004 13:43:13 +0000 (13:43 +0000)]
Add translation of result codes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10972 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn outgoing messages:
guy [Sun, 23 May 2004 01:53:29 +0000 (01:53 +0000)]
In outgoing messages:

put the screen name into the Info column before fetching the
message text, so it gets into the Info column even if we throw
an exception fetching the message text;

use the right offset when adding the screen name to the protocol
tree;

use the right offset for the byte after the screen name when
calling "aim_get_message()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10971 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut in a missing space.
guy [Sun, 23 May 2004 01:10:00 +0000 (01:10 +0000)]
Put in a missing space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10970 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd "ethereal-tmp.pod" to the list of files to ignore.
guy [Sat, 22 May 2004 22:30:14 +0000 (22:30 +0000)]
Add "ethereal-tmp.pod" to the list of files to ignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10969 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"--binary" is not a universal "cat" flag, and shouldn't be necessary on
guy [Sat, 22 May 2004 22:29:28 +0000 (22:29 +0000)]
"--binary" is not a universal "cat" flag, and shouldn't be necessary on
UN*X and, hopefully, not in Cygwin either.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10968 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "/" rather than "\" in UN*X pathnames.
guy [Sat, 22 May 2004 21:52:37 +0000 (21:52 +0000)]
Use "/" rather than "\" in UN*X pathnames.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10967 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake "ethereal.1" depend on "AUTHORS-SHORT", so that "AUTHORS-SHORT"
guy [Sat, 22 May 2004 21:51:30 +0000 (21:51 +0000)]
Make "ethereal.1" depend on "AUTHORS-SHORT", so that "AUTHORS-SHORT"
(which is built in the top-level directory) is built before we try to
build "ethereal.1" (which is built in the "doc" directory).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10966 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Thomas Anders:
guy [Sat, 22 May 2004 21:47:32 +0000 (21:47 +0000)]
From Thomas Anders:

- full support for "Wake Up" and "Security Parameter Recovered" messages
- full support for IPsec (additionally to SNMPv3) DOI
- add descriptive text to the info column (COL_INFO)
- proper FT_BOOLEAN type for "Re-establish" and "ACK required" flags
- proper item length for "PacketCable" (top-level), "List of ciphersuites"
  and "Application Specific Data"
- minor cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10965 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agogoing to have a standard behaviour of the dialogs
ulfl [Sat, 22 May 2004 19:56:19 +0000 (19:56 +0000)]
going to have a standard behaviour of the dialogs
(including remebering of the dialog size in recent file).
for a first step, I replaced all window_new() calls from dialogs
into dlg_window_new() ones, and removed all gtk_window_set_position
calls, this should be done in a more generalized way

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10964 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove (duplicated) list of authors from ethereal.pod,
ulfl [Sat, 22 May 2004 17:14:32 +0000 (17:14 +0000)]
remove (duplicated) list of authors from ethereal.pod,
and use ../AUTHORS-SHORT instead to concatenate a tmp file to use

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10963 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomerged differences between this file and doc/ethereal.pod
ulfl [Sat, 22 May 2004 17:05:15 +0000 (17:05 +0000)]
merged differences between this file and doc/ethereal.pod

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10962 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosligthly change indentation,
ulfl [Sat, 22 May 2004 15:29:17 +0000 (15:29 +0000)]
sligthly change indentation,
so the generated file AUTHORS-SHORTwill look a lot better

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10961 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNext attempt to match an empty line on Windows
jmayer [Sat, 22 May 2004 14:05:33 +0000 (14:05 +0000)]
Next attempt to match an empty line on Windows

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10960 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosome beautifying and
ulfl [Sat, 22 May 2004 13:49:01 +0000 (13:49 +0000)]
some beautifying and
bring the links to live, so the html manpage will jump correctly to it's link targets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10959 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd a target to build the manpages
ulfl [Sat, 22 May 2004 13:45:05 +0000 (13:45 +0000)]
add a target to build the manpages

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10958 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoupdate manpage, to reflect recent (and not so recent :-( changes in the GUI,
ulfl [Sat, 22 May 2004 12:32:00 +0000 (12:32 +0000)]
update manpage, to reflect recent (and not so recent :-( changes in the GUI,
like some things in the menu and Preferences, and fixed some minor bugs
which caused undesired formatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10957 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Gisle Vanem: export more functions from libethereal, as they're
guy [Sat, 22 May 2004 08:12:33 +0000 (08:12 +0000)]
From Gisle Vanem: export more functions from libethereal, as they're
needed by Ethereal itself.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10956 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix the other place where we construct temporary path names to use
guy [Sat, 22 May 2004 07:50:15 +0000 (07:50 +0000)]
Fix the other place where we construct temporary path names to use
G_DIR_SEPARATOR and G_DIR_SEPARATOR_S, to get rid of one more
horse-frightening pathname.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10955 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGTK+ 1.2[.x] doesn't handle UTF-8 text, so do the "Authors" tab only
guy [Sat, 22 May 2004 07:32:11 +0000 (07:32 +0000)]
GTK+ 1.2[.x] doesn't handle UTF-8 text, so do the "Authors" tab only
with GTK+ 1.3 and later.

If we're doing the "Authors" tab, include "text_page.h" to declare
"text_page_new()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10954 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPut "make-authors-short.pl" into the release tarball.
guy [Sat, 22 May 2004 07:24:28 +0000 (07:24 +0000)]
Put "make-authors-short.pl" into the release tarball.

Use it to generate the "AUTHORS-SHORT" file, put that file into the
release tarball, and install it in the data directory.

Add "AUTHORS-SHORT" to the .cvsignore file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10953 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoInclude "cvsversion.h" so we report the version correctly for builds
guy [Sat, 22 May 2004 04:46:13 +0000 (04:46 +0000)]
Include "cvsversion.h" so we report the version correctly for builds
from CVS.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10952 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDeclare "text_page_new()" in a "gtk/text_page.h" header, rather than
guy [Sat, 22 May 2004 04:25:57 +0000 (04:25 +0000)]
Declare "text_page_new()" in a "gtk/text_page.h" header, rather than
embedding a declaration in "gtk/about_dlg.c".

Do the Authors page in the About dialog on UN*X as well as on Windows.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10951 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't put a newline at the end of the compiled-with version information
guy [Sat, 22 May 2004 04:15:01 +0000 (04:15 +0000)]
Don't put a newline at the end of the compiled-with version information
- we don't put it at the end of the run-time version information.

Add newlines into formats used with that information where appropriate
(the "About" dialog box already had a newline in the format).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10950 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoConvert to UTF-8: iconv -f latin1 -t utf-8 AUTHORS >AUTHORS.utf-8
jmayer [Fri, 21 May 2004 23:18:51 +0000 (23:18 +0000)]
Convert to UTF-8: iconv -f latin1 -t utf-8 AUTHORS >AUTHORS.utf-8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10949 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't print empty lines follwing a }
jmayer [Fri, 21 May 2004 21:08:41 +0000 (21:08 +0000)]
Don't print empty lines follwing a }

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10948 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a missing {
jmayer [Fri, 21 May 2004 21:07:28 +0000 (21:07 +0000)]
Add a missing {

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10947 f5534014-38df-0310-8fa8-9805f1628bb7