obnox/wireshark/wip.git
23 years agoAdd support for comments in "process-x11-fields.pl", and add a copyright
guy [Sat, 21 Apr 2001 08:04:43 +0000 (08:04 +0000)]
Add support for comments in "process-x11-fields.pl", and add a copyright
notice/RCS ID/credit to Christophe to "x11-fields" as a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3358 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agorquota support completed by Ronnie Sahlberg.
guy [Sat, 21 Apr 2001 08:00:12 +0000 (08:00 +0000)]
rquota support completed by Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3357 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoSPRAY support, from Ronnie Sahlberg.
guy [Sat, 21 Apr 2001 07:57:23 +0000 (07:57 +0000)]
SPRAY support, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3356 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdate the reassembly item to note that IPv4 fragments are now
guy [Sat, 21 Apr 2001 07:49:24 +0000 (07:49 +0000)]
Update the reassembly item to note that IPv4 fragments are now
reassembled.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3355 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIn ANSI C (and in pre-ANSI UNIX implementations), if you return from
guy [Fri, 20 Apr 2001 22:35:19 +0000 (22:35 +0000)]
In ANSI C (and in pre-ANSI UNIX implementations), if you return from
"main()", the program exits, and exits with an exit status equal to the
return value of "main()", so "return 0;" is sufficient at the end of
"main()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3354 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUse "%u", not "%d", to print unsigned quantities.
guy [Fri, 20 Apr 2001 22:31:25 +0000 (22:31 +0000)]
Use "%u", not "%d", to print unsigned quantities.

Remove an extra space from one format.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3353 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoExplain BASE_{DEC,HEX,OCT,BIN} a bit more, note that BASE_BIN is for
guy [Fri, 20 Apr 2001 22:00:27 +0000 (22:00 +0000)]
Explain BASE_{DEC,HEX,OCT,BIN} a bit more, note that BASE_BIN is for
binary but currently is just decimal, and note that you may not use
BASE_NONE for integers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3352 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoWhen displaying the numeric value for the value_string string that was
guy [Fri, 20 Apr 2001 21:57:55 +0000 (21:57 +0000)]
When displaying the numeric value for the value_string string that was
selected in the filter-construction GUI, treat BASE_BIN like BASE_DEC,
as that's currently how it's treated elsewhere.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3351 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIn ANSI C (and in pre-ANSI UNIX implementations), if you return from
guy [Fri, 20 Apr 2001 21:50:06 +0000 (21:50 +0000)]
In ANSI C (and in pre-ANSI UNIX implementations), if you return from
"main()", the program exits, and exits with an exit status equal to the
return value of "main()", so "return 0;" is sufficient at the end of
"main()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3350 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoInclude "process-x11-fields.pl" and "x11-fields" in the source
guy [Fri, 20 Apr 2001 21:29:02 +0000 (21:29 +0000)]
Include "process-x11-fields.pl" and "x11-fields" in the source
distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3349 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix Gerald's e-mail address - and fix it in "README.developer", so
guy [Fri, 20 Apr 2001 20:34:31 +0000 (20:34 +0000)]
Fix Gerald's e-mail address - and fix it in "README.developer", so
people don't blindly insert the old address into new dissectors, which
is probably how it got into the dissectors being fixed here.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3348 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdd a "return 0;" at the end of main() to pacify MSVC 5 (and probably
gram [Fri, 20 Apr 2001 19:41:42 +0000 (19:41 +0000)]
Add a "return 0;" at the end of main() to pacify MSVC 5 (and probably
other compilers, too.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3347 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoPut an RCS ID/GPL/copyright notice into the "process-x11-fields.pl"
guy [Fri, 20 Apr 2001 19:20:31 +0000 (19:20 +0000)]
Put an RCS ID/GPL/copyright notice into the "process-x11-fields.pl"
script.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3346 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoKLM support, from Ronnie Sahlberg.
guy [Fri, 20 Apr 2001 18:37:53 +0000 (18:37 +0000)]
KLM support, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3345 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoPut the top-level item for a TLV into the protocol tree with a text
guy [Fri, 20 Apr 2001 08:14:35 +0000 (08:14 +0000)]
Put the top-level item for a TLV into the protocol tree with a text
value, so that if we throw an exception while processing that TLV before
setting it in the dissector for that particular TLV we at least have
something in the tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3344 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMake the fields that correspond to drawable IDs, masks, and the like
guy [Fri, 20 Apr 2001 06:28:34 +0000 (06:28 +0000)]
Make the fields that correspond to drawable IDs, masks, and the like
display as hex rather than decimal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3343 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix up "process-x11-fields" to allow both a base *and* VALS to be
guy [Fri, 20 Apr 2001 06:01:10 +0000 (06:01 +0000)]
Fix up "process-x11-fields" to allow both a base *and* VALS to be
specified - with or without a name for the list of values - and to roll
up *all* the tokens at the end into the blurb for the field.

Supply a base in "x11-fields" for all numeric fields, and supply a base
of NONE rather than a parent-field width for Boolean fields that aren't
bitfields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3342 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoCheck in the file used to define fields for the X11 dissector, and the
guy [Fri, 20 Apr 2001 04:16:19 +0000 (04:16 +0000)]
Check in the file used to define fields for the X11 dissector, and the
Perl script that generates them, so that if we have to change those
fields we can do so more conveniently.

Remove the generated header files from CVS, and arrange that we generate
them when we do a build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3341 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoPut BASE_NONE back into the FT_INTn and FT_UINTn display functions
hagbard [Fri, 20 Apr 2001 03:59:11 +0000 (03:59 +0000)]
Put BASE_NONE back into the FT_INTn and FT_UINTn display functions
with useful error messages.  Some dissector are registering
FT_INTn or FT_UINTn fields with BASE_NONE.  Now when ethereal dies
because of it the offending field will be identified so that it
can be fixed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3340 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAll the object class-specific types are interior nodes, and the only
guy [Fri, 20 Apr 2001 01:22:23 +0000 (01:22 +0000)]
All the object class-specific types are interior nodes, and the only
interesting thing about them is whether they're present or absent - make
them FT_NONE, rather than FT_BOOLEAN, so they don't have an extra ":
True" added to the protocol tree display line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3339 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoDCE RPC updates from Todd Sabin.
guy [Thu, 19 Apr 2001 23:39:27 +0000 (23:39 +0000)]
DCE RPC updates from Todd Sabin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3338 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoDon't allow BASE_NONE to be used with FT_INTn and FT_UINTn variables -
guy [Thu, 19 Apr 2001 23:21:44 +0000 (23:21 +0000)]
Don't allow BASE_NONE to be used with FT_INTn and FT_UINTn variables -
you have to select a base (even before this change, you had to select
one, otherwise the filter-construction GUI would crash if you selected
an FT_INTn or FT_UINTn field with BASE_NONE and then selected a
comparison operator).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3337 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago"ethereal -G" and "tethereal -G" won't show the pseudo-field for
guy [Thu, 19 Apr 2001 23:17:30 +0000 (23:17 +0000)]
"ethereal -G" and "tethereal -G" won't show the pseudo-field for
"proto_tree_add_text()" any more, so the scripts that take that output
and massage it into various forms don't have to check for it any more.

Get rid of the FT_-name-to-description filtering in eproto2sgml, as it's
not used, and fix it in the other two scripts to correspond to the
current list of FT_ values.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3336 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoPatch from Ronnie Sahlberg to cause the field description section of the
guy [Thu, 19 Apr 2001 23:06:23 +0000 (23:06 +0000)]
Patch from Ronnie Sahlberg to cause the field description section of the
status bar to display nothing, rather than "Text (text)", when a
"proto_tree_add_text()" field is selected.

While we're at it, use a similar test to eliminate the text pseudo-field
from the output of "{ethereal,tethereal} -G", as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3335 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFT_UINTn and FT_INTn fields must always have a base selected for them;
guy [Thu, 19 Apr 2001 23:02:44 +0000 (23:02 +0000)]
FT_UINTn and FT_INTn fields must always have a base selected for them;
otherwise, the filtering GUI gets very upset when you try to construct a
filter expression to test the value of that field.  Make them BASE_DEC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3334 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFT_UINTn and FT_INTn fields must always have a base selected for them;
guy [Thu, 19 Apr 2001 22:55:31 +0000 (22:55 +0000)]
FT_UINTn and FT_INTn fields must always have a base selected for them;
otherwise, the filtering GUI gets very upset when you try to construct a
filter expression to test the value of that field.  Make some of them
that are really Booleans ("is there an object of this class in the
packet?") FT_BOOLEAN, and give others BASE_DEC, for now.

Give the hidden field for the RSVP object class to have a name (so it
shows up as "Object class" in the filtering GUI).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3333 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix up the messages printed for the SSL checks - AC_MSG_CHECKING without
guy [Thu, 19 Apr 2001 01:08:16 +0000 (01:08 +0000)]
Fix up the messages printed for the SSL checks - AC_MSG_CHECKING without
AC_MSG_RESULT is an error (it produces a message without a newline at
the end, as AC_MSG_RESULT is supposed to finish the message with the
result of the test), and, according to the autoconf documentation,
you're not supposed to use AC_MSG_RESULT without AC_MSG_CHECKING,
either.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3332 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoInclude "image/Makefile.nmake" in the distribution tarball.
guy [Thu, 19 Apr 2001 01:05:19 +0000 (01:05 +0000)]
Include "image/Makefile.nmake" in the distribution tarball.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3331 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoDistribute wtap.def
gram [Wed, 18 Apr 2001 21:34:22 +0000 (21:34 +0000)]
Distribute wtap.def

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3330 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoYPPASSWD support, from Ronnie Sahlberg.
guy [Wed, 18 Apr 2001 20:41:12 +0000 (20:41 +0000)]
YPPASSWD support, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3329 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoChange from Ronnie Sahlberg to add ONC RPC strings to the tree as
guy [Wed, 18 Apr 2001 20:27:42 +0000 (20:27 +0000)]
Change from Ronnie Sahlberg to add ONC RPC strings to the tree as
strings, with a field index, rather than as text, so they can be
filtered.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3328 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix from Patrick Wolfe.
guy [Wed, 18 Apr 2001 20:01:17 +0000 (20:01 +0000)]
Fix from Patrick Wolfe.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3327 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoCheck the validity of numbers specified in command-line options.
guy [Wed, 18 Apr 2001 05:45:58 +0000 (05:45 +0000)]
Check the validity of numbers specified in command-line options.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3326 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agonmake was compiling lemon.c twice; now let it use its default
gram [Wed, 18 Apr 2001 04:55:36 +0000 (04:55 +0000)]
nmake was compiling lemon.c twice; now let it use its default
rules, keeping it from over-compiling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3325 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIP fragment reassembly, from Ronnie Sahlberg.
guy [Wed, 18 Apr 2001 04:53:51 +0000 (04:53 +0000)]
IP fragment reassembly, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3324 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoRevert. MSVC is wrong. Thanks to Guy for pointing that out.
gram [Wed, 18 Apr 2001 04:52:51 +0000 (04:52 +0000)]
Revert. MSVC is wrong. Thanks to Guy for pointing that out.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3323 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago#define YY_NEVER_INTERACTIVE to avoid reference to isatty() on Win32,
gram [Wed, 18 Apr 2001 03:03:42 +0000 (03:03 +0000)]
#define YY_NEVER_INTERACTIVE to avoid reference to isatty() on Win32,
and thus avoid a compiler warning when compiling ascend-scanner.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3322 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMakefile.nmake pulls in settings from config.nmake
gram [Wed, 18 Apr 2001 03:02:57 +0000 (03:02 +0000)]
Makefile.nmake pulls in settings from config.nmake
Move 'const' keyword to keep const qualifiers balanced... gets rid
of complaint from MSVC.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3321 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoTvbuffify packet-yhoo.c. I could use some feedback on this, as it's my
nneul [Wed, 18 Apr 2001 00:21:01 +0000 (00:21 +0000)]
Tvbuffify packet-yhoo.c. I could use some feedback on this, as it's my
first tvb dissector. Looks like it works, but I'm not sure I'm doing
everything the best way.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3320 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoWTLS client and trusted key ID handling enhancements, from Patrick Wolfe.
guy [Tue, 17 Apr 2001 23:26:52 +0000 (23:26 +0000)]
WTLS client and trusted key ID handling enhancements, from Patrick Wolfe.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3319 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAs of GLib 1.2.9, you won't automatically get "-I/usr/local/include" and
guy [Tue, 17 Apr 2001 22:47:37 +0000 (22:47 +0000)]
As of GLib 1.2.9, you won't automatically get "-I/usr/local/include" and
"-L/usr/local/lib" added to CFLAGS and LDFLAGS merely as a result of
running AM_PATH_GLIB, as 1.2.9 and later don't install headers directly
under "/usr/local/include".  Therefore, we have to put
"-I/usr/local/include" into CFLAGS ourselves, just as we do in the
top-level configure script, or we run the risk of not being able to find
other packages (libpcap, zlib, etc.) if it's installed under
"/usr/local".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3318 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoTvbuffified by Heikki Vatiainen.
guy [Tue, 17 Apr 2001 21:25:13 +0000 (21:25 +0000)]
Tvbuffified by Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3317 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix to WTP retransmission indicator dissection, from Olivier Biot.
guy [Tue, 17 Apr 2001 18:57:10 +0000 (18:57 +0000)]
Fix to WTP retransmission indicator dissection, from Olivier Biot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3316 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix to a preferences dialog bug, from <inoue@ainet.or.jp>.
guy [Tue, 17 Apr 2001 18:49:55 +0000 (18:49 +0000)]
Fix to a preferences dialog bug, from <inoue@ainet.or.jp>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3315 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMove the declaration of "etype_vals[]" from "epan/packet.h" to
guy [Tue, 17 Apr 2001 06:43:21 +0000 (06:43 +0000)]
Move the declaration of "etype_vals[]" from "epan/packet.h" to
"etypes.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3314 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMove the declaration of "ipprotostr()" out of "epan/packet.h" into a new
guy [Tue, 17 Apr 2001 06:29:14 +0000 (06:29 +0000)]
Move the declaration of "ipprotostr()" out of "epan/packet.h" into a new
"ipproto.h" header file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3313 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoQuarterly (or so) update.
gerald [Tue, 17 Apr 2001 02:53:49 +0000 (02:53 +0000)]
Quarterly (or so) update.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3312 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix the e-mail address for Joerg Mayer (and remove it from files he
guy [Tue, 17 Apr 2001 00:46:06 +0000 (00:46 +0000)]
Fix the e-mail address for Joerg Mayer (and remove it from files he
wasn't involved with).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3311 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoGCC 2.95.1 on SPARC/Solaris, at least, is clever enough to figure out
guy [Mon, 16 Apr 2001 22:06:34 +0000 (22:06 +0000)]
GCC 2.95.1 on SPARC/Solaris, at least, is clever enough to figure out
that the loop in "lanalyzer_open()" is an infinite loop, so the "return
0;" at the end isn't necessary to suppress a compiler warning with that
compiler - and Sun C not only figures it out, it warns that the
"g_assert_not_reached()" and the "return 0;" are unreachable, so I'll
take them out for now (and put them back if my older GCC at home still
requires it to suppress warnings).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3310 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoThe "data" member of a Buffer structure is a "u_char *"; when assigning
guy [Mon, 16 Apr 2001 21:59:38 +0000 (21:59 +0000)]
The "data" member of a Buffer structure is a "u_char *"; when assigning
the result of a "g_malloc()" to it, cast it to "u_char *", not "char *".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3309 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAssorted ISIS enhancements from Hannes Gredler.
guy [Mon, 16 Apr 2001 10:04:33 +0000 (10:04 +0000)]
Assorted ISIS enhancements from Hannes Gredler.

When dissecting the ISIS NLPID CLV, use the "nlpid_vals" array to
convert NLPID values to protocol names.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3308 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoThe Vines Fragmentation Protocol dissector is called only through
guy [Sun, 15 Apr 2001 09:18:45 +0000 (09:18 +0000)]
The Vines Fragmentation Protocol dissector is called only through
dissector tables, so it doesn't need to check whether that protocol is
disabled or to set "pinfo->current_proto".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3307 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoConversation dissectors are called through a mechanism that doesn't
guy [Sun, 15 Apr 2001 09:05:17 +0000 (09:05 +0000)]
Conversation dissectors are called through a mechanism that doesn't
check for disabled protocols or set "pinfo->current_proto", so they have
to do that for themselves.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3306 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAssorted cleanups.
guy [Sun, 15 Apr 2001 08:50:37 +0000 (08:50 +0000)]
Assorted cleanups.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3305 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix up a pile of NullTVB uses that were left in the previous checkin.
guy [Sun, 15 Apr 2001 07:51:11 +0000 (07:51 +0000)]
Fix up a pile of NullTVB uses that were left in the previous checkin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3304 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago"packet-ipx.c" doesn't use anything from "packet-snmp.h", so don't
guy [Sun, 15 Apr 2001 07:36:52 +0000 (07:36 +0000)]
"packet-ipx.c" doesn't use anything from "packet-snmp.h", so don't
include it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3303 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoGet rid of an unused variable, and fix a typo in a comment.
guy [Sun, 15 Apr 2001 07:35:26 +0000 (07:35 +0000)]
Get rid of an unused variable, and fix a typo in a comment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3302 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoTvbuffify the ASN.1 code and the Kerberos, LDAP, and SNMP dissectors.
guy [Sun, 15 Apr 2001 07:30:03 +0000 (07:30 +0000)]
Tvbuffify the ASN.1 code and the Kerberos, LDAP, and SNMP dissectors.

Clean up some problems that revealed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3301 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoThere's no "enable name resolution in captures" preference in Ethereal,
guy [Sun, 15 Apr 2001 03:37:16 +0000 (03:37 +0000)]
There's no "enable name resolution in captures" preference in Ethereal,
and never was - there's only an Ethereal-wide "enable name resolution"
preference.  Name it just "name_resolve".

Replace all tests of "g_resolving_actif" with tests of
"prefs.name_resolv", and replace all code that sets "g_resolving_actif"
with code that sets "prefs.name_resolv", so that the setting of
"prefs.name_resolv" actually affects whether names are resolved or not.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3300 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoNothing in "etypes.h" is used by "ipproto.c", so there's no need to
guy [Fri, 13 Apr 2001 18:51:32 +0000 (18:51 +0000)]
Nothing in "etypes.h" is used by "ipproto.c", so there's no need to
include "etypes.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3299 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdded the ethereal capture preferences to the preference file.
jfoster [Fri, 13 Apr 2001 14:59:30 +0000 (14:59 +0000)]
Added the ethereal capture preferences to the preference file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3298 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoImprovement of 'make clean' targets.
gram [Thu, 12 Apr 2001 18:07:22 +0000 (18:07 +0000)]
Improvement of 'make clean' targets.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3297 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix up the alignment of some of the "configure --help" messages.
guy [Wed, 11 Apr 2001 23:52:50 +0000 (23:52 +0000)]
Fix up the alignment of some of the "configure --help" messages.

Print the right error message for "--without-plugindir".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3295 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoSet PLUGIN_DIR to a value that depends on "VERSION", rather than
guy [Wed, 11 Apr 2001 23:49:44 +0000 (23:49 +0000)]
Set PLUGIN_DIR to a value that depends on "VERSION", rather than
hardcoding the version number into it; this means you don't have to
remember to change the version number in two places when you change the
version.

(If, as, and when the plugin ABI stabilizes enough that we don't change
the plugin directory in every release, we can set it based on, say, some
"PLUGIN_ABI_VERSION" variable.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3294 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoPackage the 3d logo, too.
gram [Wed, 11 Apr 2001 21:34:25 +0000 (21:34 +0000)]
Package the 3d logo, too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3293 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdd an item for the tvbuffified HCLNFSD dissector.
guy [Wed, 11 Apr 2001 18:56:15 +0000 (18:56 +0000)]
Add an item for the tvbuffified HCLNFSD dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3292 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoTvbuffified HCLNFSD dissector, from Ronnie Sahlberg.
guy [Wed, 11 Apr 2001 18:55:34 +0000 (18:55 +0000)]
Tvbuffified HCLNFSD dissector, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3291 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdate the other occurrence of the version number.
guy [Wed, 11 Apr 2001 18:38:19 +0000 (18:38 +0000)]
Update the other occurrence of the version number.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3290 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdated for release 0.8.17
jfoster [Wed, 11 Apr 2001 16:35:02 +0000 (16:35 +0000)]
Updated for release 0.8.17

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3289 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoThe Software Porting And Archive Centre for HP-UX now has libpcap 0.6.2
guy [Wed, 11 Apr 2001 05:24:08 +0000 (05:24 +0000)]
The Software Porting And Archive Centre for HP-UX now has libpcap 0.6.2
binaries, so users only need to make sure they have that version
installed in order to have Ethereal (and tcpdump, and snort, and so on)
accept "lanN"-style names (i.e., names of the sort reported by lanscan
and handled by ifconfig), rather than "dlpiN".

Get rid of the patches to update libpcap, get rid of the discussion in
"README.hpux" of patching libpcap and just say "get 0.6.2", and make the
notes on HP-UX kernel patches to fix problems with capturing outgoing
packets a separate item in the list of items in "README.hpux".

Also update the error messages Ethereal and Tethereal display if they
can't open a device and the error is "can't find PPA for XXX" to say
"get 0.6.2" rather than "patch libpcap and recompile.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3288 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdates from David Frascone.
guy [Tue, 10 Apr 2001 21:49:23 +0000 (21:49 +0000)]
Updates from David Frascone.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3287 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIf the tvbuff pointer is null in "alloc_field_info()", get the data
guy [Tue, 10 Apr 2001 19:10:10 +0000 (19:10 +0000)]
If the tvbuff pointer is null in "alloc_field_info()", get the data
source name from "pi.compat_top_tvb", which should always be set to the
tvbuff that refers to the data that old-style dissectors are currently
working on.

Arrange that it be so set in those dissectors that create alternate data
sources and call other dissectors, and also arrange that "pi.len" and
"pi.captured_len" be set appropriately as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3286 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix automake packaging of win32-only files.
gram [Tue, 10 Apr 2001 16:19:34 +0000 (16:19 +0000)]
Fix automake packaging of win32-only files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3285 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdated for 0.8.17.
gram [Tue, 10 Apr 2001 16:06:08 +0000 (16:06 +0000)]
Updated for 0.8.17.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3284 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago"get_hostname()" takes an argument in network byte order, not host byte
guy [Tue, 10 Apr 2001 14:04:31 +0000 (14:04 +0000)]
"get_hostname()" takes an argument in network byte order, not host byte
order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3283 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdd instructions for using the installation package.
gram [Tue, 10 Apr 2001 12:29:22 +0000 (12:29 +0000)]
Add instructions for using the installation package.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3282 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoCheck in isprint() hack for Win32 so that Ethereal is usably while
gram [Tue, 10 Apr 2001 12:07:40 +0000 (12:07 +0000)]
Check in isprint() hack for Win32 so that Ethereal is usably while
we figure out what the real bug is.

Fix set_last_open_dir() to use G_DIR_SEPARATOR and G_DIR_SEPARATOR_S
for cross-platform compatibility.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3281 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix up some other README.developer items.
guy [Tue, 10 Apr 2001 07:21:38 +0000 (07:21 +0000)]
Fix up some other README.developer items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3280 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agolast_open_dir needs a trailing slash in order for the GTK+
gram [Mon, 9 Apr 2001 22:35:23 +0000 (22:35 +0000)]
last_open_dir needs a trailing slash in order for the GTK+
file-selection dialogue to open the directory and show its
contents, otherwise it opens the parent directory and shows *its*
contents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3279 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdate README.developer to discuss 'col_set_str' and 'col_clear', to
guy [Mon, 9 Apr 2001 22:25:39 +0000 (22:25 +0000)]
Update README.developer to discuss 'col_set_str' and 'col_clear', to
make the dissector function in the sample dissector code a static
function, and to leave out the "CHECK_DISPLAY_AS_DATA()" call and the
line to set "pinfo->current_proto" in the sample dissector, as the
sample dissector is called through a dissector table, and the code to
call through a dissector table does both of those for you.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3278 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFixes from Joerg Mayer.
guy [Mon, 9 Apr 2001 21:42:01 +0000 (21:42 +0000)]
Fixes from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3277 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoFix error in dissect_connect_ack routine, proto_tree_add_item for hf_msproxy_server_i...
jfoster [Mon, 9 Apr 2001 15:54:17 +0000 (15:54 +0000)]
Fix error in dissect_connect_ack routine, proto_tree_add_item for hf_msproxy_server_int_addr
was using a length of 2 not 4, which it should be.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3276 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoNote that UCD SNMP binaries and header files for Win32 can be gotten
guy [Mon, 9 Apr 2001 06:12:51 +0000 (06:12 +0000)]
Note that UCD SNMP binaries and header files for Win32 can be gotten
from Revelstone's Web site (in a different directory from the one
mentioned in the past).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3275 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdd support for "version 7" wandess output. Actually, I think it's
gerald [Mon, 9 Apr 2001 03:32:34 +0000 (03:32 +0000)]
Add support for "version 7" wandess output.  Actually, I think it's
simply PPP data that doesn't have a username associated with it, e.g. for
a dedicated WAN link as opposed to a dialup link.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3274 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoNote that MAPI is a DCE RPC service, and note that getting rid of the
guy [Mon, 9 Apr 2001 02:15:10 +0000 (02:15 +0000)]
Note that MAPI is a DCE RPC service, and note that getting rid of the
MAPI dissector would mean that MAPI traffic would merely be identified
as DCE RPC traffic rather than as MAPI traffic - and we might still have
to base that identification on the port number, for some captures, if
I've read the DCE RPC 1.1 documentation correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3273 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoSCTP dissector fix from Michael Tuexen.
guy [Mon, 9 Apr 2001 00:21:07 +0000 (00:21 +0000)]
SCTP dissector fix from Michael Tuexen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3272 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoOSI network layer over PPP support, fix to P2P ISIS processing, and ISIS
guy [Sun, 8 Apr 2001 19:32:05 +0000 (19:32 +0000)]
OSI network layer over PPP support, fix to P2P ISIS processing, and ISIS
hostname TLV support, from Hannes Gredler.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3271 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIf we do "offset = dissect_rpc_XXX_tvb(...)", we have to do so
guy [Sat, 7 Apr 2001 09:25:23 +0000 (09:25 +0000)]
If we do "offset = dissect_rpc_XXX_tvb(...)", we have to do so
regardless of whether the protocol tree argument is null or not;
otherwise, we don't end up updating the offset field correctly if the
argument is null.  (The "dissect_rpc_XXX_tvb(...)" routines won't try to
add something to the tree if their "tree" argument is null, so it's safe
to call them with a null "tree" argument.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3270 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoRWALL dissector, from Ronnie Sahlberg.
guy [Sat, 7 Apr 2001 08:39:46 +0000 (08:39 +0000)]
RWALL dissector, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3269 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMention RFC 1356 in the comment about handling NLPIDs other than the
guy [Sat, 7 Apr 2001 08:33:12 +0000 (08:33 +0000)]
Mention RFC 1356 in the comment about handling NLPIDs other than the
0xCC one for IP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3268 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAt least with UCD SNMP 4.1.2, you can safely pass to "sprint_value()" a
guy [Sat, 7 Apr 2001 08:23:58 +0000 (08:23 +0000)]
At least with UCD SNMP 4.1.2, you can safely pass to "sprint_value()" a
variable with a null pointer-to-value and a zero length, so we don't
need to protect the assignment to "variable.val.string" with
"SAFE_STRING()" - and doing so causes complaints from the compiler about
assigning a pointer to a "const gchar" to the non-const pointer
"variable.val.string".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3267 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoDon't hand "fdata" to "clear_fdata()" if you haven't filled it in.
guy [Sat, 7 Apr 2001 06:58:17 +0000 (06:58 +0000)]
Don't hand "fdata" to "clear_fdata()" if you haven't filled it in.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3266 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoDon't blow up if "asn1_string_value_decode()" supplies a null pointer as
guy [Sat, 7 Apr 2001 00:52:07 +0000 (00:52 +0000)]
Don't blow up if "asn1_string_value_decode()" supplies a null pointer as
the string because the string value is zero-length.

Don't try to treat an agent address in a V1 trap as an IP address if
it's not 4 bytes long.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3265 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIn "dissect_snmp_parse_error()" and "dissect_snmp_error()", put an error
guy [Fri, 6 Apr 2001 23:12:33 +0000 (23:12 +0000)]
In "dissect_snmp_parse_error()" and "dissect_snmp_error()", put an error
indication into the protocol tree as well as the summary line, so people
don't get confused if, say, doing "tethereal -V".

Pass those routines the subtree for the packet, rather than the
top-level tree, so that the error indication and the item for the rest
of the packet show up there rather than at the top level.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3264 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoBuild with zlib.
gram [Fri, 6 Apr 2001 03:52:45 +0000 (03:52 +0000)]
Build with zlib.
Pre-compiled zlib provided at
http://www.ethereal.com/distribution/win32/zlib-1.1.3-fixed.zip
"fixed" because the pre-compiled version in the "extralibs" package
from the Gimp/Win32 page has a fault zlib.lib in it.

Add note about zlib in README.win32; more work needs to be done to
this file to mention new packaging method.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3263 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoDon't call "register_all_plugin_handoffs()" if we don't have plugin
guy [Thu, 5 Apr 2001 19:25:16 +0000 (19:25 +0000)]
Don't call "register_all_plugin_handoffs()" if we don't have plugin
support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3262 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoWin32 build fix, show "0.5.2 (WinPcap 2.1)" as the libpcap version
gram [Thu, 5 Apr 2001 05:58:05 +0000 (05:58 +0000)]
Win32 build fix, show "0.5.2 (WinPcap 2.1)" as the libpcap version
for Win32, and show a slightly more informative (i.e., geared to the
user) help message when trying to capture without having WinPcap installed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3261 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdates for win32 files to ignore.
gram [Thu, 5 Apr 2001 05:38:37 +0000 (05:38 +0000)]
Updates for win32 files to ignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3260 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoRemove the 3 types of installation in favor of a "type-less"
gram [Thu, 5 Apr 2001 05:36:47 +0000 (05:36 +0000)]
Remove the 3 types of installation in favor of a "type-less"
installation. Now the user just gets to select components to install.
Provide for installing a Deskstop Icon, too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3259 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUse sed in the Win32 build to place the version in various files.
gram [Thu, 5 Apr 2001 04:39:29 +0000 (04:39 +0000)]
Use sed in the Win32 build to place the version in various files.
We us $(VERSION), defined in the top-level config.nmake, to replace
@VERSION@ in various files. $(RC_VERSION) and $(WTAP_VERSION) are
similarly used.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3258 f5534014-38df-0310-8fa8-9805f1628bb7