guy [Mon, 7 Feb 2005 19:11:45 +0000 (19:11 +0000)]
Clean up indentation.
The default for "capture_options.save_file" is a null pointer, meaning
we're not writing to a save file, we're writing out the dissection as
text.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13340
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Mon, 7 Feb 2005 15:55:13 +0000 (15:55 +0000)]
In case we have an unknown vendor tag, just decode the vendor from
manuf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13339
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Feb 2005 08:58:40 +0000 (08:58 +0000)]
From Alejandro Vaquero :
Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13338
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Feb 2005 08:57:47 +0000 (08:57 +0000)]
From Alejandro Vaquero :
Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13337
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Feb 2005 08:56:39 +0000 (08:56 +0000)]
From Alejandro Vaquero :
Find attached a patch for "Voip analysis" to get the LRQ/LCF/LRJ messages included in the H323 calls for Gatekeeper to Gatekeeper configurations
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13336
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 7 Feb 2005 08:54:24 +0000 (08:54 +0000)]
From LEGO:
- fixes a leak in analize_pdu()
- fixes a typo in analize_pdu()
- fixes a crash in scs_unsubscribe()
- save a malloc and a free in get_pdu_fields()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13335
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 7 Feb 2005 03:35:51 +0000 (03:35 +0000)]
The welcome pane isn't scrollable, so add it to the scrolling window
with a viewport.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13334
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 7 Feb 2005 03:13:51 +0000 (03:13 +0000)]
In the child process, capture_opts->fork_child is 0, not -1, so, in that
case, don't attempt to send a signal to the child.
Expand a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13333
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 7 Feb 2005 02:09:30 +0000 (02:09 +0000)]
Move the code to set the title on a window when a capture is in progress
to the "start live capture" callback, and call that from "do_capture()".
When opening a capture file, don't pop up the "What do you want to do?"
pane when closing any existing file you have open, as we're just going
to put the regular view up right after that.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13332
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 7 Feb 2005 01:32:53 +0000 (01:32 +0000)]
Declare "cf_callback_t" before using it in a further declaration.
Mark the "func" argument to "cf_callback_remove()" as unused.
Get rid of the "iface" argument to "cf_start_tail()", as it's no longer
used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13331
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 7 Feb 2005 00:54:46 +0000 (00:54 +0000)]
Instead of calling each single thing when doing/finish a file operation, file.c shouldn't call all the GUI related functions itself, instead throwing some kind of Events to it's caller(s).
I've implemented a very simple callback mechanism which provides exactly this. I've tried GHook from GLib before, but this doesn't seem to be the right thing, as it's too inflexible for the purpose here.
So I've implemented a callback function in main.c which receives all "events" and spreads them to menu, statusbar and itself.
I would see this implementation as a prototype which may need improvements. Please comment the changes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13330
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 7 Feb 2005 00:31:45 +0000 (00:31 +0000)]
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13329
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 23:16:05 +0000 (23:16 +0000)]
Don't have "set_menus_for_captured_packets()" call
"main_set_for_capture_file()"; it should only deal with menus, not
anything else - and it gets called while the menus are being set up,
which is before the main window has been completely created, so
"main_widgets_show_or_hide()", which is called by
"main_set_for_capture_file()", gets errors trying to show or hide
widgets the pointers to which are null.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13328
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 23:06:23 +0000 (23:06 +0000)]
Get rid of extra blank line at the end.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13327
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 22:21:51 +0000 (22:21 +0000)]
"iface" is now a member of "capture_opts", not "cfile".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13326
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 22:19:53 +0000 (22:19 +0000)]
Get rid of a few cf_get_ references missed by the previous checkin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13325
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 22:18:15 +0000 (22:18 +0000)]
Include <ctype.h> for "isspace()".
#ifdef a variable used only if _WIN32 is defined.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13324
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 22:06:31 +0000 (22:06 +0000)]
Clean up indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13323
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 21:36:11 +0000 (21:36 +0000)]
Back out the previous change - we were setting "datafiledir", not
"datafile", and code in epan/filesystem.c expectes DATAFILE_DIR to be
set to the "ethereal" subdirectory of the data directory, not to the
data directory itself.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13322
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 6 Feb 2005 21:34:59 +0000 (21:34 +0000)]
minor code cleanup
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13321
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 6 Feb 2005 21:20:35 +0000 (21:20 +0000)]
another two steps towards privilege seperation:
move another two capture related fields (iface and cfilter) from cfile to capture_opts
also move the handling of capture related command line options from main.c to capture.c, that way a future privilege seperated capture program can use the same code to parse it's command line than Ethereal.
It might be even possible to share this parser code even with Tethereal, didn't took a closer look at this.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13320
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 6 Feb 2005 20:53:54 +0000 (20:53 +0000)]
Clean up indentation.
Make "reset()" static (it's not used outside "sctp_stat.c"), and fix its
prototype to match what's expected for a reset routine passed to
"register_tap_listener()". Similarly, fix the prototypes of other
routines passed to "register_tap_listener()", and get rid of the casts
of pointers to those functions to "void *".
Fix some declarations in "sctp_stat.h" to have function prototypes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13319
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 6 Feb 2005 20:37:02 +0000 (20:37 +0000)]
From: LEGO
- fix a bug at gog reinit that disabled gogs after reload of a file.
- fix some crashes when Debug_GoG>0
- cleanup the debug output (no CR at the end is needed)
- Gops start when no GopStart is given and match an existing GogKey
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13318
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 6 Feb 2005 14:43:27 +0000 (14:43 +0000)]
some cleanup of the initial start sequence of Ethereal, filling in capture_opts and alike
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13317
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 6 Feb 2005 12:21:27 +0000 (12:21 +0000)]
fix bugs regarding the capture child
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13316
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 6 Feb 2005 00:13:00 +0000 (00:13 +0000)]
instead of initializing the capture_options in main.c, use the new function capture_opts_init
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13315
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Sat, 5 Feb 2005 23:34:56 +0000 (23:34 +0000)]
remove obsolete function add_rtp_streams_graph() from voip_calls.[ch] and fix a register_tap_listener() call.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13314
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 23:12:44 +0000 (23:12 +0000)]
begin a welcome page which is shown, if you don't have any capture data loaded.
This might be improved to have additional content and/or better layout of the elements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13313
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 17:53:39 +0000 (17:53 +0000)]
completely hide the main window panes, if we currently don't have a capture file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13312
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 5 Feb 2005 17:39:12 +0000 (17:39 +0000)]
From Josh Bailey:
Attached is an update to Lucent/Ascend trace parsing: fix a few bugs,
add support for ISDN and Ethernet captures - diffs to 0.10.9.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13311
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 5 Feb 2005 15:51:45 +0000 (15:51 +0000)]
Remove g_free.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13310
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 15:40:44 +0000 (15:40 +0000)]
fixed the dnd_init declaration
(we have to do something about the non existing win32 compile dependencies, this is just a pain)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13309
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 15:35:25 +0000 (15:35 +0000)]
rename kill_capture_child to capture_kill_child to have a common prefix
split drag and drop support out of main.c into new file drag_and_drop.c, to reduce the size of main.c a bit.
Hopefully this won't break unix builds because of missing #include's, I will keep an eye on the buildbot
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13308
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 14:37:56 +0000 (14:37 +0000)]
use the interfaces descriptive name to be shown in the statusbar as it's, well, more descriptive
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13307
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 14:33:03 +0000 (14:33 +0000)]
fix a comment
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13306
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 5 Feb 2005 14:24:26 +0000 (14:24 +0000)]
Re-commit the asn2eth based gsm-map dissector, hopfully it'll work better now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13305
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 13:44:27 +0000 (13:44 +0000)]
minor enhancements to Guy's last update
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13304
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 5 Feb 2005 12:50:47 +0000 (12:50 +0000)]
Put "cf_status_t" back.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13303
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 5 Feb 2005 12:08:01 +0000 (12:08 +0000)]
Make "cf_open()" match the prototype in "file.h".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13302
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 11:37:56 +0000 (11:37 +0000)]
updated some comments
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13301
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 5 Feb 2005 11:08:24 +0000 (11:08 +0000)]
From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now
using an RTP tap (not using the rtp_stream).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13300
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 5 Feb 2005 11:07:21 +0000 (11:07 +0000)]
From Alejandro Vaquero:
a patch that to shows the RTP streams in the Graph. Now
using an RTP tap (not using the rtp_stream).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13299
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 5 Feb 2005 11:00:04 +0000 (11:00 +0000)]
make some string parameters const, as they are not changed inside
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13298
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 5 Feb 2005 04:37:36 +0000 (04:37 +0000)]
retap_packets() was renamed cf_retap_packets().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13297
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 4 Feb 2005 22:48:17 +0000 (22:48 +0000)]
Activate SCTP association analysis
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13296
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 4 Feb 2005 22:45:15 +0000 (22:45 +0000)]
Update to versions compiling on and working on Windows and Unix.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13295
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Fri, 4 Feb 2005 22:39:48 +0000 (22:39 +0000)]
Add detection of zero checksum.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13294
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 4 Feb 2005 20:54:12 +0000 (20:54 +0000)]
Instead of having a single enumerated type for status return values from
cf_ functions, have separate ones for different classes of routines, and
use gboolean when the return value is just "success" or "failure" - that
way you don't get compiler warnings if a case statement isn't handling a
particular status value if the routine in question won't return it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13293
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 4 Feb 2005 20:32:32 +0000 (20:32 +0000)]
Properly define "cf_start_tail()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13292
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 19:29:27 +0000 (19:29 +0000)]
remove #include "globals.h" from summary.c, as it's a bad idea for multiple capture files.
If a summary user would like to get a summary, it should know the file of *which* it needs the summary.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13291
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 19:24:40 +0000 (19:24 +0000)]
this file doesn't use any item of the globals.h so remove #include.
However, if it needs one of:
#include "file.h"
#include <epan/timestamp.h>
it should include it directly, please let me know if it's required, as I can't test it :-(
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13290
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 18:44:44 +0000 (18:44 +0000)]
huge cleanup of capture file API (functions in file.c/file.h).
This includes: all functions in file.h now have a cf_ prefix, will have doxygen tags, will have the capture_file *cf as the first parameter and I tried to generalize the return values for non trivial functions.
Hopefully, I didn't introduced any new bugs, as I had to change a lot of files...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13289
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 4 Feb 2005 15:22:25 +0000 (15:22 +0000)]
Fix a couple of distcheck problems:
Update conversation_new and find_conversation in plugin_api_list.c and
associated files.
Add packet-dcerpc-butc.h to the distribution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13288
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 4 Feb 2005 10:48:03 +0000 (10:48 +0000)]
From Dominique Bastien: marker and OAM slow protocol support.
Fix his e-mail address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13287
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 4 Feb 2005 10:32:28 +0000 (10:32 +0000)]
HFILL can't be used to initialize at run time.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13286
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 08:52:38 +0000 (08:52 +0000)]
remove access to global cfile, use access functions and capture_opts instead
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13285
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 08:42:39 +0000 (08:42 +0000)]
remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13284
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 08:27:41 +0000 (08:27 +0000)]
remove #include "globals.h" and access to global cfile, use access functions and capture_opts instead
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13283
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 4 Feb 2005 05:26:51 +0000 (05:26 +0000)]
use a bitmap for the restore flags so the dissection is prettier
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13282
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 4 Feb 2005 04:58:03 +0000 (04:58 +0000)]
initial checkin of modified idl file for autogenerating the BUTC interface
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13281
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 4 Feb 2005 04:37:47 +0000 (04:37 +0000)]
check in new directory for the files for autogenerating dcerpc interfaces
and the prototype idl compiler.
this is not ready for wide use yet but is useful with a svn area where we can sync our changes to the compiler.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13280
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 4 Feb 2005 04:31:59 +0000 (04:31 +0000)]
add missing conversion to new use of save_file and fork_child
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13279
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 4 Feb 2005 04:02:36 +0000 (04:02 +0000)]
add support for varying strings in addition to conformant and varying strings that we already support
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13278
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 4 Feb 2005 02:17:29 +0000 (02:17 +0000)]
update BUTC and fill in all (bar one) dissectors
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13277
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 4 Feb 2005 01:29:29 +0000 (01:29 +0000)]
(some) redesign of capture data structures.
don't use global cfile at all but only an untpyed handle to call the cf_... functions in file.c
move the save_file member from capture_file to capture_opts, as it's only used while capturing and while preparing it
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13276
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 4 Feb 2005 00:29:37 +0000 (00:29 +0000)]
Albert Chin:
>From autoconf.info:
In order to support these features, it is essential that `datadir'
remains being defined as `${prefix}/share' to depend upon the current
value of `prefix'.
A corollary is that you should not use these variables except in
Makefiles. For instance, instead of trying to evaluate `datadir' in
`configure' and hard-coding it in Makefiles using e.g.,
`AC_DEFINE_UNQUOTED(DATADIR, "$datadir")', you should add
`-DDATADIR="$(datadir)"' to your `CPPFLAGS'.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13275
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Fri, 4 Feb 2005 00:22:00 +0000 (00:22 +0000)]
albert chin:
The HP-UX compilers don't like non-constant initializers (C99'ism).
Patch attached for plugins/mate/mate_setup.c.
Fix a few warnings (change some () to (void))
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13274
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 23:42:06 +0000 (23:42 +0000)]
Yaniv Kaul
Attached patch simplifies a very complex 'if' statement in packet-fw1.c
and generally streamlines the code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13273
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 23:35:57 +0000 (23:35 +0000)]
Yaniv Kaul:
Attached please find a small performance optimization to packet-ip.c,
which removes multiple redundant calls to tvb_get_ptr().
Changed srt_addr and dst_addr from char to guchar
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13272
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 23:24:08 +0000 (23:24 +0000)]
Motonori Shindo:
Please find attached a small patch for CoSine L2 debug dissector. The
code used to incorrectly select the first 4 octets in the tvbuff. This
patch fixes this problem.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13271
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 23:18:23 +0000 (23:18 +0000)]
Yniv Kaul: Small performance optimization
It change a while()->do, to do->while() and removes a variable (and an
assignment to it).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13270
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 22:52:20 +0000 (22:52 +0000)]
ncisco Alcoba:
Do not add target address if the packet is a Request. According to the RFC,
target addresses in requests have no meaning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13269
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Feb 2005 22:48:20 +0000 (22:48 +0000)]
move capture_file_fd field from capture_file to capture_opts type, as this is the place where it should be
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13268
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 22:44:13 +0000 (22:44 +0000)]
Mark C. Brown: Added support for new ixgbe card
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13267
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Feb 2005 21:58:33 +0000 (21:58 +0000)]
prevent ringbuffer from having to know about capture_file type at all (decoupling dependencies)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13266
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 3 Feb 2005 21:57:42 +0000 (21:57 +0000)]
Add dissection of some more packages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13265
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 3 Feb 2005 21:56:59 +0000 (21:56 +0000)]
Add dissection of some more packages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13264
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 3 Feb 2005 21:51:35 +0000 (21:51 +0000)]
From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message,
in the first one the calling and called numbers, and in the second the SPs
and CIC; in releases it shows the cause value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13263
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 3 Feb 2005 21:50:19 +0000 (21:50 +0000)]
From Francisco Alcoba:
Patch for graphing ISUP calls. It shows the type of message,
in the first one the calling and called numbers, and in the second the SPs
and CIC; in releases it shows the cause value.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13262
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 3 Feb 2005 21:22:09 +0000 (21:22 +0000)]
Various updates to GSM MAP
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13261
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 3 Feb 2005 21:11:46 +0000 (21:11 +0000)]
Jon Ringle: bug fix to the stun ERROR-CODE dissecting
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13260
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Feb 2005 20:44:19 +0000 (20:44 +0000)]
add tooltips to the dialogs radio buttons
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13259
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Feb 2005 20:14:11 +0000 (20:14 +0000)]
From Dominique Bastien: add the slow protocol MAC address to the list of
well-known MAC addresses.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13258
f5534014-38df-0310-8fa8-
9805f1628bb7
lroland [Thu, 3 Feb 2005 16:22:08 +0000 (16:22 +0000)]
Small fix for h225 dissector as suggested by Tomas Kukosa
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13257
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 3 Feb 2005 15:03:29 +0000 (15:03 +0000)]
From Pekka Pietikainen <pp@ee.oulu.fi>, add a byte to the hex[]
array so that there is room for the terminating NUL from sprintf().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13256
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 3 Feb 2005 06:54:55 +0000 (06:54 +0000)]
Add an OID
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13255
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Feb 2005 02:35:20 +0000 (02:35 +0000)]
Enable GTK-Wimp only for Windows 2000/XP/2003
...as Win9x/ME/NT known to have problems with it!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13254
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 3 Feb 2005 02:32:48 +0000 (02:32 +0000)]
Copied this file from:
http://nsis.sourceforge.net/archive/nsisweb.php?page=15&instances=0,11
Licensing question, as the NSIS homepage states:
http://nsis.sourceforge.net/features/license/
so it should be ok to rerelease this file under the GPL
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13253
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Feb 2005 02:26:20 +0000 (02:26 +0000)]
Give a URL for the ERF specification.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13252
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Feb 2005 01:24:07 +0000 (01:24 +0000)]
Fix a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13251
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Feb 2005 01:08:39 +0000 (01:08 +0000)]
Check in the missing part of Jon Ringle's patch (the part that actually
changed the conversation code).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13250
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 3 Feb 2005 01:07:21 +0000 (01:07 +0000)]
Undo de-UTF-8ification and other damage.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13249
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Feb 2005 22:18:37 +0000 (22:18 +0000)]
added %ETHEREAL%\disabled_protos
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13248
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 2 Feb 2005 21:13:52 +0000 (21:13 +0000)]
bugfix: the EOT flag detection in a COTP data TPDU was using little endian, although it's big endian in the packet.
some other minor output enhancements
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13247
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 2 Feb 2005 20:15:29 +0000 (20:15 +0000)]
Add Jon Ringle, at the moment I don't have the e-mail address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13246
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 2 Feb 2005 20:09:00 +0000 (20:09 +0000)]
From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13245
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 2 Feb 2005 20:08:36 +0000 (20:08 +0000)]
From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13244
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 2 Feb 2005 20:07:03 +0000 (20:07 +0000)]
From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13243
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 2 Feb 2005 20:02:46 +0000 (20:02 +0000)]
From Jon Ringle:
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13242
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Wed, 2 Feb 2005 13:37:04 +0000 (13:37 +0000)]
Add mtp3.pc as suggested by Luis Ontanon.
Cleanups
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13241
f5534014-38df-0310-8fa8-
9805f1628bb7