obnox/wireshark/wip.git
16 years agoInclude packet-wps.h, so it's part of the source tarball.
guy [Fri, 23 Nov 2007 18:25:39 +0000 (18:25 +0000)]
Include packet-wps.h, so it's part of the source tarball.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23550 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Jens Braeuer:
stig [Fri, 23 Nov 2007 17:48:28 +0000 (17:48 +0000)]
From Jens Braeuer:
Added support for Wifi Simple Config aka Wifi Protected Setup

From me:
Added standard copyright header to packet-wps

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23549 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMoved check for empty choice to make it work correctly.
stig [Fri, 23 Nov 2007 12:22:22 +0000 (12:22 +0000)]
Moved check for empty choice to make it work correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23548 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix a comment: manifest files are now embedded into .exe / .dll files, no need to...
ulfl [Fri, 23 Nov 2007 08:42:58 +0000 (08:42 +0000)]
fix a comment: manifest files are now embedded into .exe / .dll files, no need to copy them

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23547 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobecause of the privilege separation done, read filters won't work by definition now...
ulfl [Fri, 23 Nov 2007 08:39:11 +0000 (08:39 +0000)]
because of the privilege separation done, read filters won't work by definition now. Comment out the corresponding test case

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23546 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake previously removed ethertype preference obsolete. For inclusion in
sfisher [Thu, 22 Nov 2007 19:02:31 +0000 (19:02 +0000)]
Make previously removed ethertype preference obsolete.  For inclusion in
0.99.7 release.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23545 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodon't install the *.exe.manifest and *.dll.manifest files. The manifest is embedded...
ulfl [Thu, 22 Nov 2007 09:04:32 +0000 (09:04 +0000)]
don't install the *.exe.manifest and *.dll.manifest files. The manifest is embedded in the exe/dll files, so no need to install them seperately.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23544 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIf we only captured 1 packet, print "1 packet", not "1 packets".
guy [Thu, 22 Nov 2007 01:51:51 +0000 (01:51 +0000)]
If we only captured 1 packet, print "1 packet", not "1 packets".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23543 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoHave capture_loop_dispatch() calculate the number of packets written
guy [Thu, 22 Nov 2007 01:51:16 +0000 (01:51 +0000)]
Have capture_loop_dispatch() calculate the number of packets written
out, and return that; pcap_dispatch() returns the number of packets it
processed, but we might have discarded some or all of them if we hit the
packet limit in the middle of processing them.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23542 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't count packets until we've successfully written them to the capture
guy [Thu, 22 Nov 2007 01:16:57 +0000 (01:16 +0000)]
Don't count packets until we've successfully written them to the capture
file.

If we set the "stop capture" flag, don't process the packet.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23541 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRename Windows ConsoleCtrHandlerRoutine --> capture_cleanup to match SVN #23537 change
wmeier [Thu, 22 Nov 2007 00:33:22 +0000 (00:33 +0000)]
Rename Windows ConsoleCtrHandlerRoutine --> capture_cleanup to match SVN #23537 change

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23540 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded handling of octet-aligned data according to direct_reference.
stig [Wed, 21 Nov 2007 23:33:13 +0000 (23:33 +0000)]
Added handling of octet-aligned data according to direct_reference.
Implemented handling of ber_callback for tagged type octet-aligned
and arbitrary.  Renamed some functions.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23539 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCatch SIGINT, SIGHUP, and SIGTERM on UN*X, so we cleanly exit if, for
guy [Wed, 21 Nov 2007 22:49:02 +0000 (22:49 +0000)]
Catch SIGINT, SIGHUP, and SIGTERM on UN*X, so we cleanly exit if, for
example, we're ^C'ed.  This should fix bug 2003.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23538 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet rid of a no-longer-used variable.
guy [Wed, 21 Nov 2007 22:47:36 +0000 (22:47 +0000)]
Get rid of a no-longer-used variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23537 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't use "if it begins with 0xff 0x03 it's PPP, otherwise it's Cisco
guy [Wed, 21 Nov 2007 22:16:04 +0000 (22:16 +0000)]
Don't use "if it begins with 0xff 0x03 it's PPP, otherwise it's Cisco
HDLC" to try to distinguish Cisco HDLC from PPP packets;
Address-and-Control-Field-Compression can be negotiated on, so there's
no guarantee that PPP frames begin with 0xff 0x03.  Fixes bug 2005.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23535 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBug 1994: From Keith Mercer :
sake [Wed, 21 Nov 2007 20:33:50 +0000 (20:33 +0000)]
Bug 1994: From Keith Mercer :

This bugfix is focused only in the Sender ID TLV segment of code.  This was to
address the possibility that the Sender ID TLV may not have a Management
Address Domain, and/or a Management Address.  This bug was discovered when
testing the dissector using CFM-enabled Netopia modems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23534 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoCosmetic change to order the icmp.type
stig [Wed, 21 Nov 2007 19:00:20 +0000 (19:00 +0000)]
Cosmetic change to order the icmp.type

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23533 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAvoid redraw hex dump windows if redissecting.
stig [Wed, 21 Nov 2007 18:56:05 +0000 (18:56 +0000)]
Avoid redraw hex dump windows if redissecting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23532 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoMake it easier to change the default behavior of --enable-warnings-as-errors.
gerald [Wed, 21 Nov 2007 18:32:44 +0000 (18:32 +0000)]
Make it easier to change the default behavior of --enable-warnings-as-errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23531 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't try to overwrite read-only memory. Fixes bug 2001.
gerald [Wed, 21 Nov 2007 17:00:24 +0000 (17:00 +0000)]
Don't try to overwrite read-only memory.  Fixes bug 2001.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23529 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomore SSL debug info concerning conversation and ssl_session
kukosa [Wed, 21 Nov 2007 14:10:55 +0000 (14:10 +0000)]
more SSL debug info concerning conversation and ssl_session

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23528 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix crash caused with memory overwrite (flush buffer into window when we do not have...
kukosa [Wed, 21 Nov 2007 13:11:13 +0000 (13:11 +0000)]
fix crash caused with memory overwrite (flush buffer into window when we do not have space for next line)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23527 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBump the trunk to 0.99.8.
gerald [Wed, 21 Nov 2007 00:09:38 +0000 (00:09 +0000)]
Bump the trunk to 0.99.8.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23525 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug #1841: Crash after adding&deleting a column (while packet capture
sfisher [Tue, 20 Nov 2007 23:21:33 +0000 (23:21 +0000)]
Fix bug #1841: Crash after adding&deleting a column (while packet capture
is in progress).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23523 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBump the version numbers.
gerald [Tue, 20 Nov 2007 23:16:21 +0000 (23:16 +0000)]
Bump the version numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23522 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd the portableapps files to the distribution.
gerald [Tue, 20 Nov 2007 21:27:45 +0000 (21:27 +0000)]
Add the portableapps files to the distribution.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23521 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to draft-ietf-rserpool-common-param-15.txt. (Will
tuexen [Tue, 20 Nov 2007 21:21:56 +0000 (21:21 +0000)]
Update to draft-ietf-rserpool-common-param-15.txt. (Will
be published soon...)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23520 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate the privileges section.
gerald [Tue, 20 Nov 2007 20:26:01 +0000 (20:26 +0000)]
Update the privileges section.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23519 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a log message.
gerald [Tue, 20 Nov 2007 20:25:07 +0000 (20:25 +0000)]
Fix a log message.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23518 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a bounds check in order to try to fix bug #1998.
gerald [Tue, 20 Nov 2007 19:17:19 +0000 (19:17 +0000)]
Add a bounds check in order to try to fix bug #1998.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23517 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd relative start time, duration, and average data rate (bps) columns
gerald [Tue, 20 Nov 2007 18:35:41 +0000 (18:35 +0000)]
Add relative start time, duration, and average data rate (bps) columns
to the conversation lists. Move the "copy" button down to the button bar
in order to free up some real estate. Add an nstime_cmp() function. Clean
up code in a few places.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23516 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agomake-faq: Format of the online file changed slightly.
jmayer [Tue, 20 Nov 2007 17:44:39 +0000 (17:44 +0000)]
make-faq: Format of the online file changed slightly.

Update FAQ and help/faq.txt to current version.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23515 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix minor typo
sfisher [Tue, 20 Nov 2007 17:35:11 +0000 (17:35 +0000)]
Fix minor typo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23514 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate before release process starts.
jmayer [Tue, 20 Nov 2007 17:16:24 +0000 (17:16 +0000)]
Update before release process starts.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23513 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate from samba tree revision 25880 to 26066
jmayer [Tue, 20 Nov 2007 17:08:52 +0000 (17:08 +0000)]
Update from samba tree revision 25880 to 26066
============================ Samba log start ============
------------------------------------------------------------------------
r25915 | metze | 2007-11-09 20:23:25 +0100 (Fri, 09 Nov 2007) | 9 lines

ndr/pidl: change NTSTAUS into enum ndr_err_code (pidl code)

Samba4/NDR/Parser.pm
Samba4/NDR/Server.pm
Samba3/ServerNDR.pm
tests/

metze

------------------------------------------------------------------------
r26049 | metze | 2007-11-20 12:07:50 +0100 (Tue, 20 Nov 2007) | 4 lines

pidl: don't use ndr_pull_save anymore

metze

------------------------------------------------------------------------
------------------------------------------------------------------------
============================ Samba log end ==============

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23512 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIf libcap is present, have dumpcap use it to drop privileges while
gerald [Tue, 20 Nov 2007 16:53:01 +0000 (16:53 +0000)]
If libcap is present, have dumpcap use it to drop privileges while
retaining CAP_NET_ADMIN and CAP_NET_RAW.  Update some Makefile
dependencies for dumpcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23511 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReindent some to improve readability
morriss [Tue, 20 Nov 2007 16:51:14 +0000 (16:51 +0000)]
Reindent some to improve readability

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23510 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate some comments and whitespace.
gerald [Tue, 20 Nov 2007 16:46:11 +0000 (16:46 +0000)]
Update some comments and whitespace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23509 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix tag handling inside snmp trap
kukosa [Tue, 20 Nov 2007 13:55:39 +0000 (13:55 +0000)]
fix tag handling inside snmp trap

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23508 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofrom Jörg Mayer: "a proposed change to the COPYING file"
ulfl [Tue, 20 Nov 2007 08:33:09 +0000 (08:33 +0000)]
from Jörg Mayer: "a proposed change to the COPYING file"

from ULFL: some minor changes to wording and alike

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23507 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoRest of fix for SVN revision 23487. This change also changes the callback
sfisher [Tue, 20 Nov 2007 00:34:16 +0000 (00:34 +0000)]
Rest of fix for SVN revision 23487.  This change also changes the callback
function for the Save/Save As button as necessary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23506 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIntroduce use of the new FT_EBCDIC field type as a second display of
sfisher [Mon, 19 Nov 2007 21:28:17 +0000 (21:28 +0000)]
Introduce use of the new FT_EBCDIC field type as a second display of
text fields (data & sqlstatement).  Also fix the options on the FT_STRINGZ
items - change them to FT_STRING and change BASE_DEC to BASE_NONE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23505 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv kaul:
bondolo [Mon, 19 Nov 2007 21:28:08 +0000 (21:28 +0000)]
From Yaniv kaul:

Adds const declarations to req_resp_hdrs_do_reassembly() and re-orders some actions to occur after tests which may decide that the actions were not required.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23504 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoIntroduce a new field type called FT_EBCDIC. This field works the same as
sfisher [Mon, 19 Nov 2007 21:27:01 +0000 (21:27 +0000)]
Introduce a new field type called FT_EBCDIC.  This field works the same as
FT_STRING, except that it converts the data from the packet from EBCDIC
to ASCII for display in Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23503 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDetect reneged acks or at least retransmissions after an ack was seen. Mark
morriss [Mon, 19 Nov 2007 20:34:57 +0000 (20:34 +0000)]
Detect reneged acks or at least retransmissions after an ack was seen.  Mark
them with an expert info (PI_WARN).

Change "Duplicate TSN" expert info to "Retransmitted TSN" and make it PI_NOTE
instead of PI_WARN.

Change "More than 100 TSNs gap-acked" expert info to PI_WARN (from PI_NOTE).

Frame numbers (and count of retransmissions) are unsigned, display them that way.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23502 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoImproved "BER Error" messages to be more uniform.
stig [Mon, 19 Nov 2007 20:23:49 +0000 (20:23 +0000)]
Improved "BER Error" messages to be more uniform.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23501 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoGet the number of captured bytes from "rlen" instead of "wlen". This should
gerald [Mon, 19 Nov 2007 19:09:01 +0000 (19:09 +0000)]
Get the number of captured bytes from "rlen" instead of "wlen".  This should
fix bug #1983.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23500 f5534014-38df-0310-8fa8-9805f1628bb7

16 years ago- Prettify "Value" node that contains EAP tree with top-level details
martinm [Mon, 19 Nov 2007 19:07:49 +0000 (19:07 +0000)]
- Prettify "Value" node that contains EAP tree with top-level details
- Lose unuseful header file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23499 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoOnly show direction field when its set to a valid value.
martinm [Mon, 19 Nov 2007 19:04:19 +0000 (19:04 +0000)]
Only show direction field when its set to a valid value.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23498 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSecond try to not stop processing if length==0 in choice.
stig [Mon, 19 Nov 2007 17:46:11 +0000 (17:46 +0000)]
Second try to not stop processing if length==0 in choice.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23497 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix an infinite loop, and be more paranoid about looping in general.
gerald [Mon, 19 Nov 2007 17:33:59 +0000 (17:33 +0000)]
Fix an infinite loop, and be more paranoid about looping in general.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23496 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd missing \
martinm [Mon, 19 Nov 2007 17:23:30 +0000 (17:23 +0000)]
Add missing \

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23495 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoTry to fix reported uninstallation problems
martinm [Mon, 19 Nov 2007 16:29:41 +0000 (16:29 +0000)]
Try to fix reported uninstallation problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23494 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded p7 to build environment.
stig [Mon, 19 Nov 2007 13:40:27 +0000 (13:40 +0000)]
Added p7 to build environment.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23493 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded port range.
stig [Mon, 19 Nov 2007 07:31:56 +0000 (07:31 +0000)]
Added port range.
Added a dissector assert on inconsistent data.
Do not align retransmission or duplicate acknowledgement data in COL_INFO.
Removed several _U_ for used variables.
Re-indented some if-blocks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23492 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded port range.
stig [Mon, 19 Nov 2007 07:26:53 +0000 (07:26 +0000)]
Added port range.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23491 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoInitialize credentials.
stig [Mon, 19 Nov 2007 07:26:10 +0000 (07:26 +0000)]
Initialize credentials.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23490 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoReverted r23485 and r23486, this was not a correct fix.
stig [Mon, 19 Nov 2007 07:25:06 +0000 (07:25 +0000)]
Reverted r23485 and r23486, this was not a correct fix.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23489 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix my last commit (23487) to work with GTK 2.4 - 2.11+. I had accidently
sfisher [Mon, 19 Nov 2007 04:37:45 +0000 (04:37 +0000)]
Fix my last commit (23487) to work with GTK 2.4 - 2.11+.  I had accidently
used a GTK 2.12+ function in the last commit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23488 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a problem introduced with the GTK 2.4+ Toolbar API whereby the save/
sfisher [Mon, 19 Nov 2007 04:24:00 +0000 (04:24 +0000)]
Fix a problem introduced with the GTK 2.4+ Toolbar API whereby the save/
save as button would disappear (leaving a blank spot on the toolbar) after
starting & stopping a capture session more than once.

This fix gets rid of the second save_as_button when using GTK 2.4+ in favor
of converting the stock id / tooltip text of the save_button to that of
the save as button when necessary and reverting it back to just save when
necessary.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23487 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAnd dump internal ber fields for empty choice field.
stig [Sun, 18 Nov 2007 16:40:20 +0000 (16:40 +0000)]
And dump internal ber fields for empty choice field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23486 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAs proposed by Martin Peylo:
stig [Sun, 18 Nov 2007 16:20:51 +0000 (16:20 +0000)]
As proposed by Martin Peylo:
Do not stop processing if the length of a choice has the (illegal)
value of zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23485 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoUpdate to optionally use the "Ultimate Packer for eXecutables" (UPX) to pack the...
gal [Sun, 18 Nov 2007 10:20:26 +0000 (10:20 +0000)]
Update to optionally use the "Ultimate Packer for eXecutables" (UPX) to pack the exes and dlls prior to U3 and PortableApps packaging.

For the U3 package, this results in a 40% smaller package.
For the PortableApps version, the package size is not much different, but the install time is quicker.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23484 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agofix bug 1459: make the filter string "ip.version == 6" possible, by adding a "pseudo...
ulfl [Sun, 18 Nov 2007 08:16:49 +0000 (08:16 +0000)]
fix bug 1459: make the filter string "ip.version == 6" possible, by adding a "pseudo" field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23483 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix bug #1164 again - this time for GTK1.
sfisher [Sun, 18 Nov 2007 04:20:14 +0000 (04:20 +0000)]
Fix bug #1164 again - this time for GTK1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23482 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd ppp.direction field.
martinm [Sat, 17 Nov 2007 22:08:27 +0000 (22:08 +0000)]
Add ppp.direction field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23481 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoComment out dissect_ascii_tpkt to keep the buildbot happy.
gal [Sat, 17 Nov 2007 18:22:49 +0000 (18:22 +0000)]
Comment out dissect_ascii_tpkt to keep the buildbot happy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23480 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoBasic P7 (X.400 Message Store Access Protocol) dissection after request from the...
gal [Sat, 17 Nov 2007 18:08:01 +0000 (18:08 +0000)]
Basic P7 (X.400 Message Store Access Protocol) dissection after request from the list:
http://www.wireshark.org/lists/wireshark-dev/200711/msg00228.html

Only a single (private) capture file is currently available which contains only a few of the P7 operations, so testing has been minimal.
General attribute types, containing information from the X.400 envelope, are also included.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23479 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoThe asciitpkt checkin broke the TPKT dissector comment out create_dissector_handle...
etxrab [Sat, 17 Nov 2007 09:17:06 +0000 (09:17 +0000)]
The asciitpkt checkin broke the TPKT dissector comment out create_dissector_handle() and
dissector_add() for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23478 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoApply yet another set of the optimization patches:
etxrab [Sat, 17 Nov 2007 08:57:20 +0000 (08:57 +0000)]
Apply yet another set of the optimization patches:
- Don't call tree_view_select on first button click event, it's already done by the tree widget.
- Factorize slow gtk_text_buffer_insert_with_tags_by_name() calls

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23477 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd missing header file (eap.h)
martinm [Sat, 17 Nov 2007 00:20:32 +0000 (00:20 +0000)]
Add missing header file (eap.h)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23476 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix a buffer overflow in the PPP dissector. Try to fix uninitialized
gerald [Fri, 16 Nov 2007 23:56:18 +0000 (23:56 +0000)]
Fix a buffer overflow in the PPP dissector.  Try to fix uninitialized
variable warnings turned up by Valgrind.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23475 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoEmbedding EAP inside wimaxasncp.
martinm [Fri, 16 Nov 2007 23:03:09 +0000 (23:03 +0000)]
Embedding EAP inside wimaxasncp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23474 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoSome comments and formatting.
martinm [Fri, 16 Nov 2007 22:56:56 +0000 (22:56 +0000)]
Some comments and formatting.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23473 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix trivial typo.
martinm [Fri, 16 Nov 2007 22:53:18 +0000 (22:53 +0000)]
Fix trivial typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23472 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reassembly is off, catch ReportedBoundsError when calling a subdissector
morriss [Fri, 16 Nov 2007 22:04:27 +0000 (22:04 +0000)]
When reassembly is off, catch ReportedBoundsError when calling a subdissector
on the first fragment of a fragmented message.  This allows us to continue
dissecting chunks even if one of the first chunks in the frame was fragmented.
(It's useful to keep doing this partial dissection just so we have some idea
what's in that chunk.)

(One could rightfully argue that you should only see a fragmented chunk
bundled with another chunk when retransmitting but, well, I'm staring at
traces of an implementation--to remain nameless to protect the guilty--which
is sometimes fragmenting and then bundling the fragments into one packet.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23471 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd changes up to r23464.
gerald [Fri, 16 Nov 2007 20:00:00 +0000 (20:00 +0000)]
Add changes up to r23464.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23470 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoWhen reassembly is turned off don't pass non-first fragments to subdissectors: they...
morriss [Fri, 16 Nov 2007 19:32:59 +0000 (19:32 +0000)]
When reassembly is turned off don't pass non-first fragments to subdissectors: they will have no idea what they're getting and will exception out anyway.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23469 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd {} to some IF statements.
etxrab [Fri, 16 Nov 2007 09:00:14 +0000 (09:00 +0000)]
Add {} to some IF statements.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23468 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Martin Gignac:
etxrab [Fri, 16 Nov 2007 08:22:50 +0000 (08:22 +0000)]
From Martin Gignac:
Add comments and comment out an obsolete AVP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23467 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Harmeet Sawhney:
etxrab [Fri, 16 Nov 2007 08:18:30 +0000 (08:18 +0000)]
From Harmeet Sawhney:
Parse MGCP over TCP with ASCII TPKT header
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1964

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23466 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Yaniv Kaul :
bondolo [Thu, 15 Nov 2007 23:59:54 +0000 (23:59 +0000)]
From Yaniv Kaul :

Adds application/rss+xml mime type as a recognized XML type. It is used by some RSS servers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23465 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded correct svn propset settings to wiretap/netscreen.[ch]
sake [Thu, 15 Nov 2007 19:46:25 +0000 (19:46 +0000)]
Added correct svn propset settings to wiretap/netscreen.[ch]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23464 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoDon't try to reassemble a huge number of fragments.
gerald [Thu, 15 Nov 2007 19:38:04 +0000 (19:38 +0000)]
Don't try to reassemble a huge number of fragments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23463 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdd a generated lapd.direction field/filter.
martinm [Thu, 15 Nov 2007 18:37:50 +0000 (18:37 +0000)]
Add a generated lapd.direction field/filter.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23462 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew t125 dissector
sahlberg [Thu, 15 Nov 2007 10:39:16 +0000 (10:39 +0000)]
new t125 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23461 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoonly dissect it as t125 if it looks like t125
sahlberg [Thu, 15 Nov 2007 10:38:43 +0000 (10:38 +0000)]
only dissect it as t125 if it looks like t125

dissect_ber_choice() returns the index of the choice taken   not the
tag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23460 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew ldap dissector
sahlberg [Thu, 15 Nov 2007 10:32:45 +0000 (10:32 +0000)]
new ldap dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23459 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice() returns the index of the taken arm not the tag
sahlberg [Thu, 15 Nov 2007 10:32:10 +0000 (10:32 +0000)]
dissect_ber_choice() returns the index of the taken arm   not the tag
value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23458 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agonew x411 dissector
sahlberg [Thu, 15 Nov 2007 10:11:09 +0000 (10:11 +0000)]
new x411 dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23457 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice returns a gint that is the index of the choice taken,
sahlberg [Thu, 15 Nov 2007 10:10:22 +0000 (10:10 +0000)]
dissect_ber_choice returns a gint that is the index of the choice taken,
not the tag value

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23456 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated snmp dissector
sahlberg [Thu, 15 Nov 2007 09:50:36 +0000 (09:50 +0000)]
updated snmp dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23455 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agodissect_ber_choice() returns the index of the choice, not the tag of the
sahlberg [Thu, 15 Nov 2007 09:49:55 +0000 (09:49 +0000)]
dissect_ber_choice() returns the index of the choice, not the tag of the
choice

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23454 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoupdated mms dissector
sahlberg [Thu, 15 Nov 2007 09:42:21 +0000 (09:42 +0000)]
updated mms dissector

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23453 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agobranch_taken that is returned by dissect_ber_choice() is the index of
sahlberg [Thu, 15 Nov 2007 09:41:32 +0000 (09:41 +0000)]
branch_taken that is returned by dissect_ber_choice() is the index of
of the branch and not the tag value   so one cant use it with
val_to_str()
(well one can in this instance since by luck the tag values match the
indices)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23452 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP".
etxrab [Thu, 15 Nov 2007 06:03:53 +0000 (06:03 +0000)]
Fix "Diameter Dictionary: No Vendor: 3GPPDiameter Dictionary: No Vendor: 3GPP".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23451 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoChanged to use the the packet-ber EXTERNAL decoding (into the ASN1 context).
gal [Wed, 14 Nov 2007 20:57:55 +0000 (20:57 +0000)]
Changed to use the the packet-ber EXTERNAL decoding (into the ASN1 context).
Uses the ber_callback mechanism to call the rtse oid callbacks, rather than the default ber oid callback list.
A couple of fixes to packet-ber.c to mark [in]direct references as present and call the ber_callback if it has been specified.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23450 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoKeep the MEGACO dissector from looping on a malformed events descriptor.
gerald [Wed, 14 Nov 2007 19:28:29 +0000 (19:28 +0000)]
Keep the MEGACO dissector from looping on a malformed events descriptor.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23449 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoFrom Valery Sigalov via bug #1853: Fix the following console error when
sfisher [Wed, 14 Nov 2007 17:39:21 +0000 (17:39 +0000)]
From Valery Sigalov via bug #1853: Fix the following console error when
starting Wireshark:

Duplicate field detected in call to proto_register_field_array: channel_id is
already registered

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23448 f5534014-38df-0310-8fa8-9805f1628bb7

16 years agoAdded some parentheses to clarify the gint64 cast.
stig [Wed, 14 Nov 2007 10:15:20 +0000 (10:15 +0000)]
Added some parentheses to clarify the gint64 cast.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23447 f5534014-38df-0310-8fa8-9805f1628bb7