guy [Sat, 28 Mar 2009 17:30:31 +0000 (17:30 +0000)]
Don't use sprintf() - use ep_strbufs and ep_strbuf_append_printf()
instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27876
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 28 Mar 2009 05:14:16 +0000 (05:14 +0000)]
Add a missing check.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27875
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 28 Mar 2009 00:35:02 +0000 (00:35 +0000)]
Fix a couple items from the last checkin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27874
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 28 Mar 2009 00:27:03 +0000 (00:27 +0000)]
Replace a lot of pointer tracking and some GStrings with emem_strbufs. Add
ep_strbuf_printf and ep_strbuf_append_c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27873
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 27 Mar 2009 23:05:37 +0000 (23:05 +0000)]
Add initial support for string buffers - ep_allocated, growable strings
similar to GLib's GStrings. Use them to create the list of TCP flags.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27872
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 27 Mar 2009 20:16:15 +0000 (20:16 +0000)]
Remove extra parenthesis on two lines
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27871
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 27 Mar 2009 19:45:46 +0000 (19:45 +0000)]
Add request/response like tracking to the TFTP dissector. In this case, it
is used to show the source or destination filename being trasnferred on
every packet of that transfer as a generated item.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27870
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 27 Mar 2009 19:41:18 +0000 (19:41 +0000)]
Put the new tvb_get_seasonal_string() function to good use.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27869
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 27 Mar 2009 19:40:23 +0000 (19:40 +0000)]
Introduce two new functions:
tvb_get_seasonal_string();
tvb_get_seasonal_stringz();
.. which work the same as the ephemeral versions of the functions, but use
se_alloc() instead of ep_alloc().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27868
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 27 Mar 2009 16:25:49 +0000 (16:25 +0000)]
Add a note about 10.5.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27867
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 27 Mar 2009 16:17:31 +0000 (16:17 +0000)]
More size_t casts.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27866
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 27 Mar 2009 14:47:49 +0000 (14:47 +0000)]
(Trivial): fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27865
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 27 Mar 2009 14:46:54 +0000 (14:46 +0000)]
Replace some unnecessary use of g_snprintf and g_strdup_printf
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27864
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 27 Mar 2009 14:30:51 +0000 (14:30 +0000)]
(Minor): Remove unnecessary use of g_snprintf
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27863
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 27 Mar 2009 12:48:11 +0000 (12:48 +0000)]
(Minor); if (! initialized) not req'd; move hf[] to proto_register;
Remove unnecessary include files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27862
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Fri, 27 Mar 2009 12:16:02 +0000 (12:16 +0000)]
As suggested by Jakob Zawadzki: (Bug #3311): g_free() is NULL safe, so we don't need check against it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27861
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 27 Mar 2009 07:17:05 +0000 (07:17 +0000)]
From Artem Tamazov:
Added: FR MPLS PW support. Expanded: "default MPLS payload" menu.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3325
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27860
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 27 Mar 2009 07:08:07 +0000 (07:08 +0000)]
From Andreas Heise:
SIP dissector fix: mismatch of P-Asserted-Identity and P-Answer-State headers
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3356
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27859
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 27 Mar 2009 06:59:15 +0000 (06:59 +0000)]
In informationDirective use MSID instead of mobileIdentificationNumber.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27858
f5534014-38df-0310-8fa8-
9805f1628bb7
sfisher [Fri, 27 Mar 2009 02:33:23 +0000 (02:33 +0000)]
Set svn:keywords Id and svn:eol-style native
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27857
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 26 Mar 2009 22:34:53 +0000 (22:34 +0000)]
From Peter <pva At gentoo.org>: Fix build err: "variable 'payload_len' might be clobbered by 'longjmp' or 'vfork'"
Fixes Bug #3353
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27856
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 26 Mar 2009 21:46:07 +0000 (21:46 +0000)]
(Trivial): Fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27855
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Thu, 26 Mar 2009 18:33:50 +0000 (18:33 +0000)]
Repleace "" by NULL in hf-array (inspired by commit 27851).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27854
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 26 Mar 2009 18:01:26 +0000 (18:01 +0000)]
From Vincent Helfre:
Fix unaligned bitfields.
From me activate the SEQUENCE OF patch.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27853
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 26 Mar 2009 17:59:30 +0000 (17:59 +0000)]
Add missing files to the distribution.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27852
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 26 Mar 2009 17:17:06 +0000 (17:17 +0000)]
(Trivial): Use NULL instead of "" in hfp[] blurbs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27851
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Thu, 26 Mar 2009 14:40:18 +0000 (14:40 +0000)]
Fix ESP Initialization Vector dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27850
f5534014-38df-0310-8fa8-
9805f1628bb7
morriss [Thu, 26 Mar 2009 13:30:58 +0000 (13:30 +0000)]
Move iax2_analysis.c from WIRESHARK_GTK_SRC to WIRESHARK_TAP_SRC
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27849
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 25 Mar 2009 22:04:23 +0000 (22:04 +0000)]
Make it possible to check for extension marker in SEQUENCE OF and SET OF.
Fore some reason the trace in bug https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3360 does not decode properly
if dissecting the exension marker so leave that code #if 0:ed out for now.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27848
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Wed, 25 Mar 2009 18:04:30 +0000 (18:04 +0000)]
From Frederic Roudaut:
Add CAST5-CBC and HMAC-RIPEMD160-96 support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27847
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 25 Mar 2009 15:36:23 +0000 (15:36 +0000)]
Show number of UEs in label above table.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27846
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Wed, 25 Mar 2009 00:28:54 +0000 (00:28 +0000)]
Forgot Makefile.common (packet-wassp.c)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27845
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 24 Mar 2009 22:13:18 +0000 (22:13 +0000)]
Andreas Schuler
Fix display problems with b-fields:
increase the length of the string and use sprintf.
Original German comment:
weiter hab ich festgestellt das das b-field nicht richtig dargestellt wird .
Entweder ist g_snprintf broken , oder wir sind beide zu unf\344hig die
funktion zu benutzen .
Der string wird aus 16x %.2x + leerzeichen zusammengesetzt , was nach
meinen berechnungen eine h\366chstl\344nge von 144 zeichen + nullbyte ergibt .
deshalb hab ich die stringvariable auf 145 hochgesetzt und benutze wieder
sprintf . hier der patch dazu .
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27844
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 24 Mar 2009 22:09:21 +0000 (22:09 +0000)]
Andreas Schuler
small fix:
In a PP packet TA=7 gets dissected as Paging tail. In case of PP it
is really an Mt .
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27843
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 24 Mar 2009 22:02:05 +0000 (22:02 +0000)]
Beginnings of WASSP dissection - that's the protocol run between
HiPath Wireless controllers and the APs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27842
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Tue, 24 Mar 2009 17:28:30 +0000 (17:28 +0000)]
Only report CRC Status when we know it to be valid.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27841
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Tue, 24 Mar 2009 17:00:53 +0000 (17:00 +0000)]
From David Castleford: ismacrypt dissector
(See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3009)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27840
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Tue, 24 Mar 2009 11:54:56 +0000 (11:54 +0000)]
Removed code duplication in ASCII key computation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27839
f5534014-38df-0310-8fa8-
9805f1628bb7
kukosa [Tue, 24 Mar 2009 07:01:22 +0000 (07:01 +0000)]
add native-nmake.cmd into EXTRA_DIST
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27838
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Mon, 23 Mar 2009 22:16:25 +0000 (22:16 +0000)]
Add CRC error flag to frames, and show in stats window.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27837
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Mar 2009 21:24:04 +0000 (21:24 +0000)]
From Michael Lum:
ANSI MAP FeatureRequest update
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3349
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27836
f5534014-38df-0310-8fa8-
9805f1628bb7
rbalint [Mon, 23 Mar 2009 18:14:28 +0000 (18:14 +0000)]
Fix ASCII key computation.
This fixes bug 2943 thus allows ESP decoding again, which was
broken since r25264.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27835
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Mar 2009 17:33:20 +0000 (17:33 +0000)]
Get rid of another Clist.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27834
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Mar 2009 17:32:39 +0000 (17:32 +0000)]
Some updates and bug fixes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27833
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Mar 2009 17:31:50 +0000 (17:31 +0000)]
Update to the 200903 release.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27832
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Mon, 23 Mar 2009 17:30:38 +0000 (17:30 +0000)]
Fix: The AuthDir invoke is missing optional tags for a couple of parameters.
and FeatReq invoke fixes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27831
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 23 Mar 2009 13:31:04 +0000 (13:31 +0000)]
Fixed some data types to remove some warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27830
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 23 Mar 2009 13:15:56 +0000 (13:15 +0000)]
Fixed some data types to remove some warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27829
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 23 Mar 2009 13:13:05 +0000 (13:13 +0000)]
Fixed some data types to remove some warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27828
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 23 Mar 2009 13:03:18 +0000 (13:03 +0000)]
Removed some "statement not reached" warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27827
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 23 Mar 2009 12:44:50 +0000 (12:44 +0000)]
Removed some "initializer does not fit or is out of range" warnings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27826
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Mon, 23 Mar 2009 12:41:56 +0000 (12:41 +0000)]
Fixed some data types to remove some warnings in the solaris build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27825
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 Mar 2009 22:15:23 +0000 (22:15 +0000)]
P64 change
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27824
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 22 Mar 2009 21:20:56 +0000 (21:20 +0000)]
Dissect all the ESM messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27823
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 Mar 2009 20:55:31 +0000 (20:55 +0000)]
P64 changes: Fix some cases for which size_t is not required
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27822
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 22 Mar 2009 18:06:06 +0000 (18:06 +0000)]
Sigh.
dladdr() in GNU libc isn't available (<dlfcn.h> doesn't define Dl_info)
unless _GNU_SOURCE is defined.
In addition, it's not guaranteed to return anything more useful than
argv[0]; just in case that changes at some point in the future, however,
we still use it, we just run it through the same machinery that we run
argv[0] through. (On Mac OS X, for example, the path of the executable
is handed to the run-time linker by the kernel, so it *is* useful
there.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27821
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 Mar 2009 16:25:01 +0000 (16:25 +0000)]
(Minor) Change a g_snprint to a g_strlcpy;
Also: Fix an off-by-1 inadvertantly introduced a while back.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27820
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 Mar 2009 15:42:03 +0000 (15:42 +0000)]
g_snprintf() & etc since glib 1.3.12 don't return -1,
and also always NUL terminate the string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27819
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 Mar 2009 15:31:44 +0000 (15:31 +0000)]
From Jakub Zawadzki: g_snprintf() & etc since glib 1.3.12
don't return -1, and also always NUL terminate the string.
We can clean sources by removing dead/unnecessary code.
From me: A few additional changes re use of g_snprintf.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27818
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 22 Mar 2009 15:03:23 +0000 (15:03 +0000)]
[Automatic manuf update for 2009-03-22]
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27816
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Sun, 22 Mar 2009 14:52:17 +0000 (14:52 +0000)]
Add the usual to svn:ignore
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27815
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 22 Mar 2009 06:53:17 +0000 (06:53 +0000)]
Change the signature of init_progfile_dir() so the casting of the
function pointer (to main) to an argument to dladdr() is done in
init_progfile_dir() rather than its callers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27814
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 22 Mar 2009 06:38:02 +0000 (06:38 +0000)]
In Solaris, the second argument to dladdr() is just a void *, not a
const void *.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27813
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 22 Mar 2009 00:42:33 +0000 (00:42 +0000)]
Attempt to use dladdr() to get the pathname of the executable image if
it's available and works.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27812
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 20 Mar 2009 23:20:45 +0000 (23:20 +0000)]
proto_item_append_string() actually appends to the string value for a
protocol tree item; the item being added to isn't a string, so
proto_item_append_text() should be used - but the second argument to
proto_item_append_text() should always be a format string.
Use #if 0/#endif to leave a data structure in the source code without
compiling it in, rather than a comment (if you use a comment, things can
break if you put a comment into the commented-out code).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27811
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 20 Mar 2009 23:15:15 +0000 (23:15 +0000)]
Switch back to 1.1.4.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27810
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Fri, 20 Mar 2009 22:39:29 +0000 (22:39 +0000)]
Fix broken linux build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27809
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Fri, 20 Mar 2009 20:15:46 +0000 (20:15 +0000)]
Further NAS updates.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27808
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 20 Mar 2009 16:17:02 +0000 (16:17 +0000)]
Temporarily switch back to building 1.1.3 final.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27807
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 20 Mar 2009 12:41:03 +0000 (12:41 +0000)]
Put check_col() in each column util function, as discussed in bug 2902.
This will eliminate some problems when not checking before calling the
functions, and makes the dissector code looks cleaner.
Cleaning up the dissectors is TBD.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27806
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 20 Mar 2009 11:43:48 +0000 (11:43 +0000)]
Added some svn:ignore targets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27805
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Fri, 20 Mar 2009 11:06:20 +0000 (11:06 +0000)]
From Dejan Bucar (bug 3345):
Added official LINX Ethernet type.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27804
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 20 Mar 2009 10:44:42 +0000 (10:44 +0000)]
remove GPLv2 CRC code, the new epan CRC stuff is working well
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27803
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 Mar 2009 22:03:33 +0000 (22:03 +0000)]
More NAS EPS updates and bugfixes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27802
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 Mar 2009 22:02:46 +0000 (22:02 +0000)]
Revert the previous changes MCC and MNC are coded differently in different places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27801
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 Mar 2009 17:49:11 +0000 (17:49 +0000)]
As suggested by Jakub Zawadzki: actually use sizeof(...) rather than a numeric constant in various places;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27800
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 Mar 2009 17:47:00 +0000 (17:47 +0000)]
-As suggested by Jakub Zawadzki: use sizeof(...) rather than a numeric constant in various places;
Also:
- Change indentation to be consistent;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27799
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 Mar 2009 17:44:57 +0000 (17:44 +0000)]
-As suggested by Jakub Zawadzki: use sizeof(...) rather than a numeric constant in various places;
Also:
- Change ct_port_to_str to be slightly simpler and more efficient;
- Change indentation to be consistent;
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27798
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 19 Mar 2009 17:40:18 +0000 (17:40 +0000)]
Add an expert item for the seconds-encoded-as-little-endian bug.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27797
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 Mar 2009 06:42:46 +0000 (06:42 +0000)]
Use GTK 2.16 and glib 2.20.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27796
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 19 Mar 2009 06:41:41 +0000 (06:41 +0000)]
From Michael Lum:
MEID digit translation fix.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3341
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27795
f5534014-38df-0310-8fa8-
9805f1628bb7
wmeier [Thu, 19 Mar 2009 01:54:09 +0000 (01:54 +0000)]
- Move register_dissector(...) from proto_reg_handoff() to proto_register();
- Use dissector_add_handle("udp",...) rather than dissector_add(""udp",0,...)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27794
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 19 Mar 2009 00:05:26 +0000 (00:05 +0000)]
Don't include <stdint.h>, as our Win32 environment appears not to have
it; we're using GLib types, instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27793
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 23:30:21 +0000 (23:30 +0000)]
Clean up indentation.
Note that -5047 can also mean "disk quota exceeded".
Define the ASP errors as 32-bit (negative) numbers, just like the AFP
errors.
Add a couple of ASP errors to the list of error values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27792
f5534014-38df-0310-8fa8-
9805f1628bb7
stig [Wed, 18 Mar 2009 23:06:08 +0000 (23:06 +0000)]
Removed C++ style comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27791
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 18 Mar 2009 21:59:30 +0000 (21:59 +0000)]
Create an "epan/crc" directory for CRC code. Add crc-16-plain.[ch],
generated from pycrc. The command line used to generate the file is in
epan/crc/Makefile.common. I used "plain" to distinguish it from CCITT,
USB, and other 16-bit CRCs. Integrate the new CRC code into our
infrastructure.
Add crc16_plain_tvb_offset() to epan/crc16.[ch] and use it in
plugins/profinet/packet-pn-rt.c. This _should_ work correctly, but
hasn't been tested.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27790
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 21:40:04 +0000 (21:40 +0000)]
Don't g_assert() in a dissector, just drive on.
Use ws_fopen(), not fopen(), to open files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27789
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 21:37:56 +0000 (21:37 +0000)]
Don't g_assert() in a dissector; just drive on.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27788
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:56:21 +0000 (20:56 +0000)]
None of those strings will have a length that doesn't fit in a gulong.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27787
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:54:28 +0000 (20:54 +0000)]
Get rid of a bunch of uses of size_t where int suffices.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27786
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:48:42 +0000 (20:48 +0000)]
Squelch a P64 warning.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27785
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:47:22 +0000 (20:47 +0000)]
Get rid of P64 warnings; those strings should never be longer than 2^31-1.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27784
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:45:57 +0000 (20:45 +0000)]
Use g_strreverse() to reverse strings.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27783
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:42:59 +0000 (20:42 +0000)]
Get rid of some P64 warnings; those lengths should never be > 2^31-1.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27782
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 18 Mar 2009 20:41:45 +0000 (20:41 +0000)]
Get rid of uses of size_t; they're not necessary, and it causes a pile
of 64-bit-to-32-bit conversion warnings in LLP64 environments such as
Win64.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27781
f5534014-38df-0310-8fa8-
9805f1628bb7
richardv [Wed, 18 Mar 2009 20:31:15 +0000 (20:31 +0000)]
improve dissection of optional parameters. In particular, make the tag and length fields explicit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27780
f5534014-38df-0310-8fa8-
9805f1628bb7
richardv [Wed, 18 Mar 2009 20:30:35 +0000 (20:30 +0000)]
fix unused parameter warning
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27779
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 18 Mar 2009 19:40:54 +0000 (19:40 +0000)]
- Fix APDU dissection.
- NAS EPS bugfixes and enhancements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27778
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 18 Mar 2009 17:05:41 +0000 (17:05 +0000)]
Fix the Lua path on Win64.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27777
f5534014-38df-0310-8fa8-
9805f1628bb7
martinm [Wed, 18 Mar 2009 16:21:45 +0000 (16:21 +0000)]
Use retx info in stats window.
User guide help not added yet, as having trouble building...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27776
f5534014-38df-0310-8fa8-
9805f1628bb7