obnox/wireshark/wip.git
22 years agoFree the string you "g_strdup()"ed, rather than handing "g_free()" the
guy [Thu, 31 May 2001 05:33:15 +0000 (05:33 +0000)]
Free the string you "g_strdup()"ed, rather than handing "g_free()" the
null pointer that provoked you to free the string.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3485 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoSupport for filtering on absolute and relative time fields, from Ronnie
guy [Thu, 31 May 2001 05:01:06 +0000 (05:01 +0000)]
Support for filtering on absolute and relative time fields, from Ronnie
Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3484 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdates from Johan Jorgensen.
guy [Wed, 30 May 2001 19:17:31 +0000 (19:17 +0000)]
Updates from Johan Jorgensen.

Don't use "pinfo->captured_len" to check the length of the packet -
that's the length of the *entire* frame, not the length of the portion
that belongs to the 802.11 dissector (there are currently no dissectors
for protocols in which 802.11 is encapsulated, so it doesn't currently
make a difference, but dissectors should use "tvb_length()" and so on to
get that information for the tvbuff they were handed).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3483 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoiSCSI support, from Mark Burton.
guy [Wed, 30 May 2001 18:52:38 +0000 (18:52 +0000)]
iSCSI support, from Mark Burton.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3482 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoMSVC++ doesn't define "uint"; use "guint" instead.
guy [Wed, 30 May 2001 08:49:23 +0000 (08:49 +0000)]
MSVC++ doesn't define "uint"; use "guint" instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3481 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoGet rid of some unnecessary settings of "pinfo->current_proto" - if the
guy [Wed, 30 May 2001 07:48:23 +0000 (07:48 +0000)]
Get rid of some unnecessary settings of "pinfo->current_proto" - if the
dissector is called only through a handle or dissector table, the code
that handles those calls sets it for you.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3480 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the Vines IP dissector through a handle, and call the Vines SPP
guy [Wed, 30 May 2001 07:41:18 +0000 (07:41 +0000)]
Call the Vines IP dissector through a handle, and call the Vines SPP
dissector through a handoff table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3479 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoNo old-style dissectors call "old_dissector_try_port()", so get rid of
guy [Wed, 30 May 2001 06:41:08 +0000 (06:41 +0000)]
No old-style dissectors call "old_dissector_try_port()", so get rid of
"old_dissector_try_port()".

There are no longer any old-style heuristic or conversation dissectors,
so get rid of "old_heur_dissector_add()" and "old_conv_dissector_add()"
and the data-structure members that support old-style heuristic and
conversation dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3478 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoThere are no more old-style (non-tvbuffified) ONC RPC dissectors, so get
guy [Wed, 30 May 2001 06:01:02 +0000 (06:01 +0000)]
There are no more old-style (non-tvbuffified) ONC RPC dissectors, so get
rid of support for them, and remove the "_tvb" from the end of the names
of RPC type dissection routines.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3477 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoTvbuffified NFS dissector, from Mike Frisch, plus some registered-field
guy [Wed, 30 May 2001 04:40:27 +0000 (04:40 +0000)]
Tvbuffified NFS dissector, from Mike Frisch, plus some registered-field
cleanups.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3476 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix a typo.
guy [Mon, 28 May 2001 20:18:08 +0000 (20:18 +0000)]
Fix a typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3475 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoWe now might print four IP addresses on a protocol tree line, so make
guy [Mon, 28 May 2001 20:12:30 +0000 (20:12 +0000)]
We now might print four IP addresses on a protocol tree line, so make
"ip_to_str()" capable of producing up to four separate strings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3474 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix the copyright notice to reflect the fact that Gerald holds the
guy [Sun, 27 May 2001 21:38:46 +0000 (21:38 +0000)]
Fix the copyright notice to reflect the fact that Gerald holds the
copyright on Ethereal as a whole.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3473 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoWe can't use a single static buffer for decrypted ICQ data - you might
guy [Sun, 27 May 2001 21:37:23 +0000 (21:37 +0000)]
We can't use a single static buffer for decrypted ICQ data - you might
have more than one decrypted ICQ packet visible at a time, as you might
have popped up additional single-packet windows for those packets.
Allocate the buffer for the decrypted data when you decrypt, and arrange
that it be freed when the tvbuff that refers to it is freed.

Fix the copyright notice to reflect the fact that Gerald holds the
copyright on Ethereal as a whole.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3472 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix a comment, and update Gerald's e-mail address.
guy [Sun, 27 May 2001 21:34:05 +0000 (21:34 +0000)]
Fix a comment, and update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3471 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoPlug a memory leak (we weren't freeing the "epan_dissect_t" pointed to
guy [Sun, 27 May 2001 21:33:16 +0000 (21:33 +0000)]
Plug a memory leak (we weren't freeing the "epan_dissect_t" pointed to
by the "edt" member of a "capture_file" structure if we were selecting a
new frame, we were just overwriting that pointer).

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3470 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoDon't use END_OF_FRAME - or otherwise refer to "pi" - in tvbuffified
guy [Sun, 27 May 2001 09:15:14 +0000 (09:15 +0000)]
Don't use END_OF_FRAME - or otherwise refer to "pi" - in tvbuffified
dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3469 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoDon't use END_OF_FRAME in tvbuffified dissectors.
guy [Sun, 27 May 2001 08:45:51 +0000 (08:45 +0000)]
Don't use END_OF_FRAME in tvbuffified dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3468 f5534014-38df-0310-8fa8-9805f1628bb7

22 years ago"END_OF_FRAME" should not be used in tvbuffified dissectors.
guy [Sun, 27 May 2001 08:09:49 +0000 (08:09 +0000)]
"END_OF_FRAME" should not be used in tvbuffified dissectors.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3467 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoGive protocol tree windows a horizontal scrollbar - yes, sometimes
guy [Sun, 27 May 2001 07:50:28 +0000 (07:50 +0000)]
Give protocol tree windows a horizontal scrollbar - yes, sometimes
protocol tree lines can be long enough that you might want, or even
need, one (consider really long names for SNMP OIDs, for example).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3466 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the LANE dissector through a handle.
guy [Sun, 27 May 2001 07:46:57 +0000 (07:46 +0000)]
Call the LANE dissector through a handle.

Create an ILMI dissector and call it through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3465 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the H.261 dissector through a handle.
guy [Sun, 27 May 2001 07:37:46 +0000 (07:37 +0000)]
Call the H.261 dissector through a handle.

Set the reported length of the tvbuff we hand to the H.261 dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3464 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoNo need to include "packet-q931.h" any more, as we're calling the Q.931
guy [Sun, 27 May 2001 07:28:00 +0000 (07:28 +0000)]
No need to include "packet-q931.h" any more, as we're calling the Q.931
dissector through a handle.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3463 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the Q.931 dissector through a handle.
guy [Sun, 27 May 2001 07:27:21 +0000 (07:27 +0000)]
Call the Q.931 dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3462 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoThe Q.2931 dissector is only called through a handle, so it doesn't need
guy [Sun, 27 May 2001 07:18:08 +0000 (07:18 +0000)]
The Q.2931 dissector is only called through a handle, so it doesn't need
to check whether the protocol is enabled and doesn't need to set
"pinfo->current_proto".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3461 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the Q.2931 dissector through a handle.
guy [Sun, 27 May 2001 07:15:26 +0000 (07:15 +0000)]
Call the Q.2931 dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3460 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the GVRP dissector through a handle.
guy [Sun, 27 May 2001 07:07:34 +0000 (07:07 +0000)]
Call the GVRP dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3459 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the AFS dissector through a handle.
guy [Sun, 27 May 2001 05:00:17 +0000 (05:00 +0000)]
Call the AFS dissector through a handle.

Update Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3458 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCall the SSCOP dissector through a handle. That lets us get rid of the
guy [Sun, 27 May 2001 04:50:51 +0000 (04:50 +0000)]
Call the SSCOP dissector through a handle.  That lets us get rid of the
CHECK_DISPLAY_AS_DATA call and code to set "pinfo->current_proto", as
"call_dissector()" does that for us.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3457 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIn the ICMPv6 and OSI CLNP dissectors, when calling the IPv6 or CLNP
guy [Sun, 27 May 2001 04:14:53 +0000 (04:14 +0000)]
In the ICMPv6 and OSI CLNP dissectors, when calling the IPv6 or CLNP
dissector to dissect the datagram inside an error report datagram, save
the current values of the source and destination addresses, and restore
them after the subdissector returns, so that all address columns in the
summary pane will reflect the error datagram, not the datagram that
provoked the error.

Set the Protocol and Info columns upon entry to the ICMPv6 dissector, so
that if we throw an exception they don't reflect the protocol above
ICMPv6.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3456 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIn the IPv6 dissector, don't bother with the "CHECK_DISPLAY_AS_DATA()",
guy [Sun, 27 May 2001 02:16:32 +0000 (02:16 +0000)]
In the IPv6 dissector, don't bother with the "CHECK_DISPLAY_AS_DATA()",
as it's called only through a handle or a dissector table, and the code
that handles those calls does the check.

Also, set the Protocol and Info columns before fetching anything from
the packet, so they're set if we throw an exception.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3455 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoRX and AFS dissectors tvbuffified, and bugs fixed, by Ronnie Sahlberg.
guy [Sun, 27 May 2001 01:48:25 +0000 (01:48 +0000)]
RX and AFS dissectors tvbuffified, and bugs fixed, by Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3454 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAUTH_DES support, from Mike Frisch.
guy [Fri, 25 May 2001 20:13:04 +0000 (20:13 +0000)]
AUTH_DES support, from Mike Frisch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3453 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdate Gerald's e-mail address.
guy [Fri, 25 May 2001 18:44:01 +0000 (18:44 +0000)]
Update Gerald's e-mail address.

Use "col_add_fstr()" to set the Info column, rather than "sprintf()"ing
to a buffer and using "col_add_str()".

Add a routine that dissects unknown types of IGMP messages, and use it
for all IGMP messages for which we don't have a dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3452 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix Gerald's e-mail address.
guy [Fri, 25 May 2001 16:19:31 +0000 (16:19 +0000)]
Fix Gerald's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3451 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoISUP support, from Martina Obermeier.
guy [Fri, 25 May 2001 16:17:45 +0000 (16:17 +0000)]
ISUP support, from Martina Obermeier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3450 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoWe always have to make one pass over the BOOTP options to see if the
guy [Fri, 25 May 2001 06:56:53 +0000 (06:56 +0000)]
We always have to make one pass over the BOOTP options to see if the
packet is BOOTP or DHCP; have "bootp_option()" take a flag indicating
whether it's the first pass or the second and, in the first pass, don't
put anything in the protocol tree - just return, through pointers, the
DHCP packet type and the vendor class ID.  On the second pass, don't
modify what those pointers point to, just use them as appropriate.

Make the vendor class ID pointer local to "dissect_bootp()", and have
"dissect_bootp()" do the first pass, set the Protocol and Info columns
appropriately if the packet is DHCP, and then, if a protocol tree is to
be built, make a second pass, handing "bootp_option()" the DHCP packet
type and vendor class ID we found.

If the vendor class ID is null, don't try to compare it with Intel's PXE
client indicator.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3449 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoPut in limited support for some messages that appeared in the old
guy [Fri, 25 May 2001 06:47:02 +0000 (06:47 +0000)]
Put in limited support for some messages that appeared in the old
dissector and that appear in tcpdump's IGMP dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3448 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix to TCP reassembly code for retransmitted data, from Edgar Iglesias.
guy [Thu, 24 May 2001 23:07:41 +0000 (23:07 +0000)]
Fix to TCP reassembly code for retransmitted data, from Edgar Iglesias.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3447 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAppletalk Data Stream Interface (used by AFP-over-TCP) support, from
guy [Thu, 24 May 2001 20:25:25 +0000 (20:25 +0000)]
Appletalk Data Stream Interface (used by AFP-over-TCP) support, from
Randy McEoin.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3446 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoDHCP support for Intel PXEclient DHCP requests, from Joerg Mayer.
guy [Thu, 24 May 2001 19:21:15 +0000 (19:21 +0000)]
DHCP support for Intel PXEclient DHCP requests, from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3445 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoMTP3 support, from Michael Tuexen.
guy [Thu, 24 May 2001 08:13:56 +0000 (08:13 +0000)]
MTP3 support, from Michael Tuexen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3444 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIf you call AC_MSG_CHECKING, you should always call AC_MSG_RESULT.
guy [Thu, 24 May 2001 04:04:42 +0000 (04:04 +0000)]
If you call AC_MSG_CHECKING, you should always call AC_MSG_RESULT.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3443 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdated SSL tests, from Andy Hood.
guy [Wed, 23 May 2001 19:38:07 +0000 (19:38 +0000)]
Updated SSL tests, from Andy Hood.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3442 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIf you put an item into the protocol tree with "dissect_rpc_data_tvb()",
guy [Wed, 23 May 2001 19:29:45 +0000 (19:29 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data_tvb()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3441 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIf you put an item into the protocol tree with "dissect_rpc_data()",
guy [Wed, 23 May 2001 19:13:37 +0000 (19:13 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3440 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIf you put an item into the protocol tree with "dissect_rpc_data_tvb()",
guy [Wed, 23 May 2001 19:06:55 +0000 (19:06 +0000)]
If you put an item into the protocol tree with "dissect_rpc_data_tvb()",
it must be FT_BYTES, not FT_STRING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3439 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoGet rid of an extra colon on a field name, and display that field using
guy [Wed, 23 May 2001 18:52:54 +0000 (18:52 +0000)]
Get rid of an extra colon on a field name, and display that field using
that name.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3438 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoGet rid of extra colons, and fix up the display of default metrics, from
guy [Wed, 23 May 2001 18:44:59 +0000 (18:44 +0000)]
Get rid of extra colons, and fix up the display of default metrics, from
Jean-Christian Pennetier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3437 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAdd tree summary information similar to what's in packet-tcp.c.
gerald [Wed, 23 May 2001 03:33:59 +0000 (03:33 +0000)]
Add tree summary information similar to what's in packet-tcp.c.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3436 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoWin32: build text2pcap doco and package it.
gram [Tue, 22 May 2001 16:19:45 +0000 (16:19 +0000)]
Win32: build text2pcap doco and package it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3435 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAccording to the autoconf documentation, you're not supposed to use
guy [Tue, 22 May 2001 06:43:24 +0000 (06:43 +0000)]
According to the autoconf documentation, you're not supposed to use
AC_MSG_RESULT without AC_MSG_CHECKING.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3434 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoCleanups to the "--with-ssl" configuration option, and changes to add
guy [Tue, 22 May 2001 06:33:06 +0000 (06:33 +0000)]
Cleanups to the "--with-ssl" configuration option, and changes to add
compiler flags on Solaris with GCC to cope with X11 header file
inadequacies.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3433 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix a typo in the "product name", and fix the "internal name".
guy [Mon, 21 May 2001 11:01:56 +0000 (11:01 +0000)]
Fix a typo in the "product name", and fix the "internal name".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3432 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix to LDP prefix FEC dissection for IPv4, from Eran Mann.
guy [Mon, 21 May 2001 10:14:37 +0000 (10:14 +0000)]
Fix to LDP prefix FEC dissection for IPv4, from Eran Mann.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3431 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIf an RPC opaque datum isn't a string, don't use
guy [Mon, 21 May 2001 08:52:17 +0000 (08:52 +0000)]
If an RPC opaque datum isn't a string, don't use
"proto_tree_add_string_format()" to put in the protocol tree item for
the data, use "proto_tree_add_bytes_format()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3430 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAdd resource stuff for text2pcap.
guy [Mon, 21 May 2001 05:04:49 +0000 (05:04 +0000)]
Add resource stuff for text2pcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3429 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoBuild text2pcap on Windows.
guy [Mon, 21 May 2001 03:17:14 +0000 (03:17 +0000)]
Build text2pcap on Windows.

Fix text2pcap.c so that it can be compiled with Microsoft Visual C++
6.0:

protect some includes with #ifdefs, as not all the header files
in question exist in the MSVC++ build environment;

include <winsock.h> if we have it, to declare "ntohs()" and the
like;

include "getopt.h" if we need it, to declare stuff for
"getopt()";

include "config.h" if we have it, so we know whether the header
files in question exist or are needed;

rename "BYTE" to "READ_BYTE", as <winsock.h> defines BYTE as
well, and that definition causes a conflict;

get rid of references to "__FUNCTION__", as MSVC++ doesn't
define it (I suspect at least some UNIX compilers don't define
it, either).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3428 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix up a cast so that it properly sign-extends the server time zone;
guy [Sun, 20 May 2001 22:26:14 +0000 (22:26 +0000)]
Fix up a cast so that it properly sign-extends the server time zone;
from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3427 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoRewritten IGMP dissector, from Ronnie Sahlberg.
guy [Sun, 20 May 2001 22:20:33 +0000 (22:20 +0000)]
Rewritten IGMP dissector, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3426 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAdd the text2pcap generated files to .cvsignore.
guy [Sun, 20 May 2001 22:06:04 +0000 (22:06 +0000)]
Add the text2pcap generated files to .cvsignore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3425 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoDeclare "yylex()" in "text2pcap.h", so that there's a prototype in scope
guy [Thu, 17 May 2001 00:11:37 +0000 (00:11 +0000)]
Declare "yylex()" in "text2pcap.h", so that there's a prototype in scope
when it's used by "text2pcap.c" - and so that the *same* prototype is in
scope when it's defined by "text2pcap-scanner.c".

Define "YY_NO_UNPUT" in "text2pcap.h", so we don't define "yyunput()" in
"text2pcap-scanner.c"; it's not used, so some compilers whine about it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3424 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoDocumentation fix to generalize 'text2pcap -e' for all L3 packets instead of just IP.
ashokn [Wed, 16 May 2001 22:50:36 +0000 (22:50 +0000)]
Documentation fix to generalize 'text2pcap -e' for all L3 packets instead of just IP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3423 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agotext2pcap.1 was not being installed due to an omission in Makefile.am. Fixed this.
ashokn [Wed, 16 May 2001 22:04:53 +0000 (22:04 +0000)]
text2pcap.1 was not being installed due to an omission in Makefile.am. Fixed this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3422 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAdded 'text2pcap', a utility to convert text hexdumps into pcap
ashokn [Wed, 16 May 2001 21:32:05 +0000 (21:32 +0000)]
Added 'text2pcap', a utility to convert text hexdumps into pcap
files. See text2pcap.1 (built from doc/text2pcap.pod) for details.

Changed 'tethereal -x' output to match hex dump format of text2pcap,
Ethereal and others.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3421 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdate hte entry for the Cisco-proprietary capabilities in BGP to give
guy [Wed, 16 May 2001 20:02:51 +0000 (20:02 +0000)]
Update hte entry for the Cisco-proprietary capabilities in BGP to give
the name of the person who submitted that change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3419 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoPut in the name for <bgp4news@yahoo.com>.
guy [Wed, 16 May 2001 20:00:13 +0000 (20:00 +0000)]
Put in the name for <bgp4news@yahoo.com>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3418 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdate NEWS file for release 8.18
jfoster [Wed, 16 May 2001 18:57:47 +0000 (18:57 +0000)]
Update NEWS file for release 8.18

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3417 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoSupport for Cisco-proprietary capabilities in BGP, from
guy [Wed, 16 May 2001 18:52:37 +0000 (18:52 +0000)]
Support for Cisco-proprietary capabilities in BGP, from
<bgp4news@yahoo.com>.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3416 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdate files for release 8.18
jfoster [Wed, 16 May 2001 16:17:52 +0000 (16:17 +0000)]
Update files for release 8.18

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3415 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoStop depending on the order in which operations are performed by
guy [Tue, 15 May 2001 18:58:15 +0000 (18:58 +0000)]
Stop depending on the order in which operations are performed by
generated code, as per Chris Foulds' note.

Also, when constructing the system ID or area string, always append the
four-octet groups, rather than overwriting them, as we had been doing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3414 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoVarious ISIS improvements (ISIS IPv6 routing TLV dissection, ISIS
guy [Mon, 14 May 2001 18:40:17 +0000 (18:40 +0000)]
Various ISIS improvements (ISIS IPv6 routing TLV dissection, ISIS
traffic engineering TLV dissection, IS neighbor and IP reachability TLVs
given their own subtree types), from Jean-Christian Pennetier.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3413 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdates to OSPF for the changes between drafts 3 and 4 of
guy [Mon, 14 May 2001 18:25:34 +0000 (18:25 +0000)]
Updates to OSPF for the changes between drafts 3 and 4 of
draft-katz-yeung-ospf-traffic, from Michael Rozhavsky.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3412 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix a bug reported by Christopher McAvaney in
gerald [Sat, 12 May 2001 19:45:37 +0000 (19:45 +0000)]
Fix a bug reported by Christopher McAvaney in
http://www.ethereal.com/lists/ethereal-dev/200104/msg00152.html.
In the display filter help window, the height of the text widget
can easily exceed the maximum height of an X window, which results
in a nonfunctioning vertical scroll bar.  This fix disables the
GtkScrolledWindow vertical scroll bar, and creates a new scroll bar
attached directly to the GtkText widget.

The layout is a little off - the horizontal scroll bar now occupies the
full height of the GtkScrolledWindow widget.  There doesn't seem to be
an easy way to grab the height of the horizontal scroll bar in order to
pad out the are underneath the vertical scroll bar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3411 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoPassive FTP support, from Juan Toledo.
guy [Fri, 11 May 2001 23:24:10 +0000 (23:24 +0000)]
Passive FTP support, from Juan Toledo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3410 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoUpdates for the current CVS version of autoconf, from Nathan Neulinger
guy [Fri, 11 May 2001 01:09:59 +0000 (01:09 +0000)]
Updates for the current CVS version of autoconf, from Nathan Neulinger
(without those updates, I'm not even certain it was doing the right
thing even with autoconf 2.13, as it was sticking "dnl" into the program
it was handing to the C preprocessor, although, as it was only handing
it to the preprocessor, the extra "dnl" may have been harmless).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3409 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAutomake updates, from Nathan Neulinger, to handle the current CVS
guy [Fri, 11 May 2001 00:39:57 +0000 (00:39 +0000)]
Automake updates, from Nathan Neulinger, to handle the current CVS
version of automake (which will probably eventually become the next
release of automake) - it assumes variables that end with _SOURCES are
of the form "target_SOURCES", where "target" must be a target that the
Makefile builds.

Rename "DISSECTOR_SOURCES" to "DISSECTOR_SRC" in "Makefile.nmake", as
well, so that part of "Makefile.nmake" exactly matches that part of
"Makefile.am".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3408 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoPatch from Chris Jepeway to use, in NetXRay 2.x captures, a field from
guy [Wed, 9 May 2001 04:42:27 +0000 (04:42 +0000)]
Patch from Chris Jepeway to use, in NetXRay 2.x captures, a field from
the file header to specify the time units; different files appear to
have different time stamp units.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3407 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoWhen generating a filter expression to match a protocol tree line not
guy [Wed, 9 May 2001 01:22:46 +0000 (01:22 +0000)]
When generating a filter expression to match a protocol tree line not
corresponding to a named field, by matching stuff at a particular offset
in the frame, don't treat a length of 1 byte specially - the syntax for
a one-byte byte string is the same as for longer byte strings, with no
leading "0x" allowed.

Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3406 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoOnly set the Info column to an error indication if we haven't already
guy [Tue, 8 May 2001 19:50:29 +0000 (19:50 +0000)]
Only set the Info column to an error indication if we haven't already
put a packet description there.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3405 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoAdditional LDAP checks for invalid packets, from Scott Renfro.
guy [Tue, 8 May 2001 19:46:32 +0000 (19:46 +0000)]
Additional LDAP checks for invalid packets, from Scott Renfro.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3404 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoFix one remaining "NIS" to be "NIS+".
guy [Mon, 7 May 2001 21:11:42 +0000 (21:11 +0000)]
Fix one remaining "NIS" to be "NIS+".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3403 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoIf "proto_item_set_len()" is passed a null pointer as its first
guy [Mon, 7 May 2001 21:06:59 +0000 (21:06 +0000)]
If "proto_item_set_len()" is passed a null pointer as its first
argument, have it just return; this allows dissectors that don't
explicitly check for a null protocol-tree argument to pass the
protocol-tree argument to "proto_tree_add_XXX()" routines - which means
they'll get a null pointer back if the protocol-tree argument is null
because we're not constructing a protocol tree - and then later use
"proto_item_set_len()" without having to check for a null
protocol-tree-item pointer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3402 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoNIS+ support, from Ronnie Sahlberg.
guy [Mon, 7 May 2001 20:49:48 +0000 (20:49 +0000)]
NIS+ support, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3401 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoSupport for dissecting XDR arrays, from Ronnie Sahlberg.
guy [Mon, 7 May 2001 20:36:39 +0000 (20:36 +0000)]
Support for dissecting XDR arrays, from Ronnie Sahlberg.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3400 f5534014-38df-0310-8fa8-9805f1628bb7

22 years agoPIM enhancements and fixes, from Heikki Vatiainen.
guy [Mon, 7 May 2001 20:26:25 +0000 (20:26 +0000)]
PIM enhancements and fixes, from Heikki Vatiainen.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3399 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoIPX SAP over IPX EIGRP support, and IP EIGRP authentication updates,
guy [Thu, 3 May 2001 22:50:33 +0000 (22:50 +0000)]
IPX SAP over IPX EIGRP support, and IP EIGRP authentication updates,
from Paul Ionescu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3398 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agouint8_t changed to guint8
girlich [Thu, 3 May 2001 07:02:50 +0000 (07:02 +0000)]
uint8_t changed to guint8

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3397 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoUpdates from Alexandre P. Ferreira.
guy [Wed, 2 May 2001 22:37:06 +0000 (22:37 +0000)]
Updates from Alexandre P. Ferreira.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3396 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdditional OSPF LSA types and opaque-options flag, from Michael
guy [Wed, 2 May 2001 18:12:46 +0000 (18:12 +0000)]
Additional OSPF LSA types and opaque-options flag, from Michael
Rozhavsky.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3395 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoPut in a comment warning that
guy [Tue, 1 May 2001 21:39:41 +0000 (21:39 +0000)]
Put in a comment warning that

1) "tvb_get_ntohll()" isn't available on all platforms (e.g.,
   with at least some compilers on Siemens' Sinix)

and

2) "%ll{d,o,x}" won't necessarily print a "long long int"
   quantity (e.g., on FreeBSD and Digital UNIX).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3394 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoBugfix: Removed an unnecessary and potentially spurious include from RSVP.
ashokn [Tue, 1 May 2001 18:33:06 +0000 (18:33 +0000)]
Bugfix: Removed an unnecessary and potentially spurious include from RSVP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3393 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago- Added support for RSVP Refresh Reduction Extensions
ashokn [Tue, 1 May 2001 18:19:04 +0000 (18:19 +0000)]
- Added support for RSVP Refresh Reduction Extensions
(draft-ietf-rsvp-refresh-reduct-05).

- Added one-line summary of each RSVP object in the object line.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3392 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoAdded support for DHCP Authentication extensions specified in
ashokn [Tue, 1 May 2001 03:54:04 +0000 (03:54 +0000)]
Added support for DHCP Authentication extensions specified in
draft-ietf-dhc-authentication-16.txt

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3391 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoBase HAVE_PLUGINS on whether "g_module_supported()" returns TRUE, not on
guy [Tue, 1 May 2001 02:44:52 +0000 (02:44 +0000)]
Base HAVE_PLUGINS on whether "g_module_supported()" returns TRUE, not on
whether there's a "dlfcn.h" header file; that lets us support plugins on
HP-UX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3390 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago"-l" command-line option to turn on automatic scrolling in "Update list
guy [Tue, 1 May 2001 00:41:46 +0000 (00:41 +0000)]
"-l" command-line option to turn on automatic scrolling in "Update list
of captures in real time" captures, from Christian Lacunza.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3389 f5534014-38df-0310-8fa8-9805f1628bb7

23 years ago"prefs.capture_real_time", not "prefs.capture_auto_scroll", should
guy [Tue, 1 May 2001 00:18:48 +0000 (00:18 +0000)]
"prefs.capture_real_time", not "prefs.capture_auto_scroll", should
control whether we have a child process do the capturing; a user might
want the packet list to be updated as packets arrive but *not* want it
to scroll so that the most recently arrived packets are shown.

"prefs.capture_auto_scroll", not "auto_scroll_live", should control
whether we scroll a real-time-update capture's packet list;
"auto_scroll_live" isn't set by the capture dialog box,
"prefs_capture_auto_scroll" is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3388 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMake the "pktsize" argument to "dissect_icqv5Server()" an "int", as it
guy [Fri, 27 Apr 2001 01:38:19 +0000 (01:38 +0000)]
Make the "pktsize" argument to "dissect_icqv5Server()" an "int", as it
can either be a 16-bit unsigned) packet size, or -1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3387 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoMore signed-vs-unsigned changes from Joerg Mayer.
guy [Fri, 27 Apr 2001 01:27:37 +0000 (01:27 +0000)]
More signed-vs-unsigned changes from Joerg Mayer.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3386 f5534014-38df-0310-8fa8-9805f1628bb7

23 years agoGet rid of support for non-tvbuffified plugin dissectors.
guy [Wed, 25 Apr 2001 08:41:22 +0000 (08:41 +0000)]
Get rid of support for non-tvbuffified plugin dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@3385 f5534014-38df-0310-8fa8-9805f1628bb7