obnox/wireshark/wip.git
20 years agotry to dissect the ms cldap netlogon rpc flags bits.
sahlberg [Tue, 20 Apr 2004 08:33:15 +0000 (08:33 +0000)]
try to dissect the ms cldap netlogon rpc  flags bits.
the information comes from the samba sources and may or may not
be reliable or menaingful.

ms documentation in their knowledgebase says that the only really important part
in the netlogon response is the sitename.

(i have reasons to belive at least one of the flags,  closest, is completely bogous)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10649 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agofixed MSVC problems
ulfl [Tue, 20 Apr 2004 05:32:46 +0000 (05:32 +0000)]
fixed MSVC problems

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10648 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom metatech: basic BEA Tuxedo protocol support.
guy [Tue, 20 Apr 2004 05:07:23 +0000 (05:07 +0000)]
From metatech: basic BEA Tuxedo protocol support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10647 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jelmer Vernooij:
guy [Tue, 20 Apr 2004 04:48:32 +0000 (04:48 +0000)]
From Jelmer Vernooij:

Add support for a couple more SNAC's.

Handle TLV's in a somewhat more extendible manner.

Fix a bug in the buddylist dissector that caused pango warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10646 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Yuriy Sidelnikov: add a dissector table for OIDs to the ACSE
guy [Tue, 20 Apr 2004 04:17:52 +0000 (04:17 +0000)]
From Yuriy Sidelnikov: add a dissector table for OIDs to the ACSE
dissector, and make the FTAP dissector register itself in that table.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10645 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a textual "(Dont Fragment)" and "(More Fragments)" to the ip.flags line
obiot [Mon, 19 Apr 2004 23:36:46 +0000 (23:36 +0000)]
Add a textual "(Dont Fragment)" and "(More Fragments)" to the ip.flags line
in case the DF bit or the MF bit is set.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10644 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a bug in the processing of WV-CSP OPAQUE data (TCPAddress was Integer in
obiot [Mon, 19 Apr 2004 23:26:36 +0000 (23:26 +0000)]
Fix a bug in the processing of WV-CSP OPAQUE data (TCPAddress was Integer in
WV-CSP 1.0 but became a String from WV-CSP 1.1 onwards).

The token code page 3 of WV-CSP 1.2 is the same as in WV-CSP 1.1 (not 1.0).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10643 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut the value(s) of a parameter into the top-level item for that
guy [Mon, 19 Apr 2004 22:41:19 +0000 (22:41 +0000)]
Put the value(s) of a parameter into the top-level item for that
parameter, and clean up the display of the value(s) under that item.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10642 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd length checks to submessages.
guy [Mon, 19 Apr 2004 20:20:49 +0000 (20:20 +0000)]
Add length checks to submessages.

Clean up the handling of parameter sequences - add a bunch of length
checking, give each parameter a protocol tree item with the
ID/length/value under it, and don't format variable-length string
parameters into fixed-length buffers.  Use the parameter-sequence
dissector for the ISSUE message.

Use the "number of bits" value when dissecting a bitmap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10641 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate Pasi Eronen's e-mail address.
guy [Mon, 19 Apr 2004 08:26:12 +0000 (08:26 +0000)]
Update Pasi Eronen's e-mail address.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10640 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse a "while()" loop, rather than a "do { ... } while()" loop, in
guy [Mon, 19 Apr 2004 08:19:48 +0000 (08:19 +0000)]
Use a "while()" loop, rather than a "do { ... } while()" loop, in
"dissect_rtps()", just in case a message with *no* submessages is sent.

Fetch the flags field in that loop, as we need the E bit value to
determine the byte order of the "next submessage offset" field; fetch
that value in the loop as well, and pass both those values, and the
byte-order flag, to submessage dissector routines as necessary.

Make the main protocol tree item for each submessage cover the entire
submessage; put into that protocol tree an item that covers the
submessage ID, with a named field.

Construct the submessage subtree in that loop, rather than in the
submessage dissectors.

Put into that subtree items for the flags and next submessage offset; we
do that in the submessage dissector, as the interpretation of the bits
in the flags field differs from submessage to submessage.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10639 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe "next_submsg" argument passed to "get_bitmap()" is an offset within
guy [Sun, 18 Apr 2004 20:08:59 +0000 (20:08 +0000)]
The "next_submsg" argument passed to "get_bitmap()" is an offset within
the tvbuff, not a relative offset, so it should just be a "gint".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10638 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of an unused variable.
guy [Sun, 18 Apr 2004 19:52:06 +0000 (19:52 +0000)]
Get rid of an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10637 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake "little_endian" local to the routines to parse submessages.
guy [Sun, 18 Apr 2004 18:55:13 +0000 (18:55 +0000)]
Make "little_endian" local to the routines to parse submessages.

Before checking for the "RTPS" tag, make sure we have at least 4 bytes
in the message.

Use "tvb_reported_length()" to get the length of the message, so we
throw an exception on a packet cut short by a snapshot length.

Put in a comment asking whether the byte order of the "offset to next
submessage" field is little-endian or specified by the E bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10636 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate the cygwin build instructions (plugins can now be compiled too).
obiot [Sun, 18 Apr 2004 10:16:19 +0000 (10:16 +0000)]
Update the cygwin build instructions (plugins can now be compiled too).

Hint on how cygwin gcc can be used to compile a native Win32 Ethereal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10635 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded a small section about the supported compilers
ulfl [Sun, 18 Apr 2004 06:41:42 +0000 (06:41 +0000)]
added a small section about the supported compilers

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10634 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoremoved some MSVC warnings
ulfl [Sun, 18 Apr 2004 06:40:27 +0000 (06:40 +0000)]
removed some MSVC warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10633 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoreplaced some integer types by glib ones,
ulfl [Sun, 18 Apr 2004 06:39:31 +0000 (06:39 +0000)]
replaced some integer types by glib ones,
to be able to compile again on win32

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10632 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut "#" in pre-processor keywords at the beginning of the line - I seem
guy [Sat, 17 Apr 2004 22:11:42 +0000 (22:11 +0000)]
Put "#" in pre-processor keywords at the beginning of the line - I seem
to remember that at least at one point in the history of C, at least one
compiler required that.

Clean up the byte-order stuff - LITTLE_ENDIAN and BIG_ENDIAN aren't
defined by Ethereal or GLib, so we shouldn't use them (some platforms
might define them, but at least some platforms define them *both* as
non-zero values, so they can't be used as "true or false" values for
"e_bit"), and we don't need to worry about the byte order of the machine
running Ethereal - we should just use Ethereal's standard routines to
fetch little-endian or big-endian values.

Get rid of C++ comments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10631 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Lukas Pokorny: RTPS (Real-Time Publish-Subscribe) support.
guy [Sat, 17 Apr 2004 21:43:32 +0000 (21:43 +0000)]
From Lukas Pokorny: RTPS (Real-Time Publish-Subscribe) support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10630 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdates from metatech:
guy [Sat, 17 Apr 2004 20:58:49 +0000 (20:58 +0000)]
Updates from metatech:

- Added SPI messages.
- A bit a factorisation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10629 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded PSML output to the printing dialog
ulfl [Sat, 17 Apr 2004 11:50:14 +0000 (11:50 +0000)]
added PSML output to the printing dialog

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10628 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix a typo in %DateTime of length 7 (missing colon between minutes and seconds).
obiot [Sat, 17 Apr 2004 10:45:58 +0000 (10:45 +0000)]
Fix a typo in %DateTime of length 7 (missing colon between minutes and seconds).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10627 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPDML output: if a protocol field is invisible,
ulfl [Sat, 17 Apr 2004 09:02:32 +0000 (09:02 +0000)]
PDML output: if a protocol field is invisible,
add the attribute: hide="yes" to the field node

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10626 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoNeaten up the display of the top-level protocol tree item for a number
guy [Sat, 17 Apr 2004 04:43:58 +0000 (04:43 +0000)]
Neaten up the display of the top-level protocol tree item for a number
IE.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10625 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIn EnterNotify and LeaveNotify events, the last byte isn't a Boolean,
guy [Sat, 17 Apr 2004 03:38:09 +0000 (03:38 +0000)]
In EnterNotify and LeaveNotify events, the last byte isn't a Boolean,
it's a bitmask with "focus" and "same-screen" bits.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10624 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoThe value returned by "diameter_avp_get_value()" is used only in
guy [Sat, 17 Apr 2004 03:02:01 +0000 (03:02 +0000)]
The value returned by "diameter_avp_get_value()" is used only in
protocol tree items that also have the AVP value in the text, so there's
no reason to have the string returned by "diameter_avp_get_value()"
contain that value as well - it's redundant.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10623 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoConfirmation dialogs should be marked as such.
guy [Sat, 17 Apr 2004 01:12:47 +0000 (01:12 +0000)]
Confirmation dialogs should be marked as such.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10622 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFailure to get the list of interfaces should be reported as an error.
guy [Sat, 17 Apr 2004 01:10:09 +0000 (01:10 +0000)]
Failure to get the list of interfaces should be reported as an error.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10621 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFailures when capturing should be reported as errors.
guy [Sat, 17 Apr 2004 01:07:47 +0000 (01:07 +0000)]
Failures when capturing should be reported as errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10620 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUpdate to handle the changed epan_init() API, with a "general failure"
guy [Sat, 17 Apr 2004 01:05:00 +0000 (01:05 +0000)]
Update to handle the changed epan_init() API, with a "general failure"
routine added.  Add a missing newline to the end of read failure
messages.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10619 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoReport problems due to the user specifying something we can't handle as
guy [Sat, 17 Apr 2004 01:01:22 +0000 (01:01 +0000)]
Report problems due to the user specifying something we can't handle as
errors, not warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10618 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoReport errors in opening various configuration files at the time the
guy [Fri, 16 Apr 2004 23:57:54 +0000 (23:57 +0000)]
Report errors in opening various configuration files at the time the
failure occurs; now that "simple_dialog()" queues up messages if we
don't yet have the main window, those messages will be queued up until
then.

Move the point at which we pop up those queued messages after the
"process all pending GUI events" is done, so that those messages are
properly displayed on top of the main window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10617 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a "report_failure()" routine to allow dissectors to report arbitrary
guy [Fri, 16 Apr 2004 23:17:13 +0000 (23:17 +0000)]
Add a "report_failure()" routine to allow dissectors to report arbitrary
errors to the user.  Use that, rather than "g_warning()", in the
Diameter dissector to report errors reading the dictionary.

Make the format argument to "simple_dialog()" a "const" pointer.

Fix up the read-error message in Tethereal to end with a newline.

If a simple dialog is requested before the main window or the
capture-control window is popped up, queue it up and pop the queued
messages up once the main or capture-control window is displayed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10616 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a discriminator for WV-CSP so the correct version is used for rendering the WBXML...
obiot [Fri, 16 Apr 2004 22:44:24 +0000 (22:44 +0000)]
Add a discriminator for WV-CSP so the correct version is used for rendering the WBXML tokens in WV-CSP.

Provide rendering of OPAQUE data for media types, based on a framework of 4 functions that take care of well-known and literal tags and attribute names for deciding on the meaning of the OPAQUE data. Applied to SI, EMN and WV-CSP.

Update reference URLs for WAP, OMA and related specs.

Note: as the WBXML common code only takes ~2000 lines while the token mappings take ~4000 lines, maybe it is time to envisage writing the per-media mappings to dedicated source files (packet-wbxml-wml.c, packet-wbxml-wv_csp.c etc)?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10615 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoIf we're printing summaries and packet detail or hex dump information,
guy [Fri, 16 Apr 2004 20:20:54 +0000 (20:20 +0000)]
If we're printing summaries and packet detail or hex dump information,
print the header before each summary line, and print a blank line
separating the summary line and the remaining information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10614 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake "new_color_filter()" take the background and foreground colors, as
guy [Fri, 16 Apr 2004 19:36:36 +0000 (19:36 +0000)]
Make "new_color_filter()" take the background and foreground colors, as
GdkColors, as arguments.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10613 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoYou have to initialize a GtkColor structure before passing it to
guy [Fri, 16 Apr 2004 19:05:05 +0000 (19:05 +0000)]
You have to initialize a GtkColor structure before passing it to
"get_color()" - otherwise, GDK will allocate a color from the colormap
to match whatever random values happen to be there.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10612 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agomake print dialog "Packet Format" options somewhat similar to the
ulfl [Fri, 16 Apr 2004 18:17:48 +0000 (18:17 +0000)]
make print dialog "Packet Format" options somewhat similar to the
Ethereal panes, thus better understandable

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10611 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agobugfix: make the "no dissections" radiobutton insensitive,
ulfl [Fri, 16 Apr 2004 05:30:39 +0000 (05:30 +0000)]
bugfix: make the "no dissections" radiobutton insensitive,
if packet details isn't selected

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10610 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRename a bunch of variables and routines that pertain to string search
guy [Thu, 15 Apr 2004 23:28:11 +0000 (23:28 +0000)]
Rename a bunch of variables and routines that pertain to string search
with "string" rather than "ascii", to make it clearer what they're
involved with.

Use "gtk_toggle_button_set_active()", not
"gtk_toggle_button_set_state()" (the latter is a deprecated alias for
the former, probably dating back to GTK+ 1.0[.x] - 1.2[.x] and later
have "gtk_toggle_button_set_active()").

Do *NOT* change the radio buttons for the type of string search to do
based on whether we're doing a string search or not - doing so means we
don't correctly remember the type of string search.

Get rid of code to fetch some values that we don't subsequently use.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10609 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd two preferences to the WBXML dissector:
obiot [Thu, 15 Apr 2004 22:38:22 +0000 (22:38 +0000)]
Add two preferences to the WBXML dissector:
- Control the rendering of WBXML tokens to a media type token mapping.
- Control the dissection of the tokens that make up the WBXML body.
Both preferences are OFF by default.

Fix some comments as they did not reflect the current state anymore.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10608 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded print output option, to suppress dissection completely
ulfl [Thu, 15 Apr 2004 19:56:15 +0000 (19:56 +0000)]
added print output option, to suppress dissection completely
(for raw packet hexdump)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10607 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded print output of PDML format
ulfl [Thu, 15 Apr 2004 19:07:13 +0000 (19:07 +0000)]
added print output of PDML format

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10606 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Dick Gooris: PacketCable support in the COPS dissector.
guy [Thu, 15 Apr 2004 09:24:07 +0000 (09:24 +0000)]
From Dick Gooris: PacketCable support in the COPS dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10605 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agodecryption and dissection of PA_ENC_TIMESTAMP
sahlberg [Thu, 15 Apr 2004 08:34:21 +0000 (08:34 +0000)]
decryption and dissection of PA_ENC_TIMESTAMP

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10604 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agodissect EncKDCRepPart applications 25 and 26
sahlberg [Thu, 15 Apr 2004 07:47:47 +0000 (07:47 +0000)]
dissect EncKDCRepPart   applications 25 and 26

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10603 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd some braces to squelch a GCC warning.
guy [Thu, 15 Apr 2004 00:18:38 +0000 (00:18 +0000)]
Add some braces to squelch a GCC warning.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10602 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd support for plugin dissectors on cygwin builds, by adding the following
obiot [Wed, 14 Apr 2004 22:13:28 +0000 (22:13 +0000)]
Add support for plugin dissectors on cygwin builds, by adding the following
line to every Makefile.am file for a given plugin XXX:

XXX_la_LIBADD = -L../../epan -lethereal @GLIB_LIBS@

This way symbols defined in libethereal and GLib are resolved when linking
the plugin dissector modules.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10601 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAt last compiling on CygWin works again! Added the missing PCRE and GLIB
obiot [Wed, 14 Apr 2004 18:42:19 +0000 (18:42 +0000)]
At last compiling on CygWin works again! Added the missing PCRE and GLIB
libraries to libftypes.

Provide caching of computed configure tests.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10600 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agotwo memory leaks removed
ulfl [Wed, 14 Apr 2004 05:46:34 +0000 (05:46 +0000)]
two memory leaks removed

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10599 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoCorrect the removal of spaces before parameters in the Content type line, change...
etxrab [Wed, 14 Apr 2004 04:45:10 +0000 (04:45 +0000)]
Correct the removal of spaces before parameters in the Content type line, change some  tags according to --sip-publish-03

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10598 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFix the default clause for not implemented MMS headers by adding more generic
obiot [Tue, 13 Apr 2004 22:07:34 +0000 (22:07 +0000)]
Fix the default clause for not implemented MMS headers by adding more generic
code from WSP (based on the wkh_default() method).

Add initial support for MMS 1.1 and MMS 1.2 (header names, PDU types, response
status codes, message status).

TODO: implement the *full* header dissections for MMS 1.1 and MMS 1.2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10597 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoUse the "a_bit" true_false_string for the "llcgprs.as" field.
guy [Tue, 13 Apr 2004 21:32:57 +0000 (21:32 +0000)]
Use the "a_bit" true_false_string for the "llcgprs.as" field.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10596 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoChange the decision tree for protocol and data compression so that it
guy [Tue, 13 Apr 2004 21:29:18 +0000 (21:29 +0000)]
Change the decision tree for protocol and data compression so that it
doesn't test all four possibilities - with the old code, GCC doesn't
understand that one of the four possibilities must be true, so it
complains that "compression_field_item" might not be set, but it does
understand that with the new code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10595 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jon Oberheide: Add interface name to the capture and ethereal window
tuexen [Tue, 13 Apr 2004 18:01:40 +0000 (18:01 +0000)]
From Jon Oberheide: Add interface name to the capture and ethereal window
                    while capturing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10594 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoGet rid of some unused variables, as per Josef Korelus.
guy [Tue, 13 Apr 2004 17:48:34 +0000 (17:48 +0000)]
Get rid of some unused variables, as per Josef Korelus.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10593 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoDon't put blanks at the ends of strings added with "col_add_fstr()", put
guy [Tue, 13 Apr 2004 04:45:37 +0000 (04:45 +0000)]
Don't put blanks at the ends of strings added with "col_add_fstr()", put
them at the beginnings of strings appended with "col_append_str()", so
there won't be extra blanks at the end.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10592 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Christian Falckenberg: GPRS SNDCP support.
guy [Tue, 13 Apr 2004 04:36:20 +0000 (04:36 +0000)]
From Christian Falckenberg: GPRS SNDCP support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10591 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Josef Korelus: GPRS LLC support.
guy [Tue, 13 Apr 2004 04:21:30 +0000 (04:21 +0000)]
From Josef Korelus: GPRS LLC support.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10590 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Clinton Work: dissect Cisco PID 0x010b as STP (it's actually their
guy [Tue, 13 Apr 2004 04:04:56 +0000 (04:04 +0000)]
From Clinton Work: dissect Cisco PID 0x010b as STP (it's actually their
own modified Per-VLAN STP, so there's some extra stuff at the end of the
packet that needs to be decoded).

Indicate in a comment in packet-cisco-oui.c what PVSTP is.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10589 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoPut in a comment noting a possible memory leak.
guy [Mon, 12 Apr 2004 22:14:37 +0000 (22:14 +0000)]
Put in a comment noting a possible memory leak.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10588 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoESC key presses Close button
ulfl [Mon, 12 Apr 2004 18:01:27 +0000 (18:01 +0000)]
ESC key presses Close button

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10587 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded a close button to the dialogs,
ulfl [Mon, 12 Apr 2004 09:48:19 +0000 (09:48 +0000)]
added a close button to the dialogs,
use the dlg_window_new function for all dialogs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10586 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded missing #include from my latest checkin
ulfl [Mon, 12 Apr 2004 08:59:41 +0000 (08:59 +0000)]
added missing #include from my latest checkin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10585 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded a close button to the dialogs,
ulfl [Mon, 12 Apr 2004 08:53:02 +0000 (08:53 +0000)]
added a close button to the dialogs,
use the dlg_window_new function for all dialogs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10584 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoadded a close button to the dialogs
ulfl [Mon, 12 Apr 2004 07:10:11 +0000 (07:10 +0000)]
added a close button to the dialogs

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10583 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jon Oberheide: add the "Password Hash" label to AIM_TLV_PASSWORD
guy [Sun, 11 Apr 2004 20:57:10 +0000 (20:57 +0000)]
From Jon Oberheide: add the "Password Hash" label to AIM_TLV_PASSWORD
(0x0025) which was previously "Unknown".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10582 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jon Oberheide: add a missing hf[] entry for a field.
guy [Sun, 11 Apr 2004 20:47:58 +0000 (20:47 +0000)]
From Jon Oberheide: add a missing hf[] entry for a field.

Fix up AUTHORS and the authors list in the Ethereal man page.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10581 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agodid lot's of cleanup to the text, especially in the library sections
ulfl [Sat, 10 Apr 2004 09:10:01 +0000 (09:10 +0000)]
did lot's of cleanup to the text, especially in the library sections

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10580 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoModify the "setup" target to download the packages we've defined, so that we
ulfl [Sat, 10 Apr 2004 07:29:14 +0000 (07:29 +0000)]
Modify the "setup" target to download the packages we've defined, so that we
  don't download the GTK1 packages unless we have GTK1_DIR defined.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10579 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake the hex dump byte counter a guint32, so that we don't wrap prematurely.
gerald [Fri, 9 Apr 2004 19:44:27 +0000 (19:44 +0000)]
Make the hex dump byte counter a guint32, so that we don't wrap prematurely.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10578 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoModify the "setup" target to download the packages we've defined, so that we
gerald [Fri, 9 Apr 2004 16:54:07 +0000 (16:54 +0000)]
Modify the "setup" target to download the packages we've defined, so that we
don't download the GTK2 packages unless we have GTK2_DIR defined.

Fix some path checking in win32-setup.sh.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10577 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom metatech:
guy [Fri, 9 Apr 2004 09:15:36 +0000 (09:15 +0000)]
From metatech:

- No registration of port 1414, only the heuristics.

- More dissection of pre-defined MQ structures or messages types
  (MSH, DH, DLH, OR, RR, PMR, MDE, MQSET, MQINQ, MQPUT1, PING).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10576 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Josh Bailey:
guy [Fri, 9 Apr 2004 08:39:00 +0000 (08:39 +0000)]
From Josh Bailey:

Fix missing handling for tags 0x6F and 0x70 (send and receive
encoding type).

Shorten fields displayed in COL_INFO.

Display information about all IPDC packets in COL_INFO if
there's more than one.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10575 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agouse the configured names from config.nmake for the required apps list
ulfl [Fri, 9 Apr 2004 07:38:38 +0000 (07:38 +0000)]
use the configured names from config.nmake for the required apps list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10574 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agodo some more explanations how to use the new library download tool
ulfl [Fri, 9 Apr 2004 07:37:25 +0000 (07:37 +0000)]
do some more explanations how to use the new library download tool
updated ADNS library version

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10573 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoeven more h235 dissection
sahlberg [Fri, 9 Apr 2004 03:51:30 +0000 (03:51 +0000)]
even more h235 dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10572 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agosome more h235 dissection
sahlberg [Fri, 9 Apr 2004 03:32:17 +0000 (03:32 +0000)]
some more h235 dissection

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10571 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd dissection of AuthenticationMechanism to h235
sahlberg [Fri, 9 Apr 2004 01:07:30 +0000 (01:07 +0000)]
Add dissection of AuthenticationMechanism to h235

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10570 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoMake it more obvious when ethereal fails to dissect a PER contruct
sahlberg [Fri, 9 Apr 2004 00:31:41 +0000 (00:31 +0000)]
Make it more obvious when ethereal fails to dissect a PER contruct

1, put a hint why it failed in the COL_INFO line
2, abort dissecting any further (by reading from the arbitrary position 9999 in the tvb
3, put "something unknown here [xxx]" as the last entry in the tree.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10569 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoimplement some basic dissection of H.235 ClearToken so that the capture reported...
sahlberg [Thu, 8 Apr 2004 23:52:12 +0000 (23:52 +0000)]
implement some basic dissection of H.235 ClearToken so that the capture reported on the list will be dissected properly.

maybe someone should break out all the h.235 code sometime later and put it in packet-h235.c?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10568 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd a Makefile.nmake target called "setup" that uses the script
gerald [Thu, 8 Apr 2004 20:36:09 +0000 (20:36 +0000)]
Add a Makefile.nmake target called "setup" that uses the script
tools\win32-setup.sh to

  - Check for applications required to build Ethereal
  - Download and unpack required packages into $ETHEREAL_LIBS

Update ADNS to the latest version.

Make Python 2.3 the default.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10567 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agocatch the enter key from the interface drop-down list,
ulfl [Thu, 8 Apr 2004 19:07:43 +0000 (19:07 +0000)]
catch the enter key from the interface drop-down list,
so pressing enter will really start a capture

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10566 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoupdate to netlogon: make it dissect all the bits of the UserAccountControl flags...
sahlberg [Thu, 8 Apr 2004 10:21:10 +0000 (10:21 +0000)]
update to netlogon:  make it dissect all the bits of the UserAccountControl flags field in the pac structure and elsewhere in netlogon

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10565 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agodissection of netlogon userflags in tha pac structure and elsewhere
sahlberg [Thu, 8 Apr 2004 09:34:47 +0000 (09:34 +0000)]
dissection of netlogon userflags in tha pac structure and elsewhere

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10564 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agodissect group attributes for the pac structure and other places in netlogon
sahlberg [Thu, 8 Apr 2004 09:17:16 +0000 (09:17 +0000)]
dissect group attributes for the pac structure and other places in netlogon

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10563 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoOn Windows, when looking for the ":" that separates the interface
guy [Thu, 8 Apr 2004 08:05:20 +0000 (08:05 +0000)]
On Windows, when looking for the ":" that separates the interface
description from the interface name, don't count ":" followed by "//",
as it might be part of "rpcap://".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10562 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoupdate doc with better description of SUM/COUNT/MIN/MAX/AVG.
sahlberg [Thu, 8 Apr 2004 05:19:38 +0000 (05:19 +0000)]
update doc with better description of SUM/COUNT/MIN/MAX/AVG.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10561 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoupdate tcp so that it will print the string "(relative sequence/ack number)" in the...
sahlberg [Thu, 8 Apr 2004 05:09:28 +0000 (05:09 +0000)]
update tcp so that it will print the string "(relative sequence/ack number)" in the header for the fields affected by using human readable sequence and ack numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10560 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Duncan Laurie: the LUN field in IPMI packets is only in the lower 2
guy [Wed, 7 Apr 2004 06:18:55 +0000 (06:18 +0000)]
From Duncan Laurie: the LUN field in IPMI packets is only in the lower 2
bits.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10559 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoFrom Jouni Malinen: add support for the 802.11i/RSN pre-authentication
guy [Wed, 7 Apr 2004 06:04:22 +0000 (06:04 +0000)]
From Jouni Malinen: add support for the 802.11i/RSN pre-authentication
Ethertype.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10558 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agomake service response time statistics work for "unknown" rpc programs.
sahlberg [Wed, 7 Apr 2004 04:31:32 +0000 (04:31 +0000)]
make service response time statistics work for "unknown" rpc programs.
all proicedures will however get "interesting" names such as "proc-1" etc
except procedure 0 which is ALWAYS "NULL"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10557 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agowhen dealing with unknown rpc programs, create a fake program/version/procedure table...
sahlberg [Wed, 7 Apr 2004 03:57:34 +0000 (03:57 +0000)]
when dealing with unknown rpc programs, create a fake program/version/procedure table so that we can get service response time tables working later.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10556 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agofrom Thomas Palmer: add a preference setting for filter toolbar placement
ulfl [Tue, 6 Apr 2004 19:02:18 +0000 (19:02 +0000)]
from Thomas Palmer: add a preference setting for filter toolbar placement

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10555 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoRemove an extraneous 'break'.
gerald [Tue, 6 Apr 2004 16:08:56 +0000 (16:08 +0000)]
Remove an extraneous 'break'.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10554 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdd support to decrypt the encrypted part of AS/TSG -REP PDUs.
sahlberg [Mon, 5 Apr 2004 00:49:32 +0000 (00:49 +0000)]
Add support to decrypt the encrypted part of AS/TSG -REP PDUs.
Now we only need application 25/26 to be dissected as well for it to be
useful ...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10553 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAdded some more principal name types from the kerberos draft
sahlberg [Mon, 5 Apr 2004 00:28:41 +0000 (00:28 +0000)]
Added some more principal name types from the kerberos draft

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10552 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoLove contributed great help to get the heimdal decryption support working
sahlberg [Sun, 4 Apr 2004 07:12:25 +0000 (07:12 +0000)]
Love contributed great help to get the heimdal decryption support working
(wherein we also discovered an obscure bug inside heimdal itself)  Great thanks to Love.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10551 f5534014-38df-0310-8fa8-9805f1628bb7

20 years agoAs pointed out by Chernishov Yury - strip of leading spaces of parameters
etxrab [Sat, 3 Apr 2004 22:33:45 +0000 (22:33 +0000)]
As pointed out by Chernishov Yury - strip of leading spaces of parameters

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@10550 f5534014-38df-0310-8fa8-9805f1628bb7