obnox/wireshark/wip.git
19 years agoCall the "new-style init" routine for plugins a "register" routine, as
guy [Mon, 7 Mar 2005 02:44:41 +0000 (02:44 +0000)]
Call the "new-style init" routine for plugins a "register" routine, as
it serves the same purpose as the register routine in a built-in
dissector, and don't require all dissectors to have one, as they might
just be taps.

Get rid of the stats tree's init routine, as it's just a tap, and as it
doesn't do anything.

Update the idl2eth Python script to generate plugins with register routines.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13644 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoBack out the BACnet application layer dissectin code - its use of
guy [Mon, 7 Mar 2005 01:22:55 +0000 (01:22 +0000)]
Back out the BACnet application layer dissectin code - its use of
recursion instead of iteration means that packets with sufficiently
large lists can cause it to overflow the stack and crash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13643 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agominor update, add an extra parameter to a call to prepare for decryption of GSSAPI...
sahlberg [Sun, 6 Mar 2005 22:52:58 +0000 (22:52 +0000)]
minor update, add an extra parameter to a call to prepare for decryption of GSSAPI wrapped data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13642 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoexport decrypt_krb5_data
sahlberg [Sun, 6 Mar 2005 22:34:13 +0000 (22:34 +0000)]
export decrypt_krb5_data

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13641 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe length field in the "BACnet encoding rules" is limited to 32 bits
guy [Sun, 6 Mar 2005 22:14:24 +0000 (22:14 +0000)]
The length field in the "BACnet encoding rules" is limited to 32 bits
("Data lengths larger than 2^32-1 are not encodable using primitive
tags"), so it doesn't need to be a "guint64" - but it *can* be that big,
so we should handle the 65536-2^32-1 case.

Don't gratuitously throw away the upper 24 bits of various lengths by
casting them to guint8.

Show signed values as such.

Don't use "match_strval()" - it returns a null pointer if it doesn't
find the value in the value_string table; instead, use "val_to_str()" so
we don't blow up if the value isn't found.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13640 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- Add some media types to be dissected as xml
lego [Sun, 6 Mar 2005 21:57:25 +0000 (21:57 +0000)]
- Add some media types to be dissected as xml
- be more tollerant on how an XML document should look like

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13639 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a preference for another alternate tcp port
lego [Sun, 6 Mar 2005 21:32:13 +0000 (21:32 +0000)]
Add a preference for another alternate tcp port

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13638 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix a minor bug with FT_BOOLEAN.
etxrab [Sun, 6 Mar 2005 20:54:01 +0000 (20:54 +0000)]
Fix a minor bug with FT_BOOLEAN.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13637 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago add format_text() to the plugin API
lego [Sun, 6 Mar 2005 20:43:54 +0000 (20:43 +0000)]
 add format_text() to the plugin API

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13636 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHandle XNS IDP socket numbers.
guy [Sun, 6 Mar 2005 20:13:58 +0000 (20:13 +0000)]
Handle XNS IDP socket numbers.

Handle SMB-over-SPP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13635 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago"report_err.h" declares "report_failure()", so it doesn't need to be
guy [Sun, 6 Mar 2005 19:37:09 +0000 (19:37 +0000)]
"report_err.h" declares "report_failure()", so it doesn't need to be
declared in "epan.h", and, as "epan/plugins.c" now includes
"report_err.h", it doesn't need to include "epan.h".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13634 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- get rid of some warnings
lego [Sun, 6 Mar 2005 18:30:59 +0000 (18:30 +0000)]
- get rid of some warnings

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13633 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- use the string id of the node, not the integer id in tick_stat_node
lego [Sun, 6 Mar 2005 18:02:27 +0000 (18:02 +0000)]
- use the string id of the node, not the integer id in tick_stat_node

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13632 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- replace tabs with spaces while printing
lego [Sun, 6 Mar 2005 17:06:55 +0000 (17:06 +0000)]
- replace tabs with spaces while printing
- get rid of a warning in windows compile

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13631 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoForgot this in the last checkin
lego [Sun, 6 Mar 2005 16:58:34 +0000 (16:58 +0000)]
Forgot this in the last checkin

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13630 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd stats_tree and xml plugins to the build process
lego [Sun, 6 Mar 2005 16:49:16 +0000 (16:49 +0000)]
Add stats_tree and xml plugins to the build process

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13629 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUndo the last "fix" (13626): Unconditionally including <pcap.h> is
jmayer [Sun, 6 Mar 2005 10:26:00 +0000 (10:26 +0000)]
Undo the last "fix" (13626): Unconditionally including <pcap.h> is
going to cause trouble for compilations without libpcap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13628 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWarning fix:
jmayer [Sun, 6 Mar 2005 10:03:53 +0000 (10:03 +0000)]
Warning fix:
menu.c:1841:1: warning: C++ style comments are not allowed in ISO C90
menu.c:1841:1: warning: (this will be reported only once per input file)
(just removed it)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13627 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWarning fix:
jmayer [Sun, 6 Mar 2005 10:02:39 +0000 (10:02 +0000)]
Warning fix:
../capture.h:115: warning: struct pcap_stat declared inside parameter list
../capture.h:115: warning: its scope is only this definition or declaration,
        which is probably not what you want
../capture.h:125: warning: struct pcap_stat declared inside parameter list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13626 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWarning fix:
jmayer [Sun, 6 Mar 2005 09:40:58 +0000 (09:40 +0000)]
Warning fix:
plugins.c:236: warning: implicit declaration of function
        'report_failure'

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13625 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWarning fix:
jmayer [Sun, 6 Mar 2005 09:33:44 +0000 (09:33 +0000)]
Warning fix:
packet-sdp.c:74: warning: 'reset_sdp_packet_info' declared 'static'
        but never defined

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13624 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Yaniv Kaul: show the protocol name in every record.
guy [Sun, 6 Mar 2005 04:42:51 +0000 (04:42 +0000)]
From Yaniv Kaul: show the protocol name in every record.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13623 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSquelch some compiler warnings.
guy [Sun, 6 Mar 2005 04:41:42 +0000 (04:41 +0000)]
Squelch some compiler warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13622 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of an unused variable.
guy [Sun, 6 Mar 2005 04:41:00 +0000 (04:41 +0000)]
Get rid of an unused variable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13621 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agooops, no new_plugin_init() now there is
lego [Sun, 6 Mar 2005 03:45:41 +0000 (03:45 +0000)]
oops, no new_plugin_init() now there is

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13620 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe first part of the XML dissector
lego [Sun, 6 Mar 2005 03:38:25 +0000 (03:38 +0000)]
The first part of the XML dissector
currently just a preety-printer with some generic fields

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13619 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNo, the code is the numerical value, not the vendor ID.
guy [Sun, 6 Mar 2005 03:38:17 +0000 (03:38 +0000)]
No, the code is the numerical value, not the vendor ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13618 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Ben Turner: fix an addVendor() call.
guy [Sun, 6 Mar 2005 03:28:41 +0000 (03:28 +0000)]
From Ben Turner: fix an addVendor() call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13617 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a newline to the end of the file.
guy [Sun, 6 Mar 2005 03:25:19 +0000 (03:25 +0000)]
Add a newline to the end of the file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13616 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of "unknown transport" warnings - don't spam the user just
guy [Sun, 6 Mar 2005 03:19:34 +0000 (03:19 +0000)]
Get rid of "unknown transport" warnings - don't spam the user just
because we haven't yet written a dissector for a particular protocol.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13615 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHandle the "32-bit length is > 2^31-1, so the protocol tree routines
guy [Sun, 6 Mar 2005 03:11:24 +0000 (03:11 +0000)]
Handle the "32-bit length is > 2^31-1, so the protocol tree routines
will treat it as negative" problem by first calling
"tvb_ensure_bytes_exist()" - if the length is *that* large, it will run
past the end of the tvbuff, so the exception that
"tvb_ensure_bytes_exist()" will throw with a negative argument will be
the correct exception.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13614 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoremove plugin_init()
lego [Sun, 6 Mar 2005 02:55:06 +0000 (02:55 +0000)]
remove plugin_init()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13613 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange to new_plugin_init()
lego [Sun, 6 Mar 2005 02:53:23 +0000 (02:53 +0000)]
Change to new_plugin_init()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13612 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNo, they don't use BER for the variable portion of a PDU; update the
guy [Sun, 6 Mar 2005 02:24:49 +0000 (02:24 +0000)]
No, they don't use BER for the variable portion of a PDU; update the
comment appropriately.

Make a bunch of routines static.

Don't just dissect stuff past the end of the variable portion as data -
the protocol spec doesn't appear to say there's anything after that.

Don't pass the offset to the routines to dissect the different types of
PDUs, just have them start at 0.

Use guint8 for 8-bit unsigned quantities.

Rename the routine to dissect Abort PDUs to match the other PDU
dissectors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13611 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUpdate to Sun, February 27 2005.
jmayer [Sun, 6 Mar 2005 02:07:53 +0000 (02:07 +0000)]
Update to Sun, February 27 2005.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13610 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoDon't use "long" and "%l[doux]" for 64-bit quantities, use guint64 and %
guy [Sun, 6 Mar 2005 01:53:56 +0000 (01:53 +0000)]
Don't use "long" and "%l[doux]" for 64-bit quantities, use guint64 and %
followed by PRIu64.

Don't use C++/C99-style comments.

Use "tvb_reported_length()" to get packet lengths - don't use
"tvb_length()", and especially don't directly refer to the "length"
field of the tvbuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13609 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- Modify make-manuf to add a message to manuf how to modify it
jmayer [Sun, 6 Mar 2005 01:52:34 +0000 (01:52 +0000)]
- Modify make-manuf to add a message to manuf how to modify it
  (aka: don't modify manuf, change manuf.tmpl and wka.tmpl instead)
- Remove OUI 08:00:0F from manuf.tmpl, the IEEE provides the correct
  value by now.
- Regenerate manuf

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13608 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMartin Mathieson: Add information sources
jmayer [Sun, 6 Mar 2005 01:15:29 +0000 (01:15 +0000)]
Martin Mathieson: Add information sources

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13607 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoJuan Gonzales of Mitel Networks pointed out this change to the IEEE's OUI list
lego [Sun, 6 Mar 2005 00:39:40 +0000 (00:39 +0000)]
Juan Gonzales of Mitel Networks pointed out this change to the IEEE's OUI list

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13606 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Herbert Lischka: implement some (not all) tags according to BACNET
guy [Sun, 6 Mar 2005 00:17:37 +0000 (00:17 +0000)]
From Herbert Lischka: implement some (not all) tags according to BACNET
application handbook.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13605 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoGet rid of a redundant test.
guy [Sat, 5 Mar 2005 23:44:23 +0000 (23:44 +0000)]
Get rid of a redundant test.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13604 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFor OSPF versions other than 2 or 3, stop dissecting the packet after
guy [Sat, 5 Mar 2005 23:36:07 +0000 (23:36 +0000)]
For OSPF versions other than 2 or 3, stop dissecting the packet after
the checksum (which is the last header field common to V2 and V3).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13603 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Mike Duigou updates to JXTA
sahlberg [Sat, 5 Mar 2005 21:00:41 +0000 (21:00 +0000)]
From Mike Duigou   updates to JXTA

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13602 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Laurent Rabret: handle the case where there's no file name (i.e.,
guy [Sat, 5 Mar 2005 20:52:03 +0000 (20:52 +0000)]
From Laurent Rabret: handle the case where there's no file name (i.e.,
an unsaved live capture), and avoid dividing by zero.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13601 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoClean up indentation.
guy [Sat, 5 Mar 2005 20:36:03 +0000 (20:36 +0000)]
Clean up indentation.

Strings don't have a base, so use BASE_NONE with them, not BASE_DEC or
BASE_HEX.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13600 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoWhen analyzing RTP streams, use the source address as well as the SSRC
gerald [Sat, 5 Mar 2005 17:57:27 +0000 (17:57 +0000)]
When analyzing RTP streams, use the source address as well as the SSRC
to determine forward and reverse directions.  This fixes a capture I
have which has the same SSRC in the forward and reverse streams.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13599 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoNew Protocol : DTP
sahlberg [Sat, 5 Mar 2005 11:12:01 +0000 (11:12 +0000)]
New Protocol : DTP

From Charlie Lenahan   initial DTP support

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13598 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofrom susanne edlund : make tlli appear in the tree
sahlberg [Sat, 5 Mar 2005 10:51:30 +0000 (10:51 +0000)]
from susanne edlund :  make tlli appear in the tree

also change value_length and total_length signed to eliminate a compiler warning

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13597 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPreparations for dropping the old plugin api.
lroland [Sat, 5 Mar 2005 06:28:10 +0000 (06:28 +0000)]
Preparations for dropping the old plugin api.
Introduce a new init routine for plugins,
which does not take the plugin api table as an
argument and allows etheral to distinguish
between plugins using the old and the new api.

Update README.plugins accordingly

Change all g_warnings() in epan/plugins.c to report_failue().
On windows we do not have a log console open while
loading the plugins, because a log console cannot be opened before the prefs have been read. Thus g_warnings()
does not work for reporting problems with plugins.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13596 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Susanne Edlund: filter on NRI values in BSSGP.
guy [Sat, 5 Mar 2005 04:58:13 +0000 (04:58 +0000)]
From Susanne Edlund: filter on NRI values in BSSGP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13595 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Chris Waters: correct an error with the decoding of signal
guy [Sat, 5 Mar 2005 01:03:22 +0000 (01:03 +0000)]
From Chris Waters: correct an error with the decoding of signal
strength information in 802.11 captures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13594 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOmit some stuff when building without a Kerberos library, as it's unused
guy [Sat, 5 Mar 2005 01:00:15 +0000 (01:00 +0000)]
Omit some stuff when building without a Kerberos library, as it's unused
if you don't have a Kerberos library to do decryption.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13593 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoEnable details in protocol tree by default like TCP and UDP.
tuexen [Sat, 5 Mar 2005 00:51:33 +0000 (00:51 +0000)]
Enable details in protocol tree by default like TCP and UDP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13592 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofix kerberos dissector for those having no kerberos decryption
lroland [Sat, 5 Mar 2005 00:21:46 +0000 (00:21 +0000)]
fix kerberos dissector for those having no kerberos decryption

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13591 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofrom Carlos Pignataro
sahlberg [Fri, 4 Mar 2005 22:32:06 +0000 (22:32 +0000)]
from Carlos Pignataro

update MPLS to support MPLS Echo

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13590 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofrom didier: bug fix for the menu,
sahlberg [Fri, 4 Mar 2005 22:25:02 +0000 (22:25 +0000)]
from didier:  bug fix for the menu,
if ethereal could not open the file   make us still be able to use the Open menu item to open a different file

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13589 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSmall fixes to previous patch
jmayer [Fri, 4 Mar 2005 18:54:22 +0000 (18:54 +0000)]
Small fixes to previous patch

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13588 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoRemove AUTHORS-SHORT and AUTHORS-SHORT-FORMAT from the distribution.
gerald [Fri, 4 Mar 2005 17:42:42 +0000 (17:42 +0000)]
Remove AUTHORS-SHORT and AUTHORS-SHORT-FORMAT from the distribution.
(They're automatically generated.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13587 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomake kpasswd privide subdissectors to handle the user-data field for the KRB_PRIV...
sahlberg [Fri, 4 Mar 2005 13:39:15 +0000 (13:39 +0000)]
make kpasswd privide subdissectors to handle the user-data field for the KRB_PRIV structure for kpasswd requests and replies.

decrypt and behold the new password in plaintext in all its glory
(given you have the keytab with the old one of course)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13586 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- Add -Xmx256m automatically on unixish systems.
jmayer [Fri, 4 Mar 2005 13:24:47 +0000 (13:24 +0000)]
- Add -Xmx256m automatically on unixish systems.
- Make build process for A4 and letter pdfs more similar.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13585 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agosome authentication stuff from metze
sahlberg [Fri, 4 Mar 2005 12:28:00 +0000 (12:28 +0000)]
some authentication stuff from metze

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13584 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agomake ethereal able to decrypt KRB_PRIV which kpasswd uses
sahlberg [Fri, 4 Mar 2005 12:21:40 +0000 (12:21 +0000)]
make ethereal able to decrypt KRB_PRIV which kpasswd uses

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13583 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agothe unknown stuff in the decrypted blobs in mapi are just uninitialized buffer paddin...
sahlberg [Fri, 4 Mar 2005 11:08:03 +0000 (11:08 +0000)]
the unknown stuff in the decrypted blobs in mapi are just uninitialized buffer padding  so dont show them in the decode tree

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13582 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Francisco Alcoba,
lego [Thu, 3 Mar 2005 13:59:52 +0000 (13:59 +0000)]
From Francisco Alcoba,
do not look for data blocks in ACK packets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13581 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Anders Broman: fix a fault in the CODEC LIST routine where offset
guy [Thu, 3 Mar 2005 10:23:29 +0000 (10:23 +0000)]
From Anders Broman: fix a fault in the CODEC LIST routine where offset
was wrongly calculated, and clean up some other miscellaneous stuff.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13580 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOops, forgot packet-idp.h.
guy [Thu, 3 Mar 2005 09:36:19 +0000 (09:36 +0000)]
Oops, forgot packet-idp.h.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13579 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Yuriy Sidelnikov: correctly display User Information
guy [Thu, 3 Mar 2005 08:54:00 +0000 (08:54 +0000)]
From Yuriy Sidelnikov: correctly display User Information
field in release request/response PDu if the Reason field
is absent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13578 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd support for what appears to be 3Com's scheme for encapsulating XNS
guy [Thu, 3 Mar 2005 08:34:48 +0000 (08:34 +0000)]
Add support for what appears to be 3Com's scheme for encapsulating XNS
over Token Ring (and presumably other link layers using 802.2 LLC), and
for the XNS IDP and SPP protocols.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13577 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Alejandro Vaquero:
lego [Wed, 2 Mar 2005 23:25:41 +0000 (23:25 +0000)]
From Alejandro Vaquero:
Avoid adding to a call non ISUP mtp3 packets towards the same destination as a copy of the last ISUP packet towards that dpc.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13576 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThis is the rest of the patch from Francisco Alcoba.
lego [Wed, 2 Mar 2005 23:22:11 +0000 (23:22 +0000)]
This is the rest of the patch from Francisco Alcoba.
I forgot to check in changes to these files yesterday

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13575 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUse "tvb_get_string()" to fetch strings from the packet, rather than
guy [Wed, 2 Mar 2005 21:08:47 +0000 (21:08 +0000)]
Use "tvb_get_string()" to fetch strings from the packet, rather than
filling up a fixed-length buffer.

Add a bunch of length checks.

Clean up indentation.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13574 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoPresent diameter time as UTC time rather than the local time zone of the machine...
etxrab [Wed, 2 Mar 2005 20:16:18 +0000 (20:16 +0000)]
Present diameter time as UTC time rather than the local time zone of the machine running Ethereal is at.
 Insert a comment that time before 1970 will not be presented properly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13573 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrrom Francisco Alcoba
lego [Wed, 2 Mar 2005 01:24:18 +0000 (01:24 +0000)]
Frrom Francisco Alcoba
- Name resolution support for the RTP Stream Analysis functionality
- fix a crash when trying to analyze with no stream selected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13572 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHandle the CRC correctly:
guy [Wed, 2 Mar 2005 00:21:33 +0000 (00:21 +0000)]
Handle the CRC correctly:

don't do it if we don't have the entire packet, including the
CRC value;

fetch the CRC value from the packet with tvb_get_letoh24(),
and compare that against the computed CRC, rather than comparing
the computed CRC (presumably in host byte order) with the
little-endian CRC in the packet (that doesn't work if host byte
order is big-endian).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13571 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf -z was not given as the very last argument the tap listener initialization might...
lego [Tue, 1 Mar 2005 23:46:05 +0000 (23:46 +0000)]
If -z was not given as the very last argument the tap listener initialization might have crashed.

Copy the optarg so that when the tap initialization is called it gets the right argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13570 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoOK, *really* set the properties this time.
guy [Tue, 1 Mar 2005 21:49:19 +0000 (21:49 +0000)]
OK, *really* set the properties this time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13569 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoSet the svn:keywords and svn:eol-style properties appropriately, and
guy [Tue, 1 Mar 2005 21:47:54 +0000 (21:47 +0000)]
Set the svn:keywords and svn:eol-style properties appropriately, and
give it an RCS ID.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13568 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoThe DBS Etherwatch file handler does look for a magic number (the word
guy [Tue, 1 Mar 2005 19:59:54 +0000 (19:59 +0000)]
The DBS Etherwatch file handler does look for a magic number (the word
"ETHERWATCH").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13567 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd the http_srv tap a tree to verify load distribution between several http servers...
lego [Tue, 1 Mar 2005 19:43:14 +0000 (19:43 +0000)]
add the http_srv tap a tree to verify load distribution between several http servers and/or virtual hosts

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13566 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Alejandro Vaquero:
lego [Tue, 1 Mar 2005 16:19:46 +0000 (16:19 +0000)]
From Alejandro Vaquero:

patch to the voip calls facility to:

- Add a horizontal scrollbar in the "Graph" to scroll the "comments"
- Fix a "state" bug in H323 and SIP calls
- Fix a bug that can make the "graph" to crash, and also clean up the "address" when the window is close

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13565 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIn packets with more than one req/resp the items of all the req/resp subtrees always...
lego [Tue, 1 Mar 2005 11:37:26 +0000 (11:37 +0000)]
In packets with more than one req/resp the items of all the req/resp subtrees always pointed to the offset of the first req/resp.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13564 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoIf errorrecoverylevel==0 is used and the A bit is clear in a DataIn PDU
sahlberg [Tue, 1 Mar 2005 10:09:53 +0000 (10:09 +0000)]
If errorrecoverylevel==0 is used and the A bit is clear in a DataIn PDU
the iscsi layer will not hold the LUN value (it is reserved)
so we need to remember if from the initial Command PDU.

make the LUN reporting work for errorrecoverylevel==0 targets

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13563 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoShow NTP times correctly.
guy [Tue, 1 Mar 2005 06:32:56 +0000 (06:32 +0000)]
Show NTP times correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13562 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoShow NTP times in a fashion more similar to that used for other times.
guy [Tue, 1 Mar 2005 06:04:31 +0000 (06:04 +0000)]
Show NTP times in a fashion more similar to that used for other times.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13561 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoShow NTP times correctly.
guy [Tue, 1 Mar 2005 06:03:08 +0000 (06:03 +0000)]
Show NTP times correctly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13560 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFrom Graeme Hewson: rename the global preferences file to "preferences"
guy [Tue, 1 Mar 2005 00:05:57 +0000 (00:05 +0000)]
From Graeme Hewson: rename the global preferences file to "preferences"
(it's now in an "ethereal" directory, so there's no need for it to have
a name that distinguishes it from files for other programs) - if it's
not found as "preferences", try "ethereal.conf" for compatibility - and
update the man pages appropriately.

Fix a typo in the section color filters (the file name is "colorfilters",
not "color filters").

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13559 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAnother step towards using the parent/child mode for ALL captures.
ulfl [Mon, 28 Feb 2005 22:46:49 +0000 (22:46 +0000)]
Another step towards using the parent/child mode for ALL captures.

This is currently still disabled, as we cannot pass all required capture flags to the child process (lack of command line parameters).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13558 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoeven if unharmful, this was simply ugly.
lego [Mon, 28 Feb 2005 22:39:03 +0000 (22:39 +0000)]
even if unharmful, this was simply ugly.
change

do {
 if (i == 0) break;
 ...
} while (i);

for a propper

while(i) {
 ...
}

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13557 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoadd the http_stats_tree,
lego [Mon, 28 Feb 2005 22:32:16 +0000 (22:32 +0000)]
add the http_stats_tree,
a replacement for the current http tap listeners and a tree for requested hosts/uris

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13556 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agofew changes to http
lego [Mon, 28 Feb 2005 22:27:24 +0000 (22:27 +0000)]
few changes to http
- stat_infos are mantained in a GPtrArray to avoid leaking and overwriting them
- added http_host and request_uri to http_info_value_t

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13555 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoChange the RADIUS ATTRIBUTES for some 3GPP AVP:s to display them as (UTF8)Strings...
etxrab [Mon, 28 Feb 2005 20:51:23 +0000 (20:51 +0000)]
Change the RADIUS ATTRIBUTES for some 3GPP AVP:s to display them as (UTF8)Strings, also
added some more AVP:s from a later spec.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13554 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoUndo change of return (addVendor(atoi(id), code, name)); as it wasn't correct.
etxrab [Mon, 28 Feb 2005 20:49:34 +0000 (20:49 +0000)]
Undo change of return (addVendor(atoi(id), code, name)); as it wasn't correct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13553 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoCorrect presentation of IMSI digits and highlight correct bytes.
etxrab [Mon, 28 Feb 2005 20:48:23 +0000 (20:48 +0000)]
Correct presentation of IMSI digits and highlight correct bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13552 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdd a link to an RX spec, and ask whether the Epoch really should be
guy [Mon, 28 Feb 2005 19:47:46 +0000 (19:47 +0000)]
Add a link to an RX spec, and ask whether the Epoch really should be
dissected as a UN*X time.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13551 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoAdapt the stats_tree example plugin to the last changes
lego [Mon, 28 Feb 2005 11:10:49 +0000 (11:10 +0000)]
Adapt the stats_tree example plugin to the last changes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13550 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoFix capitalization.
guy [Mon, 28 Feb 2005 09:21:59 +0000 (09:21 +0000)]
Fix capitalization.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13549 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMap "llcgprs.ignore_cipher_bit" to "llcgprs.autodetect_cipher_bit".
guy [Mon, 28 Feb 2005 09:21:19 +0000 (09:21 +0000)]
Map "llcgprs.ignore_cipher_bit" to "llcgprs.autodetect_cipher_bit".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13548 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoHandle the new signature for "dissect_per_restricted_character_string()".
guy [Mon, 28 Feb 2005 08:22:02 +0000 (08:22 +0000)]
Handle the new signature for "dissect_per_restricted_character_string()".

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13547 f5534014-38df-0310-8fa8-9805f1628bb7

19 years ago- do not free the string passed to register_ethereal_tap()
lego [Mon, 28 Feb 2005 01:20:52 +0000 (01:20 +0000)]
- do not free the string passed to register_ethereal_tap()
it caused the taps to have "funny" names.

- rename the window as "$name Stats Tree"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13546 f5534014-38df-0310-8fa8-9805f1628bb7

19 years agoMake sure that plugin tap listeners get registered before the non-plugin tap listeners
lego [Mon, 28 Feb 2005 00:55:49 +0000 (00:55 +0000)]
Make sure that plugin tap listeners get registered before the non-plugin tap listeners
that's because stat trees are registered as tap listeners by either
gtk/stats_tree_stat.c or tap-stats_tree.c

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13545 f5534014-38df-0310-8fa8-9805f1628bb7