sahlberg [Sun, 17 Mar 2002 12:16:11 +0000 (12:16 +0000)]
quota update partial NTGetUserQuota support
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4964
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 17 Mar 2002 11:59:36 +0000 (11:59 +0000)]
Partial dissection of NT Set User Quota data block
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4963
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 17 Mar 2002 11:24:16 +0000 (11:24 +0000)]
SMB Quota updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4962
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 17 Mar 2002 10:59:35 +0000 (10:59 +0000)]
Updates for NT QUOTA in packet-smb.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4961
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 17 Mar 2002 07:43:11 +0000 (07:43 +0000)]
Some minor bugfixes for netlogon
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4960
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 23:15:45 +0000 (23:15 +0000)]
From Aamer Akhter: LDP support for draft-martini-l2circuit-trans-mpls,
LDP status code updates, and small LDP cleanups.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4959
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 22:54:20 +0000 (22:54 +0000)]
Put an item into the protocol tree for the secondary address in a bind
ack PDU.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4958
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 22:39:45 +0000 (22:39 +0000)]
The service is just called "IPC"; the pipe is what's called "IPC$".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4957
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 22:35:51 +0000 (22:35 +0000)]
Whether the data returned from a read or sent in a write is DCERPC
traffic or not, that data doesn't include the padding; handle padding
if you're dissecting it as DCERPC traffic.
Don't treat the traffic as DCERPC traffic unless it's to the IPC$ share.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4956
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 22:02:55 +0000 (22:02 +0000)]
A double-click in a filter name in the list-of-filters dialog box should
activate the text widget into which the filter text is put only if
clicking "OK" in the list-of-filters dialog box does so. Make it so.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4955
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 22:01:27 +0000 (22:01 +0000)]
There is no guarantee that, when processing an SMB response, "si->sip"
is non-null, as there's no guarantee that the corresponding SMB request
is in the capture. Check whether it's null before using it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4954
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 20:22:14 +0000 (20:22 +0000)]
Update the developer documentation to reflect current reality (or a
subset thereof).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4953
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sat, 16 Mar 2002 04:39:29 +0000 (04:39 +0000)]
A new type of DCERPC over SMB transport.
I have captures with w2k speaking DCERPC without using the normal
Transaction named pipes SMBs.
Instead DCERPC is just implemented ontop of ordinary read/write calls.
The smb dissector now examines TreeConnectAndX and stores the conversation/tid/type-of-share in a table for later access.
All SMB requests examine that hash table to find out if TID in the header refers
to a normal share or an IPC$ share.
Initial support in read/write SMB calls to detect if the operations are for an
IPC share and thus it assumes it must be DCERPC commands in the payload.
Desegmentation/Reassembly of these types of calls are not implemented yet.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4952
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 02:25:48 +0000 (02:25 +0000)]
XDMCP support, from Pasi Eronen.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4951
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 16 Mar 2002 02:09:28 +0000 (02:09 +0000)]
Fix a couple of incorrect calls to "proto_tree_add_boolean()" to call
"proto_tree_add_item()" instead.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4950
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Fri, 15 Mar 2002 20:46:04 +0000 (20:46 +0000)]
Pretty up Policy Handles.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4949
f5534014-38df-0310-8fa8-
9805f1628bb7
sharpe [Fri, 15 Mar 2002 19:47:03 +0000 (19:47 +0000)]
Pretty up the SID dissector ...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4948
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 15 Mar 2002 08:59:53 +0000 (08:59 +0000)]
Moved the value_string for MS country codes from packet-dcerpc-nt.c to
packet-smb.c so that packet-smb-pipe.c can reference this struct as well.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4947
f5534014-38df-0310-8fa8-
9805f1628bb7
tpot [Fri, 15 Mar 2002 04:46:43 +0000 (04:46 +0000)]
Added error messages for invalid name and invalid form size.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4946
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Mar 2002 21:24:40 +0000 (21:24 +0000)]
From Andrew Feren: put all of Cisco's OUIs into manuf.tmpl.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4945
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Mar 2002 21:22:11 +0000 (21:22 +0000)]
From Andrew Feren: minor patch to correct what looks like a cut and
paste error in an error message. The wrong filename is being displayed
if manuf can't be opened for writing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4944
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 14 Mar 2002 10:04:02 +0000 (10:04 +0000)]
Added a value_string for the countreis which have their MS contry code listed
at www.unicode.org and made samr and netlogon use it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4943
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Thu, 14 Mar 2002 09:19:17 +0000 (09:19 +0000)]
hf_netlogon_code did not have an hf_[] entry.
some cruft removed from LSA_SECURITY_DESCRIPTOR that is not used anymore since
we call the dissector in packet-smb.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4942
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Mar 2002 05:46:59 +0000 (05:46 +0000)]
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4941
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Mar 2002 05:45:16 +0000 (05:45 +0000)]
Clean up the display of the top-level item for the NT ACE Flags, so that
there's a space after the colon, and so that there's no extra comma at the
end and only one space between the items.
Fix a typo.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4940
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 14 Mar 2002 05:41:59 +0000 (05:41 +0000)]
Boost the maximum amount of indentation put into text output.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4939
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Thu, 14 Mar 2002 04:32:35 +0000 (04:32 +0000)]
When defining the struct select_item, don't create an instance of that
struct, alsoc alled select_item, as it's not used.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4938
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 13 Mar 2002 11:19:16 +0000 (11:19 +0000)]
Make LSA_SECURITY_DESCRIPTOR dissector call dissect_nt_sec_desc()
instead of just displaying it as some hex string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4937
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 13 Mar 2002 10:52:22 +0000 (10:52 +0000)]
Added mockups for LSA_SECRET and LSA_SECURITY_DESCRIPTOR inside
packet-dcerpc-netlocon.c so that SamDelta_reply packets will be dissected properly.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4936
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 13 Mar 2002 09:03:28 +0000 (09:03 +0000)]
Fixed bug in SAMDELTAS_request.
There is still a bug in the dissection of SAMDELTA_reply but this is due to
LSA_SECRET not being implemented yet which is embedded in one of the
netlogon structures.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4935
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 13 Mar 2002 07:38:34 +0000 (07:38 +0000)]
Update dissect_ndr_nt_STRING so it can also accept FT_BYTES and for that type
display the data as a hexadecimal string.
Update netlogon so that nt and lm challenge response bytes are displayed
in hexadecimal form and not pseudo-ascii
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4934
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 13 Mar 2002 02:52:21 +0000 (02:52 +0000)]
Give the "prevent/allow medium removal" command the right name (it's
"prevent/allow", not "prevent allow").
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4933
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 12 Mar 2002 11:30:45 +0000 (11:30 +0000)]
From Dinesh Dutt: initial dissection of a variable-length CDB.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4932
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 12 Mar 2002 10:40:01 +0000 (10:40 +0000)]
Get rid of unnecessary includes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4931
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 12 Mar 2002 10:37:04 +0000 (10:37 +0000)]
Get rid of the "--enable-snmp" option; instead, use "--with-ucdsnmp".
Make the directory option to "--with-ucdsnmp" optional. Handle
"--with-ucdsnmp" similar to the way "--with-pcap" is handled.
Get rid of unnecessary #defines in "packet-cops.c".
Get rid of no-longer-necessary include of "dlfcn.h" in "packet-snmp.c".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4930
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Tue, 12 Mar 2002 08:16:41 +0000 (08:16 +0000)]
Small fix for dissect_ndr_nt_UNICODE_STRING_str() in packet-dcerpc-nt.c
so that NETLOGON will not dump core (since netlogon has these structs as top
level reference pointers)
Addition of full netlogon dissection. Full in the sense as it assumes the idl
is correct and complete.
Many calls and fields are unknown so they get dissected with "unknown long,
contact ethereal-dev@... if you know what it is".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4929
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 08:47:46 +0000 (08:47 +0000)]
From Adam Sulmicki: use "proto_tree_add_uint()" rather than
"proto_tree_add_boolean()" for the "hf_eapol_keydes_key_index_indexnum"
field, as it's an FT_UINT8, not an FT_BOOLEAN.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4928
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 07:02:47 +0000 (07:02 +0000)]
In the message at the end that indicates how Ethereal was configured,
refer to "UCD SNMP" rather than just "SNMP".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4927
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 02:12:41 +0000 (02:12 +0000)]
Update various README and INSTALL files to reflect the requirement for
UCD SNMP 4.2.2 or later if you want MIB-reading support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4926
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 01:51:37 +0000 (01:51 +0000)]
"format_var()" returns a "malloc()"ed string, not a "g_malloc()"ed
string; free it with "free()", not "g_free()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4925
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 01:48:08 +0000 (01:48 +0000)]
If we're linking with the UCD SNMP library, make "format_oid()" append a
display of the symbolic form of the OID. Remove code that used to do
that outside of "format_oid()".
Export "format_oid()" from "packet-snmp.c" and use it in
"packet-cops.c".
Remove support for CMU SNMP and older versions of UCD SNMP from
"packet-cops.c", as it has been removed from the rest of Ethereal.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4924
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 01:42:58 +0000 (01:42 +0000)]
Put "extern" in front of the function declaration.
Update Gerald's e-mail address.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4923
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 11 Mar 2002 01:40:28 +0000 (01:40 +0000)]
The "val_len" member of a "struct variable_list" should be set to the
length of the variable's value, in bytes, not the length of the BER
encoding of that variable's value. The latter setting means it won't be
correct for object IDs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4922
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 11 Mar 2002 00:28:21 +0000 (00:28 +0000)]
Final patch in preparing for NETLOGON dissector.
Exported some functions from packet-dcerpc-samr.c and added two
more functions the netlogon dissector will need.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4921
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 11 Mar 2002 00:15:20 +0000 (00:15 +0000)]
Move the STRING dissector to packet-dcerpc-nt.c and add one more parameter
to make it more similar to the UNICODE_STRING dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4920
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Mon, 11 Mar 2002 00:00:15 +0000 (00:00 +0000)]
Rename samr_dissect_LOGON_HOURS() to dissect_ndr_nt_LOGON_HOURS() and
export it to other modules.
NETLOGON dissector (and others) will need this function.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4919
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 10 Mar 2002 23:24:48 +0000 (23:24 +0000)]
Moved dissect_ndr_nt_NTTIME() from packet-dcerpc-samr.c to packet-dcerpc-nt.c
since this function will be used by other NT services as well such as NETLOGON.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4918
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 23:19:44 +0000 (23:19 +0000)]
Remove code to show the presence, and version number, of the CMU SNMP
library, as we no longer support linking with that library.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4917
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 23:17:00 +0000 (23:17 +0000)]
Use "ds_set_int()", not "snmp_set_suffix_only()", to set the "print
suffixes only" setting.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4916
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 10 Mar 2002 23:13:04 +0000 (23:13 +0000)]
Absolute and Relative times were swapped. Also add comment that there seems
to be an unknown special time constant : 0x40000000
00000000 that we dont know
yet what it means.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4915
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 22:18:12 +0000 (22:18 +0000)]
Use the "sprint_realloc_" routines in UCD SNMP 4.2.2 and later, rather
than the "sprint_" routines in UCD and CMU SNMP; the latter routines
have no bounds checking, and if you use them you cannot protect against
buffer overflows.
As we now require UCD SNMP 4.2.2 or later:
1) we no longer need code to support CMU SNMP;
2) we no longer need code to work around problems with UCD SNMP
4.1.1;
and, as we no longer use the "sprint_" routines, we no longer need code
to work around the changed API and ABI of those routines in some
nonstandard versions of the UCD SNMP library.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4914
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 22:04:25 +0000 (22:04 +0000)]
Don't use "proto_tree_add_string_format()" when
"proto_tree_add_string()" will suffice.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4913
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 21:30:11 +0000 (21:30 +0000)]
Use "dissect_ndr_nt_UNICODE_STRING_str()", not
"dissect_ndr_nt_UNICODE_STRING_string()", in
"samr_dissect_connect2_server()"; that eliminates an unnecessary extra
level of protocol tree.
That removes the last call to "dissect_ndr_nt_UNICODE_STRING_string()";
eliminate that routine.
In "dissect_ndr_nt_UNICODE_STRING()", initially create the subtree with
the name of the field as a string, so that if an exception is thrown
before the name is set, the subtree won't show up as blank when
displayed or printed. Also pass in the name to "dissect_ndr_pointer()",
so the same happens for subtrees below it. Append only the string data,
not its name, to items up the tree, as the name was put in when the item
was created. Also, when adding a colon before the string, put a space
after the colon, as is done elsewhere in Ethereal.
When appending additional strings, put the blank before the new string,
not after it.
In "dissect_ndr_nt_STRING()", put the subtree into the string with the
name of the field, rather than just "String". Pass in that name to
"dissect_ndr_pointer()", so subtrees below it get a name when they're
initially created.
Get rid of colons in the name string passed to "dissect_ndr_pointer()"
in some calls. Supply a non-null name string in more calls to
"dissect_ndr_pointer()", and fix some calls to pass in the name of the
field being handed to "dissect_ndr_pointer()".
There's no need to fetch the entire "header_field_info" structure for a
protocol field in order to get the field's name - just use
"proto_registrar_get_name()" to get the name.
Use a length of -1, not 0, when creating a subtree whose length will be
set when the dissection of the items under the subtree is complete; that
way, if an exception is thrown while dissecting the items - which means
the item goes past the end of the tvbuff - the item will refer to all
data to the end of the tvbuff, rather than referring to nothing.
Fix a typo in the name of the "hf_samr_unknown_string" field.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4912
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 03:11:10 +0000 (03:11 +0000)]
Catch another "(NULL pointer)%s" we didn't catch with the previous
checkin.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4911
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 03:09:48 +0000 (03:09 +0000)]
Put a space between "(NULL pointer)" and the name of the item being
dissected, just as is done with "(duplicate PTR)".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4910
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 03:08:31 +0000 (03:08 +0000)]
Register the heuristic SMPP dissector with X.25.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4909
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 03:07:16 +0000 (03:07 +0000)]
Initialize the "tm_isdst" field of a "struct tm" to -1 before passing it
to "mktime()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4908
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 01:02:06 +0000 (01:02 +0000)]
Initialize the "tm_isdst" field of a "struct tm" to -1 before passing it
to "mktime()".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4907
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 10 Mar 2002 00:05:20 +0000 (00:05 +0000)]
For Reverse ARP replies, the *target* hardware and protocol addresses
contain the interesting "XXX is at YYY" data; put that into the Info
column. Thanks to Andreas Sikkema for catching this.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4906
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 9 Mar 2002 23:07:26 +0000 (23:07 +0000)]
Sigh. Tcpdump cannot handle capture files with a snapshot length of 0,
as BPF filters return either 0 if they fail or the snapshot length if
they succeed, and a snapshot length of 0 means success is
indistinguishable from failure and the filter expression would reject
all packets.
Now that a snapshot length of 0, inside Ethereal, means "snapshot length
unknown", we have to, when opening a libpcap file for output, make the
snapshot length some non-zero value. We make it WTAP_MAX_PACKET_SIZE,
in case some program uses the snapshot length as a buffer size. (That
doesn't help if there are packets with more than 65535 bytes of data; if
there are, we'd need to raise WTAP_MAX_PACKET_SIZE just to make those
files readable in Ethereal in any case.)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4905
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 9 Mar 2002 22:54:27 +0000 (22:54 +0000)]
Fix some "proto_tree_add_uint()" and "proto_tree_add_uint_hidden()"
calls that passed TRUE or FALSE, rather than an integer value, as the
last argument.
A SOCKS command is one byte, so make the "socks.command" field an
FT_UINT8.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4904
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 9 Mar 2002 22:46:29 +0000 (22:46 +0000)]
Use -1, rather than 0, as the length when creating an item with a
subtree under it, so that if an exception is thrown while we're
dissecting the items in the subtree, it runs to the end of the tvbuff
(as, if an exception is thrown, it means the item should cover the stuff
in the tvbuff *and* stuff beyond it).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4903
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 9 Mar 2002 22:41:51 +0000 (22:41 +0000)]
From Jouni Malinen: fix bugs in 802.11 authentication frame dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4902
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 9 Mar 2002 02:12:47 +0000 (02:12 +0000)]
No need to put ", N byte{s} at offset O" into the Info column twice;
once is enough.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4901
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 7 Mar 2002 21:46:06 +0000 (21:46 +0000)]
Fix a comment.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4899
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 7 Mar 2002 21:31:12 +0000 (21:31 +0000)]
Fix a typo - IFT_ISO88025 is 9, not 8.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4898
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 7 Mar 2002 21:08:33 +0000 (21:08 +0000)]
Bug fix from Marc Milgram: occasionally the VMS parser would read off
the end of string, and find some old data that looked useful, but was
bogus for the frame.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4897
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 7 Mar 2002 05:51:11 +0000 (05:51 +0000)]
Updates from Mike Frisch.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4895
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 6 Mar 2002 23:37:12 +0000 (23:37 +0000)]
Don't say "without SNMP"; that can confuse people into thinking it means
Ethereal doesn't dissect SNMP if not linked with an SNMP library (and
*did* confuse at least one person into thinking that). Say "without
SNMP MIB support", instead, as you only lose the ability to read SNMP
MIBs and interpret OIDs and variable bindings according to those MIBs.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4894
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 6 Mar 2002 19:17:06 +0000 (19:17 +0000)]
tvb_get_nstringz() needs to terminate a string with a NUL if the
end of the tvbuff is reached before the maximum_length passed by the
caller is reached and before a terminating NUL is found. In this case,
tvb_get_nstringz() returns a -1, but if the string is not artificially
terminated with a NUL by tvb_get_nstringz(), the
caller has no idea where the string should end because 1) the
return value "-1" gives the impression that the string ends
at the end of the buffer but 2) the string does
not end at the end of the buffer, but somewhere in the middle, due
to the packet being shorter than expected.
tvb_get_nstringz() and tvb_get_nstringz0() were both modified.
The FT_STRINGZ case in proto_tree_add_item() is made simpler.
During regression testing, when investigating a regression that I later
corrected, I discovered that strings added through proto_tree_add_item
(FT_STRING, FT_STRINGZ, and FT_UINT_STRING) leaked memory due to double
allocation of the string. The proto_tree_add_string*() functions do
not leak memory, since they only copy the string once. The memory
leak was fixed by adding another argument to the static function
proto_tree_set_string() to let the string ftype code know to g_strdup()
the string or not.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4891
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 6 Mar 2002 17:56:28 +0000 (17:56 +0000)]
Remove incorrect usage of ?: expression in favor or the correct,
and more readable, "if" statement.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4890
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 6 Mar 2002 10:01:17 +0000 (10:01 +0000)]
Rename function and variables for dissecting an NT service Account Control
bitmap and make the function not static.
This bitmap is present in other RPC protocols for NT services as well
besides SAMR.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4889
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 6 Mar 2002 08:58:01 +0000 (08:58 +0000)]
Moved dissector for UNICODE_STRING structure from packet-dcerpc-samr.c to packet-dcerpc-nt.c since this is a structure that is common to all NT services and not only SAMR.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4888
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Wed, 6 Mar 2002 08:28:57 +0000 (08:28 +0000)]
Fixed bug in dissect_ndr_pointer(). Top level Unique and Full pointers are
not encoded in the same way in the NDR representation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4887
f5534014-38df-0310-8fa8-
9805f1628bb7
itojun [Wed, 6 Mar 2002 06:36:22 +0000 (06:36 +0000)]
1.3 was committed by mistake
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4886
f5534014-38df-0310-8fa8-
9805f1628bb7
itojun [Wed, 6 Mar 2002 06:33:37 +0000 (06:33 +0000)]
VRRPv3 (for IPv6) support, by sumikawa@kame.net
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4885
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 6 Mar 2002 06:14:21 +0000 (06:14 +0000)]
Use the gdb "x" (examine memory) command instead of "print" to obtain
the packet data. "print" will only show the first 200 members of an array,
whereas "x" doesn't seem to have a limit.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4884
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 6 Mar 2002 04:02:02 +0000 (04:02 +0000)]
From Mike Frisch: remove debug printf statements.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4883
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 6 Mar 2002 03:52:13 +0000 (03:52 +0000)]
Check to make sure SNMP_IPADDR items are 4 bytes long and SNMP_COUNTER64
items are 8 bytes long.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4882
f5534014-38df-0310-8fa8-
9805f1628bb7
gram [Wed, 6 Mar 2002 03:34:50 +0000 (03:34 +0000)]
Add ability to pull packet from add_packet_to_packet_list() frame.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4881
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 22:15:21 +0000 (22:15 +0000)]
The length field in the TPKT header contains the length of the packet
*including the length of the TPKT header itself*, not just the length of
the payload.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4880
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 12:03:27 +0000 (12:03 +0000)]
From Joerg Mayer: remove unused variables.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4879
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 11:56:00 +0000 (11:56 +0000)]
From Joerg Mayer: use _U_ to flag unused arguments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4878
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 11:04:15 +0000 (11:04 +0000)]
From Adam Sulmicki: fixes to typos in comments.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4877
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 09:18:58 +0000 (09:18 +0000)]
Fix another problem found by the PROTOS captures - in
"asn1_string_value_decode()", don't pass "g_malloc()" an argument of 0,
as "g_malloc()" will return NULL in that case, and the callers of
"asn1_string_value_decode()" aren't necessarily prepared for a null
argument.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4876
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 08:40:27 +0000 (08:40 +0000)]
Make "wtap_seek_read()" return TRUE on success and FALSE on error, like
"wtap_read()".
Add some additional error checks to the Sniffer file reader.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4875
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 05:58:41 +0000 (05:58 +0000)]
Have "wtap_seek_read()" return 0 on success and -1 on failure, and take
an "err" argument that points to an "int" into which to put an error
code if it fails.
Check for errors in one call to it, and note that we should do so in
other places.
In the "wtap_seek_read()" call in the TCP graphing code, don't overwrite
"cfile.pseudo_header", and make the buffer into which we read the data
WTAP_MAX_PACKET_SIZE bytes, as it should be.
In some of the file readers for text files, check for errors from the
"parse the record header" and "parse the hex dump" routines when reading
sequentially.
In "csids_seek_read()", fix some calls to "file_error()" to check the
error on the random stream (that being what we're reading).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4874
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 03:10:52 +0000 (03:10 +0000)]
There's just a single H.225 dissector, for both Call Signaling and
Registration, Admission, and Status, so just call it "h225", not
"h225_cs".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4871
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 02:25:09 +0000 (02:25 +0000)]
Cut down the vertical spacing in the "Capture Options" dialog box.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4870
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 00:24:24 +0000 (00:24 +0000)]
From David Frascone: fix pathname of Diameter directory file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4869
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 00:21:02 +0000 (00:21 +0000)]
From David Frascone: dictionary fixes to NASREQ command codes.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4868
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Tue, 5 Mar 2002 00:09:21 +0000 (00:09 +0000)]
From Michael Tuexen: SCCP-atop-M3UA support.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4867
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 4 Mar 2002 22:39:22 +0000 (22:39 +0000)]
SCCP support, from Jeff Morriss.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4866
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 4 Mar 2002 03:31:10 +0000 (03:31 +0000)]
Add entries for March.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4861
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 4 Mar 2002 01:39:12 +0000 (01:39 +0000)]
Note the update to the SCTP checksum code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4860
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 4 Mar 2002 01:26:40 +0000 (01:26 +0000)]
Update the "README.win32" file to reflect Andrew Feren's changes to use
Python iff PYTHON is defined in "config.nmake".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4859
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 4 Mar 2002 00:31:26 +0000 (00:31 +0000)]
Fix some items.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4858
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 4 Mar 2002 00:25:35 +0000 (00:25 +0000)]
Check for errors in seeks, "tell"s, and "stat()"s/"fstat()"s.
For file types where we allocate private data, add "close" routines
where they were missing, to free the private data. Also fix up the code
to clean up after some errors by freeing private data where that wasn't
being done.
Get rid of unused arguments to "wtap_dump_open_finish()".
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4857
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 3 Mar 2002 23:59:29 +0000 (23:59 +0000)]
Bump the version to 0.9.2. Update NEWS to include everything from February.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4856
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sun, 3 Mar 2002 22:42:08 +0000 (22:42 +0000)]
From Michael Tuexen: report the type of an unrecognized parameter.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@4855
f5534014-38df-0310-8fa8-
9805f1628bb7