ulfl [Mon, 28 Mar 2005 16:14:34 +0000 (16:14 +0000)]
fix Solaris build (I've removed O_BINARY)
rename sync_mode to real_time_mode, as we using sync_mode all the time now, so the name is misleading
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13956
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 28 Mar 2005 15:55:47 +0000 (15:55 +0000)]
In tvb_get_string(), throw an exception if our length is less than zero.
Add a message block length check to the AIM dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13955
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 15:31:13 +0000 (15:31 +0000)]
remove capture_child flag from capture_opts as it's no longer required
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13954
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 14:39:31 +0000 (14:39 +0000)]
a lot more capture engine code cleanup
most notably:
- moved opening of safe_file to the capture child (capture_loop.c)
- removed save_file_fd from capture_opts (no longer need to have it global)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13953
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 28 Mar 2005 03:08:29 +0000 (03:08 +0000)]
The "cf" field of a "capture_options" structure is a "void *" and, in
practice, it points to a "capture_file" structure; print it with "%p",
not "%s".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13952
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Mon, 28 Mar 2005 02:53:49 +0000 (02:53 +0000)]
The "application_context_version" variables in the CAMEL and GSM MAP
dissectors aren't needed outside the dissectors, and having more than
one of them exported causes build problems, at least on OS X - make them
static.
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13951
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Mon, 28 Mar 2005 02:03:45 +0000 (02:03 +0000)]
Make hf_oampdu_info_state_parser "BASE_HEX" instead of "8", so that we don't
throw an assertion in hfinfo_uint_vals_format().
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13950
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Mon, 28 Mar 2005 00:19:02 +0000 (00:19 +0000)]
major capture engine rework: use two task model for EVERY capture mode
rework of the -b command line parameter (for Ethereal and Tethereal)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13949
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Sun, 27 Mar 2005 22:56:32 +0000 (22:56 +0000)]
make skinny compile again
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13948
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 22:11:09 +0000 (22:11 +0000)]
Fix a typo
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13947
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:53:28 +0000 (21:53 +0000)]
Add Jacques, Olivier as the Camel dissector author.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13946
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:44:26 +0000 (21:44 +0000)]
From Jacques, Olivier:
Camel dissector
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13945
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:40:27 +0000 (21:40 +0000)]
Get rid of an unused variabnle
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13944
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:39:38 +0000 (21:39 +0000)]
From Jacques, Olivier:
The patch attached fixes it by creating a table of unique files at the
time of file deletion. This way, current asn2eth behaviour is not
modified.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13943
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:37:05 +0000 (21:37 +0000)]
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13942
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:14:48 +0000 (21:14 +0000)]
Previous commit failed doing them one by one.
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13941
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:14:15 +0000 (21:14 +0000)]
Previous commit failed doing them one by one.
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13940
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:12:39 +0000 (21:12 +0000)]
Previous commit failed doing them one by one.
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13939
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:11:48 +0000 (21:11 +0000)]
Previous commit failed doing them one by one.
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13938
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 21:01:21 +0000 (21:01 +0000)]
Use the new table for dynamic payload types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13937
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 20:55:14 +0000 (20:55 +0000)]
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13936
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 20:54:18 +0000 (20:54 +0000)]
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13935
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sun, 27 Mar 2005 20:53:15 +0000 (20:53 +0000)]
From Alejandro Vaquero :
Find attached a patch for SDP sessions to:
- Dissect Dynamic payload types in RTP packets
- Add the dynamic payload type description in RTP packets
- Add RTP dynamic payload types description in the Voip Calls Graph, in the RTP and SDP.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13934
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 27 Mar 2005 12:28:03 +0000 (12:28 +0000)]
buildbot bugfix: add another tvb_ensure_bytes_exist()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13933
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 27 Mar 2005 10:53:14 +0000 (10:53 +0000)]
buildbot bugfix: add another tvb_ensure_bytes_exist()
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13932
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sun, 27 Mar 2005 04:43:49 +0000 (04:43 +0000)]
Add SCTP and MEGACO types, so that we can add SCTP to the "random" test.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13931
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 27 Mar 2005 02:40:05 +0000 (02:40 +0000)]
bugfix of a bug causing tethereal value output to fail:
value_string's must be terminated with { 0, NULL }!!!
...seems I've missed one place in my last commit!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13930
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 27 Mar 2005 02:19:51 +0000 (02:19 +0000)]
add a new checkitem "Colorize Packet List" into the View menu
keep it's setting in the recent file
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13929
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 27 Mar 2005 01:18:06 +0000 (01:18 +0000)]
bugfix of a bug causing tethereal value output to fail:
value_string's must be terminated with { 0, NULL }!!!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13928
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sun, 27 Mar 2005 01:02:29 +0000 (01:02 +0000)]
buildbot bugfix: add another tvb_ensure_bytes_exist (tvb,offset,length);
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13927
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 23:31:35 +0000 (23:31 +0000)]
Add a note about doing checks before subtracting, for example, the
length of a fixed-length header from the length of the item with that
fixed-length header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13926
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Sat, 26 Mar 2005 23:02:24 +0000 (23:02 +0000)]
Make sure we have enough bytes in our tvbuff to dissect our header.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13925
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 21:31:13 +0000 (21:31 +0000)]
Update the URL for draft-stewart-sctp-pktdrprep to the -02 draft.
Clean up indentation.
Have the main loop for dissecting chunks check that the chunk size is
large enough for the chunk header, and have it pass the chunk size,
minus the size of the chunk header, to dissectors for particular chunk
types. Make those dissectors check that value to make sure it's large
enough for any fixed-length portion before subtracting the length of
that portion and using the result as a remaining data length.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13924
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 26 Mar 2005 19:55:46 +0000 (19:55 +0000)]
Fix some typos + decode more IE stuff
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13923
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Sat, 26 Mar 2005 19:09:05 +0000 (19:09 +0000)]
Fix a bug reported by Soi Hon Lo octet 6x and 7 not read from tvb.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13922
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 12:10:58 +0000 (12:10 +0000)]
buildbot bugfix: another (un-)signed problem and a problem with the offset (fixed by calling tvb_ensure...)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13921
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 11:32:43 +0000 (11:32 +0000)]
move some color_filter related things from file.c to color_filters.c
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13920
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 10:48:38 +0000 (10:48 +0000)]
Add rules to build xml_lexer.c, and to remove it with "make distclean",
modeled after the rules in epan/dfilter/Makefile.nmake.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13919
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 04:04:37 +0000 (04:04 +0000)]
With the recent change that makes the length field for FT_PROTOCOL and
FT_NONE be, in effect, unsigned, it's no longer necessary to check for a
so-large-it-doesn't-fit-in-a-signed-value length for items of those types.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13918
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 03:56:54 +0000 (03:56 +0000)]
Get rid of boilerplate.
Use "tvb_ensure_bytes_exist()" to check for some invalid lengths.
Add some comments about possible problems in the code.
Get rid of an unnecessary length check (the length is the sum of a small
constant and a value extracted from a single byte, so the sum won't
overflow).
For a FCP_RSP, make the top-level protocol tree item run to the end of
the tvbuff and then set its length when we finish dissecting it (if we
throw an exception and don't get around to setting the length, that
means that we hit the end of the tvbuff before we hit the end of the
item). Add some checks to catch too-large length fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13917
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 03:34:58 +0000 (03:34 +0000)]
Add xml_lexer.c to the list of files to ignore, as it's a generated
file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13916
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 03:30:08 +0000 (03:30 +0000)]
xml_lexer.c is generated by Flex; we don't put files generated by Flex
into the SVN tree, we just put the files from which they're generated
into the SVN tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13915
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 03:27:46 +0000 (03:27 +0000)]
There's no need to create a directory just because you're about to
remove a file in it - the directory presumably exists already, if you're
about to remove a file in it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13914
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 03:27:22 +0000 (03:27 +0000)]
For protocol tree items of type FT_NONE and FT_PROTOCOL, treat negative
length values (other than -1) as very large positive values, and for
values larger than the amount of data remaining in the tvbuff, clip the
value to the length of the tvbuff, so that dissectors don't have to
worry about doing that clipping themselves.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13913
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 03:03:43 +0000 (03:03 +0000)]
buildbot bugfix: if a length value is below zero, trim it to zero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13912
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 01:23:39 +0000 (01:23 +0000)]
buildbot bugfix: another (un-)signed one
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13911
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Sat, 26 Mar 2005 01:09:14 +0000 (01:09 +0000)]
code cleanup: use common prefix for all functions in color_filters.h
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13910
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 01:05:29 +0000 (01:05 +0000)]
Create the directory for the preferences files before writing out the
"recent" file.
Have "write_recent()" handle putting up error windows for failed
attempts to write the "recent" file.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13909
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Sat, 26 Mar 2005 00:15:19 +0000 (00:15 +0000)]
Add some length checks to the CHAP dissector.
Use %u, not %d, to display unsigned values.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13908
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 23:44:49 +0000 (23:44 +0000)]
buildbot bugfix: yet another (un-)signed problem.
Guy, you may have a look to add some "invalid" message to the tree in this case
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13907
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 23:12:07 +0000 (23:12 +0000)]
buildbot bugfix: and again, a guint16 will never become lower than zero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13906
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 22:52:45 +0000 (22:52 +0000)]
code cleanup: the term filter_list was used with different meanings throughout the code, and the filter_list of the color_filters is "global".
use appropriate prefixes to avoid confusion and bugs
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13905
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2005 22:37:58 +0000 (22:37 +0000)]
jxta updates
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13904
f5534014-38df-0310-8fa8-
9805f1628bb7
sahlberg [Fri, 25 Mar 2005 22:27:37 +0000 (22:27 +0000)]
updates to SAMR
from Michael richardson
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13903
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 21:19:18 +0000 (21:19 +0000)]
bugfix: prevent a negative length, if ah.ah_len is zero
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13902
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 25 Mar 2005 20:12:27 +0000 (20:12 +0000)]
For the Bandwidth Allocation Protocol Phone Delta option:
the length of a suboption must be at least 2;
the length of the Unique Digit option must be 3, and its name is
"Unique Digit", not "Uniq Digit";
the length of the other suboptions must be at least 3.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13901
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Fri, 25 Mar 2005 19:52:51 +0000 (19:52 +0000)]
In the cases fixed by the two previous fixes, check to make sure the
items don't run past the length left in the option, and, if they do, put
an indication into the protocol tree that they did.
The length returned by "tvb_strsize()" includes the terminating null
character.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13900
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2005 19:44:09 +0000 (19:44 +0000)]
Add checks to make sure the packet length hasn't overflowed in a couple of
places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13899
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Fri, 25 Mar 2005 17:24:48 +0000 (17:24 +0000)]
bugfix: similar problem than the previous one fixed by Gerald
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13898
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Fri, 25 Mar 2005 17:04:00 +0000 (17:04 +0000)]
Keep the length value from rolling over in CBCP. Add a comment asking if
there's a better way to do this.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13897
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Thu, 24 Mar 2005 21:17:08 +0000 (21:17 +0000)]
Add a few more payload length checks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13896
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2005 14:21:30 +0000 (14:21 +0000)]
From Jacques Olivier:
Here is a patch that:
* packet-ber.c:
- Fixes handling tags longer than one octet (in
"packet-ber.c:get_ber_identifier") which consists of replacing "if (t &
0x80) break;" by "if (!(t & 0x80)) break;"
- Add debug info on the identifier when debug is enabled (I don't know if we want to keep this, but I find it useful)
- printf's a warning when packet-ber hits a constructed type (to remind that we eventually have to handle this)
- Add the display of unknown BER octet strings (this one was already submitted along with the initial Camel dissector but didn't got
included)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13895
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Thu, 24 Mar 2005 14:19:24 +0000 (14:19 +0000)]
From Jacques Olivier add some OID:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13894
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Thu, 24 Mar 2005 08:55:23 +0000 (08:55 +0000)]
make it possible to use multiple capture files with "duration based switching" only
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13893
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 05:27:03 +0000 (05:27 +0000)]
The "new" routine for STTYPE_STRING and STTYPE_UNPARSED does a
"strdup()" on the argument, so we don't need to do that ourselves (and,
in fact, as we're doing it ourselves but not freeing the result, we leak
memory).
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13892
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 04:44:33 +0000 (04:44 +0000)]
Keep a list of all the x11_conv_data_t structures, so that when we're
freeing our data structures, we can go through all those structures and
free up the hash tables associated with them, rather than just leaking
them.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13891
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 03:58:38 +0000 (03:58 +0000)]
GtkStyles are reference-counted, and a style returned by
"gtk_style_copy()" has a reference count of 1; release the reference
when we're finished setting other widgets' styles to it.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13890
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Thu, 24 Mar 2005 03:10:31 +0000 (03:10 +0000)]
Plug some more small leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13889
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 22:49:32 +0000 (22:49 +0000)]
Plug a small leak found by the "leaks" tool on OS X.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13888
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 22:30:37 +0000 (22:30 +0000)]
The correlation ID is a 32-bit integer, not a string.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13887
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 21:42:40 +0000 (21:42 +0000)]
The DNS name data starts at the beginning of the suboption data, not the
beginning of the suboption.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13886
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 23 Mar 2005 21:38:05 +0000 (21:38 +0000)]
Some more IE stuff and added some ref:s
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13885
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 21:22:18 +0000 (21:22 +0000)]
When checking whether suboption data fits within the option, check
whether the suboption data offset plus the suboption data length is >,
not >=, the end of the option data - the end of the option data is the
first byte *after* the option data.
For CableLabs string suboptions, use the right offset when fetching the
data.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13884
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 20:25:29 +0000 (20:25 +0000)]
From Anton Ivanov: add support for Frame Relay over ATM.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13883
f5534014-38df-0310-8fa8-
9805f1628bb7
gerald [Wed, 23 Mar 2005 16:23:30 +0000 (16:23 +0000)]
Add "cleanup_dissection".
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13882
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 12:58:59 +0000 (12:58 +0000)]
Add a "cleanup_dissection()" routine, intended to free up data
structures allocated by a dissection. Currently, it's the same as
"init_dissection()", but they should be split with "init_dissection()"
allocating the initial data structures and "cleanup_dissection()"
freeing them and *not* reallocating the initial data structures.
Use "cleanup_dissection()" in "cf_close()" to make it easier to find leaks.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13881
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Wed, 23 Mar 2005 12:57:09 +0000 (12:57 +0000)]
Let packet-gsm_a.c dissect L3 messages.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13880
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 09:47:11 +0000 (09:47 +0000)]
Audit for TLV loops that don't check the length to make sure it's large
enough, and fix them - and handle the already-fixed case similarly (note
that the length is bogus, and break out of the loop).
Put object header items into the protocol tree in the order in which
they appear in the packet.
For unknown subobjects, make the "Data (N bytes)" item cover only the
data, not the header (which is already covered).
Fix the offset in some calls.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13879
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 23 Mar 2005 09:08:36 +0000 (09:08 +0000)]
buildbot reported bug fixed: prevent an endless loop
But what's the right way to do instead? Just inserted a return, this should do no harm.
Could someone with more knowledge of this dissector review this change?
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13878
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 23 Mar 2005 08:38:47 +0000 (08:38 +0000)]
hf_oampdu_info_state_parser seems to be an uint8 not bool, as it can contain 4 values
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13877
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 03:51:38 +0000 (03:51 +0000)]
"tvb_get_stringz()" and "abs_time_to_str()" don't return null pointers,
so don't check whether they've done so with "DISSECTOR_ASSERT()".
("proto_item_set_string()" and friends already do so.)
Fix indentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13876
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 02:48:47 +0000 (02:48 +0000)]
Thou shalt not g_assert() in a dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13875
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 02:39:21 +0000 (02:39 +0000)]
Remind people not to use "g_ntoh[ls]()" or "g_hton[ls]()" to convert
big-endian to little-endian - that doesn't work on big-endian machines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13874
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 01:55:11 +0000 (01:55 +0000)]
It doesn't matter whether, when building with WinPcap, we have
pcap_lib_version() in the WinPcap on the system on which we're building.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13873
f5534014-38df-0310-8fa8-
9805f1628bb7
guy [Wed, 23 Mar 2005 01:25:01 +0000 (01:25 +0000)]
If we have "pcap_freecode()", use it to free the instructions for a BPF
filter after installing the filter.
Set HAVE_PCAP_LIB_VERSION if we're building with WinPcap 3.1; it's not
present in earlier versions, but is present in current 3.1 betas.
Check HAVE_PCAP_LIB_VERSION when building capture-wpcap.c.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13872
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Wed, 23 Mar 2005 00:09:12 +0000 (00:09 +0000)]
use DISSECTOR_ASSERT instead of g_assert
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13871
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 22 Mar 2005 23:59:54 +0000 (23:59 +0000)]
add a DISSECTOR_ASSERT_NOT_REACHED() macro
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13870
f5534014-38df-0310-8fa8-
9805f1628bb7
obiot [Tue, 22 Mar 2005 22:27:14 +0000 (22:27 +0000)]
As suggested by Ulf Lamping, prevent Ethereal from bailing out if there's a protocol error, as we now have a DISSECTOR_ASSERT() macro.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13869
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 22 Mar 2005 21:47:11 +0000 (21:47 +0000)]
bugfix for buildbot randpkt: don't call proto_tree_add_string with a NULL pointer
TO THE DISSECTOR DEVELOPERS, PLEASE FIX THIS: I could easily found several places where a g_assert is called, depending on the input packet data. NEVER DO THIS, as this crashes Ethereal simply by invalid packet data input!!!
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13868
f5534014-38df-0310-8fa8-
9805f1628bb7
ulfl [Tue, 22 Mar 2005 21:39:37 +0000 (21:39 +0000)]
replace another g_assert by DISSECTOR_ASSERT, so Ethereal won't crash if a dissector triggers that assert
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13867
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 21:33:53 +0000 (21:33 +0000)]
More IE dissection
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13866
f5534014-38df-0310-8fa8-
9805f1628bb7
jmayer [Tue, 22 Mar 2005 16:02:09 +0000 (16:02 +0000)]
Remove trailing ';'
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13865
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:41:40 +0000 (15:41 +0000)]
Initial checkin of a camel dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13864
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:40:58 +0000 (15:40 +0000)]
Initial checkin of a camel dissector.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13863
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:36:33 +0000 (15:36 +0000)]
Dissect part of the payload.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13862
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:34:51 +0000 (15:34 +0000)]
Export q850_cause_code_vals
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13861
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:33:50 +0000 (15:33 +0000)]
Export q850_cause_code_vals as its's used by other dissector(s)
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13860
f5534014-38df-0310-8fa8-
9805f1628bb7
etxrab [Tue, 22 Mar 2005 15:19:53 +0000 (15:19 +0000)]
ERROR seems to be a reserved word change it to SCTP_ERROR to be able to build.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13859
f5534014-38df-0310-8fa8-
9805f1628bb7
tuexen [Tue, 22 Mar 2005 10:25:07 +0000 (10:25 +0000)]
From Irene Ruengeler: Bugfixes and support of chunk statistics per end point.
Some cleanups of the code.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13858
f5534014-38df-0310-8fa8-
9805f1628bb7
lego [Mon, 21 Mar 2005 22:23:17 +0000 (22:23 +0000)]
Hint in README.tapping about the stats_tree.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13857
f5534014-38df-0310-8fa8-
9805f1628bb7